Hi Alexey, Daniel,
On 05-04-2018 10:32, Daniel Vetter wrote:
> On Thu, Apr 5, 2018 at 9:16 AM, Alexey Brodkin
> wrote:
>> Hi Daniel,
>>
>> On Thu, 2018-04-05 at 08:18 +0200, Daniel Vetter wrote:
>>> On Wed, Apr 4, 2018 at 10:06 PM, Alexey Brodkin
>>> wrote:
Hello,
We're trying to
Hi,
On 13-12-2017 11:05, Hans Verkuil wrote:
> On 13/12/17 11:30, Maxime Ripard wrote:
>> Hi Hans,
>>
>> On Fri, Dec 08, 2017 at 04:48:47PM +0100, Hans Verkuil wrote:
>>> When I connected my cubieboard running 4.15-rc1 to my 4k display I got no
>>> picture. Some
>>> digging found that there is no
Hi Sean,
On 07-12-2017 00:00, Sean Paul wrote:
> Welcome to version 4 of the patchset. I think we're nearing the finish line
> (hopefully) now. This set addresses the review feedback from v3. I applied
> some
> R-b's from v3 review, and converted others to Cc since other changes were made
> to th
On 05-12-2017 11:53, Alexey Brodkin wrote:
>
> From my note above about udl_drm_gem_mmap() being only used in case of Xserver
> I barely may conclude anything. Given my lack of knowledge of DRM guts
> especially
> when it comes to complicated cases with DMA buffer exports/imports I cannot
> say
>
Hi Alexey,
On 04-12-2017 17:29, Alexey Brodkin wrote:
>
> Indeed, in case of kmscube etnaviv is a renderer while UDL
> outputs the picture on the screen.
Thats nice :)
Ok, from your logs I was not able to see anything wrong. X server
does not error exit and Prime seems to be working in DRM ...
On 04-12-2017 16:00, Alexey Brodkin wrote:
> [30.763] (II) armada(0): etnaviv: Xv: using YUY2 format intermediate YUV
> target
>
I'm wondering if this means that target format for UDL is YUV ...
But anyway, I revisited your first email and noticed that you
said kmscube runs fine. Is this usi
On 04-12-2017 14:53, Alexey Brodkin wrote:
> Full log you may find below.
Sorry but I meant /var/log/Xorg.0.log file.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 04-12-2017 13:16, Alexey Brodkin wrote:
> Option "kmsdev" "/dev/dri/card1"
Which drm driver uses /dev/dri/card0? I'm seing drmOpen code and
if you don't specify the busID it will fallback for the first
card that matches "armada-drm" or "imx-drm" or "udl".
> But if I swap "imx-
Hi Alexey,
On 04-12-2017 11:32, Alexey Brodkin wrote:
> My first [probably incorrect] assumption is Xserver requires fbdev (/dev/fbX)
> and it cannot use DRI video card natively. Is that correct?
>
>
Xserver can use DRI directly, you need to enable modesetting
driver in Xorg config or use the des
On 03-12-2017 05:20, Nick Bowler wrote:
>
> Your patch changes things. With this applied on top of 4.15-rc1
> it is failing 100% of the time instead of only half of the time.
Ok, it was a long shot anyway.
>
> I brought the original test equipment back to the setup so I can
> see the video and p
Hi Nick,
On 01-12-2017 00:11, Nick Bowler wrote:
> Hi,
>
> On 2017-11-27 22:30 -0500, Nick Bowler wrote:
>> A note about the test setup: I had to remove the test equipment so I
>> no longer have any information about the video mode from the sink side
>> (like in the photos). Thus, with the curren
ev emulation never uses the corresponding fbdev flag
> there should be no sane way for this to come back into kms via
> userspace either.
>
> Cc: Jose Abreu
> Cc: Adam Jackson
> Cc: Keith Packard
> Signed-off-by: Ville Syrjälä
;ramdac
> interface with some ancient S3 graphics adapters. Why someone though
> it would be a good idea to expose it directly to users I don't know.
> And later on it got copied into the randr protocol and kms uapi.
>
> Cc: Jose Abreu
> Cc: Adam Jackson
> Cc: Keith Packar
depend
> on these.
>
> v2: Recommend DRIVER instead of BUILTIN (ajax)
>
> Cc: Jose Abreu
> Cc: Adam Jackson
> Cc: Keith Packard
> Signed-off-by: Ville Syrjälä
> Reviewed-by: Adam Jackson
> Reviewed-by: Alex Deucher
>
Reviewed-by: Jose Abreu
Best Regards,
Jose Miguel
Hi Ville,
On 15-11-2017 15:49, Ville Syrjala wrote:
>
> +#define DRM_MODE_FLAG_ALL (DRM_MODE_FLAG_PHSYNC | \
> + DRM_MODE_FLAG_NHSYNC | \
> + DRM_MODE_FLAG_PVSYNC | \
> + DRM_MODE_FL
harma
> Cc: Jim Bride
> Cc: Jose Abreu
> Cc: Daniel Vetter
> Cc: Emil Velikov
> Cc: Thierry Reding
> Cc: Hans Verkuil
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jose Abreu
Best Regards,
Jose Miguel Abreu
__
On 13-11-2017 17:04, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> If the user mode would specify an aspect ratio other than 4:3 or 16:9
> we now silently ignore it. Maybe a better apporoach is to return an
> error? Let's try that.
>
> Also we must be careful that we don't try to send illegal p
Hi Ville,
On 13-11-2017 17:04, Ville Syrjala wrote:
>
> + if (to_match->picture_aspect_ratio)
> + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO;
> +
>
Maybe "if (to_match->picture_aspect_ratio !=
HDMI_PICTURE_ASPECT_NONE && to_match->picture_aspect_ratio !=
HDMI_PICTURE_ASPECT_RESE
Hi Jernej,
On 20-09-2017 21:01, Jernej Skrabec wrote:
> [added media mailing list due to CEC question]
>
> This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only
> video and CEC functionality is supported. Audio needs more tweaks.
>
> Series is based on the H3 DE2 patch seri
On 19-07-2017 20:21, John Stultz wrote:
> On Wed, Jul 19, 2017 at 3:16 AM, Jose Abreu wrote:
>> Hi John,
>>
>>
>> On 18-07-2017 18:59, John Stultz wrote:
>>> Currently the hikey dsi logic cannot generate accurate byte
>>> clocks values for all pi
t;
> This patch uses the new mode_valid callback (many thanks to
> Jose Abreu for upstreaming it!) to ensure we don't select
> modes we cannot generate.
>
> Also, since the ade crtc code will adjust the mode in mode_set,
> this patch also adds a mode_fixup callback which we us
On 18-07-2017 17:56, John Stultz wrote:
> On Tue, Jul 18, 2017 at 4:10 AM, Jose Abreu wrote:
>> Hi John,
>>
>>
>> On 18-07-2017 05:22, John Stultz wrote:
>>> Currently the hikey dsi logic cannot generate accurate byte
>>> clocks values for all pi
t;
> This patch uses the new mode_valid callback (many thanks to
> Jose Abreu for upstreaming it!) to ensure we don't select
> modes we cannot generate.
>
> NOTE: Stylistically I suspect there are better ways to do what
> I'm trying to do here. The encoder -> crtc bit is
At module unload we are expecting a struct drm_device but at
probing we are not setting it right. Fix this and correct the
arcpgu module unload.
Signed-off-by: Jose Abreu
Fixes: 0c4250e7b15e ("drm: Add support of ARC PGU display controller")
Cc: Carlos Palminha
Cc: Alexey Brodkin
Hi all,
Two fixes and an improvement for arcpgu. I've sent this patches in separate
but I've now collected them all to ease the review.
Best regards,
Jose Miguel Abreu
Jose Abreu (3):
drm: arcpgu: Fix mmap() callback
drm: arcpgu: Fix module unload
drm: arcpgu: Allow some clock
.
Signed-off-by: Jose Abreu
Fixes: 0c4250e7b15e ("drm: Add support of ARC PGU display controller")
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Daniel Vetter
Cc: Dave Airlie
---
drivers/gpu/drm/arc/arcpgu_drv.c | 24 +---
1 file changed, 1 insertion(+), 23 deletion
Hi Daniel, all,
So, I was playing around with arcpgu and I found a bug at module
unloading. I corrected it and tested (using a 4.12 kernel) and I
got a nice WARNING from DRM core at unloading (instead of the old
NULL pointer I got :D). I debugged it and found out that an empty
modesetting (i.e. a
deviation. Lets take that into an advantage and use it to
calculate how much deviation we can support.
Signed-off-by: Jose Abreu
Acked-by: Alexey Brodkin
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Daniel Vetter
Cc: Dave Airlie
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 7 ---
1 file changed, 4
Now that ARC properly supports DMA mmapping we can use the
standard CMA helper to map dumb buffers. This makes ARC PGU
works with standard DRM consumer applications like, for
example, mpv via DRM.
This fixes the use of dumb buffers.
Signed-off-by: Jose Abreu
Fixes: 0c4250e7b15e ("drm
Hi Archit,
On 23-06-2017 10:36, Jose Abreu wrote:
> Currently HDMI 2.0 PHYs do not have a default configuration function.
>
> As *some* of the HDMI 2.0 PHYs have the same register layout as the 3D
> PHYs we can provide the same default configuration function for both
> and
Hi Neil,
On 06-07-2017 11:33, Neil Armstrong wrote:
> From: Russell King
>
> Add CEC notifier support to the HDMI bridge driver, so that the CEC
> part of the IP can receive its physical address.
>
> Tested-by: Neil Armstrong
> Acked-by: Neil Armstrong
> Acked-by: Hans Verkuil
> Signed-off-by
take that into an advantage and use it
to calculate how much deviation we can support.
This patch was based on today's drm-misc-next.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Daniel Vetter
Cc: Dave Airlie
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 7 ---
1
platforms.
This patch is based on today's drm-misc-next branch.
Signed-off-by: Jose Abreu
Tested-by: Mark Yao
Cc: Kieran Bingham
Cc: Laurent Pinchart
Cc: Archit Taneja
Cc: Andrzej Hajda
Cc: Mark Yao
Cc: Carlos Palminha
Cc: Heiko Stübner
Changes in v2:
- Rebased and refrased c
Hi Daniel, Alexey,
On 25-05-2017 15:19, Jose Abreu wrote:
> Now that we have a callback to check if crtc supports a given mode
> we can use it in arcpgu so that we restrict the number of probbed
> modes to the ones we can actually display.
>
> This is specially useful because
Hi Laurent,
Sorry for the late reply!
On 10-06-2017 09:50, Laurent Pinchart wrote:
> Hi Jose,
>
> On Friday 09 Jun 2017 13:53:12 Jose Abreu wrote:
>> On 09-06-2017 12:04, Jose Abreu wrote:
>>> Currently HDMI 2.0 PHYs do not have a default configuration function.
>&g
Hello,
On 09-06-2017 05:11, Archit Taneja wrote:
> Hi Philippe, Rob,
>
> On 06/08/2017 09:10 PM, Rob Herring wrote:
>> Seems strange there's not also a pixel or bit clock? Or this
>> gets driven
>> from the phy?
>
> Since you mention phy here, I wanted to share a concern with
> the bindings.
> Th
prefer the pdata provided configuration
function over the internal one.
This patch is based on today's drm-misc-next branch.
Signed-off-by: Jose Abreu
Cc: Kieran Bingham
Cc: Laurent Pinchart
Cc: Archit Taneja
Cc: Andrzej Hajda
Cc: Mark Yao
Cc: Carlos Palminha
---
drivers/gpu/drm/b
Hi Mark,
On 09-06-2017 05:03, Mark yao wrote:
> Ignore this patch, Jose has a better patch to solve rk3399 hdmi
> phy configure.
>
> Hi Jose
>
> Sorry for missing your patch about hdmi 2.0 vendor phy fixup:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_9702229&
Hi Mark,
On 09-06-2017 12:04, Jose Abreu wrote:
> Currently HDMI 2.0 PHYs do not have a default configuration function.
>
> As these PHYs have the same register layout as the 3D PHYs we can
> safely use the default configuration function.
I may have been a little to fast arri
Hi Hans,
On 02-06-2017 07:31, Hans Verkuil wrote:
> On 06/01/2017 03:47 PM, Neil Armstrong wrote:
>> On 05/30/2017 04:23 PM, Russell King wrote:
>>> Add a CEC driver for the dw-hdmi hardware.
>>>
>>> Signed-off-by: Russell King
>>> ---
>>> drivers/gpu/drm/bridge/synopsys/Kconfig | 8 +
On 01-06-2017 23:30, Russell King - ARM Linux wrote:
> On Thu, Jun 01, 2017 at 01:53:21AM +0100, Jose Abreu wrote:
>> Hi Russell,
>>
>>
>> On 30-05-2017 15:23, Russell King wrote:
>>> +static int dw_hdmi_cec_transmit(struct cec_adapter *adap, u8 attempts,
Hi Russell,
On 30-05-2017 15:23, Russell King wrote:
> Add a CEC driver for the dw-hdmi hardware.
>
> Signed-off-by: Russell King
> ---
> drivers/gpu/drm/bridge/synopsys/Kconfig | 8 +
> drivers/gpu/drm/bridge/synopsys/Makefile | 1 +
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec
g the bits that the video path needs to.
>
> Signed-off-by: Russell King
Reviewed-by: Jose Abreu
Best regards,
Jose Miguel Abreu
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 25 +++--
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --g
even compiled tested
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Daniel Vetter
Cc: Liviu Dudau
Cc: Brian Starkey
Cc: David Airlie
---
drivers/gpu/drm/arm/malidp_crtc.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_crtc.c
b
: Only compile tested.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: Andrzej Hajda
Cc: Laurent Pinchart
Cc: David Airlie
---
drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a
: Not even compiled tested
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Daniel Vetter
Cc: Boris Brezillon
Cc: David Airlie
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc
ode loops
through all the connector's encodersXbridgesXcrtcs and calls the
callback.
If at least a valid encoderXbridgeXcrtc combination is found which
accepts the mode then the function returns MODE_OK.
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Cc: Carlos Palminha
Cc: D
this clock
does not support all the needed ranges.
Also, remove the atomic_check() callback as mode_valid() callback
will be called before.
Signed-off-by: Jose Abreu
Reviewed-by: Alexey Brodkin
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Laurent Pinchart
Add a new helper to call crtc->mode_valid, connector->mode_valid
and encoder->mode_valid callbacks.
Suggested-by: Ville Syrjälä
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Reviewed-by: Andrzej Hajda
Cc: Carlos Palminha
Cc: Dave Airlie
Changes v2->v3:
- Mov
ves/dri-devel/2017-May/141761.html
Jose Abreu (10):
drm: Add drm_{crtc/encoder/connector}_mode_valid()
drm: Introduce drm_bridge_mode_valid()
drm: Use new mode_valid() helpers in connector probe helper
drm: Use mode_valid() in atomic modeset
drm: arcpgu: Use crtc->mode_valid() callba
validation.
NOTE: Only compile tested
NOTE 2: I also had to change the pdata declaration of mode_valid
custom callback so that the passed modes are const. I also changed
in the platforms I found. Not even compiled it though.
Signed-off-by: Jose Abreu
Acked-by: Neil Armstrong
Cc: Carlos Palminha
Cc
be accepted in every components.
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Reviewed-by: Andrzej Hajda
Cc: Carlos Palminha
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
Changes v1->v2:
- Removed ca
.
NOTE: Not even compiled tested
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Daniel Vetter
Cc: Eric Anholt
Cc: David Airlie
---
drivers/gpu/drm/vc4/vc4_crtc.c | 13 ++---
drivers/gpu/drm/vc4/vc4_dpi.c | 13 ++---
2 files changed, 12 insertions(+), 14 deletions(-)
diff
Introduce a new helper function which calls mode_valid() callback
for all bridges in an encoder chain.
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Cc: Carlos Palminha
Cc: Ville Syrjälä
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
---
drivers/gpu/drm
Hi Daniel,
On 22-05-2017 16:31, Daniel Vetter wrote:
> On Mon, May 22, 2017 at 09:56:00AM +0200, Daniel Vetter wrote:
>> On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote:
>>> This series is a follow up from the discussion at [1]. We start by
>>> introducing
Hi Daniel,
On 22-05-2017 08:56, Daniel Vetter wrote:
> On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote:
>> This series is a follow up from the discussion at [1]. We start by
>> introducing crtc->mode_valid(), encoder->mode_valid() and
>> bridge->mode_v
validation.
NOTE: Only compile tested
NOTE 2: I also had to change the pdata declaration of mode_valid
custom callback so that the passed modes are const. I also changed
in the platforms I found. Not even compiled it though.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville
be accepted in every components.
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Reviewed-by: Andrzej Hajda
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
---
drivers/gpu/drm/drm_ato
Introduce a new helper function which calls mode_valid() callback
for all bridges in an encoder chain.
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc
.
NOTE: Not even compiled tested
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
---
drivers/gpu/drm/vc4/vc4_crtc.c | 13 ++---
drivers/gpu/drm/vc4/vc4_dpi.c
: Only compile tested.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
---
drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++---
1 file changed, 6 insertions
even compiled tested
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
---
drivers/gpu/drm/arm/malidp_crtc.c | 11 +--
1 file changed, 5 insertions(+), 6
this clock
does not support all the needed ranges.
Also, remove the atomic_check() callback as mode_valid() callback
will be called before.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit
ment it.
[1] https://patchwork.kernel.org/patch/9702233/
[2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html
Jose Abreu (10):
drm: Add drm_{crtc/encoder/connector}_mode_valid()
drm: Introduce drm_bridge_mode_valid()
drm: Use new mode_valid() helpers in connector probe
ode loops
through all the connector's encodersXbridgesXcrtcs and calls the
callback.
If at least a valid encoderXbridgeXcrtc combination is found which
accepts the mode then the function returns MODE_OK.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjä
Add a new helper to call crtc->mode_valid, connector->mode_valid
and encoder->mode_valid callbacks.
Suggested-by: Ville Syrjälä
Signed-off-by: Jose Abreu
Reviewed-by: Daniel Vetter
Reviewed-by: Andrzej Hajda
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel V
: Not even compiled tested
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
Cc: Laurent Pinchart
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 -
1 file changed, 4
d mode_valid, even if it looks like
> that at first glance.
>
> Cc: Andrzej Hajda
> Cc: Laurent Pinchart
> Cc: Jose Abreu
> Signed-off-by: Daniel Vetter
Reviewed-by: Jose Abreu
Best regards,
Jose Miguel Abreu
> ---
> include/drm/drm_modeset_helper_vtables.h | 1
Hi Laurent,
On 15-05-2017 08:05, Laurent Pinchart wrote:
> On Monday 15 May 2017 08:47:49 Daniel Vetter wrote:
>> On Sun, May 14, 2017 at 02:04:24PM +0300, Laurent Pinchart wrote:
>>> On Friday 12 May 2017 17:06:14 Jose Abreu wrote:
>>>> On 12-05-2017 10:35, La
Hi Daniel,
On 15-05-2017 10:11, Daniel Vetter wrote:
> Laurent started a massive discussion on IRC about this. Let's try to
> document common usage a bit better.
>
> v2: Cross-links+typos.
>
> Cc: Laurent Pinchart
> Cc: Ville Syrjälä
> Cc: Jose Abreu
> Signed-
Hi Daniel,
On 15-05-2017 16:52, Daniel Vetter wrote:
> On Mon, May 15, 2017 at 10:53:25AM +0200, Daniel Vetter wrote:
>> On Thu, May 11, 2017 at 10:06:02AM +0100, Jose Abreu wrote:
>>> Now that we have a callback to check if crtc supports a given mode
>>> we can
Hi Laurent,
Sorry for the late reply.
On 12-05-2017 10:57, Laurent Pinchart wrote:
> Hi Jose,
>
> Thank you for the patch.
>
> On Tuesday 09 May 2017 18:00:15 Jose Abreu wrote:
>> Now that we have a callback to check if crtc supports a given mode
>> we can use it in
Hi Laurent,
On 12-05-2017 10:35, Laurent Pinchart wrote:
> Hi Jose,
>
> Thank you for the patch.
>
> On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote:
>> This changes the connector probe helper function to use the new
>> encoder->mode_valid() and crtc->
Hi Daniel,
On 12-05-2017 08:31, Daniel Vetter wrote:
> From: Jose Abreu
>
> This adds a new callback to crtc, encoder and bridge helper functions
> called mode_valid(). This callback shall be implemented if the
> corresponding component has some sort of restriction in the mode
Add a new helper to call crtc->mode_valid, connector->mode_valid
and encoder->mode_valid callbacks.
Suggested-by: Ville Syrjälä
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Arch
ode loops
through all the connector's encodersXbridgesXcrtcs and calls the
callback.
If at least a valid encoderXbridgeXcrtc combination is found which
accepts the mode then the function returns MODE_OK.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjä
g/patch/9702233/
Jose Abreu (6):
drm: Add crtc/encoder/bridge->mode_valid() callbacks
drm: Add drm_{crtc/encoder/connector}_mode_valid()
drm: Introduce drm_bridge_mode_valid()
drm: Use new mode_valid() helpers in connector probe helper
drm: Use mode_valid() in atomic modeset
this clock
does not support all the needed ranges.
Also, remove the atomic_check() callback as mode_valid() callback
will be called before.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit
also change the documentation so that the new and old callbacks
are correctly documented.
Only the callbacks were implemented to simplify review process,
following patches will make use of them.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel
Introduce a new helper function which calls mode_valid() callback
for all bridges in an encoder chain.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
drivers/gpu/drm/drm_bridge.c
omponents.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
Changes v1->v2:
- Removed call to connector->mode_valid (Ville, Daniel)
- Change function name (Ville
Hi Daniel,
On 10-05-2017 09:03, Daniel Vetter wrote:
> On Tue, May 09, 2017 at 06:00:08PM +0100, Jose Abreu wrote:
>> This adds a new callback to crtc, encoder and bridge helper functions
>> called mode_valid(). This callback shall be implemented if the
>> corresponding co
Hi Daniel,
On 10-05-2017 08:59, Daniel Vetter wrote:
> On Tue, May 09, 2017 at 06:00:09PM +0100, Jose Abreu wrote:
>> Add a new helper to call crtc->mode_valid callback.
>>
>> Suggested-by: Ville Syrjälä
>> Signed-off-by: Jose Abreu
>> Cc: Carlos Palminha
Hi Ville,
On 10-05-2017 15:01, Jose Abreu wrote:
> Hi Ville,
>
>
> On 10-05-2017 14:41, Ville Syrjälä wrote:
>> On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote:
>>> Introduce a new helper function which calls mode_valid() callback
>>>
Hi Ville,
On 10-05-2017 14:41, Ville Syrjälä wrote:
> On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote:
>> Introduce a new helper function which calls mode_valid() callback
>> for all bridges in an encoder chain.
>>
>> Signed-off-by: Jose Abreu
>> C
Hi Daniel,
On 10-05-2017 09:01, Daniel Vetter wrote:
> On Tue, May 09, 2017 at 06:00:12PM +0100, Jose Abreu wrote:
>> This changes the connector probe helper function to use the new
>> encoder->mode_valid() and crtc->mode_valid() helper callbacks to
>> validate the mod
this clock
does not support all the needed ranges.
Also, remove the atomic_check() callback as mode_valid() callback
will be called before.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit
ll the connector's encodersXcrtcs and calls the
callback.
If at least a valid encoderXcrtc combination is found which
accepts the mode then the function returns MODE_OK.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: An
Add a new helper to call crtc->mode_valid callback.
Suggested-by: Ville Syrjälä
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
drivers/gpu/drm/drm_crtc.c |
xcept the connector->mode_valid one, so that the mode is validated.
This is done before calling mode_fixup().
Finally, at 8/8 we use the new crtc->mode_valid() callback in arcpgu
and remove the atomic_check() callback.
[1] https://patchwork.kernel.org/patch/9702233/
Jose Abreu (8):
drm: A
Add a new helper to call encoder->mode_valid callback.
Suggested-by: Ville Syrjälä
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
drivers/gpu/drm/drm_crtc_internal.h |
Add a new helper to call connector->mode_valid callback.
Suggested-by: Ville Syrjälä
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
TODO: function prototype should receiv
also change the description of connector->mode_valid() callback
so that it matches the existing behaviour: It is never called in
atomic check phase.
Only the callbacks were implemented to simplify review process,
following patches will make use of them.
Signed-off-by: Jose Abreu
Cc: Car
be accepted in every components.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
Changes v1->v2:
- Removed call to connector->mode_valid (Ville, Daniel)
- Ch
Introduce a new helper function which calls mode_valid() callback
for all bridges in an encoder chain.
Signed-off-by: Jose Abreu
Cc: Carlos Palminha
Cc: Alexey Brodkin
Cc: Ville Syrjälä
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Andrzej Hajda
Cc: Archit Taneja
---
drivers/gpu/drm/drm_bridge.c
Hi Daniel,
On 08-05-2017 08:50, Daniel Vetter wrote:
> On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote:
>> This changes the connector probe helper function to use the new
>> encoder->mode_valid() and crtc->mode_valid() helper callbacks to
>> validate the mod
Hi Ville,
On 04-05-2017 15:32, Ville Syrjälä wrote:
> On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote:
>> This changes the connector probe helper function to use the new
>> encoder->mode_valid() and crtc->mode_valid() helper callbacks to
>> validate the mod
e the new crtc->mode_valid() callback in arcpgu
and remove the atomic_check() callback.
[1] https://patchwork.kernel.org/patch/9702233/
Jose Abreu (5):
drm: Add crtc/encoder/bridge->mode_valid() callbacks
drm: Use new mode_valid() helpers in connector probe helper
drm: Introduce drm_br
Hi Daniel,
On 03-05-2017 16:00, Daniel Vetter wrote:
> On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote:
>> Hi Daniel,
>>
>>
>> On 03-05-2017 07:19, Daniel Vetter wrote:
>>> On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote:
>>>> On 02-
Hi Daniel,
On 03-05-2017 07:19, Daniel Vetter wrote:
> On Tue, May 2, 2017 at 11:29 AM, Jose Abreu wrote:
>> On 02-05-2017 09:48, Daniel Vetter wrote:
>>> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote:
>>>> Some crtc's may have restrictio
1 - 100 of 315 matches
Mail list logo
