Re: [PATCH v2 1/2] dt-bindings: pinctrl: aspeed: Update gfx node in example

2022-03-24 Thread Linus Walleij
On Fri, Mar 4, 2022 at 1:03 AM Joel Stanley wrote: > The example needs updating to match the to be added yaml bindings for > the gfx node. > > Signed-off-by: Joel Stanley Patch applied. Yours, Linus Walleij

Re: [PATCH v2 1/2] dt-bindings: pinctrl: aspeed: Update gfx node in example

2022-03-14 Thread Linus Walleij
On Fri, Mar 4, 2022 at 1:03 AM Joel Stanley wrote: > The example needs updating to match the to be added yaml bindings for > the gfx node. > > Signed-off-by: Joel Stanley Reviewed-by: Linus Walleij I guess you will merge this elsewhere or shall I apply it to the pinctrl tree?

Re: [PATCH v3 8/8] drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge

2022-03-14 Thread Linus Walleij
On Tue, Mar 8, 2022 at 9:27 AM Jagan Teki wrote: > devm_drm_of_get_bridge is capable of looking up the downstream > bridge and panel and trying to add a panel bridge if the panel > is found. > > Replace explicit finding calls with devm_drm_of_get_bridge. > > Cc: Linus

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-02 Thread Linus Walleij
On Wed, Mar 2, 2022 at 5:37 AM Jagan Teki wrote: > On Wed, Mar 2, 2022 at 4:50 AM Linus Walleij wrote: > > > > On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki > > wrote: > > > > > + bridge = devm_drm_of_get_bridge(dev, dev->of_node,

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-01 Thread Linus Walleij
dev_info(dev, "connected to non-panel bridge (unsupported)\n"); - return -ENODEV; This will now have "interesting" effects. I think. I don't know if there is a way to solve this though? Yours, Linus Walleij

Re: [PATCH v2 8/8] drm: bridge: anx7625: Switch to devm_drm_of_get_bridge

2022-03-01 Thread Linus Walleij
On Tue, Mar 1, 2022 at 3:13 PM Jagan Teki wrote: > devm_drm_of_get_bridge is capable of looking up the downstream > bridge and panel and trying to add a panel bridge if the panel > is found. > > Replace explicit finding calls with devm_drm_of_get_bridge. > > Cc: Linus

Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend

2022-02-22 Thread Linus Walleij
> > We weren't doing that for autosuspend. Let's do it. > > Fixes: 9bede63127c6 ("drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend") > Signed-off-by: Douglas Anderson Hm. I know a few places in drivers where I don't do this :/ Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-02-18 Thread Linus Walleij
On Sat, Jan 29, 2022 at 2:26 AM Linus Walleij wrote: > On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij > wrote: > > > A code drop from Sony Mobile reveals that the ACX424 panels are > > built around the Novatek NT35560 panel controllers so just bite > > the bullet an

Re: [PATCH v10 3/6] gpio: logicvc: Support compatible with major version only

2022-02-10 Thread Linus Walleij
On Tue, Feb 8, 2022 at 10:55 AM Bartosz Golaszewski wrote: > On Sun, Jan 30, 2022 at 1:43 AM Linus Walleij > wrote: > > > > On Thu, Jan 20, 2022 at 4:00 PM Paul Kocialkowski > > wrote: > > > > > Support the newly-introduced common compatible for ver

Re: [PATCH v10 4/6] dt-bindings: display: Add compatibles with major versions only

2022-01-29 Thread Linus Walleij
that only list the major version instead. > > Signed-off-by: Paul Kocialkowski Same comment as the other binding patch. Yours, Linus Walleij

Re: [PATCH v10 2/6] dt-bindings: gpio: logicvc: Add a compatible with major version only

2022-01-29 Thread Linus Walleij
nd target only a specific version. Yours, Linus Walleij

Re: [PATCH v10 3/6] gpio: logicvc: Support compatible with major version only

2022-01-29 Thread Linus Walleij
On Thu, Jan 20, 2022 at 4:00 PM Paul Kocialkowski wrote: > Support the newly-introduced common compatible for version 3. > > Signed-off-by: Paul Kocialkowski Reviewed-by: Linus Walleij Are there dependencies between the GPIO patches and the rest? Doesn't look like that. Can Bar

Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-01-28 Thread Linus Walleij
On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij wrote: > A code drop from Sony Mobile reveals that the ACX424 panels are > built around the Novatek NT35560 panel controllers so just bite > the bullet and rename the driver and all basic symbols so that > we can modify this driver to cov

[PATCH 3/3] drm/panel: nt35560: Support also ACX424AKM

2022-01-03 Thread Linus Walleij
Add some code and config to also support the ACX424AKM used in some Sony (Ericsson) Mobile phones. Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35560.c | 72 ++- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH 2/3] drm/panel: nt35560: Support more panel IDs

2022-01-03 Thread Linus Walleij
These IDs were found in the wild in a Sony Xperia vendor tree. Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35560.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35560.c b/drivers/gpu/drm/panel/panel

[PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-01-03 Thread Linus Walleij
. Signed-off-by: Linus Walleij --- MAINTAINERS | 13 +- drivers/gpu/drm/panel/Kconfig | 23 +- drivers/gpu/drm/panel/Makefile| 2 +- ...ny-acx424akp.c => panel-novatek-nt35560.c} | 215 +- 4 files changed,

[PATCH] drm/panel: Extend ACX424AKP bindings to ACX424AKM

2022-01-03 Thread Linus Walleij
...@vger.kernel.org Signed-off-by: Linus Walleij --- .../bindings/display/panel/sony,acx424akp.yaml| 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx424akp.yaml b/Documentation/devicetree/bindings/display

Re: [PATCH] dt-bindings: display: Add SPI peripheral schema to SPI based displays

2021-12-21 Thread Linus Walleij
must follow > spi-controller.yaml is both a bit out of date and redundant, so remove > it. > > Signed-off-by: Rob Herring Excellent patch. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 56/60] drm/tve200: Add support for the nomodeset kernel parameter

2021-12-14 Thread Linus Walleij
g > and only the systewm system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 21/60] drm/mcde: Add support for the nomodeset kernel parameter

2021-12-14 Thread Linus Walleij
g > and only the systewm system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge

2021-12-10 Thread Linus Walleij
On Sat, Dec 11, 2021 at 1:07 AM Linus Walleij wrote: > On Fri, Dec 10, 2021 at 6:49 PM Jagan Teki wrote: > > - dev_info(dev, "connected to panel\n"); > > - d->panel = panel; > > How does this assignment ha

Re: [PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge

2021-12-10 Thread Linus Walleij
Zabel > Cc: Chun-Kuang Hu > Cc: Linus Walleij > Signed-off-by: Jagan Teki Nice overall! > - /* Look for a panel as a child to this node */ > - for_each_available_child_of_node(dev->of_node, child) { > - panel = of_drm_find_pan

Re: [PATCH] Revert "video: fbdev: amba-clcd: Retire elder CLCD driver"

2021-12-06 Thread Linus Walleij
if a prebuilt Android for the emulation model was available. Yours, Linus Walleij

Re: [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-02 Thread Linus Walleij
On Thu, Dec 2, 2021 at 11:27 PM Stephen Boyd wrote: > drm/mcde: Migrate to aggregate driver This also works fine after the patch series. Tested-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-12-02 Thread Linus Walleij
n Reichel > Cc: > Cc: Daniel Vetter > Cc: Linus Walleij > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd Pulled in that patches and tested. Works! Tested-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm/bridge: ti-sn65dsi83: Optimize reset line toggling

2021-10-16 Thread Linus Walleij
able callback so the entire DSI83 initialization > is now in one place. > > This reduces DSI83 enablement delay by up to 10ms. > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart > Cc: Linus Walleij > Cc: Robert Foss > Cc: Sam Ravnborg > Cc: dri-devel@lists.f

Re: [PATCH] MAINTAINERS: fix typo in DRM DRIVER FOR SAMSUNG S6D27A1 PANELS

2021-09-21 Thread Linus Walleij
> > Linus, please pick this minor quick clean-up patch on drm-misc-next > (on top of the commit mentioned above). Patch applied! Yours, Linus Walleij

Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding

2021-09-14 Thread Linus Walleij
r the series: Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm/mcde: Make use of the helper function devm_platform_ioremap_resource()

2021-09-07 Thread Linus Walleij
On Tue, Aug 31, 2021 at 3:56 PM Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Patch applied! Yours, Linus Walleij

Re: [PATCH v2 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-13 Thread Linus Walleij
WideChips WS2401 display controller > driver by Linus Walleij and on other panel drivers for reference. > > Signed-off-by: Markuss Broks > > v2 -> v3: Both v3 patches applied to drm-misc-next and pushed. Yours, Linus Walleij

Re: [PATCH] drivers/firmware: fix sysfb depends to prevent build failures

2021-08-10 Thread Linus Walleij
sed for EFI on these > architectures. For !EFI the "simple-framebuffer" device is registered by > OF when parsing the Device Tree Blob (if a DT node for this is defined). > > Reported-by: kernel test robot > Signed-off-by: Javier Martinez Canillas Reviewed-by: Linus Walleij

Re: [PATCH v2 1/2] drm/panel: Add DT bindings for Samsung S6D27A1 display panel

2021-08-07 Thread Linus Walleij
nd vccio-supply as required; These bindings look good to me: Reviewed-by: Linus Walleij Will give DT reviewers some slack before applying the patches. Yours, Linus Walleij

Re: [PATCH v2 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-07 Thread Linus Walleij
> + msleep(50); This should be msleep(120) on s6d27a1 (according to board-codina-mcde.c) Yours, Linus Walleij

Re: [PATCH 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

2021-08-05 Thread Linus Walleij
desktop.org/drm/drm-misc/commit/include/drm/drm_mipi_dbi.h?id=3f5aa5ac0b0f9704f0c60f5fbbbcdc8c043d6eb6 Yours, Linus Walleij

Re: [PATCH v4 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding

2021-08-05 Thread Linus Walleij
; arch/arm/boot/dts/stm32f429-disco.dt.yaml: display@1: compatible: > ['st,sf-tc240t-9370-t'] is too short > > Fixes: a726e2f000ec ("ARM: dts: stm32: enable ltdc binding with ili9341, gyro > l3gd20 on stm32429-disco board") > Signed-off-by: Dillon Min > Reported-by: ker

Re: [PATCH v4 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-08-05 Thread Linus Walleij
ed-off-by: Dillon Min > Reported-by: kernel test robot > Reviewed-by: Linus Walleij > Reviewed-by: Jagan Teki > --- > v4: > - fix m68k-allmodconfig build error which reported by lkp, thanks. > - add Copyright 2018 David Lechner . Patch applied to drm-misc-next Thanks for working on this driver! Yours, Linus Walleij

Re: [PATCH v4 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-08-05 Thread Linus Walleij
On Sat, Jul 24, 2021 at 5:44 AM wrote: > From: Dillon Min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: Dillon Min > Reviewed-by: Linus Walleij > Reviewed-by: Rob Herring > Link: > https://lore.kernel.org/lkml/1626853288-31223-2-g

Re: [PATCH 0/8] arm: ep93xx: CCF conversion

2021-07-31 Thread Linus Walleij
t; Nikita Shubin (1): > ep93xx: clock: convert in-place to COMMON_CLK This series is looking very good. Reviewed-by: Linus Walleij I suppose the per-subsystem patches can be picked up by each subsystem maintainer and then you can send the "big patch" to the SoC tree. Yours, Linus Walleij

Re: [PATCH 2/2] drm/panel: Add Samsung S6E3FA2 DSI panel driver

2021-07-26 Thread Linus Walleij
const u8 seq_ea8064g_test_key_dis[6] = { > + 0xf1, 0xa5, 0xa5, > + 0xf0, 0xa5, 0xa5 > +}; The use of two different registers for locking is suspicious, that may point to different display controllers. :/ This is an icky panel, but it seems they are close enough to be handled by the same driver IMO. Yours, Linus Walleij

Re: [PATCH 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel

2021-07-26 Thread Linus Walleij
ed: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/2] drm/panel: Add Samsung S6E3FA2 DSI panel driver

2021-07-26 Thread Linus Walleij
D: 0x%x)\n", > > + lcd_id); > > + ctx->subtype = PANEL_EA8064G; > > + ctx->seq_data = _ea8064g; > > + break; > > + default: > > + dev_warn(>dev, "unsupported panel ID: 0x%x\n", lcd_id); > > + ctx->subtype = PANEL_UNKNOWN; This does look like two different panels, I'd like to know the MTP IDs printed (also wrote in different mail). The MTP print I think should be kept. Yours, Linus Walleij

Re: [PATCH v3 2/2] drm/panel: Add panel for Samsung Galaxy S5

2021-07-26 Thread Linus Walleij
dev_err(dev, "could not read MTP ID2\n"); return ret; } ret = mipi_dsi_dcs_read(dsi, READ_ID3, , 1); if (ret < 0) { dev_err(dev, "could not read MTP ID3\n"); return ret; } dev_info(dev, "MTP ID manufacturer: %02x version: %02x driver: %02x\n", id1, id2, id3); return 0; } (Dry coded, but you get the idea.) Yours, Linus Walleij

Re: [PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel

2021-07-26 Thread Linus Walleij
be put as children right inside the DSI controller node without any port linking the two. Other than that it looks good! Yours, Linus Walleij

Re: [PATCH v4] backlight: ktd253: Stabilize backlight

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 4:37 PM Lee Jones wrote: > How loudly will you shout if I submit this for v5.15-rc1? It's cool, the users (PostmarketOS) have the patch applied externally anyway. Yours, Linus Walleij

Re: [PATCH] dt-bindings: Remove "status" from schema examples

2021-07-21 Thread Linus Walleij
On Tue, Jul 20, 2021 at 7:20 PM Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). All of mine are mistakes anyway. Reviewe

Re: [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 4:18 PM Sam Ravnborg wrote: > Hi Linus, > On Wed, Jul 21, 2021 at 04:00:35PM +0200, Linus Walleij wrote: > > On Wed, Jul 21, 2021 at 9:41 AM wrote: > > > > > From: Dillon Min > > > > > > Add documentation for "il

Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 9:41 AM wrote: > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus

Re: [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-21 Thread Linus Walleij
On Wed, Jul 21, 2021 at 9:41 AM wrote: > From: Dillon Min > > Add documentation for "ilitek,ili9341" panel. > > Cc: Linus Walleij > Signed-off-by: Dillon Min > Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/2] drm/panel: Add ilitek ili9341 panel driver

2021-07-17 Thread Linus Walleij
veral regulators using bulk. The regulator framework will provide dummy regulators if you didn't define some of them so it is fine to just provide one or two. Yours, Linus Walleij

Re: [PATCH 1/2] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2021-07-17 Thread Linus Walleij
cription: Voltage supply for the LED driver (1.65 .. 3.3 V) Yours, Linus Walleij

[PATCH v4] backlight: ktd253: Stabilize backlight

2021-07-15 Thread Linus Walleij
is substantial. Add some code to detect if an interrupt occurs during the tight loop and in that case just redo it from the top. Fixes: 5317f37e48b9 ("backlight: Add Kinetic KTD253 backlight driver") Cc: Stephan Gerhold Reported-by: newb...@disroot.org Reviewed-by: Daniel Thompson Signed-off

[PATCH] drm/panel-sony-acx424akp: Modernize backlight handling

2021-07-15 Thread Linus Walleij
obe() use cases along the way. Tested on the U8500 HREF520 reference design. Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sony-acx424akp.c | 84 +++- 1 file changed, 28 insertions(+), 56 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sony-acx424akp.c b/driv

[PATCH] drm/panel: Document internal backlight handling

2021-07-15 Thread Linus Walleij
Panels with internal backlight need to assign their backlight member directly. Reported-by: Doug Anderson Signed-off-by: Linus Walleij --- include/drm/drm_panel.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index

Re: [PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-15 Thread Linus Walleij
gt; */ > > I do not personally know the motivation of not letting drivers assign > it, but with the words "shall not". Yikes! I think it's a documentation bug. I trust Sam more than the docs. I'll send a patch. Yours, Linus Walleij

[PATCH 2/2 v4] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-14 Thread Linus Walleij
Reviewed-by: Douglas Anderson Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Add more talkative Kconfig telling which mobile phone has this. - Make sure to turn off the internal backlight totally if requested. - Alter the logic so that we assign the backlight handle to panel->bac

[PATCH 1/2 v4] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-07-14 Thread Linus Walleij
This adds device tree bindings for the Samsung Mobile Displays LMS380KF01 RGB DPI display panel. Cc: devicet...@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: Noralf Trønnes Reviewed-by: Sam Ravnborg Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring Signed-off-by: Linus Walleij

Re: [PATCH v3] backlight: ktd253: Stabilize backlight

2021-07-13 Thread Linus Walleij
On Fri, Jun 4, 2021 at 8:34 AM Linus Walleij wrote: > Remove interrupt disablement during backlight setting. It is > way to dangerous and makes platforms instable by having it > miss vblank IRQs leading to the graphics derailing. > > The code is using ndelay() which i

Re: [PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-09 Thread Linus Walleij
here is no datasheet. These delays are in the product source code tree for the GT-I8160 (Codina) mobile phone, actually in the glue integration code. WideChips were acquired by some other firm and do not exist anymore so I can't ask them, and asking Samsung for anything else than source code doesn't work either. (I have tried.) Yours, Linus Walleij

[PATCH 2/2 v3] drm/panel: ws2401: Add driver for WideChips WS2401

2021-07-07 Thread Linus Walleij
-off-by: Linus Walleij --- ChangeLog v2->v3: - Drop the ws2401_command() macro - we enhanced the mipi_dbi_command() to print errors for everyone instead. - Read out MTP properly (used wrong variables) - Register internal backlight if and only if the panel->backlight field is NULL after

[PATCH 1/2 v3] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-07-07 Thread Linus Walleij
This adds device tree bindings for the Samsung Mobile Displays LMS380KF01 RGB DPI display panel. Cc: devicet...@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: Douglas Anderson Cc: Noralf Trønnes Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - No changes just resending with the ser

[PATCH v3] drm/dbi: Print errors for mipi_dbi_command()

2021-07-02 Thread Linus Walleij
mipi_dbi_command_buf() directly instead. After this any code wishing to send command arrays can rely on mipi_dbi_command() providing an appropriate error message if something goes wrong. Suggested-by: Noralf Trønnes Suggested-by: Douglas Anderson Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - M

[PATCH v2] drm/dbi: Print errors for mipi_dbi_command()

2021-07-02 Thread Linus Walleij
mipi_dbi_command_buf() directly instead. After this any code wishing to send command arrays can rely on mipi_dbi_command() providing an appropriate error message if something goes wrong. Suggested-by: Noralf Trønnes Suggested-by: Douglas Anderson Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Fish

Re: [PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-02 Thread Linus Walleij
r %d when sending > > command\n", ret); \ > > }) > > Coud this be more informative if the spi device was printed, it is > available? Maybe in 99% of the cases there is only one user anyway so it > will not help? Hm I can get to the SPI device, lemme try this. Yours, Linus Walleij

[PATCH] drm/dbi: Print errors for mipi_dbi_command()

2021-07-01 Thread Linus Walleij
mipi_dbi_command_buf() directly instead. After this any code wishing to send command arrays can rely on mipi_dbi_command() providing an appropriate error message if something goes wrong. Suggested-by: Noralf Trønnes Suggested-by: Douglas Anderson Signed-off-by: Linus Walleij --- drivers/gpu/drm/drm_mipi_dbi.c

[PATCH] drm/panel: Fix up DT bindings for Samsung lms397kf04

2021-07-01 Thread Linus Walleij
e SPI host bindings. - Make spi-cpha, spi-cpol and port compulsory. - Update the example with a real-world SPI controller, spi-gpio. Cc: Douglas Anderson Cc: Noralf Trønnes Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- .../display/panel/samsung,lms397kf04.yaml | 18 +++

[PATCH] drm/panel: db7430: Improve error reporting

2021-06-30 Thread Linus Walleij
This creates a macro wrapping mipi_dbi_command() such that we get some explicit error reporting if something goes wrong. Cc: Noralf Trønnes Suggested-by: Douglas Anderson Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-samsung-db7430.c | 66 +++- 1 file changed

[PATCH 2/2 v2] drm/panel: ws2401: Add driver for WideChips WS2401

2021-06-30 Thread Linus Walleij
-off-by: Linus Walleij --- ChangeLog v1->v2: - Disable the backlight in ->unprepare() before entering sleep mode. - If we are not using internal backlight, close the L2 access after initializing. - Depromote some talkative dev_info()s to dev_dbg(). - Power up and read the MTP values bef

[PATCH 1/2 v2] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-06-30 Thread Linus Walleij
This adds device tree bindings for the Samsung Mobile Displays LMS380KF01 RGB DPI display panel. Cc: devicet...@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: Douglas Anderson Cc: Noralf Trønnes Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Expect SPI bindings to be pul

Re: [PATCH] drm/panel: ws2401: Add driver for WideChips WS2401

2021-06-30 Thread Linus Walleij
ontroller vendor comes out in the first MTP byte, and by collecting this data we can figure out to some extent what kind of hardware is actually inside some of these displays. In this case 0xDA is 0x40 so that is widechips manufacturer ID. I fixed the rest of the comments! Yours, Linus Walleij

Re: [PATCH] drm/panel: ws2401: Add driver for WideChips WS2401

2021-06-30 Thread Linus Walleij
ring is part of why we can't just have one display driver to rule them all... sadly they also make semantic sense. The vendor driver needs the display to come out of sleep right after the power-on to send the init sequence. The vendor driver does exactly this. The placement of these sleep mode in prepare/unprepare calls is because of this. Yours, Linus Walleij

Re: [PATCH v2] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-06-29 Thread Linus Walleij
O_EOT_PACKET. > > Signed-off-by: Nicolas Boichat Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-06-28 Thread Linus Walleij
On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat wrote: > On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij wrote: > > > dsi->mode_flags = > > > MIPI_DSI_CLOCK_NON_CONTINUOUS | > > > -

[PATCH] drm/panel: ws2401: Add driver for WideChips WS2401

2021-06-24 Thread Linus Walleij
-off-by: Linus Walleij --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu/drm/panel/panel-widechips-ws2401.c| 404 ++ 4 files changed, 421 insertions

[PATCH] drm/panel: Add DT bindings for Samsung LMS380KF01

2021-06-24 Thread Linus Walleij
This adds device tree bindings for the Samsung Mobile Displays LMS380KF01 RGB DPI display panel. Cc: devicet...@vger.kernel.org Cc: phone-de...@vger.kernel.org Cc: Douglas Anderson Cc: Noralf Trønnes Signed-off-by: Linus Walleij --- .../display/panel/samsung,lms380kf01.yaml | 96

Re: [PATCH 2/4] drm: panel: sofef00: remove reset GPIO handling

2021-06-24 Thread Linus Walleij
As Bjorn says: just use *_optional and comment the line out in the device tree if there is a problem. Yours, Linus Walleij

Re: [PATCH 2/2] drm/gud: Use scatter-gather USB bulk transfer

2021-06-14 Thread Linus Walleij
? then write that) The other users of usb_sg_wait() in the kernel do not have these timeout wrappers, I suspect the reasoning is something like "it's graphics, not storage, so if we timeout and lose an update, too bad but let's just continue hoping the lost graphics will be less than noticeable" so then we should write that as a comment about that in the code or something. With these comments fixed up: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 1/2] drm/gud: Free buffers on device removal

2021-06-14 Thread Linus Walleij
this is a common problem. Connect the buffer allocations to the device which will use them not the userspace facing device, indeed. Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH 2/2 v2] drm/panel: s6e63m0: Switch to DBI abstraction for SPI

2021-06-14 Thread Linus Walleij
The SPI access to s6e63m0 is using the DBI protocol, so switch to using the elaborate DBI protocol implementation in the DRM DBI helper library. Acked-by: Noralf Trønnes Reviewed-by: Douglas Anderson Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Drop two debug prints - Drop developm

[PATCH 1/2 v2] drm/dbi: Support DBI typec1 read operations

2021-06-14 Thread Linus Walleij
control. Reviewed-by: Noralf Trønnes Reviewed-by: Douglas Anderson Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Only print MIPI_DBI_DEBUG_COMMAND if ret == 0 - Collect Noralf's Reviewed-by - Collect Doug's Reviewed-by --- drivers/gpu/drm/drm_mipi_dbi.c |

[PATCH 2/2] drm/panel: s6e63m0: Switch to DBI abstraction for SPI

2021-06-11 Thread Linus Walleij
The SPI access to s6e63m0 is using the DBI protocol, so switch to using the elaborate DBI protocol implementation in the DRM DBI helper library. Cc: Douglas Anderson Cc: Noralf Trønnes Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/Kconfig | 1 + .../gpu/drm/panel

[PATCH 1/2] drm/dbi: Support DBI typec1 read operations

2021-06-11 Thread Linus Walleij
control. Cc: Douglas Anderson Cc: Noralf Trønnes Signed-off-by: Linus Walleij --- drivers/gpu/drm/drm_mipi_dbi.c | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c index 43a9b739bba7

Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
On Fri, Jun 11, 2021 at 12:42 AM Doug Anderson wrote: > On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij > wrote: > > #define mipi_dbi_command(dbi, cmd, seq...) \ > > ({ \ > > const u8 d[] = { seq }; \ > > mipi_dbi_command_stac

Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
#define mipi_dbi_command(dbi, cmd, seq...) \ ({ \ const u8 d[] = { seq }; \ mipi_dbi_command_stackbuf(dbi, cmd, d, ARRAY_SIZE(d)); \ }) I'll fix up the include and apply then we can think about what to do with mipi_dbi_command(). Yours, Linus Walleij

[PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
. The DBI "device" portions can not be used because that code assumes the use of a single regulator and specific timings around the reset pulse that do not match the DB7430 datasheet. Cc: Paul Cercueil Cc: Doug Anderson Acked-by: Noralf Trønnes Signed-off-by: Linus Walleij --- Change

Re: [PATCH v4] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
ct mipi_dbi_dev where the regulator is. Yours, Linus Walleij

[PATCH v4] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-10 Thread Linus Walleij
. The DBI "device" portions can not be used because that code assumes the use of a single regulator and specific timings around the reset pulse that do not match the DB7430 datasheet. Cc: Noralf Trønnes Cc: Paul Cercueil Cc: Doug Anderson Signed-off-by: Linus Walleij --- Change

Re: [PATCH v9 10/11] drm/bridge: ti-sn65dsi86: Improve probe errors with dev_err_probe()

2021-06-09 Thread Linus Walleij
not find any panel node > > Let's use dev_err_probe() which nicely quiets this error and also > simplifies the code a tiny bit. We'll also update other places in the > file which can use dev_err_probe(). > > Signed-off-by: Douglas Anderson Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v9 07/11] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev

2021-06-09 Thread Linus Walleij
bits return EPROBE_DEFER for a > while or wait on some sort of completion), but it seems simple enough > to just not even bother creating the bridge device until the AUX > channel probes. That's what we'll do. > > Signed-off-by: Douglas Anderson > Reviewed-by: Lyude Paul Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v9 06/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC

2021-06-09 Thread Linus Walleij
s. > > If we happen to have access to the DP AUX bus and we weren't provided > the ddc-i2c-bus in some other manner, let's use the DP AUX bus for it. > > Signed-off-by: Douglas Anderson > Reviewed-by: Lyude Paul Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v9 03/11] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child

2021-06-09 Thread Linus Walleij
glas Anderson > Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v9 02/11] dt-bindings: drm: Introduce the DP AUX bus

2021-06-09 Thread Linus Walleij
us's design was hashed out over IRC [1]. > > [1] > https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel=2021-05-11 > > Signed-off-by: Douglas Anderson > Reviewed-by: Rob Herring I overall like this approach a lot: Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH] drm/mcde: Fix off by 10^3 in calculation

2021-06-08 Thread Linus Walleij
everse calculating it from the vrefresh") Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index b3fd3501c412..5275b2723293 100644 --- a/drivers/gpu/d

Re: [PATCH v2] drm/panel: db7430: Add driver for Samsung DB7430

2021-06-04 Thread Linus Walleij
ld patch a few other drivers with this as well. Yours, Linus Walleij

Re: [PATCH 2/2] drm/vc4: hdmi: Convert to gpiod

2021-06-04 Thread Linus Walleij
On Fri, Jun 4, 2021 at 10:01 AM Maxime Ripard wrote: > On Fri, May 28, 2021 at 01:57:56AM +0200, Linus Walleij wrote: > > On Mon, May 24, 2021 at 3:19 PM Maxime Ripard wrote: > > > > > The new gpiod interface takes care of parsing the GPIO flags and to > > &

Re: [PATCH 1/2] drm/vc4: hdmi: Fix error path of hpd-gpios

2021-06-04 Thread Linus Walleij
, so the latter is definitely justified. > However at that point we still haven't called pm_runtime_enable, so the > call to pm_runtime_disable is not supposed to be there. > > Fixes: 10ee275cb12f ("drm/vc4: prepare for CEC support") > Signed-off-by: Maxime Ripard Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends

2021-06-04 Thread Linus Walleij
On Fri, Jun 4, 2021 at 11:15 AM Daniel Vetter wrote: > On Fri, Jun 04, 2021 at 09:44:59AM +0200, Linus Walleij wrote: > > On Fri, Jun 4, 2021 at 3:41 AM Kees Cook wrote: > > > > > VEXPRESS_CONFIG needs to either be missing, built-in, or modular when > > > pl1

Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends

2021-06-04 Thread Linus Walleij
ork, thanks for fixing this! > Signed-off-by: Kees Cook > - depends on VEXPRESS_CONFIG > + depends on ARM || ARM64 || COMPILE_TEST > + depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n That's the right solution, Reviewed-by: Linus Walleij Yours, Linus Walleij

LIMA kernel bug - help!

2021-06-04 Thread Linus Walleij
My UI definitely want to render some more stuff so it gets stuck here. Any hints on how to troubleshoot this? Yours, Linus Walleij

[PATCH v3] backlight: ktd253: Stabilize backlight

2021-06-04 Thread Linus Walleij
is substantial. Add some code to detect if an interrupt occurs during the tight loop and in that case just redo it from the top. Fixes: 5317f37e48b9 ("backlight: Add Kinetic KTD253 backlight driver") Cc: Stephan Gerhold Reported-by: newb...@disroot.org Signed-off-by: Linus Walleij --- Change

[PATCH] drm/panel: nt35510: Do not fail if DSI read fails

2021-06-03 Thread Linus Walleij
by killing the Gnome session repeatedly on the Samsung Skomer. Fixes: 899f24ed8d3a ("drm/panel: Add driver for Novatek NT35510-based panels") Cc: Stephan Gerhold Reported-by: newb...@disroot.org Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 4 +--- 1 file

<    1   2   3   4   5   6   7   8   9   10   >