Re: [PATCH v2 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-29 Thread Liu Ying
On 05/29/2024, Alexander Stein wrote: > Hi, > > Am Mittwoch, 29. Mai 2024, 09:50:24 CEST schrieb Liu Ying: >> On 05/29/2024, Alexander Stein wrote: >>> Although very unlike to occur (media_blk_ctrl needs 'syscon' compatible >>> removed), it lines up with the ot

Re: [PATCH v2 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-29 Thread Liu Ying
_regmap(np, true); } EXPORT_SYMBOL_GPL(syscon_node_to_regmap); Regard, Liu Ying > > Signed-off-by: Alexander Stein > --- > Changes in v2: > * Removed unused variable > * Added missing \n at end of string > > drivers/gpu/drm/bridge/imx/imx93-mipi-

Re: [PATCH 1/1] drm/bridge: imx93-mipi-dsi: Use dev_err_probe

2024-05-28 Thread Liu Ying
"failed to get block ctrl regmap"); Missing \n. And, a build warning: drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c: In function ‘imx93_dsi_probe’: drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c:837:13: warning: unused variable ‘ret’ [-Wunused-variable]

Re: [PATCH] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-05-21 Thread Liu Ying
mark the respective IRQ status >> accordingly, and delay the check until everything has been processed. >> >> This should guarantee the helper functions don't return prematurely >> while still returning proper values of either IRQ_HANDLED or IRQ_NONE. >> >> Reported b

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Liu Ying
On 5/20/24 17:08, Dmitry Baryshkov wrote: > On Mon, 20 May 2024 at 06:29, Liu Ying wrote: >> >> On 5/20/24 06:11, Dmitry Baryshkov wrote: >>> On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: >>>> Commit f3d9683346d6 ("drm/bridge: adv7511:

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-19 Thread Liu Ying
On 5/20/24 06:11, Dmitry Baryshkov wrote: > On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote: >> Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") >> fails to consider the case where adv7511->i2c_main->irq is zero, i.e., &

Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

2024-05-16 Thread Liu Ying
On 5/16/24 20:36, Neil Armstrong wrote: > On 16/05/2024 13:06, Aradhya Bhatia wrote: >> Hi Liu, >> >> Thanks for reviewing the patch. >> >> On 16/05/24 07:49, Liu Ying wrote: >>> On 5/15/24 17:51, Aradhya Bhatia wrote: >>>> Add the Microtips T

[PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-16 Thread Liu Ying
s(). Fixes: f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm

Re: [PATCH v3 6/6] drm/panel: simple: Add Microtips Technology MF-103HIEB0GA0 panel

2024-05-15 Thread Liu Ying
oads/spec/datasheetFile/2660/13-103HIEB0GA0-S_V1.0_20211206.pdf > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/panel/panel-simple.c | 32 > 1 file changed, 32 insertions(+) Like my comments for patch 3/6, this panel is not simple enou

Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

2024-05-15 Thread Liu Ying
hich don't comply with this binding, like RL, TB, STBYB and RESET. Note this binding only allows compatible, ports, backlight, enable-gpios and power-supply properties, nothing more. Regards, Liu Ying > [2]: > https://lincolntechsolutions.com/wp-content/uploads/2023/04/LCD185-101CT

Re: [PATCH] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core

2024-05-14 Thread Liu Ying
linux.dev > Cc: ker...@dh-electronics.com > Cc: linux-arm-ker...@lists.infradead.org > --- > .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 > .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml| 8 > 2 files changed, 8 insertions(+), 8 delet

[PATCH] drm/bridge: adv7511: Attach next bridge without creating connector

2024-05-13 Thread Liu Ying
.display-controller: error -EINVAL: Cannot connect bridge [2.274009] imx-lcdif 32e8.display-controller: probe with driver imx-lcdif failed with error -22 Fixes: 14b3cdbd0e5b ("drm/bridge: adv7511: make it honour next bridge in DT") Signed-off-by: Liu Ying --- drivers/gpu/drm/brid

Re: [PATCH] drm/bridge: imx: Remove redundant checks on existence of bridge->encoder

2024-05-12 Thread Liu Ying
bridge attach functions are called." Regards, Liu Ying > > Remove the redundant checking codes "if (!bridge->encoder) { ... }". > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 5 - > drivers/gpu/drm/bridge/im

[PATCH] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA

2024-05-08 Thread Liu Ying
KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. This aligns display_timing with panel_desc. Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel") Signed-off-by

[PATCH v2 2/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-26 Thread Liu Ying
ot;) Fixes: 199cf07ebd2b ("drm/bridge: panel: Add a device link between drm device and panel device") Reported-by: Linus Walleij Closes: https://lore.kernel.org/lkml/cacrpkdagzxd6hbix7mvunjajtmepg00pp6+nj1p0jrfj-ar...@mail.gmail.com/T/ Tested-by: Linus Walleij Signed-off-by: Liu Ying

[PATCH v2 1/2] driver core: Export device_is_dependent() to modules

2023-11-26 Thread Liu Ying
Export device_is_dependent() since the drm_kms_helper module is starting to use it. Signed-off-by: Liu Ying --- v2: * Newly introduced as needed by patch 2. drivers/base/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 67ba592afc77

[PATCH v2 0/2] drm/bridge: panel: Check device dependency before managing device link

2023-11-26 Thread Liu Ying
ink. Note that patch 2 is already in drm-misc/drm-misc-fixes and drm-misc/for-linux-next-fixes. Patch 1 needs to be reviewed and picked up. v2: * Introduce patch 1 to export device_is_dependent() to modules as needed by patch 2. Liu Ying (2): driver core: Export device_is_dependent() to modules

[PATCH v2] drm/bridge: imx93-mipi-dsi: Fix a couple of building warnings

2023-11-22 Thread Liu Ying
by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311151746.f7u7dzbz-...@intel.com/ Signed-off-by: Liu Ying --- v2: * Initialize 'best_n' to UINT_MAX instead of zero. (Maxime) drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH] drm/bridge: panel: Check device dependency before managing device link

2023-11-22 Thread Liu Ying
ot;) Fixes: 199cf07ebd2b ("drm/bridge: panel: Add a device link between drm device and panel device") Reported-by: Linus Walleij Closes: https://lore.kernel.org/lkml/cacrpkdagzxd6hbix7mvunjajtmepg00pp6+nj1p0jrfj-ar...@mail.gmail.com/T/ Tested-by: Linus Walleij Signed-off-by: Liu Ying

[PATCH] drm/bridge: imx93-mipi-dsi: Fix a couple of building warnings

2023-11-21 Thread Liu Ying
es: https://lore.kernel.org/oe-kbuild-all/202311151746.f7u7dzbz-...@intel.com/ Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c b/drivers/gpu/drm/bridge/imx/

[PATCH] drm/bridge: synopsys: dw-mipi-dsi: Fix hcomponent lbcc for burst mode

2023-10-17 Thread Liu Ying
: Use pixel clock rate to calculate lbcc") Reported-by: Heiko Stübner Closes: https://lore.kernel.org/linux-arm-kernel/5979575.UjTJXf6HLC@diego/T/#u Tested-by: Heiko Stübner # px30 minievb with xinpeng xpp055c272 Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/synopsys/dw-mipi-

[PATCH v14 RESEND 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2023-08-22 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v11->v14: * No change. v10->v11: * Rebase upon v6.0-rc1. v9->v10: * Add Laurentiu's A-b tag. v1->v9: * No change. MAINTAINERS | 9 + 1 file changed,

[PATCH v14 RESEND 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2023-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v14: * No change. v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional

[PATCH v14 RESEND 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2023-08-22 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v6->v14: * No change. v5->v6: * Fix commit message typo - s/Artifically/Artificially/

[PATCH v14 RESEND 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2023-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v4->v14: * No change. v3->v4: * Improve compatible property by using enum instead of oneOf+const. (Rob) * Add Rob's R-b tag. v2->v3: * No change. v1->v

[PATCH v14 RESEND 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2023-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v7->v14: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag as review is needed. v4->v5: * No change. v3-&g

[PATCH v14 RESEND 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-08-22 Thread Liu Ying
Fix dt binding yamllint warnings. * Require bypass0 and bypass1 clocks for both i.MX8qxp and i.MX8qm in DPU's dt binding documentation. * Use new dt binding way to add clocks in the dt binding examples. * Address several comments from Laurentiu on the DPU DRM patch. Liu Ying (6): dt-bindings: disp

[PATCH v3 RESEND 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-08-20 Thread Liu Ying
i.MX93 MIPI DSI specific extensions. Signed-off-by: Liu Ying --- v2->v3: * Select GENERIC_PHY to fix Kconfig warning for GENERIC_PHY_MIPI_DPHY dependency. v1->v2: * Use dev_err_probe() to replace DRM_DEV_ERROR(). (Sam and Alexander) * Use dev_*() to replace DRM_*(). (Sam) * Fix build f

[PATCH v3 RESEND 8/9] dt-bindings: display: bridge: Document Freescale i.MX93 MIPI DSI

2023-08-20 Thread Liu Ying
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host controller and a Synopsys Designware MIPI DPHY. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Signed-off-by: Liu Ying Reviewed-by: Rob Herring --- v2->v3: * No change. v1->v2: * Add Rob

[PATCH v3 RESEND 7/9] drm/bridge: synopsys: dw-mipi-dsi: Disable HSTX and LPRX timeout check

2023-08-20 Thread Liu Ying
happen for the 1920x1080p@60 video mode at least. Signed-off-by: Liu Ying Reviewed-by: Neil Armstrong --- v2->v3: * Add Neil's R-b tag from v1. v1->v2: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH v3 RESEND 6/9] drm/bridge: synopsys: dw-mipi-dsi: Set minimum lane byte clock cycles for HSA and HBP

2023-08-20 Thread Liu Ying
sum up HSA, HBP, HFP and HDISPLAY. This helps the case where Raydium RM67191 DSI panel is connected, since it's video timing for hsync length is only 2 pixels and without this patch the programmed value for DSI_VID_HSA_TIME is only 2 with 4 data lanes. Signed-off-by: Liu Ying Reviewed-by: N

[PATCH v3 RESEND 5/9] drm/bridge: synopsys: dw-mipi-dsi: Use pixel clock rate to calculate lbcc

2023-08-20 Thread Liu Ying
video mode. Signed-off-by: Liu Ying Reviewed-by: Neil Armstrong --- v2->v3: * Add Neil's R-b tag from v1. v1->v2: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi

[PATCH v3 RESEND 4/9] drm/bridge: synopsys: dw-mipi-dsi: Add mode fixup support

2023-08-20 Thread Liu Ying
Vendor drivers may need to fixup mode due to pixel clock tree limitation, so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data and call it at atomic check stage if available. Signed-off-by: Liu Ying --- v1->v3: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.

[PATCH v3 RESEND 3/9] drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags

2023-08-20 Thread Liu Ying
. Signed-off-by: Liu Ying --- v1->v3: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 945d46a76995..ed9288a9c444 100

[PATCH v3 RESEND 2/9] drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support

2023-08-20 Thread Liu Ying
ormats through pdata->get_input_bus_fmts() first. If it's unavailable, fall back to the only format - MEDIA_BUS_FMT_FIXED, which matches the default behavior if ->atomic_get_input_bus_fmts() is not implemented as ->atomic_get_input_bus_fmts()'s kerneldoc indicates. Signed-off-by: Liu Y

[PATCH v3 RESEND 1/9] drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper

2023-08-20 Thread Liu Ying
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor drivers which implement vendor specific extensions to Synopsys DW MIPI DSI. Signed-off-by: Liu Ying --- v1->v3: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++ include/drm/bridge/dw_mipi_ds

[PATCH v3 RESEND 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-08-20 Thread Liu Ying
mprove error messages for imx93_dsi_phy_init() in patch 9. Liu Ying (9): drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags drm/

[PATCH v3] drm/bridge: panel: Add a device link between drm device and panel device

2023-08-07 Thread Liu Ying
the order is reversed, like the problematic case mentioned in the below link. Link: https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/ Suggested-by: Ulf Hansson Signed-off-by: Liu Ying --- v2->v3: * Improve commit message s/swapped/reversed/.

[PATCH v3 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-08-06 Thread Liu Ying
i.MX93 MIPI DSI specific extensions. Signed-off-by: Liu Ying --- v2->v3: * Select GENERIC_PHY to fix Kconfig warning for GENERIC_PHY_MIPI_DPHY dependency. v1->v2: * Use dev_err_probe() to replace DRM_DEV_ERROR(). (Sam and Alexander) * Use dev_*() to replace DRM_*(). (Sam) * Fix build f

[PATCH v3 8/9] dt-bindings: display: bridge: Document Freescale i.MX93 MIPI DSI

2023-08-06 Thread Liu Ying
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host controller and a Synopsys Designware MIPI DPHY. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Signed-off-by: Liu Ying Reviewed-by: Rob Herring --- v2->v3: * No change. v1->v2: * Add Rob

[PATCH v3 6/9] drm/bridge: synopsys: dw-mipi-dsi: Set minimum lane byte clock cycles for HSA and HBP

2023-08-06 Thread Liu Ying
sum up HSA, HBP, HFP and HDISPLAY. This helps the case where Raydium RM67191 DSI panel is connected, since it's video timing for hsync length is only 2 pixels and without this patch the programmed value for DSI_VID_HSA_TIME is only 2 with 4 data lanes. Signed-off-by: Liu Ying Reviewed-by: N

[PATCH v3 7/9] drm/bridge: synopsys: dw-mipi-dsi: Disable HSTX and LPRX timeout check

2023-08-06 Thread Liu Ying
happen for the 1920x1080p@60 video mode at least. Signed-off-by: Liu Ying Reviewed-by: Neil Armstrong --- v2->v3: * Add Neil's R-b tag from v1. v1->v2: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH v3 4/9] drm/bridge: synopsys: dw-mipi-dsi: Add mode fixup support

2023-08-06 Thread Liu Ying
Vendor drivers may need to fixup mode due to pixel clock tree limitation, so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data and call it at atomic check stage if available. Signed-off-by: Liu Ying --- v1->v3: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.

[PATCH v3 5/9] drm/bridge: synopsys: dw-mipi-dsi: Use pixel clock rate to calculate lbcc

2023-08-06 Thread Liu Ying
video mode. Signed-off-by: Liu Ying Reviewed-by: Neil Armstrong --- v2->v3: * Add Neil's R-b tag from v1. v1->v2: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi

[PATCH v3 3/9] drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags

2023-08-06 Thread Liu Ying
. Signed-off-by: Liu Ying --- v1->v3: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 8580b8a97fb1..8cd89a63b5f2 100

[PATCH v3 2/9] drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support

2023-08-06 Thread Liu Ying
ormats through pdata->get_input_bus_fmts() first. If it's unavailable, fall back to the only format - MEDIA_BUS_FMT_FIXED, which matches the default behavior if ->atomic_get_input_bus_fmts() is not implemented as ->atomic_get_input_bus_fmts()'s kerneldoc indicates. Signed-off-by: Liu Y

[PATCH v3 1/9] drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper

2023-08-06 Thread Liu Ying
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor drivers which implement vendor specific extensions to Synopsys DW MIPI DSI. Signed-off-by: Liu Ying --- v1->v3: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++ include/drm/bridge/dw_mipi_ds

[PATCH v3 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-08-06 Thread Liu Ying
y_init() in patch 9. Liu Ying (9): drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags drm/bridge: synopsys: dw-mipi-dsi: Add mode fixup support

[PATCH v2] drm/bridge: panel: Add a device link between drm device and panel device

2023-07-17 Thread Liu Ying
the order is swapped, like the problematic case mentioned in the below link. Link: https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/ Suggested-by: Ulf Hansson Signed-off-by: Liu Ying --- v1->v2: * Fix bailout for panel_bridge_attach() in c

[PATCH] drm/bridge: panel: Add a device link between drm device and panel device

2023-07-17 Thread Liu Ying
the order is swapped, like the problematic case mentioned in the below link. Link: https://lore.kernel.org/lkml/capdykfr0xjru_udkoukq_q8rwaukyql+8fv-7s1ctmqi7u3...@mail.gmail.com/T/ Suggested-by: Ulf Hansson Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/panel.c | 15 +++ 1 file

[PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-17 Thread Liu Ying
i.MX93 MIPI DSI specific extensions. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/imx/Kconfig | 10 + drivers/gpu/drm/bridge/imx/Makefile | 1 + drivers/gpu/drm/bridge/imx/imx93-mipi-dsi.c | 934 3 files changed, 945 insertions(+) create mode 100644

[PATCH 8/9] dt-bindings: display: bridge: Document Freescale i.MX93 MIPI DSI

2023-07-17 Thread Liu Ying
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host controller and a Synopsys Designware MIPI DPHY. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Signed-off-by: Liu Ying --- .../display/bridge/fsl,imx93-mipi-dsi.yaml| 115

[PATCH 7/9] drm/bridge: synopsys: dw-mipi-dsi: Disable HSTX and LPRX timeout check

2023-07-17 Thread Liu Ying
happen for the 1920x1080p@60 video mode at least. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index

[PATCH 6/9] drm/bridge: synopsys: dw-mipi-dsi: Set minimum lane byte clock cycles for HSA and HBP

2023-07-17 Thread Liu Ying
sum up HSA, HBP, HFP and HDISPLAY. This helps the case where Raydium RM67191 DSI panel is connected, since it's video timing for hsync length is only 2 pixels and without this patch the programmed value for DSI_VID_HSA_TIME is only 2 with 4 data lanes. Signed-off-by: Liu Ying --- drivers/gpu/

[PATCH 5/9] drm/bridge: synopsys: dw-mipi-dsi: Use pixel clock rate to calculate lbcc

2023-07-17 Thread Liu Ying
video mode. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index c754d55f71d1..332388fd86da 100644

[PATCH 3/9] drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags

2023-07-17 Thread Liu Ying
. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 8580b8a97fb1..8cd89a63b5f2 100644 --- a/drivers/gpu/drm

[PATCH 4/9] drm/bridge: synopsys: dw-mipi-dsi: Add mode fixup support

2023-07-17 Thread Liu Ying
Vendor drivers may need to fixup mode due to pixel clock tree limitation, so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data and call it at atomic check stage if available. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c |

[PATCH 2/9] drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support

2023-07-17 Thread Liu Ying
ormats through pdata->get_input_bus_fmts() first. If it's unavailable, fall back to the only format - MEDIA_BUS_FMT_FIXED, which matches the default behavior if ->atomic_get_input_bus_fmts() is not implemented as ->atomic_get_input_bus_fmts()'s kerneldoc indicates. Signed-off-by: Liu Yin

[PATCH 1/9] drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper

2023-07-17 Thread Liu Ying
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor drivers which implement vendor specific extensions to Synopsys DW MIPI DSI. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++ include/drm/bridge/dw_mipi_dsi.h | 2 ++ 2 files

[PATCH 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-17 Thread Liu Ying
driver. Patch 8 adds DT-binding documentation for i.MX93 MIPI DSI. Patch 9 adds i.MX93 MIPI DSI DRM bridge. Liu Ying (9): drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support drm/bridge: synopsys

[PATCH v2] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Liu Ying
: cb285a5348e7 ("drm: mxsfb: Replace mxsfb_get_fb_paddr() with drm_fb_cma_get_gem_addr()") Cc: sta...@vger.kernel.org # 5.19+ Signed-off-by: Liu Ying --- v1->v2: * Cc stable. (Marek) drivers/gpu/drm/mxsfb/mxsfb_kms.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/

[PATCH] drm/mxsfb: Disable overlay plane in mxsfb_plane_overlay_atomic_disable()

2023-06-12 Thread Liu Ying
: cb285a5348e7 ("drm: mxsfb: Replace mxsfb_get_fb_paddr() with drm_fb_cma_get_gem_addr()") Signed-off-by: Liu Ying --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c index 3b

[PATCH v3 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2023-06-05 Thread Liu Ying
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Add a DRM bridge driver to support the display format configuration. Signed-off-by: Liu Ying --- v2->v3: * No change. v1->v2: * Set

[PATCH v3 1/2] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example

2023-06-05 Thread Liu Ying
i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Document the Parallel Display Format Configuration(PDFC) subnode and add the subnode to example. Signed-off-by: Liu Ying --- v2-&g

[PATCH v3 0/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2023-06-05 Thread Liu Ying
ove_new callback in imx93_pdfc_bridge_driver in patch 2/2. Liu Ying (2): dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example drm/bridge: imx: Add i.MX93 parallel display format configuration support .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 68 ++ drivers/gpu/drm/br

[PATCH v2 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2023-05-31 Thread Liu Ying
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Add a DRM bridge driver to support the display format configuration. Signed-off-by: Liu Ying --- v1->v2: * Set *num_input_fmts to

[PATCH v2 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration

2023-05-31 Thread Liu Ying
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Add device tree bindings for the display format configuration. Signed-off-by: Liu Ying --- v1->v2: * No change. .../display/bri

[PATCH v2 0/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2023-05-31 Thread Liu Ying
zero in case imx93_pdfc_bridge_atomic_get_input_bus_fmts() returns NULL in patch 2/2. * Replace .remove callback with .remove_new callback in imx93_pdfc_bridge_driver in patch 2/2. Liu Ying (2): dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration drm/bri

[PATCH v6 6/6] drm: lcdif: Add i.MX93 LCDIF compatible string

2023-05-10 Thread Liu Ying
-by: Marek Vasut Signed-off-by: Liu Ying --- v5->v6: * Add Marek's R-b tag. v4->v5: * Add Alexander's T-b tag. v3->v4: * Add Alexander's R-b tag. v2->v3: * Fix a trivial typo in commit message. v1->v2: * Split from patch 2/2 in v1. (Marek, Alexander) drivers/gpu/drm/mxsfb/lcdif

[PATCH v6 5/6] drm: lcdif: Add multiple encoders and first bridges support

2023-05-10 Thread Liu Ying
. Tested-by: Alexander Stein Acked-by: Alexander Stein Signed-off-by: Liu Ying --- v5->v6: * Drop MAX_DISPLAYS macro. (Marek) * Drop the encoder member in struct lcdif_drm_private. * Drop endpoint id check. * Allocate encoders by calling devm_kzalloc(). v4->v5: * Rebase upon v6

[PATCH v6 4/6] drm: lcdif: Check consistent bus format and flags across first bridges

2023-05-10 Thread Liu Ying
ein Reviewed-by: Marek Vasut Signed-off-by: Liu Ying --- v5->v6: * Add Marek's R-b. * A slight change brought from the update in patch 2/6 to keep default MEDIA_BUS_FMT_RGB888_1X24 bus format. v4->v5: * Add Alexander's A-b and T-b tags. v3->v4: * No change. v2->v3: * No change.

[PATCH v6 3/6] drm: lcdif: Determine bus format and flags in ->atomic_check()

2023-05-10 Thread Liu Ying
structure is introduced to cache bus format and bus flags states in ->atomic_check() so that they can be read in ->atomic_enable(). Tested-by: Alexander Stein Reviewed-by: Alexander Stein Reviewed-by: Marek Vasut Signed-off-by: Liu Ying --- v5->v6: * Add Marek's R-b tag. * A slight c

[PATCH v6 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge

2023-05-10 Thread Liu Ying
A valid bridge is already found in lcdif_attach_bridge() and set to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop the unnecessary NULL pointer check in KMS stage. Tested-by: Alexander Stein Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v5->v6: * Kee

[PATCH v6 1/6] dt-bindings: lcdif: Add i.MX93 LCDIF support

2023-05-10 Thread Liu Ying
). i.MX93 LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device tree binding for i.MX93 LCDIF. Acked-by: Krzysztof Kozlowski Reviewed-by: Marek Vasut Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Add Alexan

[PATCH v6 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-05-10 Thread Liu Ying
nneeded 'bridges' member from lcdif_drm_private structure. * Drop a comment about bridge input bus format from lcdif_crtc_atomic_check(). Liu Ying (6): dt-bindings: lcdif: Add i.MX93 LCDIF support drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge drm: lcdif: Det

[PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support

2023-05-08 Thread Liu Ying
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support. The panel has a LVDS display interface. The panel's product specification can be found at: http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf Signed-off-by: Liu Ying --- v1->v2: * Us

[PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support

2023-05-08 Thread Liu Ying
ing in patch 2/2 to tell minimum and maximum pixel clock rates. * Set bus_flags to DRM_BUS_FLAG_DE_HIGH in struct panel_desc in patch 2/2. Liu Ying (2): dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support .../bindi

[PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel

2023-05-08 Thread Liu Ying
igned-off-by: Liu Ying --- v1->v2: * Add Krzysztof's A-b tag. .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/pan

[PATCH v5 6/6] drm: lcdif: Add i.MX93 LCDIF compatible string

2023-05-07 Thread Liu Ying
-by: Liu Ying --- v4->v5: * Add Alexander's T-b tag. v3->v4: * Add Alexander's R-b tag. v2->v3: * Fix a trivial typo in commit message. v1->v2: * Split from patch 2/2 in v1. (Marek, Alexander) drivers/gpu/drm/mxsfb/lcdif_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

[PATCH v5 5/6] drm: lcdif: Add multiple encoders and first bridges support

2023-05-07 Thread Liu Ying
. Tested-by: Alexander Stein Acked-by: Alexander Stein Signed-off-by: Liu Ying --- v4->v5: * Rebase upon v6.4-rc1 and resolve a trivial conflict. * Add Alexander's A-b and T-b tags. v3->v4: * Improve warning message when ignoring invalid LCDIF OF endpoint ids. (Alexander) v2->v3: *

[PATCH v5 4/6] drm: lcdif: Check consistent bus format and flags across first bridges

2023-05-07 Thread Liu Ying
ein Signed-off-by: Liu Ying --- v4->v5: * Add Alexander's A-b and T-b tags. v3->v4: * No change. v2->v3: * No change. v1->v2: * Split from patch 2/2 in v1. (Marek, Alexander) * Drop a comment about bridge input bus format from lcdif_crtc_atomic_check(). drivers/gpu/drm/mxsfb/l

[PATCH v5 3/6] drm: lcdif: Determine bus format and flags in ->atomic_check()

2023-05-07 Thread Liu Ying
structure is introduced to cache bus format and bus flags states in ->atomic_check() so that they can be read in ->atomic_enable(). Tested-by: Alexander Stein Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v4->v5: * Add Alexander's R-b and T-b tags. v3->v4: * Use 'new_{c,p}state'

[PATCH v5 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge

2023-05-07 Thread Liu Ying
A valid bridge is already found in lcdif_attach_bridge() and set to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop the unnecessary NULL pointer check in KMS stage. Tested-by: Alexander Stein Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v4->v5: * Add Alexan

[PATCH v5 1/6] dt-bindings: lcdif: Add i.MX93 LCDIF support

2023-05-07 Thread Liu Ying
). i.MX93 LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device tree binding for i.MX93 LCDIF. Acked-by: Krzysztof Kozlowski Reviewed-by: Marek Vasut Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v4->v5: * No change. v3->v4: * Add Alexander's R-b tag.

[PATCH v5 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-05-07 Thread Liu Ying
ut bus format from lcdif_crtc_atomic_check(). Liu Ying (6): dt-bindings: lcdif: Add i.MX93 LCDIF support drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge drm: lcdif: Determine bus format and flags in ->atomic_check() drm: lcdif: Check consistent bus format and flags across first bridges

Re: [PATCH 37/37] drm/bridge/imx/Kconfig: Prevent imx-ldb-helper from appearing in 2 separate modules

2023-03-17 Thread Liu Ying
Hi Lee, On Fri, 2023-03-17 at 08:17 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile: > imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb > > Cc: Liu Ying &

[PATCH v2] drm/bridge: Fix returned array size name for atomic_get_input_bus_fmts kdoc

2023-03-13 Thread Liu Ying
2df58acc68 ("drm/bridge: Add the necessary bits to support bus format negotiation") Signed-off-by: Liu Ying --- v1->v2: * Correct Fixes tag format. * Copy DRM bridge driver maintainers. * Copy Boris. include/drm/drm_bridge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH] MAINTAINERS: Add include/drm/drm_bridge.h to DRM DRIVERS FOR BRIDGE CHIPS

2023-03-12 Thread Liu Ying
Appropriate maintainers should be suggested for changes to the include/drm/drm_bridge.h header file, so add the header file to the 'DRM DRIVERS FOR BRIDGE CHIPS' section. Signed-off-by: Liu Ying --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH] drm: Use of_property_present() for testing DT property presence

2023-03-12 Thread Liu Ying
ind_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring > --- > drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 2 +- Reviewed-by: Liu Ying # i

[PATCH] drm/bridge: Fix returned array size name for atomic_get_input_bus_fmts kdoc

2023-03-09 Thread Liu Ying
ot;f32df58acc68 drm/bridge: Add the necessary bits to support bus format negotiation") Signed-off-by: Liu Ying --- include/drm/drm_bridge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 6b65b0dfb4fb.

Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-02-20 Thread Liu Ying
On Mon, 2023-02-20 at 11:16 +0100, Alexander Stein wrote: > Hi Liu, Hi Alexander, > > Am Montag, 20. Februar 2023, 09:55:19 CET schrieb Alexander Stein: > > Hi Liu, > > > > Am Freitag, 17. Februar 2023, 09:59:14 CET schrieb Liu Ying: > > > On Fri, 2023-0

Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-02-17 Thread Liu Ying
On Fri, 2023-02-17 at 09:18 +0100, Alexander Stein wrote: > Hi Liu, Hi Alexander, > > Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying: > > Hi, > > > > This patch set aims to add i.MX93 LCDIF display controller support > > in the existing LCDI

[PATCH v4 6/6] drm: lcdif: Add i.MX93 LCDIF compatible string

2023-02-16 Thread Liu Ying
With all previous preparations done to make it possible for the single LCDIF embedded in i.MX93 SoC to drive multiple displays simultaneously, add i.MX93 LCDIF compatible string as the last step of adding i.MX93 LCDIF support. Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v3->

[PATCH v4 5/6] drm: lcdif: Add multiple encoders and first bridges support

2023-02-16 Thread Liu Ying
. Signed-off-by: Liu Ying --- v3->v4: * Improve warning message when ignoring invalid LCDIF OF endpoint ids. (Alexander) v2->v3: * No change. v1->v2: * Split from patch 2/2 in v1. (Marek, Alexander) * Drop '!remote ||' from lcdif_attach_bridge(). (Lothar) * Drop unneeded 'bridges' me

[PATCH v4 4/6] drm: lcdif: Check consistent bus format and flags across first bridges

2023-02-16 Thread Liu Ying
The single LCDIF embedded in i.MX93 SoC may drive multiple displays simultaneously. Check bus format and flags across first bridges in ->atomic_check() to ensure they are consistent. This is a preparation for adding i.MX93 LCDIF support. Signed-off-by: Liu Ying --- v3->v4: * No change.

[PATCH v4 3/6] drm: lcdif: Determine bus format and flags in ->atomic_check()

2023-02-16 Thread Liu Ying
structure is introduced to cache bus format and bus flags states in ->atomic_check() so that they can be read in ->atomic_enable(). Signed-off-by: Liu Ying --- v3->v4: * Use 'new_{c,p}state' instead of 'new_{crtc,plane}_state'. (Alexander) * Simplify lcdif_crtc_reset() by calling lcdif_crtc_at

[PATCH v4 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge

2023-02-16 Thread Liu Ying
A valid bridge is already found in lcdif_attach_bridge() and set to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop the unnecessary NULL pointer check in KMS stage. Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v3->v4: * Add Alexander's R-b tag. v2->v3:

[PATCH v4 1/6] dt-bindings: lcdif: Add i.MX93 LCDIF support

2023-02-16 Thread Liu Ying
). i.MX93 LCDIF IP is essentially the same to i.MX8MP LCDIF IP. Add device tree binding for i.MX93 LCDIF. Acked-by: Krzysztof Kozlowski Reviewed-by: Marek Vasut Reviewed-by: Alexander Stein Signed-off-by: Liu Ying --- v3->v4: * Add Alexander's R-b tag. v2->v3: * No change. v1->

[PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-02-16 Thread Liu Ying
es' member from lcdif_drm_private structure. * Drop a comment about bridge input bus format from lcdif_crtc_atomic_check(). Liu Ying (6): dt-bindings: lcdif: Add i.MX93 LCDIF support drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge drm: lcdif: Determine bus format and flags

Re: [PATCH v3 5/6] drm: lcdif: Add multiple encoders and first bridges support

2023-02-15 Thread Liu Ying
On Wed, 2023-02-15 at 08:54 +0100, Alexander Stein wrote: > Hi Liu, Hi Alexander, > > thanks for the update. Thanks for the review. > > Am Montag, 13. Februar 2023, 09:56:11 CET schrieb Liu Ying: > > The single LCDIF embedded in i.MX93 SoC may drive multiple displa

  1   2   3   4   5   6   7   8   9   10   >