Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-05 Thread Marek Vasut
On 6/5/24 6:05 PM, Rob Herring wrote: diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml index 2ad0cd6dd49e0..dcf56e996ee22 100644 ---

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-05 Thread Marek Vasut
On 6/5/24 6:03 PM, Rob Herring wrote: Hi, diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml index 2ad0cd6dd49e0..dcf56e996ee22 100644 ---

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-05 Thread Marek Vasut
On 6/5/24 12:52 PM, Alexander Stein wrote: Hi Marek, Hi, The accuracy degrades with each call, until a full kHz frequency is reached, because drm_display_mode.clock only accounts for kHz, but the PLL calculation takes Hz into account. Hm, I need to take a closer look at this one. Do

Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-04 Thread Marek Vasut
On 6/4/24 1:12 PM, Alexander Stein wrote: Hi Marek, Hi, Am Montag, 3. Juni 2024, 23:25:43 CEST schrieb Marek Vasut: On 6/3/24 2:18 PM, Alexander Stein wrote: Hi Marek, Hi, Am Freitag, 31. Mai 2024, 22:39:49 CEST schrieb Marek Vasut: This line_pixel_subtract is no longer needed now

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-04 Thread Marek Vasut
On 6/4/24 11:42 AM, Alexander Stein wrote: Hi Marek, Hi, --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml @@ -98,6 +98,24 @@ properties: reference to a valid eDP panel input

Re: [PATCH 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-06-04 Thread Marek Vasut
On 6/4/24 11:49 AM, Alexander Stein wrote: Hi, @@ -2372,6 +2392,21 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc) tc->bridge.ops |= DRM_BRIDGE_OP_DETECT; tc->bridge.ops |= DRM_BRIDGE_OP_EDID; + port = of_graph_get_port_by_id(dev->of_node, 2); +

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-04 Thread Marek Vasut
On 6/4/24 1:35 PM, Alexander Stein wrote: Hi Marek, Hi, Am Montag, 3. Juni 2024, 23:27:34 CEST schrieb Marek Vasut: On 6/3/24 2:45 PM, Alexander Stein wrote: Hi, @@ -1631,6 +1643,18 @@ static int tc_edp_atomic_check(struct drm_bridge *bridge, struct

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-03 Thread Marek Vasut
On 6/3/24 2:45 PM, Alexander Stein wrote: Hi, @@ -1631,6 +1643,18 @@ static int tc_edp_atomic_check(struct drm_bridge *bridge, struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { + struct tc_data *tc

Re: [PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-03 Thread Marek Vasut
On 6/3/24 2:18 PM, Alexander Stein wrote: Hi Marek, Hi, Am Freitag, 31. Mai 2024, 22:39:49 CEST schrieb Marek Vasut: This line_pixel_subtract is no longer needed now that the bridge can request and obtain specific pixel clock on input to the bridge, with clock frequency that matches

[PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-05-31 Thread Marek Vasut
e 0=0dB, 1=3.5dB, 2=6dB . Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Krzysztof Kozlowski Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstron

[PATCH 2/2] drm/bridge: tc358767: Add configurable default preemphasis

2024-05-31 Thread Marek Vasut
e 0=0dB, 1=3.5dB, 2=6dB . Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Krzysztof Kozlowski Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstron

[PATCH 4/6] drm/bridge: tc358767: Disable MIPI_DSI_CLOCK_NON_CONTINUOUS

2024-05-31 Thread Marek Vasut
The MIPI_DSI_CLOCK_NON_CONTINUOUS causes visible artifacts in high resolution modes, disable it. Namely, in DSI->DP mode 1920x1200 24 bpp 59.95 Hz, with DSI bus at maximum 1 Gbps per lane setting, the image contains jittering empty lines. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda

[PATCH 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-05-31 Thread Marek Vasut
as it never worked when the Pixel PLL and input clock were off just so that the required amount of pixels to subtract would not be whole integer. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc

[PATCH 5/6] drm/bridge: tc358767: Set LSCLK divider for SYSCLK to 1

2024-05-31 Thread Marek Vasut
LSCLK_DIV 1 has no adverse effects either. In the worst case, the internal TC358767 clock would run faster. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst Cc

[PATCH 6/6] Revert "drm/bridge: tc358767: Set default CLRSIPO count"

2024-05-31 Thread Marek Vasut
This reverts commit 01338bb82fed40a6a234c2b36a92367c8671adf0. With clock improvements in place, this seems to be no longer necessary. Set the CLRSIPO to default setting recommended by manufacturer. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej

[PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-05-31 Thread Marek Vasut
PLL frequency is important for this bridge, as if the frequencies do not match, the bridge does suffer VFIFO overruns or underruns. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Lucas Stach

[PATCH 1/6] drm/bridge: tc358767: Split tc_pxl_pll_en() into parameter calculation and enablement

2024-05-31 Thread Marek Vasut
, as if the frequencies do not match, the bridge does suffer VFIFO overruns or underruns. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst Cc: Maxime Ripard Cc

[PATCH] drm/bridge: tc358767: Check if fully initialized before signalling HPD event via IRQ

2024-05-31 Thread Marek Vasut
Make sure the connector is fully initialized before signalling any HPD events via drm_kms_helper_hotplug_event(), otherwise this may lead to NULL pointer dereference. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc

[PATCH] drm/bridge: tc358767: Fix comment in tc_edp_mode_valid

2024-05-31 Thread Marek Vasut
Fix comment copy-paste error in tc_edp_mode_valid(), this function is validating DP/eDP clock, not DPI clock frequency. Update the comment to match. No functional change. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman

[PATCH] dt-bindings: display: bridge: tc358767: Keep enum sorted

2024-05-31 Thread Marek Vasut
Keep the list sorted numerically. No functional change. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Krzysztof Kozlowski Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst Cc

[PATCH] drm: lcdif: Use adjusted_mode .clock instead of .crtc_clock

2024-05-31 Thread Marek Vasut
expects precise timing on its input side, the precise timing must be generated by the LCDIF. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Lucas Stach Cc: Lukas F. Hartmann Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Pengutronix Kernel Team Cc

[PATCH v2] dt-bindings: display: synopsys, dw-hdmi: Mark ddc-i2c-bus as deprecated

2024-05-21 Thread Marek Vasut
The ddc-i2c-bus property should be placed in connector node, mark the HDMI TX side property as deprecated. Acked-by: Rob Herring (Arm) Reviewed-by: Laurent Pinchart Reviewed-by: Neil Armstrong Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David

[PATCH] dt-bindings: display: synopsys, dw-hdmi: Mark ddc-i2c-bus as deprecated

2024-05-21 Thread Marek Vasut
The ddc-i2c-bus property should be placed in connector node, mark the HDMI TX side property as deprecated. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Krzysztof Kozlowski

Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core

2024-05-15 Thread Marek Vasut
On 5/15/24 8:27 AM, Marek Vasut wrote: The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, move the property description into the DW HDMI common DT schema too, so this property can be used on all devices integrating the DW HDMI core. Signed-off-by: Marek Vasut

Re: [PATCH] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core

2024-05-15 Thread Marek Vasut
On 5/15/24 5:12 AM, Liu Ying wrote: On 5/15/24 06:04, Marek Vasut wrote: The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, move the property description into the DW HDMI common DT schema too, so this property can be used on all devices integrating the DW HDMI core

[PATCH v2] dt-bindings: display: synopsys, dw-hdmi: Document ddc-i2c-bus in core

2024-05-15 Thread Marek Vasut
The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, move the property description into the DW HDMI common DT schema too, so this property can be used on all devices integrating the DW HDMI core. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc

[PATCH] dt-bindings: display: synopsys, dw-hdmi: Document ddc-i2c-bus in core

2024-05-14 Thread Marek Vasut
The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, move the property description into the DW HDMI common DT schema too, so this property can be used on all devices integrating the DW HDMI core. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Conor Dooley Cc

[PATCH v2] drm/bridge: tc358767: Enable FRMSYNC timing generator

2024-05-13 Thread Marek Vasut
which make the output video look striped horizontally. Reviewed-by: Robert Foss Signed-off-by: Marek Vasut --- Cc: Adam Ford Cc: Alexander Stein Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Frieder Schrempf Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Lucas

Re: [PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach

2024-05-13 Thread Marek Vasut
On 5/13/24 9:57 AM, Marek Szyprowski wrote: On 13.05.2024 04:16, Marek Vasut wrote: Initialize the bridge on attach already, to force lanes into LP11 state, since attach does trigger attach of downstream bridges which may trigger (e)DP AUX channel mode read. This fixes a corner case where

[PATCH 2/2] drm/bridge: tc358767: Reset chip again on attach

2024-05-12 Thread Marek Vasut
at that point the DSI lane mode is undefined. When the .attach callback is called, the DSI link is surely in LP11 mode. Toggle the RESX signal here and reconfigure the AUX channel. That way, the AUX channel communication from this point on does surely run at 10 MHz as it should. Signed-off-by: Marek Vasut

[PATCH 1/2] drm: bridge: samsung-dsim: Initialize bridge on attach

2024-05-12 Thread Marek Vasut
channel access later in its attach callback. Signed-off-by: Marek Vasut --- Cc: Adam Ford Cc: Alexander Stein Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Frieder Schrempf Cc: Inki Dae Cc: Jagan Teki Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Lucas Stach Cc

[PATCH] drm/bridge: tc358767: Enable FRMSYNC timing generator

2024-05-12 Thread Marek Vasut
which make the output video look striped horizontally. Signed-off-by: Marek Vasut --- Cc: Adam Ford Cc: Alexander Stein Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Frieder Schrempf Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maarten Lankhorst

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-22 Thread Marek Vasut
On 4/22/24 3:04 PM, Adam Ford wrote: On Mon, Apr 22, 2024 at 8:01 AM Marek Vasut wrote: On 4/22/24 2:09 PM, Adam Ford wrote: On Sun, Apr 21, 2024 at 9:36 AM Marek Vasut wrote: On 2/12/24 12:09 AM, Adam Ford wrote: When using video sync pulses, the HFP, HBP, and HSA are divided between

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-22 Thread Marek Vasut
On 4/22/24 2:09 PM, Adam Ford wrote: On Sun, Apr 21, 2024 at 9:36 AM Marek Vasut wrote: On 2/12/24 12:09 AM, Adam Ford wrote: When using video sync pulses, the HFP, HBP, and HSA are divided between the available lanes if there is more than one lane. For certain timings and lane

Re: [PATCH V2 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2024-04-21 Thread Marek Vasut
struct samsung_dsim *dsi, u16 _m, best_m; u8 _s, best_s; - p_min = DIV_ROUND_UP(fin, (12 * MHZ)); - p_max = fin / (6 * MHZ); + p_min = DIV_ROUND_UP(fin, (driver_data->pll_fin_max * MHZ)); The parenthesis around driver_data... are not needed. With that fixed: Reviewed-by: Marek Vasut

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-21 Thread Marek Vasut
On 2/12/24 12:09 AM, Adam Ford wrote: When using video sync pulses, the HFP, HBP, and HSA are divided between the available lanes if there is more than one lane. For certain timings and lane configurations, the HFP may not be evenly divisible. If the HFP is rounded down, it ends up being too

Re: [RFC][PATCH] drm: bridge: dw-mipi-dsi: Call modeset in modeset callback

2024-04-21 Thread Marek Vasut
On 4/21/24 1:09 PM, Ondřej Jirman wrote: Hi, Hi, On Sun, Apr 21, 2024 at 02:22:35AM GMT, Marek Vasut wrote: Doing modeset in .atomic_pre_enable callback instead of dedicated .mode_set callback does not seem right. Undo this change, which was added as part of Actually no. If anything

[RFC][PATCH] drm: bridge: dw-mipi-dsi: Call modeset in modeset callback

2024-04-20 Thread Marek Vasut
;TC358762 DSI-to-DPI bridge->PT800480 DPI panel pipeline. The original fix for HX8394 panel likely requires HX8394 panel side fix instead. Fixes: 05aa61334592 ("drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller") Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Biju

[PATCH 4/4] drm/panel: simple: Add Innolux G121XCE-L01 LVDS display support

2024-03-28 Thread Marek Vasut
/G121X1-L03_Datasheet.pdf [2] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121XCE-L01_Datasheet.pdf Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc

[PATCH 1/4] dt-bindings: display: simple: Document support for Innolux G121XCE-L01

2024-03-28 Thread Marek Vasut
riant. [1] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf [2] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121XCE-L01_Datasheet.pdf Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jessica

[PATCH 3/4] drm/panel: simple: Convert Innolux G121X1-L03 to display_timing

2024-03-28 Thread Marek Vasut
TIMING SPECIFICATIONS. [1] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G121X1-L03_Datasheet.pdf Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil

[PATCH 2/4] drm/panel: simple: Add missing Innolux G121X1-L03 format, flags, connector

2024-03-28 Thread Marek Vasut
/Innolux/G121X1-L03_Datasheet.pdf Fixes: f8fa17ba812b ("drm/panel: simple: Add support for Innolux G121X1-L03") Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil

Re: sn65dsi83: dsi burst mode

2024-03-07 Thread Marek Vasut
On 3/7/24 9:09 AM, Sean Nyekjaer wrote: Hi, Hi, We are using the stm32mp1 together with the sn65dsi83 bridge. The ti,sn65dsi83 driver is (hard) enabling MIPI_DSI_MODE_VIDEO_BURST, then the st,stm32-dsi driver is adding +20% to the clock speed. That means our LVDS is +20% higher than

[PATCH v3] drm/lcdif: Do not disable clocks on already suspended hardware

2024-02-26 Thread Marek Vasut
LCDIF variant") Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Liu Ying Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc: Sascha Hauer Cc: Shawn Guo Cc: Stefan Agner Cc: Thomas Zimmermann Cc:

[PATCH v2] drm/lcdif: Do not disable clocks on already suspended hardware

2024-02-25 Thread Marek Vasut
LCDIF variant") Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Liu Ying Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc: Sascha Hauer Cc: Shawn Guo Cc: Stefan Agner Cc: Thomas Zimmermann Cc:

Re: [PATCH] drm/lcdif: Do not disable clock on already suspended hardware

2024-02-23 Thread Marek Vasut
On 1/18/24 19:39, Marek Vasut wrote: In case the LCDIF is enabled in DT but unused, the clock used by the LCDIF are not enabled. Those clock may even have a use count of 0 in case there are no other users of those clock. This can happen e.g. in case the LCDIF drives HDMI bridge which has

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-02-16 Thread Marek Vasut
On 2/16/24 10:10, Tomi Valkeinen wrote: On 15/02/2024 11:03, Alexander Stein wrote: Hi everyone, Am Donnerstag, 15. Februar 2024, 09:53:54 CET schrieb Jan Kiszka: On 11.12.23 09:07, Aradhya Bhatia wrote: On 06/12/23 17:41, Tomi Valkeinen wrote: Hi, On 08/11/2023 14:45, Alexander Stein

Re: [PATCH] drm/lcdif: Do not disable clock on already suspended hardware

2024-02-11 Thread Marek Vasut
On 1/18/24 19:39, Marek Vasut wrote: In case the LCDIF is enabled in DT but unused, the clock used by the LCDIF are not enabled. Those clock may even have a use count of 0 in case there are no other users of those clock. This can happen e.g. in case the LCDIF drives HDMI bridge which has

[PATCH] drm/bridge: tc358767: Limit the Pixel PLL input range

2024-01-18 Thread Marek Vasut
According to new configuration spreadsheet from Toshiba for TC9595, the Pixel PLL input clock have to be in range 6..40 MHz. The sheet calculates those PLL input clock as reference clock divided by both pre-dividers. Add the extra limit. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc

[PATCH] drm/lcdif: Do not disable clock on already suspended hardware

2024-01-18 Thread Marek Vasut
a warning from clock core about this condition. Note that the lcdif_rpm_suspend() and lcdif_rpm_resume() functions internally perform the clock disable and enable operations and act as runtime PM hooks too. Fixes: 9db35bb349a0 ("drm: lcdif: Add support for i.MX8MP LCDIF variant") Signed-off

[PATCH v2 1/2] dt-bindings: display: simple: Add AUO G156HAN04.0 LVDS display

2023-12-08 Thread Marek Vasut
and 16.7M colors (RGB 8-bits) with LED backlight driving circuit. All input signals are LVDS interface compatible. G156HAN04.0 is designed for a display unit of notebook style personal computer and industrial machine. Acked-by: Krzysztof Kozlowski Signed-off-by: Elmar Albert Signed-off-by: Marek Vasut

[PATCH v2 2/2] drm/panel: simple: Add AUO G156HAN04.0 LVDS display support

2023-12-08 Thread Marek Vasut
. All input signals are LVDS interface compatible. G156HAN04.0 is designed for a display unit of notebook style personal computer and industrial machine. Signed-off-by: Elmar Albert Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jessica Zhang Cc

Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-05 Thread Marek Vasut
@8003: interrupts: [[46], [45]] is too long from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml# Signed-off-by: Fabio Estevam Indeed Reviewed-by: Marek Vasut

[PATCH] drm: lcdif: Switch to drmm_mode_config_init

2023-11-27 Thread Marek Vasut
Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc

[PATCH v2] drm/mxsfb: Switch to drmm_mode_config_init

2023-11-27 Thread Marek Vasut
Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc

[PATCH] drm/mxsfb: Switch to drmm_mode_config_init

2023-11-25 Thread Marek Vasut
Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc

[PATCH] drm/mxsfb: Drop extra space in request_irq args

2023-11-25 Thread Marek Vasut
Drop extra space, no functional change. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: NXP Linux Team Cc: Pengutronix Kernel Team Cc: Sascha Hauer Cc: Shawn Guo Cc: Stefan Agner Cc: Thomas Zimmermann Cc

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-11-19 Thread Marek Vasut
On 11/17/23 09:40, Maxime Ripard wrote: On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote: On 10/9/23 10:58, Neil Armstrong wrote: On 09/10/2023 00:33, Marek Vasut wrote: Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description, ones which match both the datasheet

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-11-17 Thread Marek Vasut
On 11/17/23 09:40, Maxime Ripard wrote: On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote: On 10/9/23 10:58, Neil Armstrong wrote: On 09/10/2023 00:33, Marek Vasut wrote: Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description, ones which match both the datasheet

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-11-16 Thread Marek Vasut
On 10/9/23 10:58, Neil Armstrong wrote: On 09/10/2023 00:33, Marek Vasut wrote: Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description, ones which match both the datasheet and the panel display_timing flags . Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101IC

Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 timings

2023-11-16 Thread Marek Vasut
On 10/9/23 11:01, Neil Armstrong wrote: Hi, On 09/10/2023 00:32, Marek Vasut wrote: The Innolux G101ICE-L01 datasheet [1] page 17 table 6.1 INPUT SIGNAL TIMING SPECIFICATIONS indicates that maximum vertical blanking time is 40 lines. Currently the driver uses 29 lines. Fix it, and since

Re: [PATCH 3/5] drm/bridge: tc358762: Instruct DSI host to generate HSE packets

2023-11-16 Thread Marek Vasut
On 11/16/23 17:06, Marc Kleine-Budde wrote: Hey Marek, On 15.06.2023 22:19:00, Marek Vasut wrote: This bridge seems to need the HSE packet, otherwise the image is shifted up and corrupted at the bottom. This makes the bridge work with Samsung DSIM on i.MX8MM and i.MX8MP. I'm using v6.6

[PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

2023-10-08 Thread Marek Vasut
Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description, ones which match both the datasheet and the panel display_timing flags . Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel") Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David

[PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 timings

2023-10-08 Thread Marek Vasut
cannot do 1 px HSA/VSA, distribute the delays evenly between all three parts. [1] https://www.data-modul.com/sites/default/files/products/G101ICE-L01-C2-specification-12042389.pdf Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel") Signed-off-by: Marek Vasut ---

Re: [PATCH 5/5] drm: lcdif: force modeset when FB format changes

2023-09-20 Thread Marek Vasut
false, true); + if (ret) + return ret; + + if (old_state->fb && new_state->fb->format != old_state->fb->format) + crtc_state->mode_changed = true; + + return 0; } static void lcdif_plane_primary_atomic_update(struct drm_plane *plane, Reviewed-by: Marek Vasut

Re: [PATCH 3/5] drm: lcdif: remove superfluous setup of framebuffer DMA address

2023-09-20 Thread Marek Vasut
+ LCDC_V8_CTRLDESCL_HIGH0_4); - } - drm_crtc_vblank_on(crtc); } Reviewed-by: Marek Vasut

Re: [PATCH 4/5] drm: lcdif: move pitch setup to plane atomic update

2023-09-20 Thread Marek Vasut
ficiency so set it here too. +*/ + writel(CTRLDESCL0_3_P_SIZE(2) | CTRLDESCL0_3_T_SIZE(2) | + CTRLDESCL0_3_PITCH(new_pstate->fb->pitches[0]), + lcdif->base + LCDC_V8_CTRLDESCL0_3); } static bool lcdif_format_mod_supported(struct drm_plane *plane, Reviewed-by: Marek Vasut

Re: [PATCH 2/5] drm: lcdif: move controller enable into atomic_flush

2023-09-20 Thread Marek Vasut
pper_32_bits(paddr)), lcdif->base + LCDC_V8_CTRLDESCL_HIGH0_4); } - lcdif_enable_controller(lcdif); drm_crtc_vblank_on(crtc); } Reviewed-by: Marek Vasut

Re: [PATCH 1/5] drm: lcdif: improve burst size configuration comment

2023-09-20 Thread Marek Vasut
2 - 256Byte -* Downstream set it to 256B burst size to improve the memory +* Downstream sets this to 256B burst size to improve the memory access * efficiency so set it here too. With that fixed: Reviewed-by: Marek Vasut

Re: [PATCH] drm/panel/panel-sitronix-st7701: Move init sequence from prepare() to enable()

2023-08-26 Thread Marek Vasut
On 8/26/23 20:33, Mimoja wrote: Hi, +CC Dave , he might be able to help with the last part. I appreciate you taking the time to respond! On 26.08.23 17:18, Marek Vasut wrote: On 8/26/23 11:55, Mimoja wrote: "The .prepare() function is typically called before the display controller s

Re: [PATCH] drm/panel/panel-sitronix-st7701: Move init sequence from prepare() to enable()

2023-08-26 Thread Marek Vasut
On 8/26/23 11:55, Mimoja wrote: The struct drm_panel_funcs are offering a prepare() and an enable() entrypoint for panels. According to drm/panel.h: "The .prepare() function is typically called before the display controller starts to transmit video data." and "After the display controller has

Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

2023-08-10 Thread Marek Vasut
en sitting on it waiting to see if Marek or Liu popped up.. I don't see anything which would resemble power domains like on MX8MM/N/P on the MQ MXSFB, there are such domains for the VPU and DCSS, but not MXSFB. So Reviewed-by: Marek Vasut

Re: [PATCH v4] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-08-09 Thread Marek Vasut
Drain command transfer FIFO before transfer"). Fixes: 14806c641582 ("drm: bridge: samsung-dsim: Drain command transfer FIFO before transfer") Signed-off-by: Marek Szyprowski Oh, nice, there is already a bitfield piece in place. Thanks ! Reviewed-by: Marek Vasut

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-08-07 Thread Marek Vasut
On 8/7/23 15:00, Marek Szyprowski wrote: Hi, diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 05100e91ecb9..18017b3e5d9e 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -62,6 +62,7 @@ struct

Re: [PATCH] drm/panel: simple: Fix Innolux G156HCE-L01 LVDS clock

2023-08-05 Thread Marek Vasut
14186, 15000 }, .hactive = { 1920, 1920, 1920 }, .hfront_porch = { 80, 90, 100 }, .hback_porch = { 80, 90, 100 }, Odd, now I don't see the flicker anymore. Tested-by: Marek Vasut # MX8MM with LT9211 Reviewed-by: Marek Vasut Thanks !

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-03 Thread Marek Vasut
On 8/2/23 20:49, Rob Clark wrote: On Wed, Aug 2, 2023 at 11:16 AM Dmitry Baryshkov wrote: On Wed, 2 Aug 2023 at 20:34, Marek Vasut wrote: On 8/2/23 15:38, Dmitry Baryshkov wrote: On 02/08/2023 11:52, Neil Armstrong wrote: This reverts commit [1] to fix display regression

Re: [PATCH 2/2] drm/panel-simple: Add Innolux G156HCE-L01 panel entry

2023-08-03 Thread Marek Vasut
On 8/3/23 17:06, Luca Ceresoli wrote: Hi Marek, On Thu, 3 Aug 2023 16:25:37 +0200 Marek Vasut wrote: On 8/3/23 16:23, Luca Ceresoli wrote: Hi Marek, Hi, On Mon, 31 Jul 2023 23:02:58 +0200 Marek Vasut wrote: Add support for Innolux G156HCE-L01 15.6" 1920x1080 24bpp dual-link

Re: [PATCH 2/2] drm/panel-simple: Add Innolux G156HCE-L01 panel entry

2023-08-03 Thread Marek Vasut
On 8/3/23 16:23, Luca Ceresoli wrote: Hi Marek, Hi, On Mon, 31 Jul 2023 23:02:58 +0200 Marek Vasut wrote: Add support for Innolux G156HCE-L01 15.6" 1920x1080 24bpp dual-link LVDS TFT panel. Documentation is available at [1]. Interesting, I'm bringing up this exact panel righ

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-08-02 Thread Marek Vasut
On 8/2/23 19:49, Abhinav Kumar wrote: Hi Marek On 8/2/2023 10:25 AM, Marek Vasut wrote: On 8/2/23 15:08, neil.armstr...@linaro.org wrote: Hi Marek, On 02/08/2023 14:25, Marek Vasut wrote: On 8/2/23 10:39, neil.armstr...@linaro.org wrote: Hi Marek, Hi, On 13/07/2023 20:28, Marek Vasut

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
On 8/2/23 20:16, Dmitry Baryshkov wrote: On Wed, 2 Aug 2023 at 20:34, Marek Vasut wrote: On 8/2/23 15:38, Dmitry Baryshkov wrote: On 02/08/2023 11:52, Neil Armstrong wrote: This reverts commit [1] to fix display regression on the Dragonboard 845c (SDM845) devboard. There's a mismatch

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
On 8/2/23 14:37, Neil Armstrong wrote: On 02/08/2023 14:28, Marek Vasut wrote: On 8/2/23 14:07, Marek Vasut wrote: On 8/2/23 10:52, Neil Armstrong wrote: This reverts commit [1] to fix display regression on the Dragonboard 845c (SDM845) devboard. There's a mismatch on the real action

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
- MIPI_DSI_MODE_VIDEO_NO_HFP - MIPI_DSI_MODE_VIDEO_NO_HBP which leads to a non-working display on qcom platforms. [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") Cc: Marek Vasut Cc: Robert Foss Cc: Jagan Teki Cc: Dmitry Baryshkov Cc: Abhinav Kumar Fixes: 8ddce13ae69 (&

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
On 8/2/23 15:16, Dmitry Baryshkov wrote: On 02/08/2023 15:07, Marek Vasut wrote: On 8/2/23 10:52, Neil Armstrong wrote: This reverts commit [1] to fix display regression on the Dragonboard 845c (SDM845) devboard. There's a mismatch on the real action of the following flags

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
On 8/2/23 14:38, Dmitry Baryshkov wrote: On 02/08/2023 15:07, Marek Vasut wrote: On 8/2/23 10:52, Neil Armstrong wrote: This reverts commit [1] to fix display regression on the Dragonboard 845c (SDM845) devboard. There's a mismatch on the real action of the following flags

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-08-02 Thread Marek Vasut
On 8/2/23 15:08, neil.armstr...@linaro.org wrote: Hi Marek, On 02/08/2023 14:25, Marek Vasut wrote: On 8/2/23 10:39, neil.armstr...@linaro.org wrote: Hi Marek, Hi, On 13/07/2023 20:28, Marek Vasut wrote: MIPI_DSI_MODE_VIDEO_NO_HFP means the HBP period is just skipped by DSIM

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
On 8/2/23 14:07, Marek Vasut wrote: On 8/2/23 10:52, Neil Armstrong wrote: This reverts commit [1] to fix display regression on the Dragonboard 845c (SDM845) devboard. There's a mismatch on the real action of the following flags: - MIPI_DSI_MODE_VIDEO_NO_HSA - MIPI_DSI_MODE_VIDEO_NO_HFP

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-08-02 Thread Marek Vasut
On 8/2/23 10:39, neil.armstr...@linaro.org wrote: Hi Marek, Hi, On 13/07/2023 20:28, Marek Vasut wrote: MIPI_DSI_MODE_VIDEO_NO_HFP means the HBP period is just skipped by DSIM. Maybe there is a need for new set of flags which differentiate between HBP skipped (i.e. NO HBP) and HBP

Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"

2023-08-02 Thread Marek Vasut
to a non-working display on qcom platforms. [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") Cc: Marek Vasut Cc: Robert Foss Cc: Jagan Teki Cc: Dmitry Baryshkov Cc: Abhinav Kumar Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-31 Thread Marek Vasut
On 7/31/23 23:34, Doug Anderson wrote: Hi, On Mon, Jul 31, 2023 at 2:15 PM Marek Vasut wrote: On 7/31/23 21:50, Doug Anderson wrote: Hi, On Mon, Jul 31, 2023 at 11:03 AM Marek Vasut wrote: On 7/24/23 15:49, Doug Anderson wrote: Hi, [...] Maybe the EPROBE_DEFER actually happens

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-31 Thread Marek Vasut
On 7/31/23 21:50, Doug Anderson wrote: Hi, On Mon, Jul 31, 2023 at 11:03 AM Marek Vasut wrote: On 7/24/23 15:49, Doug Anderson wrote: Hi, [...] Maybe the EPROBE_DEFER actually happens and triggers the failure ? I could certainly believe that EPROBE_DEFER is involved. So

[PATCH 1/2] dt-bindings: display: simple: Add Innolux G156HCE-L01 panel

2023-07-31 Thread Marek Vasut
Add entry for Innolux G156HCE-L01 15.6" 1920x1080 24bpp dual-link LVDS TFT panel. Documentation is available at [1]. [1] https://www.distec.de/fileadmin/pdf/produkte/TFT-Displays/Innolux/G156HCE-L01_Rev.C3_Datasheet.pdf Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vette

[PATCH 2/2] drm/panel-simple: Add Innolux G156HCE-L01 panel entry

2023-07-31 Thread Marek Vasut
plays/Innolux/G156HCE-L01_Rev.C3_Datasheet.pdf Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Krzysztof Kozlowski Cc: Neil Armstrong Cc: Rob Herring Cc: Sam Ravnborg Cc: Thierry Reding Cc: devicet...@vger.kernel.org Cc: dri-devel@lists.freedeskto

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-31 Thread Marek Vasut
On 7/24/23 15:49, Doug Anderson wrote: Hi, [...] Maybe the EPROBE_DEFER actually happens and triggers the failure ? I could certainly believe that EPROBE_DEFER is involved. So no, it is not. It is difficult to set this up and access the signals, but so I did. What happens is this:

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-23 Thread Marek Vasut
On 7/18/23 21:33, Doug Anderson wrote: Hi, On Tue, Jul 18, 2023 at 10:37 AM Marek Vasut wrote: On 7/18/23 18:15, Doug Anderson wrote: Hi, Hi, On Tue, Jul 18, 2023 at 8:36 AM Marek Vasut wrote: On 7/18/23 16:17, Doug Anderson wrote: Hi, Hi, On Sun, Jul 9, 2023 at 6:52 AM Marek

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-21 Thread Marek Vasut
Drain command transfer FIFO before transfer"). Fixes: 14806c641582 ("Drain command transfer FIFO before transfer") Signed-off-by: Marek Szyprowski Reviewed-by: Marek Vasut Thanks !

Re: [PATCH v2 2/2] drm/bridge: tc358767: give VSDELAY some positive value

2023-07-21 Thread Marek Vasut
rom Toshiba seem to always make this value equal to the HFP + 10 for DSI->DP use-case. For DSI->DPI this value should be > 2 and for DPI->DP it seems to always be 0x64. Signed-off-by: David Jander Signed-off-by: Lucas Stach Tested-by: Marek Vasut # TC9595 Reviewed-by: Marek Vasut

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-18 Thread Marek Vasut
On 7/18/23 18:15, Doug Anderson wrote: Hi, Hi, On Tue, Jul 18, 2023 at 8:36 AM Marek Vasut wrote: On 7/18/23 16:17, Doug Anderson wrote: Hi, Hi, On Sun, Jul 9, 2023 at 6:52 AM Marek Vasut wrote: The unprepared_time has to be initialized during probe to probe time ktime, otherwise

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-18 Thread Marek Vasut
On 7/18/23 16:17, Doug Anderson wrote: Hi, Hi, On Sun, Jul 9, 2023 at 6:52 AM Marek Vasut wrote: The unprepared_time has to be initialized during probe to probe time ktime, otherwise panel_simple_resume() panel_simple_wait() call may wait too short time, or no time at all, which would

Re: [PATCH] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-18 Thread Marek Vasut
On 7/18/23 15:18, Marek Szyprowski wrote: Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) doesn't report empty level of packer header FIFO. In case of those SoCs, use the old way of waiting for empty command tranfsfer FIFO, removed recently by commit 14806c641582 ("Drain

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-13 Thread Marek Vasut
On 7/13/23 20:09, Abhinav Kumar wrote: On 7/12/2023 10:41 AM, Marek Vasut wrote: On 7/9/23 03:03, Abhinav Kumar wrote: On 7/7/2023 1:47 AM, Neil Armstrong wrote: On 07/07/2023 09:18, Neil Armstrong wrote: Hi, On 06/07/2023 11:20, Amit Pundir wrote: On Wed, 5 Jul 2023 at 11:09, Dmitry

  1   2   3   4   5   6   7   8   9   10   >