[PATCH 1/3] drm: introduce share plane

2016-07-28 Thread Mark yao
On 2016年07月28日 16:03, Daniel Vetter wrote: > On Thu, Jul 28, 2016 at 11:01:04AM +0800, Mark yao wrote: >> Any ideas for the share planes? >> >> This function is important for our series of vop full design. >> The series of vop is: >> I

[PATCH 1/3] drm: introduce share plane

2016-07-28 Thread Mark yao
rk322x example on rk3288: if not support share plane, each vop only support four planes, but if support this function, each vop can support ten planes. On 2016年07月26日 17:51, Mark yao wrote: > On 2016年07月26日 16:26, Daniel Vetter wrote: >> On Tue, Jul 26, 2016 at 0

[PATCH 2/2] dt-bindings: add simple-panel-dsi and simple-panel

2016-07-27 Thread Mark yao
On 2016年07月26日 17:02, Thierry Reding wrote: > On Tue, Jul 26, 2016 at 10:01:32AM +0800, Mark yao wrote: >> On 2016年07月25日 23:21, Thierry Reding wrote: >> >> On Wed, Jul 20, 2016 at 11:18:50AM +0800, Mark Yao wrote: >> >> Allow user

[PATCH 7/9] drm/rockchip: Use drm_plane_helper_check_state()

2016-07-27 Thread Mark yao
dy > (unlikje most arm drm drivers) so there are no function changes > here. > > Cc: Yao > Cc:linux-rockchip at lists.infradead.org > Signed-off-by: Ville Syrjälä Acked-by: Mark Yao Thanks. -- Mark Yao

[PATCH 6/9] drm/rockchip: Use drm_plane_state.{src,dst}

2016-07-27 Thread Mark yao
Syrjälä Good cleanup, Acked-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c

[PATCH 1/3] drm: introduce share plane

2016-07-26 Thread Mark yao
On 2016年07月26日 16:26, Daniel Vetter wrote: > On Tue, Jul 26, 2016 at 03:46:32PM +0800, Mark Yao wrote: >> >What is share plane: >> >Plane hardware only be used when the display scanout run into plane active >> >scanout, that means we can reuse the plane hardw

[PATCH 3/3] drm/rockchip: vop: rk3288: add area plane

2016-07-26 Thread Mark Yao
Change-Id: Iac8fde019020d8f1a671d52c1a4d91ad2d050d43 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 52 - 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip

[PATCH 2/3] drm/rockchip: vop: support multi area plane

2016-07-26 Thread Mark Yao
The series vop of VOP_FULL framework support area plane, such as RK3288 and RK3399, one group of area planes share same hardware, reuse the hardware on different scanout time, this design is useful to support mulit planes with low hardware consume. Signed-off-by: Mark Yao --- drivers/gpu/drm

[PATCH 1/3] drm: introduce share plane

2016-07-26 Thread Mark Yao
has same shard id, so userspace can group them, judge share plane's limit. Signed-off-by: Mark Yao --- drivers/gpu/drm/drm_crtc.c | 110 drivers/gpu/drm/drm_ioctl.c | 5 ++ include/drm/drmP.h | 5 ++ include/drm/drm_crtc.h | 14

[PATCH 2/2] dt-bindings: add simple-panel-dsi and simple-panel

2016-07-26 Thread Mark yao
An HTML attachment was scrubbed... URL:

[v6 PATCH 6/6] drm/rockchip: cdn-dp: add cdn DP support for rk3399

2016-07-22 Thread Mark yao
hong > Reviewed-by: Sean Paul Sean Paul already do a good review, I think it's ready to be merged, so Acked-by: Mark Yao > --- > > Changes in v6: > - add a port struct > - select SND_SOC_HDMI_CODEC > - force reset the phy when hpd detected > > Changes in v5: &

[PATCH 2/2] dt-bindings: add simple-panel-dsi and simple-panel

2016-07-20 Thread Mark Yao
Allow user add display timing on device tree with simple-panel-dsi or simple-panel. Cc: Thierry Reding Cc: Rob Herring <robh+dt at kernel.org> Cc: Mark Rutland Signed-off-by: Mark Yao --- .../bindings/display/panel/simple-panel.txt| 48 ++ 1 file chang

[PATCH 1/2] drm/panel: add of display timing support

2016-07-20 Thread Mark Yao
device node. Cc: Thierry Reding Signed-off-by: Mark Yao --- drivers/gpu/drm/panel/panel-simple.c | 73 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1

[GIT PULL] drm/rockchip: some fixes

2016-07-19 Thread Mark yao
drm/rockchip: fix "should it be static?" warnings drm/rockchip: allocate correct crtc state structure on reset Mark Yao (2): drm/rockchip: vop: correct the source size of uv scale factor setting drm/rockchip: vop: correct rk3036 register define Markus

[PATCH] drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

2016-07-19 Thread Mark yao
On 2016年07月15日 21:35, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 15 Jul 2016 15:23:22 +0200 > > The drm_gem_object_unreference_unlocked() function tests whether > its argument is NULL and then returns immediately. > Thus the test around the call is not needed. > > This

[PATCH] drm/rockchip: allocate correct crtc state structure on reset

2016-07-15 Thread Mark yao
On 2016年07月14日 23:29, John Keeping wrote: > Because we are using a custom crtc_state structure, we must override the > reset helper to allocate the correct amount of memory. > > Cc: stable at vger.kernel.org > Fixes: 4e257d9eee23 ("drm/rockchip: get rid of rockchip_drm_crtc_mode_config") >

[PATCH 6/6] drm/rockchip: vop: correct rk3036 register define

2016-07-14 Thread Mark Yao
Signed-off-by: Mark Yao Reported-by: Tomasz Figa --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c index a348a7a..919992c 100644

[PATCH 5/6] drm/rockchip: vop: correct the source size of uv scale factor setting

2016-07-14 Thread Mark Yao
data format cbcr_xscale = dst_w / src_w; cbcr_yscale = dst_h / src_h; Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c

[PATCH 4/6] drm/rockchip: vop: add uv_vir register field for RK3036 VOP

2016-07-14 Thread Mark Yao
From: Yakir Yang <y...@rock-chips.com> The WIN0 of RK3036 VOP could support YUV data format, but driver forget to add the uv_vir register field for it. Signed-off-by: Yakir Yang Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 3/6] drm/rockchip: fix "should it be static?" warnings

2016-07-14 Thread Mark Yao
From: John Keeping <j...@metanate.com> Combined with the previous commit, this fixes all of the sparse warnings in drm/rockchip. Signed-off-by: John Keeping Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.

[PATCH 2/6] drm/rockchip: fb: add missing header

2016-07-14 Thread Mark Yao
symbol 'rockchip_drm_framebuffer_init' was not declared. Should it be static? drivers/gpu/drm/rockchip/rockchip_drm_fb.c:329:6: warning: symbol 'rockchip_drm_mode_config_init' was not declared. Should it be static? Signed-off-by: John Keeping Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_fb

[PATCH 1/6] drm/rockchip: dw_hdmi: remove unused #include

2016-07-14 Thread Mark Yao
From: John Keeping <j...@metanate.com> drm_encoder_slave is not used in this file. Signed-off-by: John Keeping Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drive

[PATCH 0/6] drm/rockchip: some fixes

2016-07-14 Thread Mark Yao
ove unused #include drm/rockchip: fb: add missing header drm/rockchip: fix "should it be static?" warnings Mark Yao (2): drm/rockchip: vop: correct the source size of uv scale factor setting drm/rockchip: vop: correct rk3036 register define Yakir Yang (1): drm/rockchip: vop: add u

[patch] drm/rockchip: fix a couple off by one bugs

2016-07-14 Thread Mark yao
On 2016年07月13日 18:15, Dan Carpenter wrote: > The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should > be >= here. > > Fixes: 2048e3286f34 ('drm: rockchip: Add basic drm driver') > Signed-off-by: Dan Carpenter Thanks for the fix, applied to my drm-fixes. > diff --git

[PATCH 5/7] drm/rockchip: dw-mipi: support HPD poll

2016-07-11 Thread Mark yao
On 2016年07月08日 21:52, John Keeping wrote: > On Fri, 8 Jul 2016 17:04:59 +0800, Chris Zhong wrote: > >> At the first time of bind, there is no any panel attach in mipi. Add a >> DRM_CONNECTOR_POLL_HPD porperty to detect the panel status, when panel >> probe, the dw_mipi_dsi_host_attach would

iommu/rockchip: Fix bugs and enable on ARM64

2016-07-08 Thread Mark yao
On 2016年06月27日 20:57, Joerg Roedel wrote: > On Fri, Jun 24, 2016 at 10:13:25AM +0800, Shunqian Zheng wrote: >> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 100 +++-- >> drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + >> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 221 >>

[PATCH v5 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain

2016-07-08 Thread Mark yao
d heavily on GEM > implementation of Tegra DRM driver. Acked-by: Mark Yao > > Signed-off-by: Tomasz Figa > Signed-off-by: Shunqian Zheng > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 3 + > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 221 > +++

[PATCH v5 7/8] drm/rockchip: Use common IOMMU API to attach devices

2016-07-08 Thread Mark yao
U address space > management, there is no need to use DMA API anymore and this patch wires > things to use the new method. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Tomasz Figa Looks good for me, and it works on rk3399 board, so Acked-by: Mark Yao > --- > drivers/gpu/d

[PATCH 2/2] drm/rockchip: vop: correct the source size of uv scale factor setting

2016-06-07 Thread Mark yao
On 2016年06月06日 15:58, Yakir Yang wrote: > From: Mark Yao > > When the input color format is YUV, we need to do some external scale > for CBCR. Like, > * In YUV420 data format: > cbcr_xscale = dst_w / src_w * 2; > cbcr_yscale = dst_h / src_h * 2; >

[PATCH 1/2] drm/rockchip: vop: add uv_vir register field for RK3036 VOP

2016-06-07 Thread Mark yao
On 2016年06月06日 15:58, Yakir Yang wrote: > The WIN0 of RK3036 VOP could support YUV data format, but driver > forget to add the uv_vir register field for it. > > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + > 1 file changed, 1 insertion(+) > > diff

[PATCH 10/20] drm: rockchip: Rely on the default ->best_encoder() behavior

2016-06-07 Thread Mark yao
ncoder() for us. Good, All connectors and encoders is 1:1 relationship on rockchip outputs, so Acked-by: Mark Yao > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 9 - > drivers/gpu/drm/rockchip/inno_hdmi.c | 9 - >

[PATCH v2 1/5] drm/rockchip: sort registers define by chip's number

2016-06-02 Thread Mark yao
On 2016年06月02日 14:51, Tomasz Figa wrote: > Hi Mark, > > Mark Yao rock-chips.com> writes: >> No functional changes, sort the vop registers to make >> code more readable. > I might have found a typo. I guess it could be just fixed in this patch, > if it's

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

2016-06-02 Thread Mark yao
On 2016年06月02日 13:57, Tomeu Vizoso wrote: > On 25 May 2016 at 03:33, Mark yao wrote: >> On 2016年05月25日 09:06, Mark yao wrote: >> >> On 2016年05月24日 18:11, Tomeu Vizoso wrote: >> >> Hi Tomeu >>> Sorry for reply late. >>> I do

[PATCH] drm/rockchip: vop: do axi reset in vop initial time

2016-06-01 Thread Mark yao
On 2016年06月01日 17:19, Yakir Yang wrote: > There is a bug in RK3399 VOP, when bootloader/kernel only enable > VOP Big or VOP Little to display, then VOP IOMMU would failed to > reset at the initial time and VOP register couldn't write rightly. > > After do the pure reset of VOP module, then

[PATCH v2 06/10] drm/rockchip: analogix_dp: make panel detect to an optional action

2016-06-01 Thread Mark yao
On 2016年05月24日 13:02, Yakir Yang wrote: > Some boards don't need to declare a panel device node, like the > display interface is DP monitors, so it's necessary to make the > panel detect to an optional action. > > Signed-off-by: Yakir Yang > --- Looks for me, So: Acked-by

[PATCH v2 08/10] drm/rockchip: analogix_dp: correct the connector display color format and bpc

2016-06-01 Thread Mark yao
tatic int rockchip_dp_bind(struct device *dev, struct > device *master, > dp->plat_data.subdev_type = dp_data->chip_type; > dp->plat_data.power_on = rockchip_dp_poweron; > dp->plat_data.power_off = rockchip_dp_powerdown; > + dp->plat_data.mode_valid = rockchip_dp_mode_valid; > > return analogix_dp_bind(dev, dp->drm_dev, >plat_data); > } Looks for me, So: Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH v2 09/10] drm/rockchip: analogix_dp: update the comments about why need to hardcode VOP output mode

2016-06-01 Thread Mark yao
e VOP output mode to RGA10 here. > > Signed-off-by: Yakir Yang Looks for me, So: Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH v2 02/10] drm/rockchip: analogix_dp: split the lcdc select setting into device data

2016-06-01 Thread Mark yao
for each chips. > > Signed-off-by: Yakir Yang Looks for me, So: Acked-by: Mark Yao -- ï¼­ark Yao

[PATCH v2 05/10] drm/rockchip: analogix_dp: add rk3399 eDP support

2016-06-01 Thread Mark yao
les changed, 35 insertions(+), 3 deletions(-) > > Looks for me, So for the drm/rockchip side: Acked-by: Mark Yao Thanks. -- ï¼­ark Yao

[RESEND PATCH 3/6] drm/rockchip: vop: add cdn DP support for rk3399

2016-06-01 Thread Mark yao
An HTML attachment was scrubbed... URL:

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

2016-05-25 Thread Mark yao
An HTML attachment was scrubbed... URL:

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

2016-05-25 Thread Mark yao
An HTML attachment was scrubbed... URL:

[GIT PULL] drm/rockchip: new feature to support rk3399 vop and some fixes

2016-05-23 Thread Mark yao
ers (2016-05-23 14:39:37 +0800) John Keeping (3): drm/rockchip: dw_hdmi: remove unused #include drm/rockchip: fb: add missing header drm/rockchip: fix "should it be static?" warnings Mark Yao (5

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

2016-05-23 Thread Mark yao
On 2016年05月05日 17:34, Tomeu Vizoso wrote: > On 20 April 2016 at 16:23, Tomeu Vizoso wrote: >> On 11 April 2016 at 03:15, Mark yao wrote: >>> On 2016年04月08日 18:54, Tomeu Vizoso wrote: >>>> On 8 April 2016 at 03:07, Mark yao wrote: >>>>> O

[PATCH 0/3] drm/rockchip: fix some sparse warnings

2016-05-23 Thread Mark yao
On 2016年05月11日 00:03, John Keeping wrote: > The first patch wasn't found by sparse, but is something I noticed while > in the area. The following two fix all of the sparse warnings inside > drm/rockchip. > > John Keeping (3): >drm/rockchip: dw_hdmi: remove unused #include >

[PATCH RESEND v3 1/2] drm: introduce bus_flags in drm_display_info

2016-05-05 Thread Mark yao
Hi Stefan Actually, the pixel clock or data enable polarity are also needed by drm/rockchip, but I have a question: why not add these polarity into drm_display_mode->flags. drm_display_mode->flags has hsync and vsync polarity, I think it's cool that add pixel clock or data enable polarity on

[GIT PULL] drm/rockchip: some fixes

2016-05-03 Thread Mark yao
(2016-05-03 14:11:23 +0800) Dan Carpenter (1): drm/rockchip: inno_hdmi: fix an error code John Keeping (2): drm/rockchip: remove redundant statement drm/rockchip: don't leak iommu mapping Mark Yao (4): drm

[PATCH v2] drm/rockchip: vop: fix iommu crash with async atomic

2016-04-29 Thread Mark Yao
actually swap out from vop hardware. Signed-off-by: Mark Yao --- Changes in v2: - fix some format problem. drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

[PATCH] drm/rockchip: vop: Initialize vskiplines to zero

2016-04-29 Thread Mark Yao
There is a path that use vskiplines with non-initialize. That would cause vop abnormal behavior. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu

[PATCH] drm/rockchip: vop: fix iommu crash with async atomic

2016-04-29 Thread Mark Yao
hardware. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 28596e7..38c4de9 100644 --- a/drivers/gpu/drm

[PATCH v3] drm/rockchip: support non-iommu buffer path

2016-04-29 Thread Mark Yao
Some rockchip vop not support iommu, need use non-iommu buffer for it. And if we get iommu issues, we can compare the issues with non-iommu path, the would help the debug. Signed-off-by: Mark Yao --- Changes in v3 - fix conflict with other iommu patch. Changes in v2 Advised by Heiko Stuebner

[patch] drm/rockchip: inno_hdmi: fix an error code

2016-04-22 Thread Mark yao
On 2016年04月21日 22:03, Dan Carpenter wrote: > On Fri, Feb 26, 2016 at 02:26:23PM +0800, Yakir Yang wrote: >> Dan, >> >> On 02/26/2016 05:30 AM, Dan Carpenter wrote: >>> We were accidentally returning PTR_ERR(NULL) which means success when we >>> wanted to return a negative error code. >>> >>>

[PATCH v2 5/5] dt-bindings: add documentation for Rockchip rk3399 display controllers

2016-04-20 Thread Mark Yao
Cc: Rob Herring <robh+dt at kernel.org> Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell <ijc+devicetree at hellion.org.uk> Cc: Kumar Gala Signed-off-by: Mark Yao --- .../bindings/display/rockchip/rockchip-vop.txt |5 + 1 file changed, 5 insertions(+) diff --git a/D

[PATCH v2 4/5] drm/rockchip: vop: add rk3399 vop support

2016-04-20 Thread Mark Yao
four windows. VOP_LIT only support two windows. RK3399 vop register layout is similar with rk3288, so some feature can reuse with rk3288. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 15 ++- drivers/gpu/drm/rockchip/rockchip_drm_vop.h |4 + drivers/gpu/drm

[PATCH v2 3/5] drm/rockchip: vop: introduce VOP_REG_MASK

2016-04-20 Thread Mark Yao
Some new vop register support mask, bit[16-31] is mask, bit[0-15] is value, the mask is correspond to the value. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 45 ++- drivers/gpu/drm/rockchip/rockchip_drm_vop.h |1 + drivers/gpu/drm

[PATCH v2 2/5] dt-bindings: sort Rockchip vop compatible by chip's number

2016-04-20 Thread Mark Yao
Signed-off-by: Mark Yao --- .../bindings/display/rockchip/rockchip-vop.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index

[PATCH v2 1/5] drm/rockchip: sort registers define by chip's number

2016-04-20 Thread Mark Yao
No functional changes, sort the vop registers to make code more readable. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 166 +-- drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 88 +++--- 2 files changed, 127 insertions(+), 127

[PATCH v2 0/5] drm/rockchip: add rk3399 display controller support

2016-04-20 Thread Mark Yao
patches tested on rk3399 evb board. Changes in v2: - sort the registers and vop compatible name - spilt VOP_REG_MASK into a single patch - make rk3399 vop documentation more readable(Heiko Stübner) Mark Yao (5): drm/rockchip: sort registers define by chip's number dt-bindings: sort Rockchip vop

[PATCH v2] drm/rockchip: support non-iommu buffer path

2016-04-20 Thread Mark Yao
Some rockchip vop not support iommu, need use non-iommu buffer for it. And if we get iommu issues, we can compare the issues with non-iommu path, the would help the debug. Signed-off-by: Mark Yao --- Changes in v2 Advised by Heiko Stuebner - use more suitable message print. drivers/gpu/drm

[PATCH v3] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-20 Thread Mark Yao
We need to take care of the vop status when use rockchip_drm_crtc_mode_config, if vop is disabled, the function would failed, that is terrible. Save output_type and output_mode into rockchip_crtc_state, it's nice to make them into atomic. Signed-off-by: Mark Yao --- Changes in v3: - foget

[PATCH v2] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-20 Thread Mark Yao
We need to take care of the vop status when use rockchip_drm_crtc_mode_config, if vop is disabled, the function would failed, that is terrible. Save output_type and output_mode into rockchip_crtc_state, it's nice to make them into atomic. Signed-off-by: Mark Yao --- Changes in v2: Advised

[PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-20 Thread Mark yao
On 2016年04月19日 17:06, John Keeping wrote: > On Tue, 19 Apr 2016 10:43:03 +0800, Mark yao wrote: > >> On 2016年04月18日 17:25, John Keeping wrote: >>> On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote: >>> >>>>> We

[PATCH 2/2] dt-bindings: add document for rk3399-vop

2016-04-19 Thread Mark yao
On 2016年04月19日 15:58, Heiko Stübner wrote: > patch subject above: > dt-bindings: add documentation for Rockchip rk3399 display controllers > > not everybody skimming over patches directly knows what a vop is;-) > > I still believe even such a trivial patch should also get some form of >

[PATCH] drm/rockchip: rewrite IOMMU support code

2016-04-19 Thread Mark Yao
: Marek Szyprowski Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/Kconfig|3 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 +++ drivers/gpu/drm/rockchip/rockchip_drm_drv.h |1 + 3 files changed, 60 insertions(+), 25 deletions(-) diff --git

[PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-19 Thread Mark yao
On 2016年04月18日 17:25, John Keeping wrote: > On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote: > >> >We need to take care of the vop status when use >> >rockchip_drm_crtc_mode_config, if vop is disabled, >> >the function would failed, that is terri

[PATCH] drm/rockchip: support non-iommu buffer path

2016-04-19 Thread Mark Yao
Some rockchip vop not support iommu, need use non-iommu buffer for it. And if we get iommu issues, we can compare the issues with non-iommu path, the would help the debug. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 65 +++ 1 file changed

[PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-18 Thread Mark yao
On 2016年04月18日 17:25, John Keeping wrote: >> >We need to take care of the vop status when use >> >rockchip_drm_crtc_mode_config, if vop is disabled, >> >the function would failed, that is terrible. >> > >> >Save connector type and output mode on drm_display_mode->private_flags >> >at encoder

[PATCH 2/2] dt-bindings: add document for rk3399-vop

2016-04-18 Thread Mark Yao
Cc: Rob Herring <robh+dt at kernel.org> Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell <ijc+devicetree at hellion.org.uk> Cc: Kumar Gala Signed-off-by: Mark Yao --- .../bindings/display/rockchip/rockchip-vop.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/D

[PATCH 1/2] drm/rockchip: vop: add rk3399 vop support

2016-04-18 Thread Mark Yao
four windows. VOP_LIT only support two windows. RK3399 vop register layout is similar with rk3288, so some feature can reuse with rk3288. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 60 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h |5 + drivers/gpu

[PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-18 Thread Mark Yao
rtc mode_set. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 37 +++- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 44 ++- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c |5 +-- drivers/gpu/drm/rockchip/inno_hdmi.c|

[RFC 3/3] iommu: dma-iommu: use common implementation also on ARM architecture

2016-04-18 Thread Mark yao
good on drm/rockchip ARM64 platform with this patch. So Tested-by: Mark Yao Thanks. -- ï¼­ark Yao

[RFC 2/3] iommu: dma-iommu: move IOMMU/DMA-mapping code from ARM64 arch to drivers

2016-04-18 Thread Mark yao
ski IOMMU works good on drm/rockchip ARM64 platform with this patch. So Tested-by: Mark Yao Thanks. -- ï¼­ark Yao

[RFC 0/3] Unify IOMMU-based DMA-mapping code for ARM and ARM64

2016-04-18 Thread Mark yao
Hi Marek With your patches, do drm/rockchip dma-mapping rewrite, IOMMU works good on drm/rockchip ARM64 platform. Thanks for your patches. On 2016年02月19日 16:22, Marek Szyprowski wrote: > Dear All, > > This is an initial RFC on the unification of IOMMU-based DMA-mapping > code for ARM and

[PATCH 2/2] drm/rockchip: don't leak iommu mapping

2016-04-11 Thread Mark yao
On 2016年04月05日 21:50, John Keeping wrote: > arm_iommu_attach_device() takes its own reference to the mapping we give > it. Since we do not keep a reference to the mapping ourselves, we must > release it before returning. > > Also fix the error path, which fails to release the mapping if it

[PATCH 1/2] drm/rockchip: remove redundant statement

2016-04-11 Thread Mark yao
On 2016年04月05日 21:50, John Keeping wrote: > The call to arm_iommu_detach_device() on the previous line sets > dev->archdata.mapping to NULL so this call is always a no-op. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

2016-04-11 Thread Mark yao
On 2016年04月08日 18:54, Tomeu Vizoso wrote: > On 8 April 2016 at 03:07, Mark yao wrote: >> On 2016年04月06日 18:14, Tomeu Vizoso wrote: >> >> When a plane is being disabled but it's still enabled, do check if the >> previous update has been complet

[PATCH 1/2] drm/rockchip: vop: Do check if an update is pending during disable

2016-04-08 Thread Mark yao
An HTML attachment was scrubbed... URL:

[RFC PATCH v1 0/4] Add Rockchip RGA support

2016-04-05 Thread Mark yao
On 2016年03月31日 04:03, Emil Velikov wrote: > On 29 March 2016 at 14:13, Emil Velikov wrote: >> On 28 March 2016 at 23:13, Heiko Stübner wrote: >> >>> I have the feeling we're going quite a bit off-topic right now :-) . >>> The binary-driver-crazyness, hasn't really anything to do with

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v2

2016-04-01 Thread Mark yao
On 2016年04月01日 19:47, Tomeu Vizoso wrote: > On 04/01/2016 01:26 PM, Mark yao wrote: >> On 2016年03月31日 16:08, Tomeu Vizoso wrote: >>> As per the docs, atomic_commit should return -EBUSY "if an asycnhronous >>> updated is requested and there is an earl

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v2

2016-04-01 Thread Mark yao
An HTML attachment was scrubbed... URL:

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event

2016-03-31 Thread Mark yao
On 2016年03月30日 21:48, Tomeu Vizoso wrote: > As per the docs, atomic_commit should return -EBUSY "if an asycnhronous > updated is requested and there is an earlier updated pending". > > Also wait for the pending event to complete when a sync update is > requested. > > Signed-off-by: Tomeu

[GIT PULL]: drm/rockchip: some fixes

2016-03-28 Thread Mark yao
Hi Dave There are some fixes for drm/rockchip, looks good for me, I'd like you can land them. Thanks. The following changes since commit 4604202ca8d2a5e33b4bca0812b5d92975ed1bd8: Merge branch 'drm-next-4.6' of git://people.freedesktop.org/~agd5f/linux into drm-next (2016-03-25 16:02:06

[PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path

2016-03-28 Thread Mark yao
On 2016年03月08日 06:00, Douglas Anderson wrote: > The drm_encoder_cleanup() was missing both from the error path of > dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was > enabled and we ended up deferring probe of HDMI at boot. > > This call isn't needed from unbind() because if

[PATCH] drm/rockchip: vop: Don't reject empty modesets

2016-03-28 Thread Mark yao
On 2016年03月18日 19:22, Tomeu Vizoso wrote: > So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the > CRTC gets disabled. > > Signed-off-by: Tomeu Vizoso > Link: > http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw > at mail.gmail.com > --- >

[PATCH v2] drm/rockchip: vop: Disable planes when disabling CRTC

2016-03-28 Thread Mark yao
On 2016年03月22日 23:08, Tomeu Vizoso wrote: > When a VOP is re-enabled, it will start scanning right away the > framebuffers that were configured from the last time, even if those have > been destroyed already. > > To prevent the VOP from trying to access freed memory, disable all its >

[PATCH v14 09/17] drm: rockchip: dp: add rockchip platform dp driver

2016-03-23 Thread Mark yao
oks good for me, I like it, So Acked-by: Mark Yao -- ï¼­ark Yao

Who is going to merge it [Was: Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver]

2016-03-23 Thread Mark yao
On 2016年03月23日 08:41, Dave Airlie wrote: >>> So although it's small framework or just subdirectory, we would need >>> someone who can manage the framework to avoid further confusion if >>> necessary. >> So maybe it just doesn't need a maintainer, and maybe those the owner >> of the bridge

[PATCH] drm/rockchip: vop: Reset yrgb_mst when re-enabling

2016-03-19 Thread Mark yao
On 2016年03月18日 19:22, Tomeu Vizoso wrote: > When the VOP is re-enabled, it will start scanning right away the > framebuffers that were configured from the last time, even if those have > been destroyed already. To prevent the VOP from trying to access freed > memory, reset the registers that

[PATCH v15 1/3] drm: rockchip: Add basic drm driver

2016-03-15 Thread Mark yao
On 2016年03月14日 21:35, Tomeu Vizoso wrote: > On 2 December 2014 at 10:15, Mark Yao wrote: >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> new file mode 100644 >> index 000..e7ca25b >> --- /

[PATCH] drm/rockchip: cancel pending vblanks on close

2016-03-14 Thread Mark yao
On 2016年03月12日 01:21, John Keeping wrote: > When closing the DRM device while a vblank is pending, we access > file_priv after it has been free'd, which gives: > >Unable to handle kernel NULL pointer dereference at virtual address > >... >PC is at __list_add+0x5c/0xe8 >

[PATCH v2] drm/rockchip: vop: fix crtc size in plane check

2016-03-14 Thread Mark yao
revious size and will not fill the screen. > > Signed-off-by: John Keeping > --- > On Fri, 04 Mar 2016 09:04:57 +0800, Mark yao wrote: >> On 2016年02月22日 20:22, John Keeping wrote: >>> If the geometry of a crtc is changing in an atomic update then we much >>

[PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path

2016-03-07 Thread Mark yao
On 2016年03月05日 20:39, Russell King - ARM Linux wrote: > On Sat, Mar 05, 2016 at 12:11:16PM +, John Keeping wrote: >> On Fri, Mar 04, 2016 at 03:22:01PM -0800, Douglas Anderson wrote: >>> The drm_encoder_cleanup() was missing both from the error path of >>> dw_hdmi_rockchip_bind(). This

[PATCH] drm/rockchip: vop: fix crtc size in plane check

2016-03-04 Thread Mark yao
On 2016年02月22日 20:22, John Keeping wrote: > If the geometry of a crtc is changing in an atomic update then we much I think "we much validate" should be "we must validate".:-) > validate the plane size against the new state of the crtc and not the > current size, otherwise if the crtc size

[PATCH v8 0/2] Add Rockchip Inno-HDMI driver

2016-02-18 Thread Mark yao
On 2016年01月29日 14:42, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: >- Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter >- Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec >- Digital video interface supports a pixel

[GIT PULL] drm/rockchip: new feature to support inno hdmi

2016-02-18 Thread Mark yao
Hi Dave These patches based on drm-next, it looks good and Innosilicon HDMI works, so I'd like you can land them. Thanks. The following changes since commit 5443ce86fa37e7d3cc63d2067d05e3388fdeec17: drm: virtio-gpu: set atomic flag (2016-02-11 08:56:23 +1000) are available in the git

[PATCH v8.1 1/2] drm/rockchip: hdmi: add Innosilicon HDMI support

2016-02-18 Thread Mark yao
On 2016年02月18日 05:00, Heiko Stuebner wrote: > Am Mittwoch, 3. Februar 2016, 17:44:57 schrieb Yakir Yang: >> The Innosilicon HDMI is a low power HDMI 1.4 transmitter >> IP, and it have been integrated on some rockchip CPUs >> (like RK3036, RK312x). >> >> Signed-off-by: Yakir Yang > On a

[PATCH v8 0/2] Add Rockchip Inno-HDMI driver

2016-02-16 Thread Mark yao
Hi Ping, it seems inno hdmi driver is ready, So I'd like to merge it into drm/rockchip if there is no doubt these days. Thanks. Mark On 2016年01月29日 14:42, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: >- Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard

[PATCH v2 15/17] drm/rockchip: removed optional dummy encoder mode_fixup function.

2016-02-16 Thread Mark yao
implementations. > > (made on top of Daniel topic/drm-misc branch) > > Signed-off-by: Carlos Palminha > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 > 1 file changed, 8 deletions(-) > > Acked-by: Mark Yao Thanks Mark

[PATCH v8 2/2] dt-bindings: add document for Innosilicon HDMI on Rockchip platform

2016-01-29 Thread Mark yao
An HTML attachment was scrubbed... URL:

[PATCH v7 0/2] Add Rockchip Inno-HDMI driver

2016-01-29 Thread Mark yao
On 2016年01月26日 10:59, Yakir Yang wrote: > Here are a brief introduction to Innosilicon HDMI IP: >- Support HDMI 1.4a, HDCP 1.2 and DVI 1.0 standard compliant transmitter >- Support HDMI1.4 a/b 3D function defined in HDMI 1.4 a/b spec >- Digital video interface supports a pixel

<    1   2   3   4   5   6   >