Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code

2022-06-03 Thread nicolas saenz julienne
as the > driver's PM ops were not hooked-up. > > So, in order to support regular operation with V3D on BCM2711 (Raspberry > Pi 4), get rid of the PM code. PM will be reinstated once we figure out > the underlying issues. > > Signed-off-by: Nicolas Saenz Julienne > Si

Re: [PATCH v2 3/3] drm/vc4: Notify the firmware when DRM is in charge

2021-12-10 Thread nicolas saenz julienne
Hi Maxime, On Fri, 2021-12-03 at 14:51 +0100, Maxime Ripard wrote: > Once the call to drm_fb_helper_remove_conflicting_framebuffers() has > been made, simplefb has been unregistered and the KMS driver is entirely > in charge of the display. > > Thus, we can notify the firmware it can free whateve

Re: [PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline

2021-11-30 Thread nicolas saenz julienne
Hi Maxime, On Wed, 2021-11-17 at 15:50 +0100, Maxime Ripard wrote: > Hi, > > The VC4 driver has had limited support to disable the HDMI controllers and > pixelvalves at boot if the firmware has enabled them. > > However, this proved to be limited, and a bit unreliable so a new firmware > command

Re: [PATCH 03/11] mmc: bcm2835: stop setting chan_config->slave_id

2021-11-15 Thread nicolas saenz julienne
off-by: Arnd Bergmann > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas

Re: [PATCH] drm/vc4: crtc: Make sure the HDMI controller is powered when disabling

2021-09-30 Thread nicolas saenz julienne
d complaint > when we do that kind of access. > > Let's make sure we have the HDMI controller properly powered while > disabling it. > > Fixes: 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time") > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas

[PATCH] drm/vc4: hdmi: Limit noise when deferring snd card registration

2021-06-29 Thread Nicolas Saenz Julienne
such case. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 04936cd6db8c..32da45821d3a 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c

Re: vc4_bo_create: Failed to allocate from CMA

2021-06-17 Thread nicolas saenz julienne
On Sat, 2021-06-12 at 17:17 +0200, Stefan Wahren wrote: > Hi, > > while testing the mainline kernel (arm64, defconfig) on Raspberry Pi 3 B > Plus with Raspberry Pi OS - 64 bit, sometimes X doesn't start into > desktop properly (unexpected and unusable login screen instead of auto > login or mouse

Re: [PATCH 4/4] ARM: boot: dts: bcm2711: Add BCM2711 VEC compatible

2021-06-08 Thread nicolas saenz julienne
On Thu, 2021-05-20 at 17:03 +0200, Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > The BCM2711 has a slightly different VEC than the one found in the older > SoCs. Now that we support the new variant, add its compatible to the > device tree. > > Signed-off-by: Mateusz Kwiatkowski > Signed-

Re: [PATCH v2 11/12] drm/vc4: hdmi: Remove redundant variables

2021-06-01 Thread nicolas saenz julienne
On Tue, 2021-05-25 at 15:23 +0200, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard Adding a commit message would've been nice. But I guess the patch is trivial enough. Other than that: Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas

Re: [PATCH v2 10/12] drm/vc4: hdmi: Register HDMI codec

2021-06-01 Thread nicolas saenz julienne
On Tue, 2021-05-25 at 15:23 +0200, Maxime Ripard wrote: > The hdmi-codec brings a lot of advanced features, including the HDMI > channel mapping. Let's use it in our driver instead of our own codec. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas

Re: [PATCH v2 09/12] drm/vc4: hdmi: Remove firmware logic for MAI threshold setting

2021-06-01 Thread nicolas saenz julienne
On Tue, 2021-05-25 at 15:23 +0200, Maxime Ripard wrote: > From: Dom Cobley > > This was a workaround for bugs in hardware on earlier Pi models > and wasn't totally successful. What's to expect sound wise on older RPis? Regards, Nicolas

Re: [PATCH v2 08/12] drm/vc4: hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE

2021-06-01 Thread nicolas saenz julienne
ff-by: Dom Cobley > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas

Re: [PATCH v2 07/12] drm/vc4: hdmi: Set HDMI_MAI_FMT

2021-06-01 Thread nicolas saenz julienne
On Tue, 2021-05-25 at 15:23 +0200, Maxime Ripard wrote: > From: Dom Cobley > > The hardware uses this for generating the right audio > data island packets when using formats other than PCM > > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard > --- Reviewed-by

Re: [PATCH v2 06/12] drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET

2021-06-01 Thread nicolas saenz julienne
fifo, > filling up the broken sample and maintaining alignment. > > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas

[PATCH v3 12/15] drm/v3d: Add support for bcm2711

2021-02-17 Thread Nicolas Saenz Julienne
Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/Kconfig | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig

[PATCH v3 11/15] drm/v3d: Get rid of pm code

2021-02-17 Thread Nicolas Saenz Julienne
regular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_debugfs.c | 18 +- drivers/gpu/drm/v3d/v3d_drv.c | 11 ---

[PATCH v3 10/15] dt-bindings: gpu: v3d: Add BCM2711's compatible

2021-02-17 Thread Nicolas Saenz Julienne
BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Document

[PATCH v3 00/15] Raspberry PI 4 V3D enablement

2021-02-17 Thread Nicolas Saenz Julienne
e or less stable experience using mesa 20.3.4 and X11/Gnome. Regards, Nicolas --- Changes since v2: - Correct ASB names - Address dt-binding comments Changes since v1: - Use 'reg-names' - Correct ASB names - Add missing binding patch for V3D - Address Stefan's comments Nico

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Nicolas Saenz Julienne
hich will mean that HDMI I2C will be > polled, like it was before. > > Reported-by: Dave Stevenson > Signed-off-by: Florian Fainelli Acked-by: Nicolas Saenz Julienne Regards, Nicolas signature.asc Description: This is a digitally signed message part __

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-12 Thread Nicolas Saenz Julienne
On Wed, 2021-02-10 at 10:49 -0800, Florian Fainelli wrote: > On 2/10/21 7:49 AM, Dave Stevenson wrote: > > Hi Marc. > > > > On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: > > > > > > Hi Maxime, > > > > > > On 2021-02-10 14:40, Maxime Ripard wrote: > > > > Hi Dave, > > > > > > > > On Tue, Fe

[RFC/PATCH v2 12/16] drm/v3d: Get rid of pm code

2021-02-09 Thread Nicolas Saenz Julienne
regular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_debugfs.c | 18 +- drivers/gpu/drm/v3d/v3d_drv.c | 11 ---

[RFC/PATCH v2 13/16] drm/v3d: Add support for bcm2711

2021-02-09 Thread Nicolas Saenz Julienne
Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/Kconfig | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig

[RFC/PATCH v2 11/16] dt-bindings: gpu: v3d: Add BCM2711's compatible

2021-02-09 Thread Nicolas Saenz Julienne
BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings. Signed-off-by: Nicolas Saenz Julienne --- Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu

[RFC/PATCH v2 00/16] Raspberry PI 4 V3D enablement

2021-02-09 Thread Nicolas Saenz Julienne
ges since v1: - Use 'reg-names' - Correct ASB names - Add missing binding patch for V3D - Address Stefan's comments Nicolas Saenz Julienne (16): dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names dt-binding

[RFC/PATCH 00/11] Raspberry PI 4 V3D enablement

2021-02-05 Thread Nicolas Saenz Julienne
really provide an exact explanation on what changed HW wise. Ultimately, I need confirmation from the Broadcom folks that they are alright with patch #7. With all this, I get a more or less stable experience using mesa 20.3.4 and X11/Gnome. Regards, Nicolas --- Nicolas Saenz Julienne (11)

[RFC/PATCH 08/11] drm/v3d: Add support for bcm2711

2021-02-05 Thread Nicolas Saenz Julienne
Add compatible string and Kconfig options for bcm2711. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/Kconfig | 2 +- drivers/gpu/drm/v3d/v3d_drv.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig

[RFC/PATCH 07/11] drm/v3d: Get rid of pm code

2021-02-05 Thread Nicolas Saenz Julienne
gular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues. Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_debugfs.c | 18 +- drivers/gpu/drm/v3d/v3d_drv.c | 11 ---

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-04 Thread Nicolas Saenz Julienne
ome cases as it applies to all entries. 'contains' is the correct schema > to use in the case of multiple entries. > > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Eric Anholt > Cc: Nicolas Saenz Julienne > Cc: F

Re: [PATCH v2 15/15] ARM: dts: bcm2711: Add the CEC interrupt controller

2021-01-28 Thread Nicolas Saenz Julienne
On Mon, 2021-01-11 at 15:23 +0100, Maxime Ripard wrote: > The CEC and hotplug interrupts go through an interrupt controller shared > between the two HDMI controllers. > > Let's add that interrupt controller and the interrupts for both HDMI > controllers > > Reviewed-by: Florian Fainelli > Signed

Re: [PATCH v2 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2021-01-26 Thread Nicolas Saenz Julienne
Hi, On Mon, 2021-01-11 at 15:22 +0100, Maxime Ripard wrote: > Hi, > > Here's a series introducing the CEC support for the BCM2711 found on the > RaspberryPi4. > > The BCM2711 HDMI controller uses a similar layout for the CEC registers, the > main difference being that the interrupt handling part

Re: [PATCH RFC] drm/vc4: hdmi: Avoid ASoC error messages on startup

2021-01-19 Thread Nicolas Saenz Julienne
Hi Stefan, Maxime, On Mon, 2021-01-18 at 12:28 +0100, Stefan Wahren wrote: > Hi, > > Am 15.01.21 um 19:39 schrieb Mark Brown: > > On Fri, Jan 15, 2021 at 07:14:37PM +0100, Maxime Ripard wrote: > > > On Wed, Jan 13, 2021 at 11:42:23AM +, Mark Brown wrote: > > > > On Wed, Jan 13, 2021 at 10:19:

Re: [PATCH V4] dt-bindings: gpu: Convert v3d to json-schema

2021-01-16 Thread Nicolas Saenz Julienne
On Wed, 2021-01-13 at 20:08 +0100, Stefan Wahren wrote: > This converts the v3d bindings to yaml format. > > Signed-off-by: Stefan Wahren > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas > > Changes in V4: > - define order for required reg-names > - adapt

Re: [PATCH RFC] drm/vc4: hdmi: Avoid ASoC error messages on startup

2021-01-16 Thread Nicolas Saenz Julienne
rrors by returning EPROBE_DEFER in this situation. > > Signed-off-by: Stefan Wahren > --- Seems reasonable to me: Tested-by: Nicolas Saenz Julienne Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas signature.asc Description: This is a digitally signed message part

[PATCH] drm/vc4: Unify PCM card's driver_name

2021-01-16 Thread Nicolas Saenz Julienne
ports with two distinct audio cards. This is reflected in their names, making them different from previous RPi versions. With this, ALSA ultimately misses the board's configuration on RPi4. In order to avoid this, set "card->driver_name" to "vc4-hdmi" unanimously. S

Re: [PATCH v2 01/15] ARM: bcm: Select BRCMSTB_L2_IRQ for bcm2835

2021-01-11 Thread Nicolas Saenz Julienne
@Maxime it seems you forgot to CC me on the series :) On Mon, 2021-01-11 at 08:54 -0800, Florian Fainelli wrote: > > On 1/11/2021 6:22 AM, Maxime Ripard wrote: > > The BCM2711 has a number of instances of interrupt controllers handled > > by the driver behind the BRCMSTB_L2_IRQ Kconfig option (ir

Re: [PATCH V2 3/4] drm/v3d: Don't clear MMU control bits on exception

2020-12-25 Thread Nicolas Saenz Julienne
and writing the > result back. There are some important control bits in that register, > including MMU_ENABLE, so a safer approach is to simply write back the > value just read unaltered. > > Signed-off-by: Phil Elwell > Signed-off-by: Stefan Wahren > --- Reviewed-by: Nicol

Re: [PATCH V2 2/4] drm/v3d: Set dma_mask as well as coherent_dma_mask

2020-12-25 Thread Nicolas Saenz Julienne
> > Signed-off-by: Phil Elwell > Signed-off-by: Stefan Wahren > --- Reviewed-by: Nicolas Saenz Julienne Regards, Nicolas signature.asc Description: This is a digitally signed message part ___ dri-devel mailing list dri-devel@

Re: [PATCH 8/8] ARM: dts: bcm2711: Use compatible string for BCM2711 DSI1

2020-12-22 Thread Nicolas Saenz Julienne
On Thu, 2020-12-03 at 14:25 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > Updates the compatible string for DSI1 on BCM2711 to > differentiate it from BCM2835. > > Signed-off-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- Applied for-next, Thanks! signature.asc Descripti

Re: [PATCH 2/8] drm/vc4: dsi: Correct DSI register definition

2020-12-10 Thread Nicolas Saenz Julienne
ned-off-by: Maxime Ripard > > Wouldn't this deserve a "Fixes: ..." and "Cc: sta...@vger.kernel.org" > tag, as this bug is present in all stable releases since this driver was > introduced? I think it would be really helpful to have it backported. Agree, this would be nice

Re: [PATCH 1/8] drm/vc4: drv: Remove the DSI pointer in vc4_drv

2020-12-10 Thread Nicolas Saenz Julienne
On Thu, 2020-12-03 at 14:25 +0100, Maxime Ripard wrote: > That pointer isn't used anywhere, so there's no point in keeping it. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Nicolas Saenz Julienne >  drivers/gpu/drm/vc4/vc4_drv.h | 1 - >  drivers/gpu/drm/vc4/

Re: [PATCH v2 3/3] ARM: dts: rpi-4: disable wifi frequencies

2020-11-21 Thread Nicolas Saenz Julienne
On Thu, 2020-10-29 at 14:40 +0100, Maxime Ripard wrote: > The RPi4 WiFi chip and HDMI outputs have some frequency overlap with > crosstalk around 2.4GHz. Let's mark it as such so we can use some evasive > maneuvers. > > Signed-off-by: Maxime Ripard > > --- > > Changes from v1: > - Changed the

Re: [PATCH v2 1/3] dt-bindings: display: Add a property to deal with WiFi coexistence

2020-10-30 Thread Nicolas Saenz Julienne
On Thu, 2020-10-29 at 19:07 +0100, Maxime Ripard wrote: > Hi Nicolas, > > On Thu, Oct 29, 2020 at 06:43:27PM +0100, Nicolas Saenz Julienne wrote: > > Hi maxime, > > > > On Thu, 2020-10-29 at 14:40 +0100, Maxime Ripard wrote: > > > The RaspberryPi4 has both a W

Re: [PATCH v2 1/3] dt-bindings: display: Add a property to deal with WiFi coexistence

2020-10-30 Thread Nicolas Saenz Julienne
Hi maxime, On Thu, 2020-10-29 at 14:40 +0100, Maxime Ripard wrote: > The RaspberryPi4 has both a WiFi chip and HDMI outputs capable of doing > 4k. Unfortunately, the 1440p resolution at 60Hz has a TMDS rate on the > HDMI cable right in the middle of the first Wifi channel. > > Add a property to o

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-09 Thread Nicolas Saenz Julienne
Hi Dave, sorry for the late reply. On Tue, 2020-10-06 at 18:14 +0100, Dave Stevenson wrote: > Hi Maxime > > On Tue, 6 Oct 2020 at 16:26, Maxime Ripard wrote: > > Hi Dave, > > > > On Fri, Oct 02, 2020 at 04:57:05PM +0100, Dave Stevenson wrote: > > > Hi Maxime > > > > > > On Fri, 2 Oct 2020 at 1

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Nicolas Saenz Julienne
On Wed, 2020-09-30 at 09:38 -0700, Nathan Chancellor wrote: > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > Hi Nathan, > > > > On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > > > On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > > > > Now th

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Nicolas Saenz Julienne
Hi Tim, thanks for the info! On Thu, 2020-10-01 at 11:15 +0100, Tim Gover wrote: > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > VCO to support a core-frequency of 550 MHz which is the minimum > frequency required by the HVS at 4Kp60. The side effect is that if the > disp

Re: [PATCH v2 1/4] clk: bcm: rpi: Add register to control pixel bvb clk

2020-09-09 Thread Nicolas Saenz Julienne
hw = raspberrypi_clk_register(rpi, clks->parent, > clks->id); > if (IS_ERR(hw)) Acked-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 0/4] drm/vc4: Support HDMI QHD or higher output

2020-09-09 Thread Nicolas Saenz Julienne
On Tue, 2020-09-01 at 13:07 +0900, Hoegeun Kwon wrote: > Hi everyone, > > There is a problem that the output does not work at a resolution > exceeding FHD. To solve this, we need to adjust the bvb clock at a > resolution exceeding FHD. > > Rebased on top of next-20200708 and [1]. > > [1] : [PATC

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-09 Thread Nicolas Saenz Julienne
On Thu, 2020-09-03 at 10:01 +0200, Maxime Ripard wrote: > Now that all the drivers have been adjusted for it, let's bring in the > necessary device tree changes. > > The VEC and PV3 are left out for now, since it will require a more specific > clock setup. > > Reviewed-by: Dave Stevenson > Teste

Re: [PATCH v11 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-09-09 Thread Nicolas Saenz Julienne
On Tue, 2020-09-08 at 11:43 +0200, Christoph Hellwig wrote: > And because I like replying to myself so much, here is a link to the > version with the arm cleanup patch applied. Unlike the previous two > attempts this has at least survived very basic sanity testing: > > http://git.infradead.org/us

Re: [PATCH v11 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-09-08 Thread Nicolas Saenz Julienne
Hi Jim, sorry I'm a little late to the party, but was on vacation. On Thu, 2020-09-03 at 13:32 -0400, Jim Quinlan wrote: > On Wed, Sep 2, 2020 at 8:52 PM Nathan Chancellor > wrote: > > On Wed, Sep 02, 2020 at 05:36:29PM -0700, Florian Fainelli wrote: > > > > > > On 9/2/2020 3:38 PM, Nathan Chanc

Re: [PATCH v11 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-09-08 Thread Nicolas Saenz Julienne
Hi Christoph, a small fix to your fixes: On Tue, 2020-09-01 at 10:24 +0200, Christoph Hellwig wrote: > I've applied this to the dma-mapping tree. > > I had to resolve a conflict in drivers/of/address.c with a recent > mainline commit. I also applied the minor tweaks Andy pointed out > plus a few

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-08 Thread Nicolas Saenz Julienne
Hi Maxime, On Mon, 2020-09-07 at 18:22 +0200, Maxime Ripard wrote: > Hi, > > On Thu, Sep 03, 2020 at 10:00:32AM +0200, Maxime Ripard wrote: > > Hi everyone, > > > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > > for the display pipeline found in the BCM2711 (and thu

Re: [PATCH v11 07/11] device-mapping: Introduce DMA range map, supplanting dma_pfn_offset

2020-09-08 Thread Nicolas Saenz Julienne
On Mon, 2020-09-07 at 13:40 -0400, Jim Quinlan wrote: > On Mon, Sep 7, 2020 at 11:01 AM Nicolas Saenz Julienne > wrote: > > > > > > Hi Nicolas, > > > > > > Can you please help us out here? It appears that your commit > > > > It's dma_

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-08-03 Thread Nicolas Saenz Julienne
Hi Jim, here's some comments after testing your series against RPi4. On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > The new field 'dma_range_map' in struct device is used to facilitate the > use of single or multiple offsets between mapping regions of cpu addrs and > dma addrs. It subsum

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-31 Thread Nicolas Saenz Julienne
On Thu, 2020-07-30 at 13:25 -0400, Jim Quinlan wrote: > On Thu, Jul 30, 2020 at 1:05 PM Nicolas Saenz Julienne > wrote: > > Hi Jim, > > > > On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > > > static void __init of_unittest_pci_dma_ranges(void) > >

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-31 Thread Nicolas Saenz Julienne
Hi Jim, On Fri, 2020-07-24 at 16:33 -0400, Jim Quinlan wrote: > static void __init of_unittest_pci_dma_ranges(void) > diff --git a/drivers/pci/controller/pcie-brcmstb.c > b/drivers/pci/controller/pcie-brcmstb.c > index bfc2542d54a8..8dacb9d3b7b6 100644 > --- a/drivers/pci/controller/pcie-brcmstb

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-31 Thread Nicolas Saenz Julienne
On Thu, 2020-07-30 at 12:44 -0400, Jim Quinlan wrote: > On Wed, Jul 29, 2020 at 10:28 AM Rob Herring wrote: > > On Wed, Jul 29, 2020 at 12:19 AM Christoph Hellwig wrote: > > > On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote: > > > > I started using devm_kcalloc() but at least two revi

[PATCH] drm/v3d: Use platform_get_irq_optional() to get optional IRQs

2020-07-17 Thread Nicolas Saenz Julienne
Aside from being more correct, the non optional version of the function prints an error when failing to find the IRQ. Fixes: eea9b97b4504 ("drm/v3d: Add support for V3D v4.2") Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_irq.c | 2 +- 1 file changed, 1 inser

[PATCH] drm/v3d: Fix double free in gem code

2020-07-17 Thread Nicolas Saenz Julienne
quot;Merge v5.4-rc7 into drm-next") Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/v3d/v3d_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 915f8bfdb58c..3cfbdb8e6a91 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.

Re: [PATCH v3 004/105] clk: bcm: Add BCM2711 DVP driver

2020-06-07 Thread Nicolas Saenz Julienne
On Fri, 2020-06-05 at 19:43 +0200, Maxime Ripard wrote: > Hi Nicolas, > > On Thu, Jun 04, 2020 at 07:26:07PM +0200, Nicolas Saenz Julienne wrote: > > On Wed, 2020-05-27 at 17:47 +0200, Maxime Ripard wrote: > > > The HDMI block has a block that controls clocks and reset si

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-07 Thread Nicolas Saenz Julienne
Hi Christoph, a question arouse, is there a real value to dealing with PFNs (as opposed to real addresses) in the core DMA code/structures? I see that in some cases it eases interacting with mm, but the overwhelming usage of say, dev->dma_pfn_offset, involves shifting it. Hi Jim, On Thu, 2020-06-0

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Nicolas Saenz Julienne
Hi Jim, On Wed, 2020-06-03 at 15:20 -0400, Jim Quinlan wrote: > The new field in struct device 'dma_pfn_offset_map' is used to facilitate > the use of multiple pfn offsets between cpu addrs and dma addrs. It > subsumes the role of dev->dma_pfn_offset -- a uniform offset -- and > designates the si

Re: [PATCH v3 09/13] device core: Introduce multiple dma pfn offsets

2020-06-05 Thread Nicolas Saenz Julienne
Hi Jim, On Thu, 2020-06-04 at 10:35 -0400, Jim Quinlan wrote: [...] > > > --- a/arch/sh/kernel/dma-coherent.c > > > +++ b/arch/sh/kernel/dma-coherent.c > > > @@ -14,6 +14,8 @@ void *arch_dma_alloc(struct device *dev, size_t size, > > > dma_addr_t *dma_handle, > > > { > > > void *ret, *ret

Re: [PATCH v3 004/105] clk: bcm: Add BCM2711 DVP driver

2020-06-05 Thread Nicolas Saenz Julienne
Hi Maxime, On Wed, 2020-05-27 at 17:47 +0200, Maxime Ripard wrote: > The HDMI block has a block that controls clocks and reset signals to the > HDMI0 and HDMI1 controllers. Why not having two separate drivers? > Let's expose that through a clock driver implementing a clock and reset > provider.

Re: [PATCH v2 20/91] clk: bcm: rpi: Discover the firmware clocks

2020-05-21 Thread Nicolas Saenz Julienne
Hi Maxime, On Fri, 2020-05-15 at 10:19 +0200, Maxime Ripard wrote: > Hi Nicolas, > > On Mon, May 04, 2020 at 02:05:47PM +0200, Nicolas Saenz Julienne wrote: > > Hi Maxime, as always, thanks for the series! > > Some extra context, and comments below. > > > >

Re: [PATCH v2 20/91] clk: bcm: rpi: Discover the firmware clocks

2020-05-04 Thread Nicolas Saenz Julienne
Hi Maxime, as always, thanks for the series! Some extra context, and comments below. On Fri, 2020-04-24 at 17:34 +0200, Maxime Ripard wrote: > The RaspberryPi4 firmware actually exposes more clocks than are currently > handled by the driver and we will need to change some of them directly > based

Re: [PATCH v2 05/91] clk: bcm: rpi: Allow the driver to be probed by DT

2020-05-01 Thread Nicolas Saenz Julienne
On Fri, 2020-04-24 at 17:33 +0200, Maxime Ripard wrote: > The current firmware clock driver for the RaspberryPi can only be probed by > manually registering an associated platform_device. > > While this works fine for cpufreq where the device gets attached a clkdev > lookup, it would be tedious to

Re: [PATCH v2 04/91] firmware: rpi: Only create clocks device if we don't have a node for it

2020-05-01 Thread Nicolas Saenz Julienne
On Fri, 2020-04-24 at 17:33 +0200, Maxime Ripard wrote: > The firmware clocks driver was previously probed through a platform_device > created by the firmware driver. > > Since we will now have a node for that clocks driver, we need to create the > device only in the case where there's no node for

Re: [PATCH v2 04/91] firmware: rpi: Only create clocks device if we don't have a node for it

2020-04-28 Thread Nicolas Saenz Julienne
Hi Maxime, On Fri, 2020-04-24 at 17:33 +0200, Maxime Ripard wrote: > The firmware clocks driver was previously probed through a platform_device > created by the firmware driver. > > Since we will now have a node for that clocks driver, we need to create the > device only in the case where there's

Re: [PATCH] drm/vc4: Fix HDMI mode validation

2020-03-30 Thread Nicolas Saenz Julienne
Hi Daniel, On Thu, 2020-03-26 at 13:20 +0100, Nicolas Saenz Julienne wrote: > Current mode validation impedes setting up some video modes which should > be supported otherwise. Namely 1920x1200@60Hz. > > Fix this by lowering the minimum HDMI state machine clock to pixel clock >

Re: [PATCH] drm/vc4: Fix HDMI mode validation

2020-03-30 Thread Nicolas Saenz Julienne
On Fri, 2020-03-27 at 13:40 +0100, Maxime Ripard wrote: > On Fri, Mar 27, 2020 at 12:46:52PM +0100, Nicolas Saenz Julienne wrote: > > Hi Daniel, > > > > On Thu, 2020-03-26 at 13:20 +0100, Nicolas Saenz Julienne wrote: > > > Current mode validation impedes setting up

[PATCH] drm/vc4: Fix HDMI mode validation

2020-03-26 Thread Nicolas Saenz Julienne
eported-by: Stefan Wahren Suggested-by: Dave Stevenson Signed-off-by: Nicolas Saenz Julienne --- drivers/gpu/drm/vc4/vc4_hdmi.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index ce

Re: [PATCH] drm/vc4: Fix HDMI mode validation

2020-03-26 Thread Nicolas Saenz Julienne
On Thu, 2020-03-26 at 18:19 +0100, Stefan Wahren wrote: > Am 26.03.20 um 13:20 schrieb Nicolas Saenz Julienne: > > Current mode validation impedes setting up some video modes which should > > be supported otherwise. Namely 1920x1200@60Hz. > > > > Fix this by lowe

Re: [PATCH 86/89] drm/vc4: hdmi: Adjust HSM clock rate depending on pixel rate

2020-03-17 Thread Nicolas Saenz Julienne
Hi Maxime, On Mon, 2020-02-24 at 10:07 +0100, Maxime Ripard wrote: > @@ -1460,6 +1456,7 @@ static int vc4_hdmi_dev_remove(struct platform_device > *pdev) > } > > struct vc4_hdmi_variant bcm2835_variant = { > + .max_pixel_clock= 14850, Just a reminder this might change in the cl

Re: [PATCH 07/89] clk: bcm: rpi: Allow the driver to be probed by DT

2020-02-29 Thread Nicolas Saenz Julienne
Hi Maxime, On Wed, 2020-02-26 at 16:01 +0100, Maxime Ripard wrote: [...] > This was actually a shameless bait to start that discussion, so I'm > glad it worked ;) :) [...] > > - Some of those fw managed clocks you're creating have their mmio > > counterpart > > being registered by clk-bcm23

Re: [PATCH 10/89] clk: bcm: rpi: Remove global pllb_arm clock pointer

2020-02-27 Thread Nicolas Saenz Julienne
On Wed, 2020-02-26 at 15:26 +0100, Maxime Ripard wrote: > Hi Nicolas, > > On Tue, Feb 25, 2020 at 05:13:33PM +0100, Nicolas Saenz Julienne wrote: > > On Mon, 2020-02-24 at 10:06 +0100, Maxime Ripard wrote: > > > The pllb_arm clk_hw pointer in the raspberry_clk structure i

Re: [PATCH 18/89] clk: bcm: rpi: Rename is_prepared function

2020-02-26 Thread Nicolas Saenz Julienne
h the other function names, and drop the fw from the > function name. It seems you didn't :) As it does use the fw interface I'd say keep it in the name, with that: Acked-by: Nicolas Saenz Julienne Thanks! Nicolas > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linu

Re: [PATCH 15/89] clk: bcm: rpi: Create a data structure for the clocks

2020-02-26 Thread Nicolas Saenz Julienne
he future, let's decouple the clock data from > the provider data. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Desc

Re: [PATCH 07/89] clk: bcm: rpi: Allow the driver to be probed by DT

2020-02-26 Thread Nicolas Saenz Julienne
Hi Maxime, On Mon, 2020-02-24 at 10:06 +0100, Maxime Ripard wrote: > The current firmware clock driver for the RaspberryPi can only be probed by > manually registering an associated platform_device. > > While this works fine for cpufreq where the device gets attached a clkdev > lookup, it would b

Re: [PATCH 10/89] clk: bcm: rpi: Remove global pllb_arm clock pointer

2020-02-26 Thread Nicolas Saenz Julienne
ael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Signed-off-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is a digitally signed message part ___ dri-devel mailing

Re: [PATCH 11/89] clk: bcm: rpi: Make sure pllb_arm is removed

2020-02-26 Thread Nicolas Saenz Julienne
use its managed variant > to take care of that for us. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This i

Re: [PATCH 12/89] clk: bcm: rpi: Remove pllb_arm_lookup global pointer

2020-02-26 Thread Nicolas Saenz Julienne
bal pointer from the structure. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is a digitally signed message part __

Re: [PATCH 08/89] clk: bcm: rpi: Statically init clk_init_data

2020-02-26 Thread Nicolas Saenz Julienne
On Mon, 2020-02-24 at 10:06 +0100, Maxime Ripard wrote: > Instead of declaring the clk_init_data and then calling memset on it, just > initialise properly. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard > ---

Re: [PATCH 16/89] clk: bcm: rpi: Add clock id to data

2020-02-26 Thread Nicolas Saenz Julienne
structure so that we can support more clocks later on. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is

Re: [PATCH 13/89] clk: bcm: rpi: Switch to clk_hw_register_clkdev

2020-02-26 Thread Nicolas Saenz Julienne
linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is a digitally signed message part ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.fre

Re: [PATCH 14/89] clk: bcm: rpi: Make sure the clkdev lookup is removed

2020-02-26 Thread Nicolas Saenz Julienne
; to make sure it happens. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is a digitally signed message part _

Re: [PATCH 09/89] clk: bcm: rpi: Use clk_hw_register for pllb_arm

2020-02-26 Thread Nicolas Saenz Julienne
an simply call > clk_hw_register with a static clk_fixed_factor structure. > > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is

Re: [PATCH 16/89] clk: bcm: rpi: Add clock id to data

2020-02-26 Thread Nicolas Saenz Julienne
Hi Maxime, On Tue, 2020-02-25 at 10:54 +0100, Maxime Ripard wrote: > Hi Stefan, > > On Mon, Feb 24, 2020 at 08:25:46PM +0100, Stefan Wahren wrote: > > Hi Maxime, > > > > Am 24.02.20 um 10:06 schrieb Maxime Ripard: > > > The driver has really only supported one clock so far and has hardcoded > >

Re: [PATCH 17/89] clk: bcm: rpi: Pass the clocks data to the firmware function

2020-02-26 Thread Nicolas Saenz Julienne
Boyd > Cc: linux-...@vger.kernel.org > Signed-off-by: Maxime Ripard Acked-by: Nicolas Saenz Julienne Thanks! Nicolas signature.asc Description: This is a digitally signed message part ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

2019-12-19 Thread Nicolas Saenz Julienne
Hi Peter, On Wed, 2019-12-18 at 08:43 +, Peter Robinson wrote: > On arm64 the config ARCH_BCM doesn't exist so to be able to > build for platforms such as the Raspberry Pi 4 we need to add > ARCH_BCM2835 similar to what has been done on vc4. > > Signed-off-by: Peter Robinson > --- v3d's ups

Re: [PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig

2019-12-19 Thread Nicolas Saenz Julienne
Hi Florian, On Wed, 2019-12-18 at 09:39 -0800, Florian Fainelli wrote: > On 12/18/19 6:39 AM, Nicolas Saenz Julienne wrote: > > Hi Peter, > > > > On Wed, 2019-12-18 at 08:43 +, Peter Robinson wrote: > > > On arm64 the config ARCH_BCM doesn't exist so to b

Re: [PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node

2019-10-14 Thread Nicolas Saenz Julienne
On Mon, 2019-10-14 at 16:28 +0800, Shawn Guo wrote: > On Tue, Sep 24, 2019 at 08:12:38PM +0200, Nicolas Saenz Julienne wrote: > > qoriq-mc's dpmacs DMA configuration is inherited from their parent node, > > which acts a bus in this regard. So far it maked all devices as > &g

Re: [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-26 Thread Nicolas Saenz Julienne
> > > > Robin, have you looked into supporting multiple dma-ranges? It's the > > > > next thing > > > > we need for BCM STB's PCIe. I'll have a go at it myself if nothing is in > > > > the > > > > works already. > > > > > > Multiple dma-ranges as far as configuring inbound windows should work > >

Re: [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-25 Thread Nicolas Saenz Julienne
On Wed, 2019-09-25 at 16:09 +0100, Robin Murphy wrote: > On 25/09/2019 15:52, Nicolas Saenz Julienne wrote: > > On Tue, 2019-09-24 at 16:59 -0500, Rob Herring wrote: > > > On Tue, Sep 24, 2019 at 1:12 PM Nicolas Saenz Julienne > > > wrote: > > > > Hi All, &

Re: [PATCH 00/11] of: Fix DMA configuration for non-DT masters

2019-09-25 Thread Nicolas Saenz Julienne
On Tue, 2019-09-24 at 16:59 -0500, Rob Herring wrote: > On Tue, Sep 24, 2019 at 1:12 PM Nicolas Saenz Julienne > wrote: > > Hi All, > > this series tries to address one of the issues blocking us from > > upstreaming Broadcom's STB PCIe controller[1]. Namely,

[PATCH 01/11] of: address: clean-up unused variable in of_dma_get_range()

2019-09-24 Thread Nicolas Saenz Julienne
'len' in of_dma_get_range() is used to check the 'dma-ranges' property length. After the fact, some calculations are run on the variable to be then left unused. Signed-off-by: Nicolas Saenz Julienne --- drivers/of/address.c | 5 ++--- 1 file changed, 2 insertions(+), 3 dele

[PATCH 02/11] of: base: introduce __of_n_*_cells_parent()

2019-09-24 Thread Nicolas Saenz Julienne
lls_parent() in order to deal with this limitation. For now, it'll only be available privately to OF code. Signed-off-by: Nicolas Saenz Julienne --- drivers/of/base.c | 44 + drivers/of/of_private.h | 3 +++ 2 files changed, 34 insertions(+

[PATCH 07/11] dts: arm64: layerscape: add dma-ranges property to qoric-mc node

2019-09-24 Thread Nicolas Saenz Julienne
qoriq-mc's node in order for DT's DMA configuration code to get the DMA constraints from it. Signed-off-by: Nicolas Saenz Julienne --- arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi

[PATCH 05/11] of: expose __of_get_dma_parent() to OF subsystem

2019-09-24 Thread Nicolas Saenz Julienne
The function was only available locally to of/address.c, make it available to the OF subsystem. Signed-off-by: Nicolas Saenz Julienne --- drivers/of/address.c| 18 -- drivers/of/base.c | 25 + drivers/of/of_private.h | 2 ++ 3 files changed

  1   2   >