[PATCH] cdv: Fix typos in initialization of mdfld_chip_ops

2012-04-28 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mdfld_device.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/mdfld_device.c b/drivers/gpu/drm/gma500/mdfld_device.c index a0bd48c..717f4db 100644 --- a/drivers/gpu/drm/gma500

[PATCH] gma500: Prevent endless loop in panel power up sequence

2012-05-13 Thread Patrik Jakobsson
Some devices don't have a panel connected to LVDS and thus will never power up. This patch checks the power sequence progress bits in PP_STATUS to prevent an endless loop on such devices. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_lid.c | 12 +--- 1 file chang

Re: [PATCH] gma500: Prevent endless loop in panel power up sequence

2012-05-13 Thread Patrik Jakobsson
On Sun, May 13, 2012 at 2:17 PM, Patrik Jakobsson wrote: > Some devices don't have a panel connected to LVDS and thus will never power > up. > This patch checks the power sequence progress bits in PP_STATUS to prevent an > endless loop on such devices. "gma500: address

[PATCH] gma500: Fix hardware cursor support for poulsbo

2012-05-13 Thread Patrik Jakobsson
devices that has this requirement. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c|1 + drivers/gpu/drm/gma500/mdfld_device.c |1 + drivers/gpu/drm/gma500/oaktrail_device.c |1 + drivers/gpu/drm/gma500/psb_device.c|1 + drivers/gpu/drm

Re: [PATCH] gma500: Prevent endless loop in panel power up sequence

2012-05-13 Thread Patrik Jakobsson
On Sun, May 13, 2012 at 3:59 PM, Alan Cox wrote: > We should never get there. In fact we don't want to because if there is > np panel the backlight is not initialised either. > > I'll take a look. I've just fixed a related problem where we wrongly > invoked the lid code on non Pouslbo devices. Ok

Re: [PATCH] gma500: Fix hardware cursor support for poulsbo

2012-05-13 Thread Patrik Jakobsson
On Sun, May 13, 2012 at 3:53 PM, Paul Menzel wrote: >> The patch also adds a mark in chip ops so we can identify devices that has >> this > > s,has,have, Noted... > How can it be verified, that the hardware cursor is working? As Alan says, use the modesetting driver from: git://anongit.freedes

Re: [PATCH] gma500: Fix hardware cursor support for poulsbo

2012-05-16 Thread Patrik Jakobsson
On Wed, May 16, 2012 at 11:01 PM, Guillaume Clément wrote: > It looks like on others parts of the kernel, kunmap is fed the same input as > kmap and not the return value of kmap. Good catch and thank you for testing, I blindly assumed the alloc / free semantics. Alan, I'll send you a new version

Re: gma500 suspend to ram fails (3.4)

2012-06-18 Thread Patrik Jakobsson
On Sun, Jun 17, 2012 at 12:03 PM, Mattia Dongili wrote: > 3.5-rc2 is not quite usable, I get a pile of warnings for > DRM_OBJECT_MAX_PROPERTY being too small and in the end I don't get > neither a console nor X. Give 3.5-rc3 a try. There is a patch that at least silences the DRM_OBJECT_MAX_PROPE

Re: question about drivers/gpu/drm/gma500/oaktrail_lvds.c

2012-07-08 Thread Patrik Jakobsson
On Sun, Jul 8, 2012 at 10:16 PM, Alan Cox wrote: > On Sun, 8 Jul 2012 10:39:43 +0200 (CEST) > Julia Lawall wrote: > >> In the function oaktrail_lvds_mode_set, I don't think that the following >> code makes any sense: >> >> /* Find the connector we're trying to set up */ >> list_

Re: [PATCH] gma500: Fix lid related crash

2012-07-16 Thread Patrik Jakobsson
On Wed, Jul 4, 2012 at 6:15 PM, Alan Cox wrote: > From: Alan Cox > > We set up the lid timer before we set up the backlight. On some devices > that causes a crash as we do a backlight change before or during the setup. > > As this fixes a crash on boot on some setups it ought to go in ASAP. > > S

Re: [PATCH 14/15] gma500: nuke the PSB debug stuff

2011-06-09 Thread Patrik Jakobsson
On Thu, Jun 9, 2011 at 12:36 PM, Dave Airlie wrote: > On Thu, 2011-06-09 at 09:11 +0100, Alan Cox wrote: >> On Thu, 9 Jun 2011 03:10:03 +0200 >> Patrik Jakobsson wrote: >> >> > Hi Alan >> > >> > Just a thought. Shouldn't we use the DRM macros fo

Re: Proposal for a low-level Linux display framework

2011-09-20 Thread Patrik Jakobsson
On Mon, Sep 19, 2011 at 9:29 AM, Tomi Valkeinen wrote: >> So DSI is more like i2c than the DisplayPort aux channel or DDC. That > > Well, not quite. DSI is like DisplayPort and DisplayPort aux combined; > there's only one bus, DSI, which is used to transfer video data and > commands. > > For DSI vi

Re: Proposal for a low-level Linux display framework

2011-09-20 Thread Patrik Jakobsson
On Tue, Sep 20, 2011 at 5:55 PM, Keith Packard wrote: > I'm not sure we need a new abstraction that subsumes both DSI and SDVO, Ok. SDVO fits within the current abstraction, but I guess what I'm fishing for is more code sharing of encoders. For instance, the SDVO code in GMA500 could be shared wit

Re: Proposal for a low-level Linux display framework

2011-09-21 Thread Patrik Jakobsson
On Wed, Sep 21, 2011 at 8:01 AM, Tomi Valkeinen wrote: > I don't know what MCS is. MCS is manufacturer specific commands (Manufacturer Command Set). > But DSI is just a bi-directional transfer > protocol between the SoC and the peripheral, you can send arbitrary data > over it. > > Normally the S

Re: [GMA500] Valid VCO frequency range on GMA500 platform?

2013-02-10 Thread Patrik Jakobsson
On Fri, Feb 8, 2013 at 2:51 PM, "David Müller (ELSOFT AG)" wrote: > > Hello > > I have a problem using a 1024x768 Eizo Monitor attached by DVI-D to a > system with GMA500 based graphics and running under Linux-3.7. > > As soon as the GMA500 driver is taking over control, the refresh > rate raises

Re: [GMA500] Valid VCO frequency range on GMA500 platform?

2013-02-11 Thread Patrik Jakobsson
On Mon, Feb 11, 2013 at 2:15 PM, "David Müller (ELSOFT AG)" wrote: > Hi Patrik > > Patrik Jakobsson wrote: >> The value of VCO_MIN comes from the Intel PRM for similar GPUs. >> >> Instead of changing VCO_MIN, could you try setting N_MIN=1, N_MAX=6 and >>

[PATCH] drm/i915: Set i9xx lvds clock limits according to specifications

2013-02-13 Thread Patrik Jakobsson
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 and 5-9. Since we do all calculations based on them being register values (which are subtracted by 2) we need to specify them accordingly. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_display.c |4

[PATCH] drm/i915: Set i9xx sdvo clock limits according to specifications

2013-02-13 Thread Patrik Jakobsson
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 and 5-9. Since we do all calculations based on them being register values (which are subtracted by 2) we need to specify them accordingly. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/intel_display.c |4

Re: [Intel-gfx] [PATCH] drm/i915: Set i9xx lvds clock limits according to specifications

2013-02-15 Thread Patrik Jakobsson
On Fri, Feb 15, 2013 at 1:51 PM, Chris Wilson wrote: > On Fri, Feb 15, 2013 at 12:18:49AM +, Chris Wilson wrote: >> On Wed, Feb 13, 2013 at 10:20:21PM +0100, Patrik Jakobsson wrote: >> > The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 >> >

Re: [Intel-gfx] [PATCH] drm/i915: Set i9xx lvds clock limits according to specifications

2013-02-16 Thread Patrik Jakobsson
On Fri, Feb 15, 2013 at 2:30 PM, Patrik Jakobsson wrote: > On Fri, Feb 15, 2013 at 1:51 PM, Chris Wilson > wrote: >> On Fri, Feb 15, 2013 at 12:18:49AM +, Chris Wilson wrote: >>> On Wed, Feb 13, 2013 at 10:20:21PM +0100, Patrik Jakobsson wrote: >>> >

[PATCH] gma500: Fix n, m1 and m2 clock limits for sdvo and lvds

2013-02-16 Thread Patrik Jakobsson
The values of n, m1 and m2 needs to be subtracted by 2 before writing them to the FP register. The dot clock calculation already thinks of these values in register form so we must also specify them as such. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 12

Re: [GMA500] Valid VCO frequency range on GMA500 platform?

2013-02-17 Thread Patrik Jakobsson
On Mon, Feb 11, 2013 at 11:18 PM, Patrik Jakobsson wrote: > On Mon, Feb 11, 2013 at 2:15 PM, "David Müller (ELSOFT AG)" > wrote: >> Hi Patrik >> >> Patrik Jakobsson wrote: >>> The value of VCO_MIN comes from the Intel PRM for similar GPUs. >>

Re: [PATCH] gma500: Fix n, m1 and m2 clock limits for sdvo and lvds

2013-02-21 Thread Patrik Jakobsson
On Sat, Feb 16, 2013 at 1:04 PM, Patrik Jakobsson wrote: > The values of n, m1 and m2 needs to be subtracted by 2 before writing them to > the FP register. The dot clock calculation already thinks of these values in > register form so we must also specify them as such. > > Signed

Re: [PATCH] gma500: medfield: Fix possible NULL pointer dereference

2013-02-25 Thread Patrik Jakobsson
} > > + dev = sender->dev; > + dev_priv = dev->dev_private; > + > /* Set default display backlight value to 85% (0xd8)*/ > mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, > true); Reviewed-by: Pat

Re: [PATCH] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-03-11 Thread Patrik Jakobsson
s_bl = kmemdup(vbt_lvds_bl, sizeof(*vbt_lvds_bl), GFP_KERNEL); > if (!lvds_bl) { > dev_err(dev_priv->dev->dev, "out of memory for backlight > data\n"); > return; > } > - memcpy(lvds_bl, vbt_lvds_bl, sizeof(*vbt_lvds_bl)

Re: [PATCH] gma500: Make VGA and HDMI connector hotpluggable

2013-04-02 Thread Patrik Jakobsson
drm_connector_init(dev, connector, >&cdv_hdmi_connector_funcs, > -- Your patch has been applied to: https://github.com/patjak/drm-gma500.git gma500-next We might also consider polling if this causes problems for people, but for now this

Re: [PATCH] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-04-02 Thread Patrik Jakobsson
bl)); > dev_priv->lvds_bl = lvds_bl; > } > > -- > 1.7.9.5 > > -- Your patch has been applied to: https://github.com/patjak/drm-gma500.git gma500-next Thanks Patrik Jakobsson ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] gma500: medfield: Fix possible NULL pointer dereference

2013-04-02 Thread Patrik Jakobsson
eturn; > } > > + dev = sender->dev; > + dev_priv = dev->dev_private; > + > /* Set default display backlight value to 85% (0xd8)*/ > mdfld_dsi_send_mcs_short(sender, write_display_brightness, 0xd8, 1, > true)

Re: gma500: Other things that I could work on

2013-04-03 Thread Patrik Jakobsson
On Wed, Apr 3, 2013 at 5:21 PM, Kero wrote: > Hi, > > I would not mind improving use of my Asus EeePC X101CH with Cedar View / > gma3600 > a bit more. But a barrier is knowledge of the hardware. Meddling with > existing (initialization) > code is possible, but for point 1 and 3 below that is not

Re: gma500: Other things that I could work on

2013-04-07 Thread Patrik Jakobsson
Hi Kero > 4) when using modules, initialization from hibernation is not good enough: >my screen stays black; without using modules, the kernel boots normally, > and everything is fine. > 5) initialization from suspend is not good enough: my Asus stays in >some text mode (80x25?), but show

Re: [PATCH] drivers/gpu/drm/gma500:fix build failure for 3.9-rc5

2013-04-09 Thread Patrik Jakobsson
On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou wrote: > From: Xiong Zhou > > This patch fixes build failure of v3.9-rc5. > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. > gma5/600 needs acpi_video just like nouveau. > > Failure message: > drivers/built-in.o: In function `psb_d

Re: [PATCH v2] gma500:fix build failure for 3.9-rc5

2013-04-10 Thread Patrik Jakobsson
On Wed, Apr 10, 2013 at 2:37 PM, Xiong Zhou wrote: > From: Xiong Zhou > > Last version of this patch is not clear enough and X86 duplicated. > > This patch fixes build failure of v3.9-rc5 and rc6. > When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. > GMA5/600 needs acpi_video

[PATCH 00/15] drm/gma500: Requesting review for gma500-next

2013-04-10 Thread Patrik Jakobsson
ssues with hibernating on Cedarview but hopefully no regressions. The repository can be found at: https://github.com/patjak/drm-gma500.git gma500-next Thanks Patrik Jakobsson Alexandru Gheorghiu (1): drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup Kero van Gelder (1):

[PATCH 01/15] gma500: remove unused drm_psb_no_fb

2013-04-10 Thread Patrik Jakobsson
From: Wang YanQing commit f9f23a77f07506a32d9dc1d925bf85c0e7507b66(gma500: remove no_fb bits) remove all the drm_psb_no_fb relations code in gma500 except this line code, so remove it also. Signed-off-by: Wang YanQing Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.h

[PATCH 02/15] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-04-10 Thread Patrik Jakobsson
From: Alexandru Gheorghiu Replaced calls kzalloc followed by memcpy with call to kmemdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/intel_bios.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 03/15] gma500: medfield: Fix possible NULL pointer dereference

2013-04-10 Thread Patrik Jakobsson
From: Syam Sidhardhan The use of pointer sender should be after the NULL check. Signed-off-by: Syam Sidhardhan Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/mdfld_dsi_output.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH 04/15] drm/gma500: Remove unused i8xx clock limits

2013-04-10 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 54 ++-- 1 file changed, 2 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 9edb190..414df48

[PATCH 05/15] drm/gma500: Calculate clock in one function instead of three identical

2013-04-10 Thread Patrik Jakobsson
i9xx_clock() and i8xx_clock() did the same calc and psb_intel_clock() just called i9xx_clock() so just move it all into psb_intel_clock(). The same calculation is duplicated in cdv_intel_display.c as well so maybe we can share it later on. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm

[PATCH 06/15] drm/gma500: Type clock limits directly into array and remove defines

2013-04-10 Thread Patrik Jakobsson
This makes it easier to read. We do the same for cdv so it becomes more consistent as well. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 66 +--- 1 file changed, 20 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH 07/15] drm/gma500: Remove unnecessary function exposure

2013-04-10 Thread Patrik Jakobsson
psb_intel_crtc_gamma_set() and psb_intel_crtc_destroy() aren't used outside of psb_intel_display.c right now so no need to expose them. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c |4 ++-- drivers/gpu/drm/gma500/psb_intel_display.h |3 --- 2

[PATCH 08/15] drm/gma500: Clean up various defines

2013-04-10 Thread Patrik Jakobsson
Remove unused defines that we'll never use and fix naming in some include guards Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/intel_bios.h|6 +++--- drivers/gpu/drm/gma500/psb_intel_display.c |2 -- drivers/gpu/drm/gma500/psb_intel_drv.h |

[PATCH 09/15] gma500: Make VGA and HDMI connector hotpluggable

2013-04-10 Thread Patrik Jakobsson
From: Kero van Gelder Both VGA and HDMI connectors are available on my Asus EeePC X101CH. This patch will cause output to be shown on either when plugged in. For both, it shows the leftmost 800x600, of the 1024x600 on LVDS. Signed-off-by: Kero van Gelder Signed-off-by: Patrik Jakobsson

[PATCH 10/15] drm/gma500: Change fb name so pm-utils doesn't apply quirks

2013-04-10 Thread Patrik Jakobsson
By having 'drm' and 'fb' in the fb screeninfo id, pm-utils will leave us alone. Otherwise we'll have quirks up to our ears and resume will break. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 11/15] drm/gma500: Add support for rebuilding the gtt

2013-04-10 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 45 ++ drivers/gpu/drm/gma500/gtt.h |2 +- 2 files changed, 38 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c index 04a371a

[PATCH 12/15] drm/gma500: Activate the gtt rebuild on suspend/resume

2013-04-10 Thread Patrik Jakobsson
than sorry. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/power.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c index 889b854..4c575a9 100644 --- a/drivers/gpu/drm/gma500/power.c +++ b/drivers/gpu/drm/gma500/po

[PATCH 13/15] drm/gma500: Add hooks for hibernation

2013-04-10 Thread Patrik Jakobsson
Currently we do whatever is done during suspend/resume but we might need some more work for hibernation so keep them in separate functions. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/power.c | 15 +++ drivers/gpu/drm/gma500/power.h |3 +++ drivers/gpu/drm

[PATCH 14/15] drm/gma500: Fix hibernation problems on sdvo encoders

2013-04-10 Thread Patrik Jakobsson
The state of the SDVO chip is more difficult to save than the LVDS so we do a full mode set on the crtc to get SDVO operational again. The SDVOB/C register is also stored just in case we have special bits set in the future. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500

[PATCH 15/15] gma500:fix build failure for 3.9-rc5

2013-04-10 Thread Patrik Jakobsson
message: drivers/built-in.o: In function `psb_driver_load': kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \ undefined reference to `acpi_video_register' make: *** [vmlinux] Error 1 Signed-off-by: Xiong Zhou Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Kcon

[PATCH] drm/gma500: Check connector status before restoring sdvo

2013-04-15 Thread Patrik Jakobsson
This patch fixes a bug introduced by: commit 749387dc8d8270b279f27a0a794cdf4f4a4aa774 Author: Patrik Jakobsson Date: Sun Apr 7 16:35:50 2013 +0200 drm/gma500: Fix hibernation problems on sdvo encoders The bug is triggered when we do a mode set on a sdvo encoder with all connectors in the

[PATCH] drm/gma500: Add debugging info to psb_gtt_restore()

2013-04-15 Thread Patrik Jakobsson
This makes it easier to see what's going on during resume/restore. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gtt.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c index 2f12faf..01

[GIT PULL] gma500-next

2013-04-16 Thread Patrik Jakobsson
ng info to psb_gtt_restore() (2013-04-15 23:44:56 +0200) Alexandru Gheorghiu (1): drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup Kero van Gelder (1): gma500: Make VGA and HDMI connector hotplu

Re: gma500: Other things that I could work on

2013-04-17 Thread Patrik Jakobsson
On Wed, Apr 17, 2013 at 7:57 PM, Kero wrote: >> > 4) when using modules, initialization from hibernation is not good enough: >> >my screen stays black; without using modules, the kernel boots >> > normally, and everything is fine. >> > 5) initialization from suspend is not good enough: my Asu

Re: [PATCH] drm/gma500: fix backlight hotkeys behaviour on cedarview netbooks

2013-04-24 Thread Patrik Jakobsson
On Wed, Apr 24, 2013 at 5:36 PM, Anisse Astier wrote: > Backlight hotkeys weren't working before on certain cedartrail laptops. > > The source of this problem is that the hotkeys' ASLE opregion interrupts > were simply ignored. Driver seemed to expect the interrupt to be > associated with a pipe,

[GIT PULL] gma500-fixes

2013-04-25 Thread Patrik Jakobsson
n for mode setting (2013-04-25 22:23:36 +0200) Anisse Astier (1): drm/gma500: fix backlight hotkeys behaviour on netbooks Patrik Jakobsson (1): drm/gma500: Increase max resolution for mode setting drivers/gpu/drm/g

Re: abuse of dumb ioctls in exynos

2013-04-30 Thread Patrik Jakobsson
On Mon, Apr 29, 2013 at 12:31 PM, Dave Airlie wrote: >> The reason we (currently) use the dumb buffer interface is because it >> does pretty much exactly what we need it to, as we only want linear >> RGB buffers: > > Except in the cases where it doesn't do what you want, and possibly in > the futu

Re: abuse of dumb ioctls in exynos

2013-04-30 Thread Patrik Jakobsson
On Tue, Apr 30, 2013 at 10:19 PM, Dave Airlie wrote: >>> Except in the cases where it doesn't do what you want, and possibly in >>> the future where it does less of what you want. You've started on a >>> slippery slope, and I'm stopping you before you make things worse. >>> >>> You are going to ha

Re: [PATCH] drm/gma500: fix backlight hotkeys behaviour on cedarview netbooks

2013-05-02 Thread Patrik Jakobsson
On Thu, May 2, 2013 at 2:39 PM, Anisse Astier wrote: > On Wed, 24 Apr 2013 23:39:58 +0200, Patrik Jakobsson > wrote : > >> On Wed, Apr 24, 2013 at 5:36 PM, Anisse Astier wrote: >> > Backlight hotkeys weren't working before on certain cedartrail laptops. >> &

Re: gma500: display displaced vertically by a few lines

2013-05-13 Thread Patrik Jakobsson
On Mon, May 13, 2013 at 3:02 PM, Holger Schurig wrote: > I installed xserver-xorg-video-modesettings (from Debian Wheezy) and also > updated xserver-core, -evdev, -vesa and -fbdev. The I started X11. Seems > that Debian doesn't yet contain the addition of the modesettings driver to > the auto-prob

Re: gma500: display displaced vertically by a few lines

2013-05-14 Thread Patrik Jakobsson
On Tue, May 14, 2013 at 2:13 PM, Holger Schurig wrote: > Okay, I found the patch that produces my regression: > > > From bc794829141f28e14fe7d0e07e35870bd9aee78c Mon Sep 17 00:00:00 2001 > From: Patrik Ja

Re: gma500: display displaced vertically by a few lines

2013-05-14 Thread Patrik Jakobsson
On Tue, May 14, 2013 at 3:07 PM, Holger Schurig wrote: > Patrick, have a > > Tested-by: Holger Schurig > > for this. I'll add that. > As for your suggestion: > >> though I recommend you use the modesetting driver because you get >> a hardware accelerated cursor. > > The current Debian Wheezy xs

[PATCH] drm/gma500: Add fb gtt offset to fb base

2013-05-20 Thread Patrik Jakobsson
Old code assumed framebuffer starts at base of stolen memory. Since the addition of hardware cursors, this might not be true anymore so add the gtt offset to the calculation. Reported-by: Holger Schurig Tested-by: Holger Schurig CC: Holger Schurig Signed-off-by: Patrik Jakobsson --- drivers

[PATCH 1/3] drm/gma500: Rework pin/unpin to prevent memory leak

2013-05-20 Thread Patrik Jakobsson
://bugzilla.novell.com/show_bug.cgi?id=812113 Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 44 ++ drivers/gpu/drm/gma500/gtt.c | 5 drivers/gpu/drm/gma500/psb_intel_display.c | 17 3 files changed, 45

[PATCH 2/3] drm/gma500: Fix mem leak of cursor objects on Poulsbo

2013-05-20 Thread Patrik Jakobsson
All dumb allocated buffers are now automatically pinned so no extra pinning is needed. Also properly unreference gem objects so they can be freed up properly. This only affects Poulsbo chips. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 49

[PATCH 3/3] drm/gma500: Fix mem leak of cursor objects on Cedarview

2013-05-20 Thread Patrik Jakobsson
All dumb allocated buffers are now automatically pinned so no extra pinning is needed. Also properly unreference gem objects so they can be freed up properly. This only affects Cedarview chips. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 39

[PATCH 2/3] drm/gma500: Fix cursor gem obj referencing on psb

2013-05-26 Thread Patrik Jakobsson
failure. This patch only affects Poulsbo chips. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500

[PATCH 3/3] drm/gma500: Fix cursor gem obj referencing on cdv

2013-05-26 Thread Patrik Jakobsson
failure. This patch only affects Cedarview chips. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500

[PATCH 1/3] drm/gma500: Unpin framebuffer when destroying it

2013-05-26 Thread Patrik Jakobsson
?id=889511 Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=812113 Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 8b1b6d9..1a11b69 10

Re: [PATCH 1/3] drm/gma500: Unpin framebuffer when destroying it

2013-05-26 Thread Patrik Jakobsson
On Sun, May 26, 2013 at 9:07 PM, Daniel Vetter wrote: > On Sun, May 26, 2013 at 08:03:53PM +0200, Patrik Jakobsson wrote: >> A framebuffer is pinned when it's set as pipe base, so we also need to >> unpin it when it's destroyed. Some framebuffers are never used as >&g

[PATCH 0/9] gma500: Fix SDVO DDC probing on Poulsbo

2011-12-07 Thread Patrik Jakobsson
This set of patches removes psb_intel_output and replaces it with psb_intel_encoder and psb_intel_connector. It also replaces the SDVO code with a slightly modified version from i915. i915 SDVO needs Intel gmbus so this is added along with a SDVO DDC bus guessing fix for Poulsbo. Patrik Jakobsson

[PATCH 1/9] gma500: Initial support for our encoder and connector structs

2011-12-07 Thread Patrik Jakobsson
First step towards adding i915 alike encoder and connector abstractions. This will make life easier when adding i915 output code into our driver. It also removes the old psb_intel_output struct. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c |7 + drivers

[PATCH 2/9] gma500: Remove psb_intel_output from ddc_probe and ddc_get_modes

2011-12-07 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_drv.h |5 +++-- drivers/gpu/drm/gma500/psb_intel_modes.c | 16 +++- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500

[PATCH 3/9] gma500: Fix encoder type checking for connectors

2011-12-07 Thread Patrik Jakobsson
Fix cases where we need to know what encoder type is behind a given connector. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/framebuffer.c |8 drivers/gpu/drm/gma500/psb_drv.c |6 +++--- drivers/gpu/drm/gma500/psb_intel_display.c | 24

[PATCH 4/9] gma500: Convert PSB LVDS to new output handling

2011-12-07 Thread Patrik Jakobsson
LVDS for PSB now uses psb_intel_encoder and psb_intel_connectors instead of psb_intel_output. i2c_bus and ddc_bus are moved to lvds_priv. There was also a pointer to mode_dev (for no obvious reason) that we now get directly from dev_priv. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm

[PATCH 5/9] gma500: Add support for Intel GMBUS

2011-12-07 Thread Patrik Jakobsson
Before we integrate the new SDVO code we need GMBUS support Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Makefile|1 + drivers/gpu/drm/gma500/intel_gmbus.c | 493 drivers/gpu/drm/gma500/psb_device.c|7 + drivers/gpu/drm

[PATCH 7/9] gma500: Convert Cedarview to work with new output handling

2011-12-07 Thread Patrik Jakobsson
Replace psb_intel_output with psb_intel_encoder and psb_intel_connector. Things will need to be cleaned up and tested so consider this an initial patch for Cedarview. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 47 +++- drivers/gpu/drm/gma500

[PATCH 8/9] gma500: Convert Moorestown to work with new output handling

2011-12-07 Thread Patrik Jakobsson
Replace psb_intel_output with psb_intel_encoder and psb_intel_connector Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/oaktrail_crtc.c | 18 drivers/gpu/drm/gma500/oaktrail_hdmi.c | 29 +++ drivers/gpu/drm/gma500/oaktrail_lvds.c | 79

[PATCH 9/9] gma500: SDVO DDC bus guessing isn't working so hardcode it instead

2011-12-07 Thread Patrik Jakobsson
We currently don't have support for parsing SDVO mappings from BIOS so we're guessing the bus switch parameter. This isn't working so hardcode it to a configuration known to work on most poulsbo hardware. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_inte

Re: [PATCH] intel, gma500, lvds: Fix use after free and mem leak in psb_intel_lvds_init()

2012-01-17 Thread Patrik Jakobsson
On Sat, Jan 14, 2012 at 10:15 PM, Jesper Juhl wrote: > In psb_intel_lvds_init(), if we fail to allocate memory for > 'psb_intel_connector' we free the memory we previously allocated for > 'psb_intel_encoder', but we then proceed to use that free'd pointer > when we do 'psb_intel_encoder->dev_priv =

Re: [PATCH 1/3] drm/gma500: Unpin framebuffer when destroying it

2013-06-05 Thread Patrik Jakobsson
On Sun, May 26, 2013 at 11:00 PM, Daniel Vetter wrote: > On Sun, May 26, 2013 at 10:31 PM, Patrik Jakobsson > wrote: >> On Sun, May 26, 2013 at 9:07 PM, Daniel Vetter wrote: >>> On Sun, May 26, 2013 at 08:03:53PM +0200, Patrik Jakobsson wrote: >>>> A framebuffe

[PATCH 1/2] drm/gma500/psb: Unpin framebuffer on crtc disable

2013-06-08 Thread Patrik Jakobsson
com/show_bug.cgi?id=889511 Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=812113 Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma

[PATCH 2/2] drm/gma500/cdv: Unpin framebuffer on crtc disable

2013-06-08 Thread Patrik Jakobsson
com/show_bug.cgi?id=889511 Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=812113 Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma

Re: [PATCH 1/2] drm/gma500/psb: Unpin framebuffer on crtc disable

2013-06-08 Thread Patrik Jakobsson
On Sat, Jun 8, 2013 at 9:01 PM, Patrik Jakobsson wrote: > The framebuffer needs to be unpinned in the crtc->disable callback > because of previous pinning in psb_intel_pipe_set_base(). This will fix > a memory leak where the framebuffer was released but not unpinned > properly.

[GIT PULL] gma500-fixes for 3.10-rc6

2013-06-09 Thread Patrik Jakobsson
for you to fetch changes up to 70b1304eeedf211fc9fa185b43350bd9ab4c119c: drm/gma500/cdv: Fix cursor gem obj referencing on cdv (2013-06-09 18:03:57 +0200) -------- Patrik Jakobsson (5): drm/gma500: Add fb gtt offset to fb base

Re: [PATCH 2/5] drm/gem: add shmem get/put page helpers

2013-07-08 Thread Patrik Jakobsson
6 +1730,10 @@ void drm_gem_free_mmap_offset(struct drm_gem_object > *obj); > int drm_gem_create_mmap_offset(struct drm_gem_object *obj); > int drm_gem_create_mmap_offset_size(struct drm_gem_object *obj, size_t size); > > +struct page **drm_gem_get_pages(struct drm_gem_object *obj, gfp_t g

Re: [PATCH 2/5] drm/gem: add shmem get/put page helpers

2013-07-09 Thread Patrik Jakobsson
On Tue, Jul 9, 2013 at 1:07 AM, Rob Clark wrote: > On Mon, Jul 8, 2013 at 4:18 PM, Daniel Vetter wrote: >> On Mon, Jul 08, 2013 at 02:56:31PM -0400, Rob Clark wrote: >>> On Mon, Jul 8, 2013 at 4:45 AM, Patrik Jakobsson >>> wrote: >>> > On Sun, J

Re: [PATCH 1/2] drm/gem: simplify object initialization

2013-07-11 Thread Patrik Jakobsson
_init(). > That isn't actually necessary for now, but might be in the future. > > Cc: Patrik Jakobsson > Signed-off-by: David Herrmann > --- > drivers/gpu/drm/drm_gem.c | 20 > drivers/gpu/drm/gma500/framebuffer.c | 6 ++ > dri

[PATCH 00/30] drm/gma500: Unify common chip functionality

2013-07-16 Thread Patrik Jakobsson
nd Poulsbo specific things. To differentiate between these we now use gma_* for generic stuff and keep psb_intel_* for the chip specifics. Eventually we'll just use gma_*, psb_*, cdv_*, etc... for everything. Patrik Jakobsson (30): drm/gma500: Add generic code for clock calculation drm/gma50

[PATCH 01/30] drm/gma500: Add generic code for clock calculation

2013-07-16 Thread Patrik Jakobsson
This patch aims to unify the bits and pieces that are common (or similar enough) for pll clock calculations. Nothing makes use of this code yet That will come in later patches. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/Makefile| 1 + drivers/gpu/drm/gma500

[PATCH 02/30] drm/gma500/cdv: Make use of the generic clock code

2013-07-16 Thread Patrik Jakobsson
Add chip specific callbacks for the generic and non-generic clock calculation code. Also remove as much dupilicated code as possible. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.c| 1 + drivers/gpu/drm/gma500/cdv_device.h| 1 + drivers/gpu/drm

[PATCH 03/30] drm/gma500: Make use of gma_pipe_has_type()

2013-07-16 Thread Patrik Jakobsson
Replace any use of xxx_intel_pipe_has_type() with the generic gma_pipe_has_type() function. Poulsbo still use it but that will be removed when we rip out psb_intel_pipe_has_type(). Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 8 drivers/gpu/drm

[PATCH 04/30] drm/gma500/psb: Make use of generic clock code

2013-07-16 Thread Patrik Jakobsson
Add chip specific callbacks for the generic and non-generic clock calculation code. Also remove as much dupilicated code as possible. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_device.c| 3 +- drivers/gpu/drm/gma500/psb_device.h| 24 drivers/gpu/drm

[PATCH 05/30] drm/gma500: Remove the unused psb_intel_display.h

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.h | 23 --- 1 file changed, 23 deletions(-) delete mode 100644 drivers/gpu/drm/gma500/psb_intel_display.h diff --git a/drivers/gpu/drm/gma500/psb_intel_display.h b/drivers/gpu/drm/gma500

[PATCH 06/30] drm/gma500: Add generic pipe/crtc functions

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 326 +++ drivers/gpu/drm/gma500/gma_display.h | 14 ++ 2 files changed, 340 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index

[PATCH 07/30] drm/gma500/cdv: Use identical generic crtc funcs

2013-07-16 Thread Patrik Jakobsson
This patch makes cdv use the gma_xxx counterparts that are identical. I took them in one sweep as they should not cause any regressions. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_device.h| 9 drivers/gpu/drm/gma500/cdv_intel_display.c | 74

[PATCH 08/30] drm/gma500: Make all chips use gma_wait_for_vblank

2013-07-16 Thread Patrik Jakobsson
Also remove the duplicated oaktrail function. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_dp.c| 3 ++- drivers/gpu/drm/gma500/mdfld_intel_display.c | 6 +++--- drivers/gpu/drm/gma500/oaktrail_crtc.c | 6 +++--- drivers/gpu/drm/gma500/oaktrail_hdmi.c

[PATCH 09/30] drm/gma500/psb: Use identical generic crtc funcs

2013-07-16 Thread Patrik Jakobsson
This patch makes psb use the gma_xxx counterparts that are identical. I took them in one sweep as they should not cause any regressions. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 41 +++--- 1 file changed, 4 insertions(+), 37

[PATCH 10/30] drm/gma500/cdv: Convert to gma_pipe_set_base()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 77 +- 1 file changed, 1 insertion(+), 76 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index ae57b93..9eee57b 100644

[PATCH 12/30] drm/gma500/cdv: Convert to gma_crtc_dpms()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 137 + drivers/gpu/drm/gma500/gma_display.c | 4 - drivers/gpu/drm/gma500/gma_display.h | 5 ++ 3 files changed, 8 insertions(+), 138 deletions(-) diff --git a/drivers

[PATCH 11/30] drm/gma500: Add IS_CDV() macro

2013-07-16 Thread Patrik Jakobsson
This macro is needed for Cedarview specific stuff in the generic gma functions. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h index eeed88c..ed1e567

[PATCH 14/30] drm/gma500/psb: Convert to gma_pipe_set_base()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 73 +- 1 file changed, 1 insertion(+), 72 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 0642e7d..ca041c6 100644

  1   2   3   4   5   6   7   8   9   >