[PATCH v4 1/2] drm/simpledrm: Allow physical width and height configuration via panel node

2023-01-26 Thread Rayyan Ansari
Parse the width-mm and height-mm devicetree properties of the panel node, and use this to set the DRM Display Mode instead of calculating it based on a hardcoded DPI. Signed-off-by: Rayyan Ansari --- drivers/gpu/drm/tiny/simpledrm.c | 32 +++- 1 file changed, 23

[PATCH v4 2/2] dt-bindings: display: simple-framebuffer: Document the panel node

2023-01-26 Thread Rayyan Ansari
Document the new panel node and what it is used for. Signed-off-by: Rayyan Ansari --- .../devicetree/bindings/display/simple-framebuffer.yaml | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation

[PATCH v4 0/2] SimpleDRM: allow configuring physical width and height

2023-01-26 Thread Rayyan Ansari
and for early boot code knowing if hi-dpi rendering is necessary. Changes since v3: - Use panel node Rayyan Ansari (2): drm/simpledrm: Allow physical width and height configuration via panel node dt-bindings: display: simple-framebuffer: Document the panel node .../bindings/display/simple

[PATCH v3 1/2] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-24 Thread Rayyan Ansari
Add optional width-mm and height-mm devicetree properties and use this to set the DRM Display Mode instead of calculating it based on an average DPI. Signed-off-by: Rayyan Ansari --- drivers/gpu/drm/tiny/simpledrm.c | 60 +++- 1 file changed, 51 insertions(+), 9

[PATCH v3 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

2023-01-24 Thread Rayyan Ansari
Document the optional width-mm and height-mm simple-framebuffer properties. Signed-off-by: Rayyan Ansari --- .../devicetree/bindings/display/simple-framebuffer.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b

[PATCH v3 0/2] SimpleDRM: allow configuring physical width and height

2023-01-24 Thread Rayyan Ansari
and for early boot code knowing if hi-dpi rendering is necessary. Changes since v2: - Remove $ref property (because it is an SI unit) - Extend commit messages Rayyan Ansari (2): drm/simpledrm: Allow physical width and height configuration via DT dt-bindings: display: simple-framebuffer: Document physical

Re: [PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

2023-01-24 Thread Rayyan Ansari
On 23/01/2023 17:53, Rob Herring wrote: On Sun, Jan 22, 2023 at 05:25:38PM +, Rayyan Ansari wrote: On 22/01/2023 15:36, Rob Herring wrote: On Sat, Jan 21, 2023 at 9:36 AM Rayyan Ansari wrote: Why do you need this change? The 'simple-framebuffer' contains data on how the bootloader

Re: [PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

2023-01-22 Thread Rayyan Ansari
On 22/01/2023 15:31, Rob Herring wrote: On Sat, 21 Jan 2023 15:35:44 +, Rayyan Ansari wrote: Signed-off-by: Rayyan Ansari --- .../devicetree/bindings/display/simple-framebuffer.yaml | 8 1 file changed, 8 insertions(+) My bot found errors running 'make DT_CHECKER_FLAGS=-m

Re: [PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

2023-01-22 Thread Rayyan Ansari
On 22/01/2023 15:36, Rob Herring wrote: On Sat, Jan 21, 2023 at 9:36 AM Rayyan Ansari wrote: Why do you need this change? The 'simple-framebuffer' contains data on how the bootloader configured the display. The bootloader doesn't configure the display size, so this information doesn't

[PATCH v2 1/2] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-21 Thread Rayyan Ansari
Signed-off-by: Rayyan Ansari --- drivers/gpu/drm/tiny/simpledrm.c | 60 +++- 1 file changed, 51 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 162eb44dcba8..7aab7fa572f0 100644 --- a/drivers/gpu

[PATCH v2 2/2] dt-bindings: display: simple-framebuffer: Document physical width and height properties

2023-01-21 Thread Rayyan Ansari
Signed-off-by: Rayyan Ansari --- .../devicetree/bindings/display/simple-framebuffer.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml index

[PATCH v2 0/2] SimpleDRM: allow configuring physical width and height

2023-01-21 Thread Rayyan Ansari
. Changes since RFC: - Switch to using 32-bit DT property - Report errors for return values of of_property_read_u32 except -EINVAL - Calculate default value during probe - Add documentation Rayyan Ansari (2): drm/simpledrm: Allow physical width and height configuration via DT dt-bindings: display

Re: [RFC PATCH] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-20 Thread Rayyan Ansari
+, Rayyan Ansari wrote: Hello, The following draft patch adds support for configuring the height-mm and width-mm DRM properties in the simpledrm driver via devicetree. This is useful to get proper scaling in UIs such as Phosh. An example of using this property is this, taken from my local tree

Re: [RFC PATCH] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-20 Thread Rayyan Ansari
On 19/01/2023 10:44, Thomas Zimmermann wrote: (cc: devicet...@vger.kernel.org, as...@lists.linux.dev) Hi, thanks for the patch. I already wondered if the DPI value should be configurable in some way. Am 18.01.23 um 19:48 schrieb Rayyan Ansari: Hello, The following draft patch adds support

[RFC PATCH] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-18 Thread Rayyan Ansari
Hello, The following draft patch adds support for configuring the height-mm and width-mm DRM properties in the simpledrm driver via devicetree. This is useful to get proper scaling in UIs such as Phosh. An example of using this property is this, taken from my local tree:

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-04 Thread Rayyan Ansari
.of_match_table = visionox_vtdr6130_of_match, + }, +}; +module_mipi_dsi_driver(visionox_vtdr6130_driver); + +MODULE_AUTHOR("Neil Armstron "); Missed a "g" here :-) +MODULE_DESCRIPTION("Panel driver for the visionox VTDR6130 AMOLED DSI panel"); I am not sure how the company capitalises the name, but to keep it consistent with the other mentions, I think it should be "Visionox". +MODULE_LICENSE("GPL"); -- Rayyan Ansari https://ansari.sh

Re: [v2,3/4] drm/panel: Add driver for JDI LPM102A188A

2022-12-25 Thread Rayyan Ansari
rr); + + jdi_panel_del(jdi); +} + +static void jdi_panel_dsi_shutdown(struct mipi_dsi_device *dsi) +{ + struct jdi_panel *jdi = mipi_dsi_get_drvdata(dsi); + + if (!jdi) + return; + + jdi_panel_disable(>base); +} + +static struct mipi_dsi_driver jdi_panel_dsi_driver = { + .driver = { + .name = "panel-jdi-lpm102a188a-dsi", Is the "-dsi" suffix needed here? Other panel drivers don't have this. + .of_match_table = jdi_of_match, + }, + .probe = jdi_panel_dsi_probe, + .remove = jdi_panel_dsi_remove, + .shutdown = jdi_panel_dsi_shutdown, +}; +module_mipi_dsi_driver(jdi_panel_dsi_driver); + +MODULE_AUTHOR("Sean Paul "); +MODULE_AUTHOR("Diogo Ivo "); +MODULE_DESCRIPTION("DRM Driver for JDI LPM102A188A DSI panel, command mode"); +MODULE_LICENSE("GPL"); -- Rayyan Ansari https://ansari.sh