Re: [PATCH] drm: core: Convert device logging to drm_* functions.

On Sat, Jul 18, 2020 at 08:25:31PM +0530, Suraj Upadhyay wrote: > Convert device logging with dev_* functions into drm_* functions. > > The patch has been generated with the coccinelle script below. > The script focuses on instances of dev_* functions where the drm device > con

[PATCH] drm: core: Convert device logging to drm_* functions.

1; expression list E2; @@ -dev_err_ratelimited(E1->dev, E2) +drm_err_ratelimited(E1, E2) @@expression E1; expression list E2; @@ -dev_dbg(E1->dev, E2) +drm_dbg_(E1, E2) Signed-off-by: Suraj Upadhyay --- drivers/gpu/drm/drm_edid.c | 6 ++ drivers/gpu/drm/drm_gem_cma_helper.

[PATCH v2] drm: core: Convert device logging to drm_* functions.

1; expression list E2; @@ -dev_err_ratelimited(E1->dev, E2) +drm_err_ratelimited(E1, E2) @@expression E1; expression list E2; @@ -dev_dbg(E1->dev, E2) +drm_dbg(E1, E2) Signed-off-by: Suraj Upadhyay --- Changes: v2: Fixed error in coccinelle script and diff,

Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

On Tue, Jul 14, 2020 at 02:41:37PM +0900, Benjamin Poirier wrote: > On 2020-07-13 17:50 +0530, Suraj Upadhyay wrote: > > Simplify while loops into more readable and simple for loops. > > > > Signed-off-by: Suraj Upadhyay > > --- > [...] > > @@ -182

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

On Fri, Jul 10, 2020 at 07:56:43PM +0200, Sam Ravnborg wrote: > Hi Suraj. > > On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > > > This patchset converts logging to drm_* functions in drm core. > > > > The following functions have been conv

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

On Sun, Jul 12, 2020 at 12:07:45PM -0700, Joe Perches wrote: > On Mon, 2020-07-13 at 00:24 +0530, Suraj Upadhyay wrote: > > On Sat, Jul 11, 2020 at 11:16:33AM -0700, Joe Perches wrote: > [] > > > Perhaps change the __drm_printk macro to not > > > derefere

Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote: > On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote: > > Simplify while loops into more readable and simple for loops. > > > > I don't think either is more clear that the other. Walter Harms hat

Re: [PATCH 0/4] drm: core: Convert logging to drm_* functions.

On Sat, Jul 11, 2020 at 11:16:33AM -0700, Joe Perches wrote: > On Sat, 2020-07-11 at 20:41 +0530, Suraj Upadhyay wrote: > > On Fri, Jul 10, 2020 at 07:56:43PM +0200, Sam Ravnborg wrote: > > > Hi Suraj. > > > > > > On Tue, Jul 07, 2020 at 10

[PATCH 3/4] drm: edid: Convert logging to drm_* functions.

Change logging of warnings to drm_warn() form dev_warn(). Signed-off-by: Suraj Upadhyay --- drivers/gpu/drm/drm_edid.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 31496b6cfc56..ad7a1f9817ed 100644

[PATCH 0/4] drm: core: Convert logging to drm_* functions.

This patchset converts logging to drm_* functions in drm core. The following functions have been converted to their respective DRM alternatives : dev_info() --> drm_info() dev_err() --> drm_err() dev_warn() --> drm_warn() dev_err_once() --> drm_err_once(). Suraj

[PATCH 2/4] drm: mipi-dbi: Convert logging to drm_* functions.

Convert logging of errors once from dev_err_once() to drm_err_once(). Signed-off-by: Suraj Upadhyay --- drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c index 79532b9a324a

[PATCH 4/4] drm: fb-helper: Convert logging to drm_* functions.

Change logging information from dev_info() to drm_info(). Signed-off-by: Suraj Upadhyay --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 5609e164805f..88146f7245c5

[PATCH 1/4] drm: mipi-dsi: Convert logging to drm_* functions.

Convert logging errors from dev_err() to drm_err(). Signed-off-by: Suraj Upadhyay --- drivers/gpu/drm/drm_mipi_dsi.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 07102d8da58f

[Proposal] drm: amd: Convert logging to drm_* functions with drm_device parameter

macros are worth it or not. I would like to start working on this task if this needs the change. Thank you, Suraj Upadhyay. [1] https://dri.freedesktop.org/docs/drm/gpu/todo.html. [2] https://dri.freedesktop.org/docs/drm/gpu/todo.html#convert-logging-to-drm-functions-with-drm-device-paramater

[PATCH] drm: connector: Indent code using tabs.

Replace space-indents with tab-indents. Issues found with checkpatch. Signed-off-by: Suraj Upadhyay --- drivers/gpu/drm/drm_connector.c | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm

[PATCH] drm : Insert blank lines after declarations.

Resolve checkpatch issues for missing blank lines after declarations. Issues found in multiple files with checkpatch.pl. Signed-off-by: Suraj Upadhyay --- Contributor comments : Hii developers, I am a new contributor to linux kernel. This email is over 600 lines however the changes are very