Re: [PATCH] drm/vc4: Add support for plane alpha

2018-04-22 Thread kbuild test robot
Hi Stefan, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.17-rc1] [also build test ERROR on next-20180420] [cannot apply to anholt/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://githu

Re: [PATCH] drm/vc4: Add support for plane alpha

2018-04-20 Thread Stefan Schake
On Sat, Apr 21, 2018 at 1:45 AM, Eric Anholt wrote: > Stefan Schake writes: > >> The HVS supports mixing fixed alpha with per-pixel alpha or >> setting a fixed plane alpha in case there is no per-pixel information. >> This allows us to support the generic DRM plane alpha property. > > Don't we ne

Re: [PATCH] drm/vc4: Add support for plane alpha

2018-04-20 Thread Eric Anholt
Stefan Schake writes: > The HVS supports mixing fixed alpha with per-pixel alpha or > setting a fixed plane alpha in case there is no per-pixel information. > This allows us to support the generic DRM plane alpha property. Don't we need to set needs_bg_fill based on alpha != OPAQUE, as well? Ot

[PATCH] drm/vc4: Add support for plane alpha

2018-04-20 Thread Stefan Schake
The HVS supports mixing fixed alpha with per-pixel alpha or setting a fixed plane alpha in case there is no per-pixel information. This allows us to support the generic DRM plane alpha property. Signed-off-by: Stefan Schake --- drivers/gpu/drm/vc4/vc4_plane.c | 14 +- drivers/gpu/drm