Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Andy Shevchenko
On Wed, Feb 02, 2022 at 12:54:32PM +0100, Javier Martinez Canillas wrote: > On 2/2/22 12:50, Andy Shevchenko wrote: > >> What's your suggestion then to solve the issue mentioned above ? With my > >> distro > >> maintainer hat I don't care that much, since the fbdev drivers will be > >> disabled.

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
On 2/2/22 12:50, Andy Shevchenko wrote: [snip] >> What's your suggestion then to solve the issue mentioned above ? With my >> distro >> maintainer hat I don't care that much, since the fbdev drivers will be >> disabled. > > I think both of them can work together. If user doesn't care, the

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Andy Shevchenko
On Wed, Feb 02, 2022 at 12:39:29PM +0100, Javier Martinez Canillas wrote: > On 2/2/22 12:06, Andy Shevchenko wrote: > > On Wed, Feb 02, 2022 at 09:38:51AM +0100, Javier Martinez Canillas wrote: > >> On 2/1/22 21:40, Sam Ravnborg wrote: > > And how will distros choose "the right" option in this

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
Hello Andy, On 2/2/22 12:06, Andy Shevchenko wrote: > On Wed, Feb 02, 2022 at 09:38:51AM +0100, Javier Martinez Canillas wrote: >> On 2/1/22 21:40, Sam Ravnborg wrote: > > ... > >> Peter Robinson suggested to >> make the driver mutually exclusive and add !FB_SSD1307 in the config symbol. > >

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Andy Shevchenko
On Wed, Feb 02, 2022 at 09:38:51AM +0100, Javier Martinez Canillas wrote: > On 2/1/22 21:40, Sam Ravnborg wrote: ... > Peter Robinson suggested to > make the driver mutually exclusive and add !FB_SSD1307 in the config symbol. And how will distros choose "the right" option in this case? What to

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Geert Uytterhoeven
Hi Pekka, On Wed, Feb 2, 2022 at 10:20 AM Pekka Paalanen wrote: > On Tue, 1 Feb 2022 12:07:07 +0100 > Geert Uytterhoeven wrote: > > On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > > > On Tue, 1 Feb 2022 10:49:03 +0100 > > > Javier Martinez Canillas wrote: > > > > On 2/1/22 09:38,

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Pekka Paalanen
On Tue, 1 Feb 2022 12:07:07 +0100 Geert Uytterhoeven wrote: > Hi Pekka, > > On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > > On Tue, 1 Feb 2022 10:49:03 +0100 > > Javier Martinez Canillas wrote: > > > On 2/1/22 09:38, Daniel Vetter wrote: > > > > On Tue, Feb 1, 2022 at 9:34 AM

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-02 Thread Javier Martinez Canillas
Hello Sam, On 2/1/22 21:40, Sam Ravnborg wrote: [snip] > > I took a look at the datasheets - and all ssd1305, ssd1306 and ssd1307 > are the same. They have timing constrains on the Vcc. > The random schematic I found on the net showed me that a PWM was used to > control the Vcc voltage - which

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Sam Ravnborg
Hi Javier, On Tue, Feb 01, 2022 at 04:03:30PM +0100, Javier Martinez Canillas wrote: > Hello Geert, > > On 2/1/22 15:14, Geert Uytterhoeven wrote: > > Hi Javier, > > > > On Tue, Feb 1, 2022 at 2:09 PM Javier Martinez Canillas > > wrote: > >> On 2/1/22 12:38, Geert Uytterhoeven wrote: >

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 15:14, Geert Uytterhoeven wrote: > Hi Javier, > > On Tue, Feb 1, 2022 at 2:09 PM Javier Martinez Canillas > wrote: >> On 2/1/22 12:38, Geert Uytterhoeven wrote: Since the current binding has a compatible "ssd1305fb-i2c", we could make the new one

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 2:09 PM Javier Martinez Canillas wrote: > On 2/1/22 12:38, Geert Uytterhoeven wrote: > >> Since the current binding has a compatible "ssd1305fb-i2c", we could make > >> the > >> new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". > > > > DT describes

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 12:38, Geert Uytterhoeven wrote: [snip] >> >> Since the current binding has a compatible "ssd1305fb-i2c", we could make the >> new one "ssd1305drm-i2c" or better, just "ssd1305-i2c". > > DT describes hardware, not software policy. > If the hardware is the same, the DT

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Tue, Feb 1, 2022 at 12:31 PM Javier Martinez Canillas wrote: > On 2/1/22 10:37, Andy Shevchenko wrote: > > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > > > ... > > > >>> Patch #3

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 10:37, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: >> On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > > ... > >>> Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x >>> (which would be more

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Pekka, On Tue, Feb 1, 2022 at 11:42 AM Pekka Paalanen wrote: > On Tue, 1 Feb 2022 10:49:03 +0100 > Javier Martinez Canillas wrote: > > On 2/1/22 09:38, Daniel Vetter wrote: > > > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > > >> On Tuesday, February 1st, 2022 at 09:26, Geert

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Pekka Paalanen
On Tue, 1 Feb 2022 10:49:03 +0100 Javier Martinez Canillas wrote: > On 2/1/22 09:38, Daniel Vetter wrote: > > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > >> > >> On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > >> wrote: > >> > >>> What's the story with the Rn formats?

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
Hello Geert, On 2/1/22 09:43, Geert Uytterhoeven wrote: > Hi Javier, > > On Mon, Jan 31, 2022 at 9:12 PM Javier Martinez Canillas > wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. >

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 11:11 schrieb Simon Ser: On Tuesday, February 1st, 2022 at 11:08, Thomas Zimmermann wrote: Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: I'd expect 8-bit grayscale to be Y8 instead. I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, we could add

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 11:08, Thomas Zimmermann wrote: > Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: > > > I'd expect 8-bit grayscale to be Y8 instead. > > I like this naming, but DRM_FORMAT_R8 is uapi already. :/ If anything, > we could add Yn formats in addition to existing Rn

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Thomas Zimmermann
Hi Am 01.02.22 um 09:36 schrieb Geert Uytterhoeven: Hi Simon, On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven wrote: What's the story with the Rn formats? The comments say "n bpp Red", while this is a monochrome (even inverted)

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Javier Martinez Canillas
On 2/1/22 09:38, Daniel Vetter wrote: > On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: >> >> On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven >> wrote: >> >>> What's the story with the Rn formats? >>> >>> The comments say "n bpp Red", while this is a monochrome (even >>> inverted)

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Andy Shevchenko
On Mon, Jan 31, 2022 at 09:56:23PM +0100, Sam Ravnborg wrote: > On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: ... > > Patch #3 adds the driver. The name ssd1307 was used instead of ssd130x > > (which would be more accurate) to avoid confusion for users who want to > >

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 09:43, Geert Uytterhoeven wrote: > Does there exist another simple test program for showing something > using the DRM API? If you're fine with going low-level, there's tentative [1] which can apply an arbitrary KMS state. See for instance [2] for basic

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Javier, On Mon, Jan 31, 2022 at 9:12 PM Javier Martinez Canillas wrote: > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. Thanks for your series! I'll give it a try on an Adafruit

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Daniel Vetter
On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > > On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > wrote: > > > What's the story with the Rn formats? > > > > The comments say "n bpp Red", while this is a monochrome (even > > inverted) display? > > I don't think the color matters

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
Hi Simon, On Tue, Feb 1, 2022 at 9:34 AM Simon Ser wrote: > On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven > wrote: > > What's the story with the Rn formats? > > > > The comments say "n bpp Red", while this is a monochrome (even > > inverted) display? > > I don't think the color

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Simon Ser
On Tuesday, February 1st, 2022 at 09:26, Geert Uytterhoeven wrote: > What's the story with the Rn formats? > > The comments say "n bpp Red", while this is a monochrome (even > inverted) display? I don't think the color matters that much. "Red" was picked just because it was an arbitrary color,

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-01 Thread Geert Uytterhoeven
On Mon, Jan 31, 2022 at 9:39 PM Simon Ser wrote: > On Monday, January 31st, 2022 at 21:36, Simon Ser wrote: > > > This driver only advertises XRGB in ssd1307_formats. It would be nice to > > expose R8 as well so that user-space can directly produce suitable buffers. > > It would also be nice

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-01-31 Thread Javier Martinez Canillas
On 1/31/22 21:56, Sam Ravnborg wrote: > Hi Javier, > On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: >> This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, >> SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. >> >> Using the

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-01-31 Thread Javier Martinez Canillas
Hello Simon, Thanks for your feedback. On 1/31/22 21:39, Simon Ser wrote: > On Monday, January 31st, 2022 at 21:36, Simon Ser wrote: > >> This driver only advertises XRGB in ssd1307_formats. It would be nice to >> expose R8 as well so that user-space can directly produce suitable buffers.

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-01-31 Thread Sam Ravnborg
Hi Javier, On Mon, Jan 31, 2022 at 09:12:20PM +0100, Javier Martinez Canillas wrote: > This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, > SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. > > Using the DRM fb emulation, all the tests from Geert

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-01-31 Thread Simon Ser
On Monday, January 31st, 2022 at 21:36, Simon Ser wrote: > This driver only advertises XRGB in ssd1307_formats. It would be nice to > expose R8 as well so that user-space can directly produce suitable buffers. > It would also be nice to have some kind of preferred format, so that >

Re: [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-01-31 Thread Simon Ser
This driver only advertises XRGB in ssd1307_formats. It would be nice to expose R8 as well so that user-space can directly produce suitable buffers. It would also be nice to have some kind of preferred format, so that user-space knows R8 is preferred over XRGB.

[PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-01-31 Thread Javier Martinez Canillas
This patch series adds a DRM driver for the Solomon OLED SSD1305, SSD1306, SSD1307 and SSD1309 displays. It is a port of the ssd1307fb fbdev driver. Using the DRM fb emulation, all the tests from Geert Uytterhoeven's fbtest (https://git.kernel.org/pub/scm/linux/kernel/git/geert/fbtest.git)