From: Dani Liberman <dliber...@habana.ai>

Failure to map is considered a non-trivial error and we need to notify
the user about it.

Signed-off-by: Dani Liberman <dliber...@habana.ai>
Reviewed-by: Oded Gabbay <ogab...@kernel.org>
Signed-off-by: Oded Gabbay <ogab...@kernel.org>
---
 drivers/accel/habanalabs/common/memory.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/accel/habanalabs/common/memory.c 
b/drivers/accel/habanalabs/common/memory.c
index 0b8689fe0b64..3348ad12c237 100644
--- a/drivers/accel/habanalabs/common/memory.c
+++ b/drivers/accel/habanalabs/common/memory.c
@@ -955,8 +955,8 @@ static int map_phys_pg_pack(struct hl_ctx *ctx, u64 vaddr,
                                (i + 1) == phys_pg_pack->npages);
                if (rc) {
                        dev_err(hdev->dev,
-                               "map failed for handle %u, npages: %llu, 
mapped: %llu",
-                               phys_pg_pack->handle, phys_pg_pack->npages,
+                               "map failed (%d) for handle %u, npages: %llu, 
mapped: %llu\n",
+                               rc, phys_pg_pack->handle, phys_pg_pack->npages,
                                mapped_pg_cnt);
                        goto err;
                }
@@ -1186,7 +1186,8 @@ static int map_device_va(struct hl_ctx *ctx, struct 
hl_mem_in *args, u64 *device
 
        rc = map_phys_pg_pack(ctx, ret_vaddr, phys_pg_pack);
        if (rc) {
-               dev_err(hdev->dev, "mapping page pack failed for handle %u\n", 
handle);
+               dev_err(hdev->dev, "mapping page pack failed (%d) for handle 
%u\n",
+                       rc, handle);
                mutex_unlock(&hdev->mmu_lock);
                goto map_err;
        }
-- 
2.34.1

Reply via email to