Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-18 Thread Lee Jones
On Wed, 18 Dec 2019, Jani Nikula wrote: > On Tue, 17 Dec 2019, Lee Jones wrote: > > Hans was making the case that this was impractical for DRM, due to the > > amount of churn you guys receive, hence the discussion. I'm very > > pleased that this is not the case. > > Heh, well, it is the case,

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Lee Jones wrote: > Hans was making the case that this was impractical for DRM, due to the > amount of churn you guys receive, hence the discussion. I'm very > pleased that this is not the case. Heh, well, it is the case, but the point is that should be our problem, not

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Lee Jones
On Tue, 17 Dec 2019, Jani Nikula wrote: > On Tue, 17 Dec 2019, Lee Jones wrote: > > On Mon, 16 Dec 2019, Hans de Goede wrote: > > > >> Hi, > >> > >> Doing immutable branches assumes that there is a base point, > >> e.g. 5.5-rc1 where the immutable branch can then be based on and > >> that the

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Jani Nikula
On Tue, 17 Dec 2019, Lee Jones wrote: > On Mon, 16 Dec 2019, Hans de Goede wrote: > >> Hi, >> >> Doing immutable branches assumes that there is a base point, >> e.g. 5.5-rc1 where the immutable branch can then be based on and >> that the branch can then be merged without issues into both

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-17 Thread Lee Jones
On Mon, 16 Dec 2019, Hans de Goede wrote: > Hi, > > On 16-12-2019 10:30, Lee Jones wrote: > > [...] > > > > > > > > > > > > > Which use a Crystal Cove PMIC, yet the LCD is connected > > > > > > > > > > > to the SoC/LPSS > > > > > > > > > > > PWM controller (and the VBT correctly indicates

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-16 Thread Hans de Goede
Hi, On 16-12-2019 10:30, Lee Jones wrote: [...] Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS PWM controller (and the VBT correctly indicates this), so here our old heuristics fail. Since only the i915 driver has access to the VBT, this commit renames the

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-16 Thread Lee Jones
[...] > > > > > > > > > Which use a Crystal Cove PMIC, yet the LCD is connected to > > > > > > > > > the SoC/LPSS > > > > > > > > > PWM controller (and the VBT correctly indicates this), so > > > > > > > > > here our old > > > > > > > > > heuristics fail. > > > > > > > > > > > > > > > > > >

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-13 Thread Hans de Goede
Hi, On 13-12-2019 09:27, Lee Jones wrote: On Thu, 12 Dec 2019, Hans de Goede wrote: Hi, On 12-12-2019 16:52, Lee Jones wrote: On Thu, 12 Dec 2019, Hans de Goede wrote: Hi, On 12-12-2019 09:45, Lee Jones wrote: On Wed, 11 Dec 2019, Hans de Goede wrote: Hi Lee, On 10-12-2019 09:51, Lee

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-13 Thread Lee Jones
On Thu, 12 Dec 2019, Hans de Goede wrote: > Hi, > > On 12-12-2019 16:52, Lee Jones wrote: > > On Thu, 12 Dec 2019, Hans de Goede wrote: > > > > > Hi, > > > > > > On 12-12-2019 09:45, Lee Jones wrote: > > > > On Wed, 11 Dec 2019, Hans de Goede wrote: > > > > > > > > > Hi Lee, > > > > > > > >

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-12 Thread Hans de Goede
Hi, On 12-12-2019 16:52, Lee Jones wrote: On Thu, 12 Dec 2019, Hans de Goede wrote: Hi, On 12-12-2019 09:45, Lee Jones wrote: On Wed, 11 Dec 2019, Hans de Goede wrote: Hi Lee, On 10-12-2019 09:51, Lee Jones wrote: On Tue, 19 Nov 2019, Hans de Goede wrote: At least Bay Trail (BYT) and

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-12 Thread Lee Jones
On Thu, 12 Dec 2019, Hans de Goede wrote: > Hi, > > On 12-12-2019 09:45, Lee Jones wrote: > > On Wed, 11 Dec 2019, Hans de Goede wrote: > > > > > Hi Lee, > > > > > > On 10-12-2019 09:51, Lee Jones wrote: > > > > On Tue, 19 Nov 2019, Hans de Goede wrote: > > > > > > > > > At least Bay Trail

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-12 Thread Hans de Goede
Hi, On 12-12-2019 09:45, Lee Jones wrote: On Wed, 11 Dec 2019, Hans de Goede wrote: Hi Lee, On 10-12-2019 09:51, Lee Jones wrote: On Tue, 19 Nov 2019, Hans de Goede wrote: At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-12 Thread Lee Jones
On Wed, 11 Dec 2019, Hans de Goede wrote: > Hi Lee, > > On 10-12-2019 09:51, Lee Jones wrote: > > On Tue, 19 Nov 2019, Hans de Goede wrote: > > > > > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > > > different PWM controllers for controlling the LCD's backlight

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-11 Thread Hans de Goede
Hi Lee, On 10-12-2019 09:51, Lee Jones wrote: On Tue, 19 Nov 2019, Hans de Goede wrote: At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC or the one

Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-12-10 Thread Lee Jones
On Tue, 19 Nov 2019, Hans de Goede wrote: > At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 > different PWM controllers for controlling the LCD's backlight brightness. > > Either the one integrated into the PMIC or the one integrated into the > SoC (the 1st LPSS PWM

[PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight

2019-11-19 Thread Hans de Goede
At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 different PWM controllers for controlling the LCD's backlight brightness. Either the one integrated into the PMIC or the one integrated into the SoC (the 1st LPSS PWM controller). So far in the LPSS code on BYT we have