From: Dafna Hirschfeld <dhirschf...@habana.ai>

in the out_err flow, combine the two cases of soft-reset since
they have mostly common code. In addition unlock reset_info.lock
after touching reset count.

Signed-off-by: Dafna Hirschfeld <dhirschf...@habana.ai>
Reviewed-by: Oded Gabbay <ogab...@kernel.org>
Signed-off-by: Oded Gabbay <ogab...@kernel.org>
---
 drivers/accel/habanalabs/common/device.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/accel/habanalabs/common/device.c 
b/drivers/accel/habanalabs/common/device.c
index 47ed2fec68bc..8e71793c6ad1 100644
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -1852,17 +1852,16 @@ int hl_device_reset(struct hl_device *hdev, u32 flags)
                        "%s Failed to reset! Device is NOT usable\n",
                        dev_name(&(hdev)->pdev->dev));
                hdev->reset_info.hard_reset_cnt++;
-       } else if (reset_upon_device_release) {
-               spin_unlock(&hdev->reset_info.lock);
-               dev_err(hdev->dev, "Failed to reset device after user 
release\n");
-               flags |= HL_DRV_RESET_HARD;
-               flags &= ~HL_DRV_RESET_DEV_RELEASE;
-               hard_reset = true;
-               goto escalate_reset_flow;
        } else {
+               if (reset_upon_device_release) {
+                       dev_err(hdev->dev, "Failed to reset device after user 
release\n");
+                       flags &= ~HL_DRV_RESET_DEV_RELEASE;
+               } else {
+                       dev_err(hdev->dev, "Failed to do compute reset\n");
+                       hdev->reset_info.compute_reset_cnt++;
+               }
+
                spin_unlock(&hdev->reset_info.lock);
-               dev_err(hdev->dev, "Failed to do compute reset\n");
-               hdev->reset_info.compute_reset_cnt++;
                flags |= HL_DRV_RESET_HARD;
                hard_reset = true;
                goto escalate_reset_flow;
-- 
2.25.1

Reply via email to