Re: [PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-10 Thread Liu Ying
Hi Guido, On Thu, 2020-12-10 at 08:14 +0100, Guido Günther wrote: > Hi, > On Tue, Dec 08, 2020 at 06:03:05PM +0800, Liu Ying wrote: > > On Tue, 2020-12-08 at 10:24 +0100, Guido Günther wrote: > > > Hi Liu, > > > some minor comments inline: > > > > > > On Fri, Dec 04, 2020 at 03:33:44PM +0800,

Re: [PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-09 Thread Guido Günther
Hi, On Tue, Dec 08, 2020 at 06:03:05PM +0800, Liu Ying wrote: > On Tue, 2020-12-08 at 10:24 +0100, Guido Günther wrote: > > Hi Liu, > > some minor comments inline: > > > > On Fri, Dec 04, 2020 at 03:33:44PM +0800, Liu Ying wrote: > > > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which

Re: [PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-09 Thread Liu Ying
On Tue, 2020-12-08 at 10:24 +0100, Guido Günther wrote: > Hi Liu, > some minor comments inline: > > On Fri, Dec 04, 2020 at 03:33:44PM +0800, Liu Ying wrote: > > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports > > either a MIPI DSI display or a LVDS display. The PHY mode is

Re: [PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-08 Thread Guido Günther
Hi Liu, some minor comments inline: On Fri, Dec 04, 2020 at 03:33:44PM +0800, Liu Ying wrote: > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports > either a MIPI DSI display or a LVDS display. The PHY mode is controlled > by SCU firmware and the driver would call a SCU

[PATCH 4/4] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2020-12-04 Thread Liu Ying
i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports either a MIPI DSI display or a LVDS display. The PHY mode is controlled by SCU firmware and the driver would call a SCU firmware function to configure the PHY mode. The single LVDS PHY has 4 data lanes to support a LVDS