From: Tomer Tayar <tta...@habana.ai>

When the DRAM region size in the BAR is not a power of 2, calculating
the corresponding BAR base address should be done using the offset from
the DRAM start address, and not using directly the DRAM address.

Signed-off-by: Tomer Tayar <tta...@habana.ai>
Reviewed-by: Oded Gabbay <ogab...@kernel.org>
Signed-off-by: Oded Gabbay <ogab...@kernel.org>
---
 drivers/accel/habanalabs/common/device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/accel/habanalabs/common/device.c 
b/drivers/accel/habanalabs/common/device.c
index 514459396818..15891de6cf39 100644
--- a/drivers/accel/habanalabs/common/device.c
+++ b/drivers/accel/habanalabs/common/device.c
@@ -55,7 +55,8 @@ static u64 hl_set_dram_bar(struct hl_device *hdev, u64 addr, 
struct pci_mem_regi
        if (is_power_of_2(prop->dram_pci_bar_size))
                bar_base_addr = addr & ~(prop->dram_pci_bar_size - 0x1ull);
        else
-               bar_base_addr = DIV_ROUND_DOWN_ULL(addr, 
prop->dram_pci_bar_size) *
+               bar_base_addr = region->region_base +
+                               div64_u64((addr - region->region_base), 
prop->dram_pci_bar_size) *
                                prop->dram_pci_bar_size;
 
        old_base = hdev->asic_funcs->set_dram_bar_base(hdev, bar_base_addr);
-- 
2.34.1

Reply via email to