Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
A side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.

Signed-off-by: Sui Jingfeng <sui.jingf...@linux.dev>
---
 drivers/gpu/drm/bridge/simple-bridge.c | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/bridge/simple-bridge.c 
b/drivers/gpu/drm/bridge/simple-bridge.c
index fd7de9b6f80e..e7348ee6daf7 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -8,8 +8,6 @@
 
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
-#include <linux/of.h>
-#include <linux/of_graph.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
 
@@ -164,33 +162,32 @@ static const struct drm_bridge_funcs 
simple_bridge_bridge_funcs = {
 
 static int simple_bridge_probe(struct platform_device *pdev)
 {
+       struct fwnode_handle *fwnode = dev_fwnode(&pdev->dev);
        struct simple_bridge *sbridge;
-       struct device_node *remote;
+       int ret;
 
        sbridge = devm_kzalloc(&pdev->dev, sizeof(*sbridge), GFP_KERNEL);
        if (!sbridge)
                return -ENOMEM;
        platform_set_drvdata(pdev, sbridge);
 
-       sbridge->info = of_device_get_match_data(&pdev->dev);
+       sbridge->info = device_get_match_data(&pdev->dev);
 
        /* Get the next bridge in the pipeline. */
-       remote = of_graph_get_remote_node(pdev->dev.of_node, 1, -1);
-       if (!remote)
-               return -EINVAL;
-
-       sbridge->next_bridge = of_drm_find_bridge(remote);
-       of_node_put(remote);
-
+       sbridge->next_bridge = drm_bridge_find_next_bridge_by_fwnode(fwnode, 1);
        if (!sbridge->next_bridge) {
                dev_dbg(&pdev->dev, "Next bridge not found, deferring probe\n");
                return -EPROBE_DEFER;
+       } else if (IS_ERR(sbridge->next_bridge)) {
+               ret = PTR_ERR(sbridge->next_bridge);
+               dev_err(&pdev->dev, "Error on finding the next bridge: %d\n", 
ret);
+               return ret;
        }
 
        /* Get the regulator and GPIO resources. */
        sbridge->vdd = devm_regulator_get_optional(&pdev->dev, "vdd");
        if (IS_ERR(sbridge->vdd)) {
-               int ret = PTR_ERR(sbridge->vdd);
+               ret = PTR_ERR(sbridge->vdd);
                if (ret == -EPROBE_DEFER)
                        return -EPROBE_DEFER;
                sbridge->vdd = NULL;
-- 
2.34.1

Reply via email to