Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-29 Thread Neil Armstrong
On 08/11/2023 16:58, Laurent Pinchart wrote: On Wed, Nov 08, 2023 at 04:34:39PM +0100, Maxime Ripard wrote: On Tue, Nov 07, 2023 at 04:26:34PM +0100, Greg Kroah-Hartman wrote: On Tue, Nov 07, 2023 at 01:18:14PM +0100, Maxime Ripard wrote: On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg Kroah-Ha

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
>> >> > DSI device lifetime has three different stages: >> >> > 1. before the DSI link being powered up and clocking, >> >> > 2. when the DSI link is in LP state (for the purpose of this question, >> >> > this is the time between the DSI link being powered up and the video >> >> > stream start) >>

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
I'm facing similar issues with the tc358775 bridge. This bridge needs to release its reset while both clock and data lanes are in LP-11 mode. But then it needs to be configured (via I2C) while the clock lane is in enabled (HS mode), but the data lanes are still in LP-11 mode. This is quite an in

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Wed, 29 Nov 2023 at 00:20, Michael Walle wrote: > > [sorry I fat fingered my former reply and converted all CCs to BCCs..] > > >> >> >> > DSI device lifetime has three different stages: > >> >> >> > 1. before the DSI link being powered up and clocking, > >> >> >> > 2. when the DSI link is in LP

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
[sorry I fat fingered my former reply and converted all CCs to BCCs..] >> >> > DSI device lifetime has three different stages: >> >> > 1. before the DSI link being powered up and clocking, >> >> > 2. when the DSI link is in LP state (for the purpose of this question, >> >> > this is the time bet

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 21:50, Michael Walle wrote: > > >> >> > DSI device lifetime has three different stages: > >> >> > 1. before the DSI link being powered up and clocking, > >> >> > 2. when the DSI link is in LP state (for the purpose of this question, > >> >> > this is the time between the DSI

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
>> >> > DSI device lifetime has three different stages: >> >> > 1. before the DSI link being powered up and clocking, >> >> > 2. when the DSI link is in LP state (for the purpose of this question, >> >> > this is the time between the DSI link being powered up and the video >> >> > stream start) >>

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 18:56, Michael Walle wrote: > > >> > DSI device lifetime has three different stages: > >> > 1. before the DSI link being powered up and clocking, > >> > 2. when the DSI link is in LP state (for the purpose of this question, > >> > this is the time between the DSI link being

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
> DSI device lifetime has three different stages: > 1. before the DSI link being powered up and clocking, > 2. when the DSI link is in LP state (for the purpose of this question, > this is the time between the DSI link being powered up and the video > stream start) > 3. when the DSI link is in HS

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Mon, 27 Nov 2023 at 18:07, Michael Walle wrote: > > Hi, > > > DSI device lifetime has three different stages: > > 1. before the DSI link being powered up and clocking, > > 2. when the DSI link is in LP state (for the purpose of this question, > > this is the time between the DSI link being powe

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-27 Thread Michael Walle
Hi, > DSI device lifetime has three different stages: > 1. before the DSI link being powered up and clocking, > 2. when the DSI link is in LP state (for the purpose of this question, > this is the time between the DSI link being powered up and the video > stream start) > 3. when the DSI link is in

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-08 Thread Laurent Pinchart
On Wed, Nov 08, 2023 at 04:34:39PM +0100, Maxime Ripard wrote: > On Tue, Nov 07, 2023 at 04:26:34PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 07, 2023 at 01:18:14PM +0100, Maxime Ripard wrote: > > > On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg Kroah-Hartman wrote: > > > > On Tue, Nov 07, 2

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-08 Thread Maxime Ripard
Hi, Thanks for your answer On Tue, Nov 07, 2023 at 04:26:34PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 01:18:14PM +0100, Maxime Ripard wrote: > > On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Nov 07, 2023 at 11:57:49AM +0100, Maxime Ripard wro

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2023 at 01:18:14PM +0100, Maxime Ripard wrote: > On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 07, 2023 at 11:57:49AM +0100, Maxime Ripard wrote: > > > +GKH > > > > Why? I don't see a question for me here, sorry. > > I guess the question is:

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-07 Thread Maxime Ripard
On Tue, Nov 07, 2023 at 12:22:21PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2023 at 11:57:49AM +0100, Maxime Ripard wrote: > > +GKH > > Why? I don't see a question for me here, sorry. I guess the question is: we have a bus with various power states (powered off, low power, high speed)

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 07, 2023 at 11:57:49AM +0100, Maxime Ripard wrote: > +GKH Why? I don't see a question for me here, sorry. greg k-h

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-07 Thread Maxime Ripard
+GKH On Thu, Oct 26, 2023 at 11:41:34AM +0300, Dmitry Baryshkov wrote: > > > > Also, we would still need to update every single panel driver, which is > > > > going to create a lot of boilerplate that people might get wrong. > > > > > > Yes, quite unfortunately. Another approach that I have in min

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 11:04, Maxime Ripard wrote: > > On Wed, Oct 25, 2023 at 06:16:14PM +0300, Dmitry Baryshkov wrote: > > On 25/10/2023 15:44, Maxime Ripard wrote: > > > On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: > > > > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote:

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-26 Thread Maxime Ripard
On Wed, Oct 25, 2023 at 06:16:14PM +0300, Dmitry Baryshkov wrote: > On 25/10/2023 15:44, Maxime Ripard wrote: > > On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: > > > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > > > > > > > On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dm

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-25 Thread Dmitry Baryshkov
On 25/10/2023 15:44, Maxime Ripard wrote: On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: The MIPI DSI links do not fully fall into the DRM callbacks model.

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-25 Thread Maxime Ripard
On Thu, Oct 19, 2023 at 02:19:51PM +0300, Dmitry Baryshkov wrote: > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > > > On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: > > > The MIPI DSI links do not fully fall into the DRM callbacks model. > > > > Explaining why would hel

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Dmitry Baryshkov
On Mon, 23 Oct 2023 at 11:14, Alexander Stein wrote: > > Am Montag, 23. Oktober 2023, 09:34:42 CEST schrieb Dmitry Baryshkov: > > On Mon, 23 Oct 2023 at 09:52, Alexander Stein > > > > wrote: > > > Hi Dmitry, > > > > > > Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > > > >

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Alexander Stein
Am Montag, 23. Oktober 2023, 09:34:42 CEST schrieb Dmitry Baryshkov: > On Mon, 23 Oct 2023 at 09:52, Alexander Stein > > wrote: > > Hi Dmitry, > > > > Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > > > On Thu, 19 Oct 2023 at 14:42, Alexander Stein > > > > > > wrote: >

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Dmitry Baryshkov
On Mon, 23 Oct 2023 at 10:35, Neil Armstrong wrote: > > On 16/10/2023 18:53, Dmitry Baryshkov wrote: > > The MIPI DSI links do not fully fall into the DRM callbacks model. The > > drm_bridge_funcs abstraction. Instead of having just two states (off and > > on) the DSI hosts have separate LP-11 sta

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Neil Armstrong
On 16/10/2023 18:53, Dmitry Baryshkov wrote: The MIPI DSI links do not fully fall into the DRM callbacks model. The drm_bridge_funcs abstraction. Instead of having just two states (off and on) the DSI hosts have separate LP-11 state. In this state the host is on, but the video stream is not yet e

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-23 Thread Dmitry Baryshkov
On Mon, 23 Oct 2023 at 09:52, Alexander Stein wrote: > > Hi Dmitry, > > Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > > On Thu, 19 Oct 2023 at 14:42, Alexander Stein > > > > wrote: > > > Hi, > > > > > > Am Donnerstag, 19. Oktober 2023, 13:19:51 CEST schrieb Dmitry Barysh

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-22 Thread Alexander Stein
Hi Dmitry, Am Sonntag, 22. Oktober 2023, 12:49:41 CEST schrieb Dmitry Baryshkov: > On Thu, 19 Oct 2023 at 14:42, Alexander Stein > > wrote: > > Hi, > > > > Am Donnerstag, 19. Oktober 2023, 13:19:51 CEST schrieb Dmitry Baryshkov: > > > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > > >

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-22 Thread Dmitry Baryshkov
On Thu, 19 Oct 2023 at 14:42, Alexander Stein wrote: > > Hi, > > Am Donnerstag, 19. Oktober 2023, 13:19:51 CEST schrieb Dmitry Baryshkov: > > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > > On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: > > > > The MIPI DSI links do no

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-19 Thread Alexander Stein
Hi, Am Donnerstag, 19. Oktober 2023, 13:19:51 CEST schrieb Dmitry Baryshkov: > On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: > > > The MIPI DSI links do not fully fall into the DRM callbacks model. > > > > Explaining why

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-19 Thread Dmitry Baryshkov
On Thu, 19 Oct 2023 at 12:26, Maxime Ripard wrote: > > On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: > > The MIPI DSI links do not fully fall into the DRM callbacks model. > > Explaining why would help A kind of explanation comes afterwards, but probably I should change the or

Re: [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-19 Thread Maxime Ripard
On Mon, Oct 16, 2023 at 07:53:48PM +0300, Dmitry Baryshkov wrote: > The MIPI DSI links do not fully fall into the DRM callbacks model. Explaining why would help > The drm_bridge_funcs abstraction. Is there a typo or missing words? > Instead of having just two states (off and on) the DSI hosts h

[RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-10-16 Thread Dmitry Baryshkov
The MIPI DSI links do not fully fall into the DRM callbacks model. The drm_bridge_funcs abstraction. Instead of having just two states (off and on) the DSI hosts have separate LP-11 state. In this state the host is on, but the video stream is not yet enabled. Introduce API that allows DSI bridges