Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread Xaver Hugl
Great, thank you! Am Do., 11. Jan. 2024 um 19:05 Uhr schrieb André Almeida < andrealm...@igalia.com>: > Em 11/01/2024 14:59, Xaver Hugl escreveu: > > Am Do., 11. Jan. 2024 um 18:13 Uhr schrieb Simon Ser > > mailto:cont...@emersion.fr>>: > > > > Are we sure that all drivers handle these two

Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread Xaver Hugl
Am Do., 11. Jan. 2024 um 18:13 Uhr schrieb Simon Ser : > Are we sure that all drivers handle these two props properly with async > page-flips? This is a new codepath not taken by the legacy uAPI. > I've only tested on amdgpu so far. Afacs the other drivers that would need testing / that support

Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread André Almeida
Em 11/01/2024 14:59, Xaver Hugl escreveu: Am Do., 11. Jan. 2024 um 18:13 Uhr schrieb Simon Ser mailto:cont...@emersion.fr>>: Are we sure that all drivers handle these two props properly with async page-flips? This is a new codepath not taken by the legacy uAPI. I've only tested on

Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread Simon Ser
Are we sure that all drivers handle these two props properly with async page-flips? This is a new codepath not taken by the legacy uAPI. Style nit: the indentation is a bit off, the continuation lines don't align with the parenthesis.

Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread André Almeida
Hi Xaver, Em 11/01/2024 13:56, Xaver Hugl escreveu: Like with FB_ID, the driver never has to do bandwidth validation to use these properties, so there's no reason not to allow them. Signed-off-by: Xaver Hugl Reviewed-by: André Almeida --- drivers/gpu/drm/drm_atomic_uapi.c | 4 +++- 1