Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-28 Thread Lee Jones
On Thu, 20 Aug 2020, Daniel Thompson wrote: > On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote: > > On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > > > > > On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > > > > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > >

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread Daniel Thompson
On Thu, Aug 20, 2020 at 08:49:16AM +0100, Lee Jones wrote: > On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > > > On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > > > > > When of_property_read_u32_array() returns

Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread Lee Jones
On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > > > When of_property_read_u32_array() returns an error code, > > > > > > a pairing refcount decrement is needed to

Re: Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread dinghao . liu
> On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > > > When of_property_read_u32_array() returns an error code, > > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > > > Can another

Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread dinghao . liu
> On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > When of_property_read_u32_array() returns an error code, > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > Can another imperative wording be helpful for the change description? > >

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread Markus Elfring
>>> +++ b/drivers/video/backlight/sky81452-backlight.c >>> @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data >>> *sky81452_bl_parse_dt( >>> num_entry); >>> if (ret < 0) { >>> dev_err(dev, "led-sources node is

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread Markus Elfring
> When of_property_read_u32_array() returns an error code, > a pairing refcount decrement is needed to keep np's refcount balanced. Can another imperative wording be helpful for the change description?

Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-20 Thread Lee Jones
On Thu, 20 Aug 2020, dinghao@zju.edu.cn wrote: > > On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > > > When of_property_read_u32_array() returns an error code, > > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > > > Can another imperative wording be

Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-19 Thread Lee Jones
On Wed, 19 Aug 2020, Markus Elfring wrote: > > When of_property_read_u32_array() returns an error code, > > a pairing refcount decrement is needed to keep np's refcount balanced. > > Can another imperative wording be helpful for the change description? >