Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-16 Thread Vasily Khoruzhick via dri-devel
On Thu, Feb 14, 2019 at 12:38 PM Rob Herring wrote: > > On Thu, Feb 14, 2019 at 2:04 PM Vasily Khoruzhick wrote: > > > > On Tue, Feb 5, 2019 at 2:24 AM Thierry Reding > > wrote: > > > > > > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 04, 2019 at 05:22:58PM

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-15 Thread Vasily Khoruzhick via dri-devel
On Tue, Feb 5, 2019 at 8:36 AM Daniel Vetter wrote: > > On Tue, Feb 05, 2019 at 11:24:19AM +0100, Thierry Reding wrote: > > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > > > On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > > > > On Mon, Feb 04, 2019 at 04:59:09P

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-15 Thread Vasily Khoruzhick via dri-devel
On Tue, Feb 5, 2019 at 2:24 AM Thierry Reding wrote: > > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 04, 2019 at 12:22:18P

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-14 Thread Rob Herring via dri-devel
On Thu, Feb 14, 2019 at 2:04 PM Vasily Khoruzhick wrote: > > On Tue, Feb 5, 2019 at 2:24 AM Thierry Reding > wrote: > > > > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > > > On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > > > > On Mon, Feb 04, 2019 at 04:59:0

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Daniel Vetter
On Tue, Feb 05, 2019 at 11:24:19AM +0100, Thierry Reding wrote: > On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 04, 2019 at 1

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Thierry Reding
On Tue, Feb 05, 2019 at 09:57:37AM +0100, Daniel Vetter wrote: > On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > > > On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > > > > On Mon, Feb 04, 2019 at 1

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 05:22:58PM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 04, 2019 at 0

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 12:23 PM Rob Herring wrote: > > simple-panel would probably work if you stuck in some mostly compatible > > string and provided a ddc-i2c-bus property in the device tree node. The > > generic-ish fallback case could be implemented by providing a fallback > > compatible stri

Re: [linux-sunxi] Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 8:39 AM Rob Herring wrote: > > On Mon, Feb 4, 2019 at 10:11 AM Vasily Khoruzhick wrote: > > > > On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding > > wrote: > > > > > > > > Pinebook used several 768p panels that have slightly different timings > > > > and recent batch uses 1

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 8:56 AM Thierry Reding wrote: > > I think it is perfectly fine to have a generic-ish fallback as long as > > it is just that, a fallback. If the panel has quirks, then you'd > > better make sure the firmware is stuffing in the right compatibles or > > that you can update th

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-05 Thread Vasily Khoruzhick
On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding wrote: > > > > Pinebook used several 768p panels that have slightly different timings > > and recent batch uses 1080p panel. > > > > What panel descriptor should I use as fallback? > > You don't use panel descriptors as fallback. The simple-panel driv

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 2:26 PM Vasily Khoruzhick wrote: > > On Mon, Feb 4, 2019 at 12:23 PM Rob Herring wrote: > > > > simple-panel would probably work if you stuck in some mostly compatible > > > string and provided a ddc-i2c-bus property in the device tree node. The > > > generic-ish fallback c

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 10:56 AM Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 10:27:09AM -0600, Rob Herring wrote: > > On Mon, Feb 4, 2019 at 2:24 AM Thierry Reding > > wrote: > > > > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > > On Sun, Feb 3, 2019 at 11:43

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 10:27:09AM -0600, Rob Herring wrote: > On Mon, Feb 4, 2019 at 2:24 AM Thierry Reding > wrote: > > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > > wrote: > > > > > > > > On Sun, Feb 03, 2019

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 10:11 AM Vasily Khoruzhick wrote: > > On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding > wrote: > > > > > > Pinebook used several 768p panels that have slightly different timings > > > and recent batch uses 1080p panel. > > > > > > What panel descriptor should I use as fallb

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Rob Herring
On Mon, Feb 4, 2019 at 2:24 AM Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > wrote: > > > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > > eDP panels usually have

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 08:11:05AM -0800, Vasily Khoruzhick wrote: > On Mon, Feb 4, 2019 at 12:24 AM Thierry Reding > wrote: > > > > > > Pinebook used several 768p panels that have slightly different timings > > > and recent batch uses 1080p panel. > > > > > > What panel descriptor should I use a

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 04:59:09PM +0100, Daniel Vetter wrote: > On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > > > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > > > On Mon, Feb 04, 2019 at 1

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 12:22:18PM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > > On Sun, Feb 3, 2019 a

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 10:40:12AM +0100, Daniel Vetter wrote: > On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > > wrote: > > > > > > > > On Sun, Feb 03,

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 09:23:59AM +0100, Thierry Reding wrote: > On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > > wrote: > > > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > > eDP panels usua

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 12:13:55AM -0800, Vasily Khoruzhick wrote: > On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding > wrote: > > > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > > eDP panels usually have EDID EEPROM, so there's no need to define panel > > > width/height

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-04 Thread Vasily Khoruzhick
On Sun, Feb 3, 2019 at 11:43 PM Thierry Reding wrote: > > On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > > eDP panels usually have EDID EEPROM, so there's no need to define panel > > width/height or any modes/timings in dts. But this panel still may have > > regulator and/or

Re: [PATCH RESEND v2 08/12] dt-bindings: add binding for generic eDP panel

2019-02-03 Thread Thierry Reding
On Sun, Feb 03, 2019 at 10:54:57AM -0800, Vasily Khoruzhick wrote: > eDP panels usually have EDID EEPROM, so there's no need to define panel > width/height or any modes/timings in dts. But this panel still may have > regulator and/or backlight. > > Signed-off-by: Vasily Khoruzhick > --- > .../de