Re: [PATCH v2] of: Add videomode helper

2012-09-25 Thread Laurent Pinchart
Hi Sascha, On Thursday 13 September 2012 13:19:54 Sascha Hauer wrote: On Thu, Sep 13, 2012 at 01:54:07PM +0300, Tomi Valkeinen wrote: On Wed, 2012-07-04 at 09:56 +0200, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be

Re: [PATCH v2] of: Add videomode helper

2012-09-13 Thread Tomi Valkeinen
On Wed, 2012-07-04 at 09:56 +0200, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct fb_videomode. I have more or less the same generic comment for this as for the

Re: [PATCH v2] of: Add videomode helper

2012-09-13 Thread Sascha Hauer
On Thu, Sep 13, 2012 at 01:54:07PM +0300, Tomi Valkeinen wrote: On Wed, 2012-07-04 at 09:56 +0200, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct

Re: [PATCH v2] of: Add videomode helper

2012-08-08 Thread Laurent Pinchart
Hi Sascha, On Friday 03 August 2012 09:38:44 Sascha Hauer wrote: On Thu, Aug 02, 2012 at 01:35:40PM -0600, Stephen Warren wrote: On 07/04/2012 01:56 AM, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted

Re: [PATCH v2] of: Add videomode helper

2012-08-08 Thread Laurent Pinchart
Hi Sascha, Sorry for the late reply. On Thursday 05 July 2012 18:50:29 Sascha Hauer wrote: On Thu, Jul 05, 2012 at 04:08:07PM +0200, Laurent Pinchart wrote: +++ b/Documentation/devicetree/bindings/video/displaymode @@ -0,0 +1,40 @@ +videomode bindings +== +

Re: [PATCH v2] of: Add videomode helper

2012-08-05 Thread Stephen Warren
On 08/03/2012 01:38 AM, Sascha Hauer wrote: Hi Stephen, On Thu, Aug 02, 2012 at 01:35:40PM -0600, Stephen Warren wrote: On 07/04/2012 01:56 AM, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a

Re: [PATCH v2] of: Add videomode helper

2012-08-03 Thread Sascha Hauer
Hi Stephen, On Thu, Aug 02, 2012 at 01:35:40PM -0600, Stephen Warren wrote: On 07/04/2012 01:56 AM, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct

Re: [PATCH v2] of: Add videomode helper

2012-08-02 Thread Stephen Warren
On 07/04/2012 01:56 AM, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct fb_videomode. diff --git a/Documentation/devicetree/bindings/video/displaymode

Re: [PATCH v2] of: Add videomode helper

2012-08-02 Thread Stephen Warren
On 07/05/2012 08:51 AM, Rob Herring wrote: On 07/04/2012 02:56 AM, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct fb_videomode. diff --git

Re: [PATCH v2] of: Add videomode helper

2012-07-11 Thread Guennadi Liakhovetski
Hi Sascha On Wed, 4 Jul 2012, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct fb_videomode. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- changes

Re: [PATCH v2] of: Add videomode helper

2012-07-11 Thread Sascha Hauer
Hi Guennadi, On Wed, Jul 11, 2012 at 10:34:54AM +0200, Guennadi Liakhovetski wrote: Hi Sascha + +Optional properties: + - width-mm, height-mm: Display dimensions in mm + - hsync-active-high (bool): Hsync pulse is active high + - vsync-active-high (bool): Vsync pulse is active high

Re: [PATCH v2] of: Add videomode helper

2012-07-11 Thread Guennadi Liakhovetski
On Wed, 11 Jul 2012, Sascha Hauer wrote: Hi Guennadi, On Wed, Jul 11, 2012 at 10:34:54AM +0200, Guennadi Liakhovetski wrote: Hi Sascha + +Optional properties: + - width-mm, height-mm: Display dimensions in mm + - hsync-active-high (bool): Hsync pulse is active high + -

Re: [PATCH v2] of: Add videomode helper

2012-07-05 Thread Laurent Pinchart
Hi Sascha, Thanks for the patch. On Wednesday 04 July 2012 09:56:35 Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct fb_videomode. Signed-off-by: Sascha Hauer

Re: [PATCH v2] of: Add videomode helper

2012-07-05 Thread Sascha Hauer
On Thu, Jul 05, 2012 at 04:08:07PM +0200, Laurent Pinchart wrote: Hi Sascha, Thanks for the patch. +++ b/Documentation/devicetree/bindings/video/displaymode @@ -0,0 +1,40 @@ +videomode bindings +== + +Required properties: + - xres, yres: Display resolution + -

Re: [PATCH v2] of: Add videomode helper

2012-07-05 Thread Sascha Hauer
On Thu, Jul 05, 2012 at 09:51:39AM -0500, Rob Herring wrote: On 07/04/2012 02:56 AM, Sascha Hauer wrote: + +There are different ways of describing a display mode. The devicetree representation +corresponds to the one used by the Linux Framebuffer framework described here in

Re: [PATCH v2] of: Add videomode helper

2012-07-05 Thread Rob Herring
On 07/04/2012 02:56 AM, Sascha Hauer wrote: This patch adds a helper function for parsing videomodes from the devicetree. The videomode can be either converted to a struct drm_display_mode or a struct fb_videomode. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- changes since v1: