Re: [PATCH 3/7] dt-bindings: display: Document ST7703 panel rotation

2024-02-13 Thread Guido Günther
Hi, On Mon, Feb 12, 2024 at 12:49:46PM -0600, Chris Morgan wrote: > From: Chris Morgan > > Document the rotation property for ST7703 based panels. > > Signed-off-by: Chris Morgan > --- > .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH 05/28] drm: Add support for 3x3 CTM

2024-02-13 Thread Pekka Paalanen
On Tue, 13 Feb 2024 12:18:12 +0530 Uma Shankar wrote: > From: Chaitanya Kumar Borah > > Add support for 3x3 Color Transformation Matrices in Color Pipeline. > > Signed-off-by: Chaitanya Kumar Borah > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ >

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-13 Thread Marius Vlad
On Tue, Feb 13, 2024 at 11:57:59AM +0200, Tomi Valkeinen wrote: > Hi, Hi, > > On 13/02/2024 11:04, Pekka Paalanen wrote: > > On Tue, 13 Feb 2024 10:16:36 +0200 > > Tomi Valkeinen wrote: > > > > > When the driver sets up the zpos property it sets the default zpos value > > > to the HW id of the

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: > > Adjust the encoder format programming in the case of video mode for DP > to accommodate CDM related changes. > > Changes in v2: > - Move timing engine programming to a separate patch from this > one > - Move

[PATCH v2 0/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-02-13 Thread Jani Nikula
Sort of successor to [1], but revamped. BR, Jani. [1] https://patchwork.freedesktop.org/series/129468/ Jani Nikula (6): drm/mst: read sideband messaging cap drm/i915/mst: improve debug logging of DP MST mode detect drm/i915/mst: abstract choosing the MST mode to use drm/i915/mst: use

[PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-13 Thread Jani Nikula
Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST with sideband messaging", or "MST". Modify all call sites to take the new return value into account. v2: - Rename enumerators (Ville) Cc: Arun R Murthy Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[PATCH v2 2/6] drm/i915/mst: improve debug logging of DP MST mode detect

2024-02-13 Thread Jani Nikula
Rename intel_dp_can_mst() to intel_dp_mst_detect(), and move all DP MST detect debug logging there. Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Do this regardless of whether we're actually enabling MST

[PATCH v2 3/6] drm/i915/mst: abstract choosing the MST mode to use

2024-02-13 Thread Jani Nikula
Clarify the conditions for choosing the MST mode to use by adding a new function intel_dp_mst_mode_choose(). This also prepares for being able to extend the MST modes to single-stream sideband messaging. Cc: Arun R Murthy Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[PATCH v2 4/6] drm/i915/mst: use the MST mode detected previously

2024-02-13 Thread Jani Nikula
Drop the duplicate read of DP_MSTM_CAP DPCD register, and the duplicate logic for choosing MST mode, and store the chosen mode in struct intel_dp. Rename intel_dp_configure_mst() to intel_dp_mst_configure() while at it. Cc: Arun R Murthy Cc: Ville Syrjälä Signed-off-by: Jani Nikula ---

[PATCH v2 5/6] drm/i915/mst: add intel_dp_mst_disconnect()

2024-02-13 Thread Jani Nikula
Abstract the MST mode disconnect to a separate function. Cc: Arun R Murthy Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

[PATCH v2 6/6] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-02-13 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, the topology manager should probably only set the sideband messaging related parts of the

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-13 Thread Daniel Stone
Hi, On Tue, 13 Feb 2024 at 10:18, Marius Vlad wrote: > On Tue, Feb 13, 2024 at 11:57:59AM +0200, Tomi Valkeinen wrote: > > I haven't. I'm quite unfamiliar with Weston, and Randolph from TI (cc'd) has > > been working on the Weston side of things. I also don't know if there's > > something TI

Re: [PATCH 3/7] dt-bindings: display: Document ST7703 panel rotation

2024-02-13 Thread Krzysztof Kozlowski
On 12/02/2024 19:49, Chris Morgan wrote: > From: Chris Morgan > > Document the rotation property for ST7703 based panels. > > Signed-off-by: Chris Morgan > --- Acked-by: Krzysztof Kozlowski (with or without empty line removal) Best regards, Krzysztof

Re: [PATCH 6/7] dt-bindings: arm: rockchip: Add Powkiddy RGB10MAX3

2024-02-13 Thread Krzysztof Kozlowski
On 12/02/2024 19:49, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB10MAX3 is a handheld gaming device made by Powkiddy and > powered by the Rockchip RK3566 SoC. > > Signed-off-by: Chris Morgan > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [RFC PATCH net-next v5 07/14] page_pool: devmem support

2024-02-13 Thread Pavel Begunkov
On 12/18/23 02:40, Mina Almasry wrote: Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net

Re: [PATCH 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

2024-02-13 Thread Robin van der Gracht
On Mon, 12 Feb 2024 17:16:35 +0100 Thomas Zimmermann wrote: > The driver sets struct fb_info.bl_dev to the correct backlight > device. Thus rely on the backlight core code to match backlight > and framebuffer devices, and remove the extra check_fb function > from struct backlight_ops. > >

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-13 Thread Ville Syrjälä
On Mon, Feb 12, 2024 at 05:50:36PM +0100, Sebastian Wick wrote: > On Mon, Feb 12, 2024 at 11:10:15AM +0200, Pekka Paalanen wrote: > > On Fri, 9 Feb 2024 17:53:07 +0100 > > Xaver Hugl wrote: > > > > > Signed-off-by: Xaver Hugl > > > --- > > > drivers/gpu/drm/drm_connector.c | 8 > > >

Re: [PATCH drm-misc-next] drm/xe: fix arguments to drm_err_printer()

2024-02-13 Thread Jani Nikula
On Tue, 13 Feb 2024, Thomas Hellström wrote: > On Tue, 2024-02-13 at 10:49 +0200, Jani Nikula wrote: >> The commit below changed drm_err_printer() arguments, but failed to >> update all places. >> >> Reported-by: Stephen Rothwell >> Closes: >>

Re: [PATCH] drm/xe: avoid function cast warnings

2024-02-13 Thread Thomas Hellström
On Tue, 2024-02-13 at 10:56 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang-16 warns about a cast between incompatible function types: > > drivers/gpu/drm/xe/xe_range_fence.c:155:10: error: cast from 'void > (*)(const void *)' to 'void (*)(struct xe_range_fence *)' converts to >

[RFC] drm/i915: Support replaying GPU hangs with captured context image

2024-02-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which prevent replicating all hangs, one step further is being able to replay against a real GPU. This is almost

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Daniel Vetter
On Mon, Feb 12, 2024 at 01:55:34PM -0800, Rob Clark wrote: > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") >

[PATCH] nouveau: fix function cast warnings

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann clang-16 warns about casting between incompatible function types: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadow.c:161:10: error: cast from 'void (*)(const struct firmware *)' to 'void (*)(void *)' converts to incompatible function type

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-13 Thread Tomi Valkeinen
Hi, On 13/02/2024 11:04, Pekka Paalanen wrote: On Tue, 13 Feb 2024 10:16:36 +0200 Tomi Valkeinen wrote: When the driver sets up the zpos property it sets the default zpos value to the HW id of the plane. That is fine as such, but as on many DSS versions the driver arranges the DRM planes in

[PATCH] drm/xe: avoid function cast warnings

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann clang-16 warns about a cast between incompatible function types: drivers/gpu/drm/xe/xe_range_fence.c:155:10: error: cast from 'void (*)(const void *)' to 'void (*)(struct xe_range_fence *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] 155

drm/msm: DisplayPort regressions in 6.8-rc1

2024-02-13 Thread Johan Hovold
Hi, Since 6.8-rc1 the internal eDP display on the Lenovo ThinkPad X13s does not always show up on boot. The logs indicate problems with the runtime PM and eDP rework that went into 6.8-rc1: [6.006236] Console: switching to colour dummy device 80x25 [6.007542]

Re: [RFC PATCH net-next v5 05/14] netdev: netdevice devmem allocator

2024-02-13 Thread Pavel Begunkov
On 12/18/23 02:40, Mina Almasry wrote: Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory

RE: [PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-13 Thread Jani Nikula
On Tue, 13 Feb 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, February 13, 2024 5:01 PM >> To: intel-...@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Nikula, >> Jani >> ; Murthy, Arun R ; Ville

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Mon, 12 Feb 2024 at 23:55, Rob Clark wrote: > > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") > Signed-off-by: Rob

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-13 Thread Pekka Paalanen
On Tue, 13 Feb 2024 10:16:36 +0200 Tomi Valkeinen wrote: > When the driver sets up the zpos property it sets the default zpos value > to the HW id of the plane. That is fine as such, but as on many DSS > versions the driver arranges the DRM planes in a different order than > the HW planes (to

Re: [PATCH drm-misc-next] drm/xe: fix arguments to drm_err_printer()

2024-02-13 Thread Thomas Hellström
On Tue, 2024-02-13 at 10:49 +0200, Jani Nikula wrote: > The commit below changed drm_err_printer() arguments, but failed to > update all places. > > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/r/20240213120410.75c45...@canb.auug.org.au > Fixes: 5e0c04c8c40b ("drm/print:

Re: [PATCH v2 2/3] Subject: [PATCH] drm/mediatek/dp: Add HDCP2.x feature for DisplayPort

2024-02-13 Thread kernel test robot
Hi mac.shen, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on pza/reset/next linus/master v6.8-rc4 next-20240213] [cannot apply to pza/imx-drm/next] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH 17/28] drm/i915: Define segmented Lut and add capabilities to colorop

2024-02-13 Thread Pekka Paalanen
On Tue, 13 Feb 2024 12:18:24 +0530 Uma Shankar wrote: > This defines the lut segments and create the color pipeline > > Signed-off-by: Uma Shankar > Signed-off-by: Chaitanya Kumar Borah > --- > drivers/gpu/drm/i915/display/intel_color.c | 109 + > 1 file changed, 109

Re: [PATCH 00/28] Plane Color Pipeline support for Intel platforms

2024-02-13 Thread Pekka Paalanen
On Tue, 13 Feb 2024 12:18:07 +0530 Uma Shankar wrote: > This series intends to add support for Plane Color Management for > Intel platforms. This is based on the design which has been agreed > upon by the community. Series implementing the design for generic > DRM core has been sent out by Harry

[PATCH] char/agp: remove agp_bridge_data::type

2024-02-13 Thread Jiri Slaby (SUSE)
agp_bridge_data::type is unused (and I cannot find when was used last). Therefore, remove it. Found by https://github.com/jirislaby/clang-struct. Signed-off-by: Jiri Slaby (SUSE) Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/char/agp/agp.h | 1 - 1 file changed, 1

Re: Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-02-13 Thread Maxime Ripard
Hi Devarsh, On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote: > Hi Maxime, > > Thanks a lot for checking on this. > > On 26/01/24 17:45, Maxime Ripard wrote: > > Hi, > > > > Thanks a lot for working on that. > > > > On Tue, Jan 16, 2024 at 07:11:41PM +0530, Devarsh Thakkar

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-13 Thread Pekka Paalanen
On Mon, 12 Feb 2024 17:50:36 +0100 Sebastian Wick wrote: > On Mon, Feb 12, 2024 at 11:10:15AM +0200, Pekka Paalanen wrote: > > On Fri, 9 Feb 2024 17:53:07 +0100 > > Xaver Hugl wrote: > > > > > Signed-off-by: Xaver Hugl > > > --- > > > drivers/gpu/drm/drm_connector.c | 8 > > > 1

Re: [PATCH 1/7] dt-bindings: display: st7703: Add Powkiddy RGB10MAX3 panel

2024-02-13 Thread Krzysztof Kozlowski
On 12/02/2024 19:49, Chris Morgan wrote: > From: Chris Morgan > > The RGB10MAX3 panel is a panel specific to the Powkiddy RGB10MAX3 > handheld device that measures 5 inches diagonally with a resolution > of 720x1280. > > Signed-off-by: Chris Morgan Acked-by: Krzysztof Kozlowski Best

[PATCH 1/2] drm/buddy: Fix alloc_range() error handling code

2024-02-13 Thread Arunpravin Paneer Selvam
Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in some of the corner cases. The right approach would be if

[PATCH 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-13 Thread Arunpravin Paneer Selvam
Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Reviewed-by: Arunpravin Paneer Selvam Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc: Christian König Signed-off-by: Arunpravin Paneer Selvam ---

Re: [PATCH 08/28] drm: Add Color lut range attributes

2024-02-13 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 12:18:15PM +0530, Uma Shankar wrote: > This defines a new structure to define color lut ranges, > along with related macro definitions and enums. This will help > describe segmented lut ranges/PWL LUTs in the hardware. > > Signed-off-by: Uma Shankar > Signed-off-by:

Re: [PATCH 09/28] drm: Add Color ops capability property

2024-02-13 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 12:18:16PM +0530, Uma Shankar wrote: > Add capability property which a colorop can expose it's > hardware's abilities. It's a blob property that can be > filled with respective data structures depending on the > colorop. The user space is expected to read this property >

RE: [PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-13 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, February 13, 2024 5:01 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Nikula, > Jani > ; Murthy, Arun R ; Ville > Syrjälä > Subject: [PATCH v2 1/6] drm/mst: read

Re: [RFC PATCH net-next v5 08/14] memory-provider: dmabuf devmem memory provider

2024-02-13 Thread Pavel Begunkov
On 12/18/23 02:40, Mina Almasry wrote: Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The

[PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann Some of the debugfs functions are stubbed out in these configurations, so trying to build the .c file with the definition fails: In file included from include/uapi/linux/posix_types.h:5, from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27:

[PATCH v2 2/8] staging/fbtft: Include

2024-02-13 Thread Thomas Zimmermann
Resolved the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann --- drivers/staging/fbtft/fb_ssd1351.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c index

[PATCH v2 3/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct backlight_device and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index

[PATCH v2 4/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct inode and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 7380d959c5d53..f269ba5202809 100644

[PATCH v2 5/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct notifier_block and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index

[PATCH v2 6/8] fbdev: Do not include in header

2024-02-13 Thread Thomas Zimmermann
Forward declare struct page and remove the include statement. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index 90f348f14a490..42155898374b1 100644

[PATCH v2 0/8] fbdev: Clean up include dependencies in header

2024-02-13 Thread Thomas Zimmermann
Remove unnecessary dependencies in the include statements of the header file . Several files throughout the kernel include the fbdev header, so reducing dependencies positively affects other subsystems as well. Also fix up nouveau and fbtft, which need backlight.h in some their source files. v2:

[PATCH v2 1/8] drm/nouveau: Include

2024-02-13 Thread Thomas Zimmermann
Resolved the proxy include via , which does not require the backlight header. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c

Re: [PATCH 2/7] drm/panel: st7703: Add Powkiddy RGB10MAX3 Panel Support

2024-02-13 Thread Guido Günther
Hi, On Mon, Feb 12, 2024 at 12:49:45PM -0600, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB10MAX3 is a handheld device with a 5 inch 720x1280 > display panel with a Sitronix ST7703 display controller. The panel > is installed rotated 270 degrees. > > Signed-off-by: Chris Morgan

Re: [PATCH 1/7] dt-bindings: display: st7703: Add Powkiddy RGB10MAX3 panel

2024-02-13 Thread Guido Günther
Hi, On Mon, Feb 12, 2024 at 12:49:44PM -0600, Chris Morgan wrote: > From: Chris Morgan > > The RGB10MAX3 panel is a panel specific to the Powkiddy RGB10MAX3 > handheld device that measures 5 inches diagonally with a resolution > of 720x1280. > > Signed-off-by: Chris Morgan > --- >

[PATCH v2 8/8] fbdev: Clean up include statements in header file

2024-02-13 Thread Thomas Zimmermann
Include mutex.h, printk.h and types.h, remove several unnecessary include statements, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 7/8] fbdev: Clean up forward declarations in header file

2024-02-13 Thread Thomas Zimmermann
Add forward declarations for struct i2c_adapter and struct module, and sort the list alphabetically. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- include/linux/fb.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/linux/fb.h

[PATCH drm-misc-next] drm/xe: fix arguments to drm_err_printer()

2024-02-13 Thread Jani Nikula
The commit below changed drm_err_printer() arguments, but failed to update all places. Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/r/20240213120410.75c45...@canb.auug.org.au Fixes: 5e0c04c8c40b ("drm/print: make drm_err_printer() device specific by using drm_err()") Cc: Luca

Re: [PATCH 4/7] drm/panel: st7703: Add Panel Rotation Support

2024-02-13 Thread Guido Günther
Hi, On Mon, Feb 12, 2024 at 12:49:47PM -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for panel rotation to ST7703 based devices. > > Signed-off-by: Chris Morgan > --- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 + > 1 file changed, 13 insertions(+) > >

[PATCH 1/2] drm/tidss: Fix initial plane zpos values

2024-02-13 Thread Tomi Valkeinen
When the driver sets up the zpos property it sets the default zpos value to the HW id of the plane. That is fine as such, but as on many DSS versions the driver arranges the DRM planes in a different order than the HW planes (to keep the non-scalable planes first), this leads to odd initial zpos

[PATCH 2/2] drm/tidss: Fix sync-lost issue with two displays

2024-02-13 Thread Tomi Valkeinen
A sync lost issue can be observed with two displays, when moving a plane from one disabled display to an another disabled display, and then enabling the display to which the plane was moved to. The exact requirements for this to trigger are not clear. It looks like the issue is that the layers

[PATCH 0/2] drm/tidss: Fixes for zpos and multi-display

2024-02-13 Thread Tomi Valkeinen
drivers/gpu/drm/tidss/tidss_crtc.c | 10 ++ drivers/gpu/drm/tidss/tidss_plane.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) --- base-commit: 423af970da74db7eed1b14f2b7f115714a67aeb8 change-id: 20240213-tidss-fixes-cc3741cd604c Best regards, -- Tomi Valkeinen

Re: Re: Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-13 Thread Ville Syrjälä
On Mon, Feb 12, 2024 at 05:53:48PM +0100, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 05:49:33PM +0200, Ville Syrjälä wrote: > > On Mon, Feb 12, 2024 at 11:01:07AM +0100, Maxime Ripard wrote: > > > On Fri, Feb 09, 2024 at 09:34:35PM +0100, Sebastian Wick wrote: > > > > On Mon, Feb 05, 2024 at

[PATCH] drm: ci: use clk_ignore_unused for apq8016

2024-02-13 Thread Dmitry Baryshkov
If the ADV7511 bridge driver is compiled as a module, while DRM_MSM is built-in, the clk_disable_unused congests with the runtime PM handling of the DSI PHY for the clk_prepare_lock(). This causes apq8016 runner to fail without completing any jobs ([1]). Drop the BM_CMDLINE which duplicate the

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-13 Thread Souza, Jose
On Fri, 2024-02-09 at 09:06 +, Tvrtko Ursulin wrote: > On 08/02/2024 17:55, Souza, Jose wrote: > > On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: > > > On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > > > > On 08/02/2024 14:30, Souza, Jose wrote: > > > > > On Thu,

Re: [PATCH i-g-t v3] benchmarks: Add VKMS benchmark

2024-02-13 Thread Arthur Grillo
On 13/02/24 15:06, Kamil Konieczny wrote: > Hi Arthur, > On 2024-02-09 at 16:39:09 -0300, Arthur Grillo wrote: > > I will merge this with different description: > > [PATCH i-g-t v3] benchmarks: Add KMS frambuffer stress benchmark > > Is this ok? Its ok Best Regards, ~Arthur Grillo > >

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 23:10, Abhinav Kumar wrote: > > > > On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: > > On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: > >>> On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar > >>>

Re: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work

2024-02-13 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next next-20240213] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc4] [If your patch is applied

Re: (subset) [PATCH 0/7] Add Support for RK3566 Powkiddy RGB10MAX3

2024-02-13 Thread Heiko Stuebner
On Mon, 12 Feb 2024 12:49:43 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RGB10MAX3 handheld gaming console. > > [1] > https://powkiddy.com/products/pre-sale-powkiddy-rgb10max3-handheld-game-console > > Chris Morgan (7): > dt-bindings: display: st7703:

Re: [PATCH 1/2] [v3] nouveau: add command-line GSP-RM registry support

2024-02-13 Thread Timur Tabi
On Tue, 2024-02-13 at 16:43 +0100, Danilo Krummrich wrote: > > +struct registry_list_entry { > > + struct list_head list; > > Nit: 'head' or 'entry' might be more suitable. Will fix in v4. > > > + size_t name_len; > > + u32 type; > > I prefer to represent type as enum or use a define

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: > > > > On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: > > On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: > >>> On Sat, 10 Feb 2024 at 03:53, Paloma Arellano > >>>

Re: [RFC PATCH net-next v5 07/14] page_pool: devmem support

2024-02-13 Thread Mina Almasry
On Tue, Feb 13, 2024 at 5:28 AM Pavel Begunkov wrote: > > On 12/18/23 02:40, Mina Almasry wrote: > > Convert netmem to be a union of struct page and struct netmem. Overload > > the LSB of struct netmem* to indicate that it's a net_iov, otherwise > > it's a page. > > > > Currently these entries in

Re: (subset) [PATCH 0/7] Add Support for RK3566 Powkiddy RGB10MAX3

2024-02-13 Thread Heiko Stuebner
On Mon, 12 Feb 2024 12:49:43 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RGB10MAX3 handheld gaming console. > > [1] > https://powkiddy.com/products/pre-sale-powkiddy-rgb10max3-handheld-game-console > > Chris Morgan (7): > dt-bindings: display: st7703:

Re: (subset) [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: remove port property

2024-02-13 Thread Heiko Stuebner
On Wed, 31 Jan 2024 22:14:29 +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi ports nodes with both in and output port subnodes. Unfortunately > with the conversion to YAML the old method with only an input port node > was used. Later the new

Re: (subset) [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: remove port property

2024-02-13 Thread Heiko Stuebner
On Wed, 31 Jan 2024 22:14:29 +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi ports nodes with both in and output port subnodes. Unfortunately > with the conversion to YAML the old method with only an input port node > was used. Later the new

Re: [RFC PATCH net-next v5 05/14] netdev: netdevice devmem allocator

2024-02-13 Thread Mina Almasry
On Tue, Feb 13, 2024 at 5:24 AM Pavel Begunkov wrote: > > On 12/18/23 02:40, Mina Almasry wrote: > > Implement netdev devmem allocator. The allocator takes a given struct > > netdev_dmabuf_binding as input and allocates net_iov from that > > binding. > > > > The allocation simply delegates to the

Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-13 Thread Sui Jingfeng
Hi, On 2024/2/13 22:38, Maxime Ripard wrote: On Sat, Feb 10, 2024 at 12:25:33AM +0800, Sui Jingfeng wrote: On 2024/2/9 23:15, Maxime Ripard wrote: On Fri, Feb 09, 2024 at 12:02:48PM +0100, Daniel Vetter wrote: On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: On Wed, Feb 07,

Re: [PATCH] backlight: ktd2801: fix LED dependency

2024-02-13 Thread Daniel Thompson
On Mon, Feb 12, 2024 at 03:31:50PM +0100, Duje Mihanović wrote: > On Monday, February 12, 2024 1:44:28 PM CET Daniel Thompson wrote: > > On Mon, Feb 12, 2024 at 12:18:12PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > The new backlight driver unconditionally selects

[PATCH] drm/msm: Wire up tlb ops

2024-02-13 Thread Rob Clark
From: Rob Clark The brute force iommu_flush_iotlb_all() was good enough for unmap, but in some cases a map operation could require removing a table pte entry to replace with a block entry. This also requires tlb invalidation. Missing this was resulting an obscure iova fault on what should be a

Re: [PATCH 1/2] drm/scheduler: improve GPU scheduler documentation v2

2024-02-13 Thread Danilo Krummrich
Hi Christian, What's the status of this effort? Was there ever a follow-up? - Danilo On 11/16/23 23:23, Danilo Krummrich wrote: Hi Christian, Thanks for sending an update of this patch! On Thu, Nov 16, 2023 at 03:15:46PM +0100, Christian König wrote: Start to improve the scheduler

Re: [PATCH i-g-t v3] benchmarks: Add VKMS benchmark

2024-02-13 Thread Kamil Konieczny
Hi Arthur, On 2024-02-09 at 16:39:09 -0300, Arthur Grillo wrote: I will merge this with different description: [PATCH i-g-t v3] benchmarks: Add KMS frambuffer stress benchmark Is this ok? Regards, Kamil > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate

Re: [PATCH v6 31/36] drm/rockchip: inno_hdmi: Switch to HDMI connector

2024-02-13 Thread Heiko Stuebner
Am Montag, 12. Februar 2024, 14:13:14 CET schrieb Maxime Ripard: > The new HDMI connector infrastructure allows to remove some boilerplate, > especially to generate infoframes. Let's switch to it. > > Signed-off-by: Maxime Ripard Acked-by: Heiko Stuebner > --- >

Re: [PATCH] drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable()

2024-02-13 Thread Heiko Stuebner
On Fri, 19 Jan 2024 11:08:40 -0800, Harshit Mogalapalli wrote: > Unlock before returning on the error path. > > Applied, thanks! [1/1] drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable() commit: b6ddaa63f728d26c12048aed76be99c24f435c41 Best regards, -- Heiko Stuebner

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma

Re: [PATCH 04/10] hid/hid-picolcd: Remove struct backlight_ops.check_fb

2024-02-13 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on lee-backlight/for-backlight-next] [also build test ERROR on lee-backlight/for-backlight-fixes hid/for-next lee-leds/for-leds-next linus/master v6.8-rc4 next-20240213] [If your patch is applied

Re: Build regressions/improvements in v6.8-rc1

2024-02-13 Thread Andreas Larsson
On 2024-01-23 15:21, Arnd Bergmann wrote: >>> + /kisskb/src/arch/sparc/include/asm/floppy_64.h: error: no previous >>> prototype for 'sparc_floppy_irq' [-Werror=missing-prototypes]: => 200:13 >>> + /kisskb/src/arch/sparc/include/asm/floppy_64.h: error: no previous >>> prototype for

Re: [PATCH 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-13 Thread Christian König
Am 13.02.24 um 15:28 schrieb Matthew Auld: On 13/02/2024 13:52, Arunpravin Paneer Selvam wrote: Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Reviewed-by: Arunpravin Paneer Selvam It looks like you

[PATCH v2 2/6] dma-buf/fence-chain: use trace_dma_fence_sync_to

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
To inform tools about the relationship between the fences. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence-chain.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c index

[PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
This new event can be used to trace where a given dma_fence is added as a dependency of some other work. I plan to use it in amdgpu. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence.c | 1 + include/trace/events/dma_fence.h | 34 2

[PATCH v2 3/6] amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
This makes it possible to understand the dependencies between jobs. Possible usage of this trace: * stuttering issues like Mesa !9189 * incorrect synchronization: I don't have a link for this one, but having these events was very useful to debug a virtio-gpu / native-context / radeonsi sync

[PATCH v2 0/6] dma-fence, drm, amdgpu new trace events

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
This series adds new events to make it easier for tools like gpuvis or umr to graph the GPUs, kernel and applications activity. UMR patches using these events can be found here: https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37 V1:

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate CDM related changes. Changes in v2: - Move timing engine programming to a separate patch from

Re: [PATCH] nouveau: offload fence uevents work to workqueue

2024-02-13 Thread Danilo Krummrich
On 2/9/24 19:52, Daniel Vetter wrote: On Fri, Feb 09, 2024 at 06:41:32PM +0100, Danilo Krummrich wrote: On 2/6/24 15:03, Daniel Vetter wrote: On Mon, Feb 05, 2024 at 11:00:04PM +0100, Danilo Krummrich wrote: On 2/5/24 22:08, Dave Airlie wrote: On Tue, 6 Feb 2024 at 02:22, Danilo Krummrich

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: > > > > On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 03:53, Paloma Arellano > > wrote: > >> > >> Adjust the encoder format programming in the case of video mode for DP > >> to accommodate CDM related changes. > >> >

Re: Re: [PATCH drm-misc-next] drm/xe: Fix a missing argument to drm_err_printer

2024-02-13 Thread Maxime Ripard
On Mon, Feb 12, 2024 at 12:53:05PM +0200, Jani Nikula wrote: > On Mon, 12 Feb 2024, Thomas Hellström > wrote: > > The indicated commit below added a device argument to the > > function, but there was a call in the xe driver that was > > not properly changed. > > Aww, crap. Looks like my

Re: Re: [PATCH drm-misc-next] drm/xe: Fix a missing argument to drm_err_printer

2024-02-13 Thread Jani Nikula
On Tue, 13 Feb 2024, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 12:53:05PM +0200, Jani Nikula wrote: >> On Mon, 12 Feb 2024, Thomas Hellström >> wrote: >> > The indicated commit below added a device argument to the >> > function, but there was a call in the xe driver that was >> > not

Re: [PATCH] dt-bindings: use capital "OR" for multiple licenses in SPDX

2024-02-13 Thread Rob Herring
On Thu, 08 Feb 2024 11:53:27 +0100, Krzysztof Kozlowski wrote: > Documentation/process/license-rules.rst and checkpatch expect the SPDX > identifier syntax for multiple licenses to use capital "OR". Correct it > to keep consistent format and avoid copy-paste issues. > > Signed-off-by:

Re: [PATCH 2/2] [v3] drm/nouveau: expose GSP-RM logging buffers via debugfs

2024-02-13 Thread Danilo Krummrich
On 2/12/24 22:15, Timur Tabi wrote: The LOGINIT, LOGINTR, LOGRM, and LOGPMU buffers are circular buffers that have printf-like logs from GSP-RM and PMU encoded in them. LOGINIT, LOGINTR, and LOGRM are allocated by Nouveau and their DMA addresses are passed to GSP-RM during initialization. The

Re: drm/msm: DisplayPort regressions in 6.8-rc1

2024-02-13 Thread Abhinav Kumar
Hi Johan Thanks for the report. I do agree that pm runtime eDP driver got merged that time but I think the issue is either a combination of that along with DRM aux bridge https://patchwork.freedesktop.org/series/122584/ OR just the latter as even that went in around the same time. Thats

[PATCH] drm/imx/dcss: fix resource size calculation

2024-02-13 Thread Dan Carpenter
The resource is inclusive of the ->start and ->end addresses so this calculation is not correct. It should be "res->end - res->start + 1". Use the resource_size() to do the calculation. Fixes: 90393c9b5408 ("drm/imx/dcss: request memory region") Signed-off-by: Dan Carpenter --- >From static

Re: [PATCH 2/2] [v3] drm/nouveau: expose GSP-RM logging buffers via debugfs

2024-02-13 Thread Danilo Krummrich
On 2/13/24 18:10, Timur Tabi wrote: On Tue, 2024-02-13 at 17:57 +0100, Danilo Krummrich wrote: + struct debugfs_blob_wrapper blob_init; + struct debugfs_blob_wrapper blob_intr; + struct debugfs_blob_wrapper blob_rm; + struct debugfs_blob_wrapper blob_pmu; + struct

  1   2   >