Re: [v1 2/2] drm/panel: ili9882t: Avoid blurred screen from fast sleep

2023-10-10 Thread cong yang
Hi, On Wed, Oct 11, 2023 at 3:11 AM Doug Anderson wrote: > > Hi, > > On Tue, Oct 10, 2023 at 4:36 AM cong yang > wrote: > > > > Hi, > > > > On Tue, Oct 10, 2023 at 4:44 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Fri, Oct 6, 2023 at 11:07 PM Cong Yang > > > wrote: > > > > > > > >

Re: [v2 1/3] drm/panel: ili9882t: Break out as separate driver

2023-10-10 Thread cong yang
Hi, On Wed, Oct 11, 2023 at 3:11 AM Doug Anderson wrote: > > Hi, > > On Tue, Oct 10, 2023 at 5:14 AM Cong Yang > wrote: > > > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > > b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > > new file mode 100644 > > index

Re: [PATCH v3] drm/virtio: add new virtio gpu capset definitions

2023-10-10 Thread Huang Rui
On Tue, Oct 10, 2023 at 11:52:14PM +0800, Dmitry Osipenko wrote: > On 10/10/23 18:40, Dmitry Osipenko wrote: > > On 10/10/23 16:57, Huang Rui wrote: > >> These definitions are used fro qemu, and qemu imports this marco in the > >> headers to enable gfxstream, venus, cross domain, and drm (native >

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Andrew Jeffery
On Wed, 11 Oct 2023, at 09:29, Guenter Roeck wrote: > On Tue, Oct 10, 2023 at 08:58:06PM +0200, Wolfram Sang wrote: >> Hi Guenter, >> >> > > > Reference to Andrew's previous proposal: >> > > > https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ >> > > >> > > I do totally agree

Re: linux-next: manual merge of the drm-msm tree with the mm, drm trees

2023-10-10 Thread Rob Clark
Hey Dave, lmk how you want me to handle this to make it easier for you when I send my pull request for 6.7.. I can merge drm-next to take care of *that* conflict (either before I send my PR or push it somewhere where you can see the resolution) but not sure about the mm conflict since pulling

Re: [PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 9:56 PM, Mario Limonciello wrote: > On 10/10/2023 07:59, Shyam Sundar S K wrote: >> PMF Policy binary is a encrypted and signed binary that will be part >> of the BIOS. PMF driver via the ACPI interface checks the existence >> of Smart PC bit. If the advertised bit is found, PMF

Re: [PATCH 1/2] drm/tegra: Return an error code if fails

2023-10-10 Thread Sui Jingfeng
Hi, On 2023/10/10 23:31, Thierry Reding wrote: On Tue, Oct 10, 2023 at 03:22:56PM +0200, Thierry Reding wrote: On Mon, Jun 26, 2023 at 10:33:30PM +0800, Sui Jingfeng wrote: Return -ENOMEM if tegra_bo_mmap() fails. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/tegra/gem.c | 2 ++ 1

Re: [PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 9:33 PM, Mario Limonciello wrote: > On 10/10/2023 07:59, Shyam Sundar S K wrote: >> PMF driver based on the output actions from the TA can request to >> update >> the system states like entering s0i3, lock screen etc. by generating >> an uevent. Based on the udev rules set in the

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Piotr Masłowski
On Wed Oct 11, 2023 at 1:35 AM CEST, Caleb Connolly wrote: > On 10/10/2023 23:53, Piotr Masłowski wrote: > They don't need to be correct, you don't need to complicate it, you just > need a value that plays nice. When it comes down to it you're much more > likely to be constrained by UI layout

[PATCH] drm/edid: fix a possible null pointer dereference

2023-10-10 Thread Ma Ke
In drm_mode_std(), the return value of drm_gtf_mode(), drm_gtf_mode() and drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_gtf_mode(), drm_gtf_mode() and drm_cvt_mode(). Add a check to avoid null point dereference. Signed-off-by: Ma Ke ---

[PATCH] drm/radeon: fix a possible null pointer dereference

2023-10-10 Thread Ma Ke
In radeon_tv_get_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid null point dereference. Signed-off-by: Ma Ke --- drivers/gpu/drm/radeon/radeon_connectors.c | 2 ++ 1 file changed,

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Caleb Connolly
On 10/10/2023 23:53, Piotr Masłowski wrote: > On Tue Oct 10, 2023 at 10:36 PM CEST, Caleb Connolly wrote: > >>> So why am I writing all of this? Well, the problem I see is that any >>> shape-based approach will likely suffer from both accuracy and >>> complexity issues. Describing curves is

[PATCH v4 3/3] usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE

2023-10-10 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Reviewed-by: Heikki Krogerus Acked-by: Greg Kroah-Hartman Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/mux/Kconfig | 2 +-

[PATCH v4 2/3] phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE

2023-10-10 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Acked-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 2 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c |

[PATCH v4 1/3] drm/bridge: add transparent bridge helper

2023-10-10 Thread Dmitry Baryshkov
Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. This is especially useful for DP/USB-C bridge chains, which can span across several devices, but do not require any

[PATCH v4 0/3 RESEND] drm: simplify support for transparent DRM bridges

2023-10-10 Thread Dmitry Baryshkov
[Resending since the discussion with Laurent has died with no response received for more than three weeks] Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). All attempts to implement DP support in a different way resulted either in series of

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Guenter Roeck
On Tue, Oct 10, 2023 at 08:58:06PM +0200, Wolfram Sang wrote: > Hi Guenter, > > > > > Reference to Andrew's previous proposal: > > > > https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ > > > > > > I do totally agree with Guenter's comment[1], though. This just affects > > > a

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Piotr Masłowski
On Tue Oct 10, 2023 at 10:36 PM CEST, Caleb Connolly wrote: >> So why am I writing all of this? Well, the problem I see is that any >> shape-based approach will likely suffer from both accuracy and >> complexity issues. Describing curves is hard and processing them is >> not something that should

Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-10 Thread Luis Chamberlain
On Mon, Oct 02, 2023 at 10:55:17AM +0200, Joel Granados via B4 Relay wrote: > Changes in v2: > - Left the dangling comma in the ctl_table arrays. > - Link to v1: > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com Thanks! Pushed onto

[PATCH 1/3] drm/ci: Add SM8250 job to CI

2023-10-10 Thread Jessica Zhang
Add job for testing the Qualcomm RB5 board to CI. This will allow developers working on MSM chipsets to test their changes on the SM8250 chipset. This board shall be hosted and maintained by Qualcomm. For now, keep the test a manual-run only. We will drop the tag after stabilizing the tests and

[PATCH 3/3] drm/ci: Add skips, fails and flakes for SM8250

2023-10-10 Thread Jessica Zhang
Add skips, fails and flakes for the SM8250 test. Generated using update-xfails.py [1] [1] https://patchwork.freedesktop.org/patch/561453/?series=124793=1 Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/ci/xfails/msm-sm8250-fails.txt | 29

[PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner

2023-10-10 Thread Jessica Zhang
Recently, we've registered a Gitlab runner for a Qualcomm RB5 device that will be hosted and maintained in Qualcomm labs. This series will add a corresponding CI job for testing SM8250 devices and add the skip/fails/flakes list. We were able to complete a successful run [1] with these changes.

[PATCH 2/3] drm/ci: enable CONFIG_INTERCONNECT_QCOM_SM8250 for arm64 config

2023-10-10 Thread Jessica Zhang
Set CONFIG_INTERCONNECT_QCOM_SM8250 needs to =y so that the ASIX AX88179 USB Ethernet driver can be probed in time to set up nfsroot. Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/ci/arm64.config | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v1] drm/tiny: correctly print `struct resource *` on error

2023-10-10 Thread Joey Gouly
The `res` variable is already a `struct resource *`, don't take the address of it. Fixes incorrect output: simple-framebuffer 9e20dc000.framebuffer: [drm] *ERROR* could not acquire memory range [??? 0x4be88a387d00-0xfefffde0a240 flags 0x0]: -16 To be correct:

Re: [PATCH RESEND v2 1/2] drm/print: Add drm_dbg_ratelimited

2023-10-10 Thread Hamza Mahfooz
On 10/10/23 08:15, Andi Shyti wrote: From: Nirmoy Das Add a function for ratelimitted debug print. Signed-off-by: Nirmoy Das Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Reviewed-by: Andrzej Hajda

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Caleb Connolly
On 10/10/2023 21:01, Piotr Masłowski wrote: > Hi Caleb, > > Thanks for posting this. I've been meaning to chime in on the discussion > about notches and co. for months now, so this makes a perfect opportunity > to finally do so. > > On Mon Oct 9, 2023 at 7:32 PM CEST, Caleb Connolly wrote: >

Re: [PATCH v2] drm/panel: Enable DSC and CMD mode for Visionox VTDR6130 panel

2023-10-10 Thread Jessica Zhang
On 10/9/2023 3:32 AM, neil.armstr...@linaro.org wrote: Hi Paloma, On 28/07/2023 03:26, Paloma Arellano wrote: Enable display compression (DSC v1.2) and CMD mode for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. In addition, this patch will set the default to command mode with DSC enabled.

Re: [PATCH RESEND v2 0/2] Add drm_dbg_ratelimited()

2023-10-10 Thread Andi Shyti
Hi John, On Tue, Oct 10, 2023 at 11:25:03AM -0700, John Harrison wrote: > On 10/10/2023 05:15, Andi Shyti wrote: > > Hi, > > > > I might have picked up the wrong series and missed some reviews > > and the extra patch from Nirmoy with a real use of the > > drm_dbg_ratelimited() that John was

please backmerge drm/drm-next into drm-misc/drm-misc-next

2023-10-10 Thread Dmitry Baryshkov
Hello, drm-misc-next is currently stuck at 6.5-rc2. Could you please backmerge drm-next into drm-misc-next to bring it to 6.6-rc2? I was going to apply one of the pending series ([1]), but got conflicts because of the outdated source tree. Thank you. [1]

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-10-10 Thread Dave Airlie
> I think we're then optimizing for different scenarios. Our compute > driver will use mostly external objects only, and if shared, I don't > forsee them bound to many VMs. What saves us currently here is that in > compute mode we only really traverse the extobj list after a preempt > fence wait,

Re: [Intel-gfx] [PATCH 2/2] drm/i915: More use of GT specific print helpers

2023-10-10 Thread Andi Shyti
Hi John, On Mon, Oct 09, 2023 at 12:57:55PM -0700, John Harrison wrote: > On 10/9/2023 12:54, Andi Shyti wrote: > > Hi John, > > > > ... > > > > > --- a/drivers/gpu/drm/i915/i915_driver.c > > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > > @@ -71,6 +71,7 @@ > > > #include "gem/i915_gem_pm.h"

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Piotr Masłowski
Hi Caleb, Thanks for posting this. I've been meaning to chime in on the discussion about notches and co. for months now, so this makes a perfect opportunity to finally do so. On Mon Oct 9, 2023 at 7:32 PM CEST, Caleb Connolly wrote: > Some folks have previously suggested that this information

Re: [PATCH v3 6/6] arm64: dts: qcom: sdm670: add display subsystem

2023-10-10 Thread Konrad Dybcio
On 10/10/23 01:33, Richard Acayan wrote: The Snapdragon 670 has a display subsystem for controlling and outputting to the display. Add support for it in the device tree. Reviewed-by: Dmitry Baryshkov Signed-off-by: Richard Acayan --- [...] + interconnects = <_noc

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Caleb Connolly
On 10/10/2023 17:52, Rob Herring wrote: > On Mon, Oct 09, 2023 at 06:32:50PM +0100, Caleb Connolly wrote: >> Some display panels found in modern phones and laptops feature >> non-standard display shapes with features like rounded corners, notches >> (sections of the display that are cut-out

Re: [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-10-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2023-10-06 15:55:03) > The purpose of this patch series is to incorporate pm runtime framework > into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel > driver during system probe time. During incorporating procedure, original > customized pm realted

Re: [v1 2/2] drm/panel: ili9882t: Avoid blurred screen from fast sleep

2023-10-10 Thread Doug Anderson
Hi, On Tue, Oct 10, 2023 at 4:36 AM cong yang wrote: > > Hi, > > On Tue, Oct 10, 2023 at 4:44 AM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Oct 6, 2023 at 11:07 PM Cong Yang > > wrote: > > > > > > At present, we have found that there may be a problem of blurred > > > screen during fast

Re: [v2 3/3] arm64: defconfig: Enable ILITEK_ILI9882T panel

2023-10-10 Thread Doug Anderson
Hi, On Tue, Oct 10, 2023 at 5:14 AM Cong Yang wrote: > > Enable ILITEK_ILI9882T panel. Could you add a little background? Maybe something like: DRM_PANEL_ILITEK_ILI9882T is being split out from DRM_PANEL_BOE_TV101WUM_NL6. Since the arm64 defconfig had the BOE panel driver enabled, let's also

Re: [v2 2/3] drm/panel: ili9882t: Avoid blurred screen from fast sleep

2023-10-10 Thread Doug Anderson
Hi, On Tue, Oct 10, 2023 at 5:14 AM Cong Yang wrote: > > At present, we have found that there may be a problem of blurred > screen during fast sleep/resume. The direct cause of the blurred > screen is that the IC does not receive 0x28/0x10. Because of the > particularity of the IC, before the

Re: [v2 1/3] drm/panel: ili9882t: Break out as separate driver

2023-10-10 Thread Doug Anderson
Hi, On Tue, Oct 10, 2023 at 5:14 AM Cong Yang wrote: > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > new file mode 100644 > index ..e095ad91c4bc > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c >

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Wolfram Sang
Hi Guenter, > > > Reference to Andrew's previous proposal: > > > https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ > > > > I do totally agree with Guenter's comment[1], though. This just affects > > a few drivers and this patch is way too intrusive for the I2C core. The > >

Re: [PATCH RESEND v2 0/2] Add drm_dbg_ratelimited()

2023-10-10 Thread John Harrison
On 10/10/2023 05:15, Andi Shyti wrote: Hi, I might have picked up the wrong series and missed some reviews and the extra patch from Nirmoy with a real use of the drm_dbg_ratelimited() that John was looking for. Thanks, Andi I just found the original post of this from back in January

Re: [PATCH] drm/amd/pm: Fix a memory leak on an error path

2023-10-10 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 10, 2023 at 2:32 AM Wang, Yang(Kevin) wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Yang Wang > > Best Regards, > Kevin > > -Original Message- > From: Kunwu.Chan > Sent: Tuesday, October 10, 2023 2:11 PM > To: Wang, Yang(Kevin) > Cc:

Re: [PATCH 2/2] backlight: Add Kinetic KTD2801 driver

2023-10-10 Thread kernel test robot
Hi Duje, kernel test robot noticed the following build warnings: [auto build test WARNING on 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa] url: https://github.com/intel-lab-lkp/linux/commits/Duje-Mihanovi/dt-bindings-backlight-add-Kinetic-KTD2801-binding/20231006-025106 base:

[PATCH] drm/atomic: clarify the rules around drm_atomic_state->allow_modeset

2023-10-10 Thread Daniel Vetter
msm is automagically upgrading normal commits to full modesets, and that's a big no-no: - for one this results in full on->off->on transitions on all these crtc, at least if you're using the usual helpers. Which seems to be the case, and is breaking uapi - further even if the ctm change

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-10 Thread Rob Herring
On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: > Add a Device Tree binding schema for the OLED panels based on the Solomon > SSD132x family of controllers. Looks like the same binding as solomon,ssd1307fb.yaml. Why a different binding? Why does that binding need a slew

Re: [PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data

2023-10-10 Thread Heiko Stübner
Am Dienstag, 10. Oktober 2023, 18:54:11 CEST schrieb Heiko Stuebner: > On Mon, 31 Jan 2022 17:47:21 +0100, quentin.sch...@theobroma-systems.com > wrote: > > From: Quentin Schulz > > > > To prepare for a new display to be supported by this driver which has a > > slightly different set of DSI

Re: [PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data

2023-10-10 Thread Heiko Stuebner
On Mon, 31 Jan 2022 17:47:21 +0100, quentin.sch...@theobroma-systems.com wrote: > From: Quentin Schulz > > To prepare for a new display to be supported by this driver which has a > slightly different set of DSI mode related flags, let's move the > currently hardcoded mode flags to the .data

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Rob Herring
On Mon, Oct 09, 2023 at 06:32:50PM +0100, Caleb Connolly wrote: > Some display panels found in modern phones and laptops feature > non-standard display shapes with features like rounded corners, notches > (sections of the display that are cut-out from the edge), and cutouts > (such as circular

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-10 Thread Conor Dooley
Hey, On Mon, Oct 09, 2023 at 08:34:22PM +0200, Javier Martinez Canillas wrote: > Add a Device Tree binding schema for the OLED panels based on the Solomon > SSD132x family of controllers. > > Signed-off-by: Javier Martinez Canillas > --- > > .../bindings/display/solomon,ssd132x.yaml | 116

Re: [PATCH v7 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-10-10 Thread Danilo Krummrich
On 10/10/23 15:37, Sarah Walker wrote: From: Donald Robson Determining the start and range of the unmap stage of a remap op is a common piece of code currently implemented by multiple drivers. Add a helper for this. Changes since v6: - Remove use of __always_inline Signed-off-by: Donald

Re: [RFC PATCH 10/10] drm/vkms: Add enumerated 1D curve colorop

2023-10-10 Thread Melissa Wen
On 09/08, Harry Wentland wrote: > Signed-off-by: Harry Wentland > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Simon Ser > Cc: Harry Wentland > Cc: Melissa Wen > Cc: Jonas Ådahl > Cc: Sebastian Wick > Cc: Shashank Sharma > Cc: Alexander Goins > Cc: Joshua Ashton > Cc: Michel Dänzer >

Re: [PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Mario Limonciello
On 10/10/2023 07:59, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

Re: [RFC PATCH 02/10] drm/colorop: Introduce new drm_colorop mode object

2023-10-10 Thread Melissa Wen
On 09/08, Harry Wentland wrote: > This patches introduces a new drm_colorop mode object. This > object represents color transformations and can be used to > define color pipelines. > > We also introduce the drm_colorop_state here, as well as > various helpers and state tracking bits. > >

Re: [PATCH v4 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-10 Thread Rob Herring
On Tue, Oct 10, 2023 at 02:16:21PM +0200, Flavio Suligoi wrote: > The Monolithic Power (MPS) MP3309C is a WLED step-up converter, featuring a > programmable switching frequency to optimize efficiency. > The brightness can be controlled either by I2C commands (called "analog" > mode) or by a PWM

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-10 Thread Melissa Wen
O 09/08, Harry Wentland wrote: > Signed-off-by: Harry Wentland > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Simon Ser > Cc: Harry Wentland > Cc: Melissa Wen > Cc: Jonas Ådahl > Cc: Sebastian Wick > Cc: Shashank Sharma > Cc: Alexander Goins > Cc: Joshua Ashton > Cc: Michel Dänzer >

Re: [PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Mario Limonciello
On 10/10/2023 07:59, Shyam Sundar S K wrote: PMF driver based on the output actions from the TA can request to update the system states like entering s0i3, lock screen etc. by generating an uevent. Based on the udev rules set in the userspace the event id matching the uevent shall get updated

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Mario Limonciello
On 10/10/2023 07:59, Shyam Sundar S K wrote: Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even

Re: [PATCH v3 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-10 Thread Mario Limonciello
On 10/10/2023 07:59, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. make amd_sfh_float_to_int() as non-static

Re: [PATCH v3] drm/virtio: add new virtio gpu capset definitions

2023-10-10 Thread Dmitry Osipenko
On 10/10/23 18:40, Dmitry Osipenko wrote: > On 10/10/23 16:57, Huang Rui wrote: >> These definitions are used fro qemu, and qemu imports this marco in the >> headers to enable gfxstream, venus, cross domain, and drm (native >> context) for virtio gpu. So it should add them even kernel doesn't use

Re: [RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-10-10 Thread Inki Dae
Hi, 2023년 10월 6일 (금) 오후 10:51, Doug Anderson 님이 작성: > > Hi, > > On Thu, Oct 5, 2023 at 7:20 PM Inki Dae wrote: > > > > Thanks for testing. :) > > > > Acked-by : Inki Dae > > Inki: does that mean you'd like this to go through drm-misc? I'm happy > to do that, but there are no dependencies here

Re: (subset) [PATCH v3 0/5] Support bridge/connector by Tegra HDMI

2023-10-10 Thread Thierry Reding
From: Thierry Reding On Mon, 07 Aug 2023 17:35:10 +0300, Svyatoslav Ryhel wrote: > This patch adds support for the bridge/connector attached to the > HDMI output, allowing to model the hardware properly. It keeps > backwards compatibility with existing bindings and is required > by devices

Re: [PATCH v3] drm/virtio: add new virtio gpu capset definitions

2023-10-10 Thread Dmitry Osipenko
On 10/10/23 16:57, Huang Rui wrote: > These definitions are used fro qemu, and qemu imports this marco in the > headers to enable gfxstream, venus, cross domain, and drm (native > context) for virtio gpu. So it should add them even kernel doesn't use > this. > > Signed-off-by: Huang Rui >

Re: [PATCH -next] drm/tegra: Remove two unused function declarations

2023-10-10 Thread Thierry Reding
On Wed, Aug 09, 2023 at 11:02:26AM +0800, Yue Haibing wrote: > Commit 776dc3840367 ("drm/tegra: Move subdevice infrastructure to host1x") > removed the implementation but not the declaration. > > Signed-off-by: Yue Haibing > --- > drivers/gpu/drm/tegra/drm.h | 3 --- > 1 file changed, 3

Re: [PATCH 1/2] drm/tegra: Return an error code if fails

2023-10-10 Thread Thierry Reding
On Tue, Oct 10, 2023 at 03:22:56PM +0200, Thierry Reding wrote: > On Mon, Jun 26, 2023 at 10:33:30PM +0800, Sui Jingfeng wrote: > > Return -ENOMEM if tegra_bo_mmap() fails. > > > > Signed-off-by: Sui Jingfeng > > --- > > drivers/gpu/drm/tegra/gem.c | 2 ++ > > 1 file changed, 2 insertions(+) >

Re: [PATCH 2/2] drm/tegra: Remove surplus else after return

2023-10-10 Thread Thierry Reding
On Mon, Jun 26, 2023 at 10:33:31PM +0800, Sui Jingfeng wrote: > else is not generally useful after return > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/tegra/gem.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) Applied, thanks. Thierry signature.asc

[PATCH] drm/gpuvm: Dual-licence the drm_gpuvm code GPL-2.0 OR MIT

2023-10-10 Thread Thomas Hellström
Dual-licence in order to make it possible for other non-GPL os'es to re-implement the code. The use of EXPORT_SYMBOL_GPL() is intentionally left untouched to prevent use of drm_gpuvm as a proxy for non-GPL drivers to access GPL-only kernel symbols. Much of the ideas and algorithms used in the

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Ilpo Järvinen
On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > On 10/10/2023 6:38 PM, Ilpo Järvinen wrote: > > On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > > > >> Sometimes policy binary retrieved from the BIOS maybe incorrect that can > >> end up in failing to enable the Smart PC solution feature. > >> > >>

Re: [PATCH RFC] dt-bindings: display: document display panel occlusions

2023-10-10 Thread Guido Günther
Hi Caleb, thanks for putting this out. On Mon, Oct 09, 2023 at 06:32:50PM +0100, Caleb Connolly wrote: > Some display panels found in modern phones and laptops feature > non-standard display shapes with features like rounded corners, notches > (sections of the display that are cut-out from the

[PATCH v3] drm/virtio: add new virtio gpu capset definitions

2023-10-10 Thread Huang Rui
These definitions are used fro qemu, and qemu imports this marco in the headers to enable gfxstream, venus, cross domain, and drm (native context) for virtio gpu. So it should add them even kernel doesn't use this. Signed-off-by: Huang Rui Reviewed-by: Akihiko Odaki --- Changes V1 -> V2: - Add

Re: [PATCH v1 1/3] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages

2023-10-10 Thread Jason Gunthorpe
On Tue, Oct 03, 2023 at 12:44:45AM -0700, Vivek Kasireddy wrote: > +/** > + * pin_user_pages_fd() - pin user pages associated with a file > + * @fd: the fd whose pages are to be pinned > + * @start: starting file offset > + * @nr_pages: number of pages from start to pin > + *

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Guenter Roeck
On Tue, Oct 10, 2023 at 11:31:56AM +0200, Wolfram Sang wrote: > Hi, > > thanks for this series! > > > Reference to Andrew's previous proposal: > > https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ > > I do totally agree with Guenter's comment[1], though. This just affects >

[PATCH v7 10/20] drm/imagination: Add GPU ID parsing and firmware loading

2023-10-10 Thread Sarah Walker
Read the GPU ID register at probe time and select the correct features/quirks/enhancements. Use the GPU ID to form the firmware file name and load the firmware. The features/quirks/enhancements arrays are currently hardcoded in the driver for the supported GPUs. We are looking at moving this

[PATCH v7 17/20] drm/imagination: Implement job submission and scheduling

2023-10-10 Thread Sarah Walker
Implement job submission ioctl. Job scheduling is implemented using drm_sched. Jobs are submitted in a stream format. This is intended to allow the UAPI data format to be independent of the actual FWIF structures in use, which vary depending on the GPU in use. The stream formats are documented

[PATCH v7 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-10-10 Thread Sarah Walker
Add the UAPI implementation for the PowerVR driver. Changes from v6 - Add padding to struct drm_pvr_dev_query_gpu_info - Improve BYPASS_CACHE flag documentation - Add SUBMIT_JOB_FRAG_CMD_DISABLE_PIXELMERGE flag Changes from v4: - Remove CREATE_ZEROED flag for BO creation (all buffers are now

[PATCH v7 15/20] drm/imagination: Implement free list and HWRT create and destroy ioctls

2023-10-10 Thread Sarah Walker
Implement ioctls to create and destroy free lists and HWRT datasets. Free lists are used for GPU-side memory allocation during geometry processing. HWRT datasets are the FW-side structures representing render targets. Changes since v6: - Fix out-of-bounds shift in get_cr_multisamplectl_val()

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 6:38 PM, Ilpo Järvinen wrote: > On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > >> Sometimes policy binary retrieved from the BIOS maybe incorrect that can >> end up in failing to enable the Smart PC solution feature. >> >> Use print_hex_dump_debug() to dump the policy binary in

[PATCH v7 08/20] drm/imagination: Add firmware and MMU related headers

2023-10-10 Thread Sarah Walker
Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker Acked-by: Maxime Ripard --- .../drm/imagination/pvr_rogue_heap_config.h | 113 ++ drivers/gpu/drm/imagination/pvr_rogue_meta.h | 356 ++ drivers/gpu/drm/imagination/pvr_rogue_mips.h | 335

[PATCH v7 14/20] drm/imagination: Implement MIPS firmware processor and MMU support

2023-10-10 Thread Sarah Walker
Add support for the MIPS firmware processor, used in the Series AXE GPU. The MIPS firmware processor uses a separate MMU to the rest of the GPU, so this patch adds support for that as well. Changes since v6: - Fix integer overflow in VM map error path Changes since v5: - Use alloc_page() when

[PATCH v7 05/20] drm/imagination: Add skeleton PowerVR driver

2023-10-10 Thread Sarah Walker
This adds the basic skeleton of the driver. The driver registers itself with DRM on probe. Ioctl handlers are currently implemented as stubs. Changes since v5: - Update compatible string & description to match marketing name - Checkpatch fixes in to/from_pvr_device/file macros Changes since v3:

[PATCH v7 03/20] dt-bindings: gpu: Add Imagination Technologies PowerVR/IMG GPU

2023-10-10 Thread Sarah Walker
Add the device tree binding documentation for the IMG AXE GPU used in TI AM62 SoCs. Co-developed-by: Frank Binns Signed-off-by: Frank Binns Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard Reviewed-by: Linus Walleij Reviewed-by: Conor Dooley --- Changes since v6: - Remove unused gpu

[PATCH v7 06/20] drm/imagination: Get GPU resources

2023-10-10 Thread Sarah Walker
Acquire clock and register resources, and enable/map as appropriate. Changes since v3: - Remove regulator resource (not used on supported platform) - Use devm helpers - Use devm_clk_get_optional() for optional clocks - Don't prepare clocks on resource acquisition - Drop

[PATCH v7 13/20] drm/imagination: Implement firmware infrastructure and META FW support

2023-10-10 Thread Sarah Walker
The infrastructure includes parsing of the firmware image, initialising FW-side structures, handling the kernel and firmware command ringbuffers and starting & stopping the firmware processor. This patch also adds the necessary support code for the META firmware processor. Changes since v6: -

[PATCH v7 12/20] drm/imagination: Implement power management

2023-10-10 Thread Sarah Walker
Add power management to the driver, using runtime pm. The power off sequence depends on firmware commands which are not implemented in this patch. Changes since v5: - Use RUNTIME_PM_OPS() to declare PM callbacks - Add Kconfig dependency on CONFIG_PM Changes since v4: - Suspend runtime PM before

[PATCH v7 18/20] drm/imagination: Add firmware trace header

2023-10-10 Thread Sarah Walker
Changes since v5: - Split up header commit due to size Signed-off-by: Sarah Walker --- .../gpu/drm/imagination/pvr_rogue_fwif_sf.h | 1648 + 1 file changed, 1648 insertions(+) create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_fwif_sf.h diff --git

[PATCH v7 20/20] drm/imagination: Add driver documentation

2023-10-10 Thread Sarah Walker
Add documentation for the UAPI. Changes since v5: - Remove obsolete VM documentation Co-developed-by: Matt Coster Signed-off-by: Matt Coster Co-developed-by: Donald Robson Signed-off-by: Donald Robson Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard --- Documentation/gpu/drivers.rst

[PATCH v7 16/20] drm/imagination: Implement context creation/destruction ioctls

2023-10-10 Thread Sarah Walker
Implement ioctls for the creation and destruction of contexts. Contexts are used for job submission and each is associated with a particular job type. Changes since v5: - Fix context release in final error path in pvr_context_create() Changes since v3: - Use drm_dev_{enter,exit}

[PATCH v7 19/20] drm/imagination: Add firmware trace to debugfs

2023-10-10 Thread Sarah Walker
Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0. Trace is enabled via the group mask at /sys/debug/dri//pvr_params/fw_trace_mask. Changes since v3: - Use drm_dev_{enter,exit} Co-developed-by: Matt Coster Signed-off-by: Matt Coster Signed-off-by: Sarah Walker ---

[PATCH v7 00/20] Imagination Technologies PowerVR DRM driver

2023-10-10 Thread Sarah Walker
This patch series adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver

[PATCH v7 01/20] sizes.h: Add entries between SZ_32G and SZ_64T

2023-10-10 Thread Sarah Walker
From: Matt Coster sizes.h has a gap in defines between SZ_32G and SZ_64T. Add the missing defines so they can be used in drivers. Signed-off-by: Matt Coster Signed-off-by: Sarah Walker Reviewed-by: Linus Walleij --- include/linux/sizes.h | 9 + 1 file changed, 9 insertions(+) diff

[PATCH v7 02/20] drm/gpuvm: Helper to get range of unmap from a remap op.

2023-10-10 Thread Sarah Walker
From: Donald Robson Determining the start and range of the unmap stage of a remap op is a common piece of code currently implemented by multiple drivers. Add a helper for this. Changes since v6: - Remove use of __always_inline Signed-off-by: Donald Robson Signed-off-by: Sarah Walker ---

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 10/10/2023 15:05, Thomas Zimmermann wrote: Hi Am 10.10.23 um 11:33 schrieb Maxime Ripard: [...] We also have discussions about kexec/kdump support. Here we'd need to retrieve the scanout address, forward it to the kexec kernel and put simpledrm onto that framebuffer until the regular driver

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Jocelyn Falempe
On 10/10/2023 14:59, Daniel Vetter wrote: On Tue, Oct 10, 2023 at 02:15:47PM +0200, Maxime Ripard wrote: On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote: On 10/10/23 11:25, Maxime Ripard wrote: On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote: So if I

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 10.10.23 um 14:59 schrieb Daniel Vetter: [...] Why can't we use the model[1] suggested by Daniel using a draw_pixel callback giving drivers full control on how they can put a pixel on the display? I share kind of the same general ideas/conclusions: "qthe idea is that all the fb

Re: [PATCH 1/2] drm/tegra: Return an error code if fails

2023-10-10 Thread Thierry Reding
On Mon, Jun 26, 2023 at 10:33:30PM +0800, Sui Jingfeng wrote: > Return -ENOMEM if tegra_bo_mmap() fails. > > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/tegra/gem.c | 2 ++ > 1 file changed, 2 insertions(+) Sorry, this fell through the cracks. I think it'd be better if tegra_bo_mmap()

Re: [PATCH 1/2] accel/qaic: Add support for periodic timesync

2023-10-10 Thread kernel test robot
Hi Jeffrey, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on next-20231010] [cannot apply to linus/master v6.6-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Ilpo Järvinen
On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > Sometimes policy binary retrieved from the BIOS maybe incorrect that can > end up in failing to enable the Smart PC solution feature. > > Use print_hex_dump_debug() to dump the policy binary in hex, so that we > debug the issues related to the

Re: [PATCH v4 2/4] drm/panic: Add a drm panic handler

2023-10-10 Thread Thomas Zimmermann
Hi Am 10.10.23 um 11:33 schrieb Maxime Ripard: [...] We also have discussions about kexec/kdump support. Here we'd need to retrieve the scanout address, forward it to the kexec kernel and put simpledrm onto that framebuffer until the regular driver takes over. Generically speaking, there's

[PATCH v3 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. make amd_sfh_float_to_int() as non-static function so that this can be called outside of

[PATCH v3 15/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K

[PATCH v3 14/16] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar Current amd_sfh driver has float_to_int() to convert units from float to int. This is fine until this function gets called outside of the current scope of file. Add a prefix "amd_sfh" to float_to_int() so that function represents the driver name. This function will be

  1   2   >