Re: [PATCH v2 1/3] Subject: [PATCH] drm/mediatek/dp: Add tee client application for HDCP feature

2024-02-19 Thread 胡俊光

[PATCH] drm/radeon: Call mmiowb() at the end of radeon_ring_commit()

2024-02-19 Thread Huacai Chen
Commit fb24ea52f78e0d595852e ("drivers: Remove explicit invocations of mmiowb()") remove all mmiowb() in drivers, but it says: "NOTE: mmiowb() has only ever guaranteed ordering in conjunction with spin_unlock(). However, pairing each mmiowb() removal in this patch with the corresponding call to

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-19 Thread Johan Hovold
On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring wrote: > > The two device node references taken during allocation need to be > > dropped when the auxiliary device is freed. > … > > +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c > … > > @@ -74,6 +75,8 @@ struct device

Re: [PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-19 Thread Nautiyal, Ankit K
On 2/16/2024 7:50 PM, Mitul Golani wrote: Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] -

Re: [PATCH 6/6] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-19 Thread Nautiyal, Ankit K
On 2/16/2024 7:50 PM, Mitul Golani wrote: Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4

Re: [PATCH] drm/v3d: Enable V3D to use different PAGE_SIZE

2024-02-19 Thread Iago Toral
El lun, 19-02-2024 a las 10:00 -0300, Maíra Canal escribió: > Hi Iago, > > On 2/19/24 09:56, Iago Toral wrote: > > Hi Maíra, > > > > El mié, 14-02-2024 a las 16:34 -0300, Maíra Canal escribió: > > > Currently, the V3D driver uses PAGE_SHIFT over the assumption > > > that > > > PAGE_SHIFT = 12,

Re: [PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-19 Thread Nautiyal, Ankit K
On 2/16/2024 7:50 PM, Mitul Golani wrote: Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of

Re: [PATCH 4/6] drm/i915/display: Compute and Enable AS SDP

2024-02-19 Thread Nautiyal, Ankit K
On 2/16/2024 7:50 PM, Mitul Golani wrote: Add necessary functions definitions to enable and compute AS SDP data. The new `intel_dp_compute_as_sdp` function computes AS SDP values based on the display configuration, ensuring proper handling of Variable Refresh Rate (VRR). --v2: - Add

Re: [PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-19 Thread Nautiyal, Ankit K
On 2/16/2024 7:50 PM, Mitul Golani wrote: Add the necessary structures and functions to handle reading and unpacking Adaptive Sync Secondary Data Packets. Also add support to write and pack AS SDP. --v2: - Correct use of REG_BIT and REG_GENMASK. [Jani] - Use as_sdp instead of async. [Jani] -

Re: [PATCH v4 0/2] drm: Check polling initialized before

2024-02-19 Thread Shradha Gupta
Gentle reminder to consume this patchset. On Tue, Feb 06, 2024 at 03:07:47PM +0100, Daniel Vetter wrote: > On Thu, Feb 01, 2024 at 10:42:56PM -0800, Shradha Gupta wrote: > > This patchset consists of sanity checks before enabling/disabling > > output polling to make sure we do not call polling

Re: [PATCH 2/6] drm: Add Adaptive Sync SDP logging

2024-02-19 Thread Nautiyal, Ankit K
On 2/16/2024 7:50 PM, Mitul Golani wrote: Add structure representing Adaptive Sync Secondary Data Packet (AS SDP). Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate debugging. --v2: - Update logging. [Jani, Ankit] - use as_sdp instead of async [Ankit] - Correct define

Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

2024-02-19 Thread Lucas De Marchi
On Fri, Feb 09, 2024 at 08:53:25AM -0800, Yury Norov wrote: On Wed, Feb 07, 2024 at 11:45:20PM -0800, Lucas De Marchi wrote: Implement fixed-type BIT() to help drivers add stricter checks, like was done for GENMASK. Signed-off-by: Lucas De Marchi Acked-by: Jani Nikula So I get v1 from

Re: [PATCH v2] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2024-02-19 Thread Dan Carpenter
On Mon, Feb 19, 2024 at 06:59:02PM +0100, Christophe JAILLET wrote: > Le 19/02/2024 à 09:37, Dan Carpenter a écrit : > > On Sun, Feb 18, 2024 at 06:46:44PM +0100, Christophe JAILLET wrote: > > > If 'list_limit' is set to a very high value, 'lsize' computation could > > > overflow if 'head.count'

Re: (subset) [linux][PATCH v6 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-02-19 Thread Dharma.B
Hi Krzysztof, On 12/02/24 3:53 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 08/02/2024 11:43, Lee Jones wrote: >> On Fri, 02 Feb 2024 05:47:33 +0530, Dharma Balasubiramani wrote: >>> Convert the atmel,hlcdc

[PATCH v14 7/7] phy: freescale: Add HDMI PHY driver for i.MX8MQ

2024-02-19 Thread Sandor Yu
Add Cadence HDP-TX HDMI PHY driver for i.MX8MQ. Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. HDMI PHY mode is configurated in the driver. Signed-off-by: Sandor Yu Tested-by: Alexander Stein --- v13->v14: *No change. v12->v13: - Fix build

[PATCH v14 6/7] phy: freescale: Add DisplayPort PHY driver for i.MX8MQ

2024-02-19 Thread Sandor Yu
Add Cadence HDP-TX DisplayPort PHY driver for i.MX8MQ Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. DisplayPort PHY mode is configurated in the driver. Signed-off-by: Sandor Yu --- v12->v14: *No change. v11->v12: - Return error code to

[PATCH v14 5/7] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY

2024-02-19 Thread Sandor Yu
Add bindings for Freescale iMX8MQ DP and HDMI PHY. Signed-off-by: Sandor Yu Reviewed-by: Rob Herring --- v9->v14: *No change. .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml | 53 +++ 1 file changed, 53 insertions(+) create mode 100644

[PATCH v14 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-02-19 Thread Sandor Yu
included respective specific firmware is required. Driver will check display connector type and then load the corresponding driver. Signed-off-by: Sandor Yu Tested-by: Alexander Stein --- v13->v14: - Rebase to next-20240219, replace get_edid function by edid_read function. v12->v13: - Expl

[PATCH v14 3/7] dt-bindings: display: bridge: Add Cadence MHDP8501

2024-02-19 Thread Sandor Yu
Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge. Signed-off-by: Sandor Yu Reviewed-by: Krzysztof Kozlowski --- v9->v14: *No change. .../display/bridge/cdns,mhdp8501.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644

[PATCH v14 2/7] phy: Add HDMI configuration options

2024-02-19 Thread Sandor Yu
Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor Yu Reviewed-by:

[PATCH v14 1/7] drm: bridge: Cadence: Create mhdp helper driver

2024-02-19 Thread Sandor Yu
MHDP8546 mailbox access functions will be share to other mhdp driver and Cadence HDP-TX HDMI/DP PHY drivers. Create a new mhdp helper driver and move all those functions into. cdns_mhdp_reg_write() is renamed to cdns_mhdp_dp_reg_write(), because it use the DPTX command ID DPTX_WRITE_REGISTER.

[PATCH v14 0/7] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2024-02-19 Thread Sandor Yu
options #5: dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY #6: phy: freescale: Add DisplayPort PHY driver for i.MX8MQ #7: phy: freescale: Add HDMI PHY driver for i.MX8MQ v13->v14: Patch #4: - Rebase to next-20240219, replace get_edid function by edid_read function as comm

Re: [PATCH v2 1/3] Subject: [PATCH] drm/mediatek/dp: Add tee client application for HDCP feature

2024-02-19 Thread 胡俊光

[PATCH v2 resend 4/4] video: fbdev: replace of_graph_get_next_endpoint()

2024-02-19 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); +

[PATCH v2 resend 3/4] media: platform: replace of_graph_get_next_endpoint()

2024-02-19 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); +

[PATCH v2 resend 2/4] media: i2c: replace of_graph_get_next_endpoint()

2024-02-19 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); +

[PATCH v2 resend 1/4] gpu: drm: replace of_graph_get_next_endpoint()

2024-02-19 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); +

[PATCH v2 resend 0/4] of: replace of_graph_get_next_endpoint()

2024-02-19 Thread Kuninori Morimoto
Hi Rob This is resend v2 of replace of_graph_get_next_endpoint() We should get rid of or minimize of_graph_get_next_endpoint() in its current form. In general, drivers should be asking for a specific port number because their function is fixed in the binding.

[PATCH 3/4] backlight: lm3630a: Use backlight_get_brightness helper in update_status

2024-02-19 Thread Luca Weiss
As per documentation "drivers are expected to use this function in their update_status() operation to get the brightness value.". With this we can also drop the manual backlight_is_blank() handling since backlight_get_brightness() is already handling this correctly. Signed-off-by: Luca Weiss

[PATCH 1/4] backlight: lm3630a: Initialize backlight_properties on init

2024-02-19 Thread Luca Weiss
The backlight_properties struct should be initialized to zero before using, otherwise there will be some random values in the struct. Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip") Signed-off-by: Luca Weiss --- drivers/video/backlight/lm3630a_bl.c | 1 + 1 file changed,

[PATCH 0/4] Various fixes for the lm3630a backlight driver

2024-02-19 Thread Luca Weiss
29 ++ 2 files changed, 16 insertions(+), 17 deletions(-) --- base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d change-id: 20240219-lm3630a-fixups-8a9359e5a8ce Best regards, -- Luca Weiss

[PATCH 4/4] ARM: dts: qcom: msm8974-hammerhead: Hook up backlight

2024-02-19 Thread Luca Weiss
Connect the panel with the backlight nodes so that the backlight can be turned off when the display is blanked. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 2/4] backlight: lm3630a: Don't set bl->props.brightness in get_brightness

2024-02-19 Thread Luca Weiss
There's no need to set bl->props.brightness, the get_brightness function is just supposed to return the current brightness and not touch the struct. With that done we can also remove the 'goto out' and just return the value. Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip")

Re: [PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 23:37, Konrad Dybcio wrote: > > On 19.02.2024 15:49, Dmitry Baryshkov wrote: > > On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio > > wrote: > >> > >> Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). > > > > Is it not? > > Sure, every electronic device

[pull] amdgpu, amdkfd, radeon drm-next-6.9

2024-02-19 Thread Alex Deucher
Hi Dave, Sima, More new stuff for 6.9. The following changes since commit d5597444032b2f5c8624918fb5b29be5bba78a3c: drm/amdgpu: Fix HDP flush for VFs on nbio v7.9 (2024-02-07 12:26:24 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: linux-next: build failure after merge of the drm-misc tree

2024-02-19 Thread Stephen Rothwell
Hi all, On Mon, 12 Feb 2024 15:15:54 +0200 Jani Nikula wrote: > > On Tue, 06 Feb 2024, Stephen Rothwell wrote: > > > > After merging the drm-misc tree, today's linux-next build (i386 defconfig) > > failed like this: > > > > In function 'i915_ttm_placement_from_obj', > > inlined from

Re: [PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-19 Thread Konrad Dybcio
On 19.02.2024 15:49, Dmitry Baryshkov wrote: > On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: >> >> Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). > > Is it not? Sure, every electronic device is also a heater, I suppose.. I found this wording extremely funny though

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-19 Thread Adam Ford
On Mon, Feb 19, 2024 at 3:00 AM Matt Coster wrote: > > Hi Adam, > > On 18/02/2024 23:26, Adam Ford wrote: > > On Fri, Feb 16, 2024 at 8:14 AM Maxime Ripard wrote: > >> > >> On Fri, Feb 16, 2024 at 09:13:14AM +, Biju Das wrote: > >>> Hi Maxime Ripard, > >>> > -Original Message- >

Re: [PATCH 3/3] drm/ci: mark universal-plane-sanity as failing on SC7180

2024-02-19 Thread Helen Koike
On 19/02/2024 17:25, Helen Koike wrote: On 18/02/2024 01:12, Dmitry Baryshkov wrote: The test kms_universal_plane@universal-plane-sanity fails on both SC7180 platforms. The drm/msm returns -ERANGE as it can not handle passet scaling range, however the test is not ready to handle that. Mark

Re: [PATCH 2/3] drm/ci: update msm-apq8096-fails list

2024-02-19 Thread Helen Koike
On 19/02/2024 17:26, Helen Koike wrote: On 18/02/2024 01:12, Dmitry Baryshkov wrote: Mark two tests as passing on the APQ8096 / db820c platform. Signed-off-by: Dmitry Baryshkov Acked-by: Helen Koike Applied to drm-misc/drm-misc-next Thanks Helen ---  

Re: [PATCH 1/3] drm/ci: update IGT test names

2024-02-19 Thread Helen Koike
On 19/02/2024 17:25, Helen Koike wrote: On 19/02/2024 14:42, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 18:48, Helen Koike wrote: On 19/02/2024 11:33, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote: Hi Dmitry, On 18/02/2024 01:12, Dmitry Baryshkov

Re: [PATCH v3] drm/i915/guc: Simplify/extend platform check for Wa_14018913170

2024-02-19 Thread Rodrigo Vivi
On Fri, Feb 16, 2024 at 10:38:41AM -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > The above w/a is required for every platform that the i915 driver > supports. It is fixed on the latest platforms but they are only > supported by Xe instead of i915. So just remove the platform

Re: [PATCH 2/3] drm/ci: update msm-apq8096-fails list

2024-02-19 Thread Helen Koike
On 18/02/2024 01:12, Dmitry Baryshkov wrote: Mark two tests as passing on the APQ8096 / db820c platform. Signed-off-by: Dmitry Baryshkov Acked-by: Helen Koike --- drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH 3/3] drm/ci: mark universal-plane-sanity as failing on SC7180

2024-02-19 Thread Helen Koike
On 18/02/2024 01:12, Dmitry Baryshkov wrote: The test kms_universal_plane@universal-plane-sanity fails on both SC7180 platforms. The drm/msm returns -ERANGE as it can not handle passet scaling range, however the test is not ready to handle that. Mark the test as failing until it is fixed.

Re: [PATCH 1/3] drm/ci: update IGT test names

2024-02-19 Thread Helen Koike
On 19/02/2024 14:42, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 18:48, Helen Koike wrote: On 19/02/2024 11:33, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote: Hi Dmitry, On 18/02/2024 01:12, Dmitry Baryshkov wrote: Since the addition of testlist.txt

[PATCH v2] drm/bridge: adv7511: fix crash on irq during probe

2024-02-19 Thread Alvin Šipraga
From: Mads Bligaard Nielsen Moved IRQ registration down to end of adv7511_probe(). If an IRQ already is pending during adv7511_probe (before adv7511_cec_init) then cec_received_msg_ts could crash using uninitialized data: Unable to handle kernel read from unreadable memory at virtual

[PATCH v3 1/2] drm/bridge: adv7511: rearrange hotplug work code

2024-02-19 Thread Alvin Šipraga
From: Alvin Šipraga In preparation for calling EDID helpers from the hotplug work, move the hotplug work below the EDID helper section. No functional change. Reviewed-by: Robert Foss Signed-off-by: Alvin Šipraga --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 120

[PATCH v3 2/2] drm/bridge: adv7511: get edid in hpd_work to update CEC phys address

2024-02-19 Thread Alvin Šipraga
From: Alvin Šipraga The adv7511 driver is solely responsible for setting the physical address of its CEC adapter. To do this, it must read the EDID. However, EDID is only read when either the drm_bridge_funcs :: get_edid or drm_connector_helper_funcs :: get_modes ops are called. Without loss of

[PATCH v3 0/2] drm/bridge: adv7511: get edid in hpd_work to update CEC phys address

2024-02-19 Thread Alvin Šipraga
This series fixes a small bug where the CEC adapter could have an invalid CEC address even though we got a hotplug connect and could have read it. Signed-off-by: Alvin Šipraga --- Changes in v3: - rebase on latest drm-misc-fixes - remove redundant NULL check before kfree() - collect Robert's

Re: [PATCH] drm/i915: check before removing mm notifier

2024-02-19 Thread Rodrigo Vivi
On Mon, Feb 19, 2024 at 01:50:47PM +0100, Nirmoy Das wrote: > Error in mmu_interval_notifier_insert() can leave a NULL > notifier.mm pointer. Catch that and return early. > > Cc: Andi Shyti > Cc: Shawn Lee > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 +++

Re: [PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion

2024-02-19 Thread Rodrigo Vivi
On Mon, Feb 19, 2024 at 01:14:23PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Request can be NULL if no guilty request was identified so simply use > engine->i915 instead. > > Signed-off-by: Tvrtko Ursulin > Fixes: d50892a9554c ("drm/i915: switch from drm_debug_printer() to device

[PATCH] accel: constify the struct device_type usage

2024-02-19 Thread Ricardo B. Marliere
; --- base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d change-id: 20240219-device_cleanup-accel-a990dc3bfbc1 Best regards, -- Ricardo B. Marliere

Re: [PATCH] drm: rockchip: Don't require MIPI DSI device when it's used for ISP

2024-02-19 Thread Ondřej Jirman
On Mon, Feb 19, 2024 at 11:02:01AM +0800, Andy Yan wrote: > Hi Ondrej: > > On 2/18/24 23:17, Ondřej Jirman wrote: > > Hi Andy, > > > > On Sun, Feb 18, 2024 at 07:14:56PM +0800, Andy Yan wrote: > > > Hi, > > > > > > On 2/18/24 02:39, Ondřej Jirman wrote: > > > > From: Ondrej Jirman > > > > > >

Re: [PATCH v2] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2024-02-19 Thread Gustavo A. R. Silva
On 2/18/24 11:46, Christophe JAILLET wrote: If 'list_limit' is set to a very high value, 'lsize' computation could overflow if 'head.count' is big enough. In such a case, udmabuf_create() would access to memory beyond 'list'. Use memdup_array_user() which checks for overflow. While at it,

Re: [PATCH] dma-buf: Add syntax highlighting to code listings in the document

2024-02-19 Thread Tommy Chiang
Kindly ping :) On Fri, Jan 19, 2024 at 11:33 AM Tommy Chiang wrote: > > This patch tries to improve the display of the code listing > on The Linux Kernel documentation website for dma-buf [1] . > > Originally, it appears that it was attempting to escape > the '*' character, but looks like it's

Re: [PATCH v2] udmabuf: Fix a potential (and unlikely) access to unallocated memory

2024-02-19 Thread Christophe JAILLET
Le 19/02/2024 à 09:37, Dan Carpenter a écrit : On Sun, Feb 18, 2024 at 06:46:44PM +0100, Christophe JAILLET wrote: If 'list_limit' is set to a very high value, 'lsize' computation could overflow if 'head.count' is big enough. The "list_limit" is set via module parameter so if you set that

Re: [PATCH v5] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-19 Thread Abhinav Kumar
Hi DRM maintainers Gentle ping for reviews on this one. Since the dependent series is mostly complete, would like to get your reviews on this one to land it. Thanks Abhinav On 2/15/2024 11:15 AM, Abhinav Kumar wrote: From: Paloma Arellano YUV420 format is supported only in the VSC SDP

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-19 Thread Markus Elfring
> The two device node references taken during allocation need to be > dropped when the auxiliary device is freed. … > +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c … > @@ -74,6 +75,8 @@ struct device *drm_dp_hpd_bridge_register(struct device > *parent, > > ret = auxiliary_device_init(adev);

Re: [PATCH 1/3] drm/ci: update IGT test names

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 18:48, Helen Koike wrote: > > > > On 19/02/2024 11:33, Dmitry Baryshkov wrote: > > On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote: > >> > >> Hi Dmitry, > >> > >> > >> On 18/02/2024 01:12, Dmitry Baryshkov wrote: > >>> Since the addition of testlist.txt the IGT has changed

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-19 Thread Matt Coster
Hi Adam, On 19/02/2024 16:38, Adam Ford wrote: > On Mon, Feb 19, 2024 at 1:45 AM Biju Das wrote: >> >> Hi Adam, >> >>> -Original Message- >>> From: Adam Ford >>> Sent: Sunday, February 18, 2024 11:26 PM >>> Subject: Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend >>>

Re: [PATCH] drm/ci: skip suspend tests for both msm-sc7180 machines

2024-02-19 Thread Helen Koike
On 19/02/2024 11:47, Vignesh Raman wrote: On 17/02/24 02:26, Dmitry Baryshkov wrote: The commit ea489a3d983b ("drm/ci: add sc7180-trogdor-kingoftown") dropped the msm-sc7180-skips.txt file, which disabled suspend-to-RAM tests. However testing shows that STR tests still can fail. Restore the

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-19 Thread Maxime Ripard
On Mon, Feb 19, 2024 at 10:38:12AM -0600, Adam Ford wrote: > On Mon, Feb 19, 2024 at 1:45 AM Biju Das wrote: > > > > Hi Adam, > > > > > -Original Message- > > > From: Adam Ford > > > Sent: Sunday, February 18, 2024 11:26 PM > > > Subject: Re: RE: RE: [PATCH v2] drm/imagination:

Re: [PATCH 1/3] drm/ci: update IGT test names

2024-02-19 Thread Helen Koike
On 19/02/2024 11:33, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote: Hi Dmitry, On 18/02/2024 01:12, Dmitry Baryshkov wrote: Since the addition of testlist.txt the IGT has changed some of test names. Some test names were changed to use '-' instead of '_'. In

Re: [PATCH 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-19 Thread Thomas Zimmermann
Hi Am 19.02.24 um 15:19 schrieb Tony Lindgren: Commit 95da53d63dcf ("drm/omapdrm: Use regular fbdev I/O helpers") broke console because there is no damage handling in fb_sys_write() unlike we have in drm_fb_helper_sys_write(). Let's fix the issue by using deferred ops with fb helpers for

Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-19 Thread Adam Ford
On Mon, Feb 19, 2024 at 1:45 AM Biju Das wrote: > > Hi Adam, > > > -Original Message- > > From: Adam Ford > > Sent: Sunday, February 18, 2024 11:26 PM > > Subject: Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend > > on ARCH_K3 > > > > On Fri, Feb 16, 2024 at 8:14 AM

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-19 Thread Thierry Reding
On Mon Feb 19, 2024 at 3:18 AM CET, Mikko Perttunen wrote: > On 2/16/24 19:02, Thierry Reding wrote: > > On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > >> From: Mikko Perttunen > >> > >> On Tegra186, other software components may rely on the kernel to > >> keep Host1x operational

Re: [PATCH 1/2] drm/omapdrm: Fix console by implementing fb_dirty

2024-02-19 Thread Thomas Zimmermann
Hi Am 19.02.24 um 15:19 schrieb Tony Lindgren: The framebuffer console stopped updating with commit f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic"). Let's fix the issue by implementing fb_dirty similar to what was done with commit 039a72ce7e57 ("drm/i915/fbdev:

Re: [PATCH 3/8] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 17:01, Konrad Dybcio wrote: > > On 19.02.2024 15:54, Andrew Halaney wrote: > > On Mon, Feb 19, 2024 at 02:35:48PM +0100, Konrad Dybcio wrote: > >> Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") > >> introduced an entry to the alpha offsets array, but

Re: [PATCH 3/8] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-19 Thread Konrad Dybcio
On 19.02.2024 15:53, Dmitry Baryshkov wrote: > On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: >> >> Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") >> introduced an entry to the alpha offsets array, but diving into QCM2290 >> downstream and some documentation, it turned out

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-19 Thread Thierry Reding
On Sat Feb 17, 2024 at 10:39 AM CET, Krzysztof Kozlowski wrote: > The xlate callbacks are supposed to translate of_phandle_args to proper > provider without modifying the of_phandle_args. Make the argument > pointer to const for code safety and readability. > > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Alex Deucher
On Mon, Feb 19, 2024 at 10:19 AM Christian König wrote: > > Am 16.02.24 um 19:37 schrieb Alex Deucher: > > On Fri, Feb 16, 2024 at 10:42 AM Christian König > > wrote: > >> Am 16.02.24 um 16:12 schrieb Mario Limonciello: > >>> On 2/16/2024 09:05, Harry Wentland wrote: > > On 2024-02-16

Re: [PATCH] drm/amd: Only allow one entity to control ABM

2024-02-19 Thread Christian König
Am 16.02.24 um 19:37 schrieb Alex Deucher: On Fri, Feb 16, 2024 at 10:42 AM Christian König wrote: Am 16.02.24 um 16:12 schrieb Mario Limonciello: On 2/16/2024 09:05, Harry Wentland wrote: On 2024-02-16 09:47, Christian König wrote: Am 16.02.24 um 15:42 schrieb Mario Limonciello: On

Re: [PATCH 00/10] backlight: Replace struct fb_info in interfaces

2024-02-19 Thread Lee Jones
On Thu, 15 Feb 2024, Thomas Zimmermann wrote: > Hi > > Am 15.02.24 um 13:13 schrieb Daniel Thompson: > > On Mon, Feb 12, 2024 at 05:16:33PM +0100, Thomas Zimmermann wrote: > > > Backlight drivers implement struct backlight_ops.check_fb, which > > > uses struct fb_info in its interface. Replace

Re: [PATCH 3/8] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-19 Thread Konrad Dybcio
On 19.02.2024 15:54, Andrew Halaney wrote: > On Mon, Feb 19, 2024 at 02:35:48PM +0100, Konrad Dybcio wrote: >> Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") >> introduced an entry to the alpha offsets array, but diving into QCM2290 >> downstream and some documentation, it turned

Re: [PATCH 7/8] arm64: dts: qcom: qcm2290: Add GPU nodes

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: > > Describe the GPU hardware on the QCM2290. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 154 > ++ > 1 file changed, 154 insertions(+) > Reviewed-by: Dmitry Baryshkov --

Re: [PATCH v5 07/14] drm/panthor: Add the MMU/VM logical block

2024-02-19 Thread Steven Price
On 18/02/2024 21:41, Boris Brezillon wrote: > MMU and VM management is related and placed in the same source file. > > Page table updates are delegated to the io-pgtable-arm driver that's in > the iommu subsystem. > > The VM management logic is based on drm_gpuva_mgr, and is assuming the > VA

Re: [PATCH 4/8] clk: qcom: Add QCM2290 GPU clock controller driver

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: > > Add a driver for the GPU clock controller block found on the QCM2290 SoC. > > Signed-off-by: Konrad Dybcio > --- > drivers/clk/qcom/Kconfig | 9 + > drivers/clk/qcom/Makefile| 1 + > drivers/clk/qcom/gpucc-qcm2290.c |

Re: [PATCH 3/8] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-19 Thread Andrew Halaney
On Mon, Feb 19, 2024 at 02:35:48PM +0100, Konrad Dybcio wrote: > Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") > introduced an entry to the alpha offsets array, but diving into QCM2290 > downstream and some documentation, it turned out that the name Huayra > apparently has been

Re: [PATCH 3/8] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: > > Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") > introduced an entry to the alpha offsets array, but diving into QCM2290 > downstream and some documentation, it turned out that the name Huayra > apparently has been used

Re: [PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: > > Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). Is it not? > > [1] > https://docs.qualcomm.com/bundle/publicresource/87-61720-1_REV_A_QUALCOMM_ROBOTICS_RB1_PLATFORM__QUALCOMM_QRB2210__PRODUCT_BRIEF.pdf >

Re: [PATCH] drm/ci: skip suspend tests for both msm-sc7180 machines

2024-02-19 Thread Vignesh Raman
On 17/02/24 02:26, Dmitry Baryshkov wrote: The commit ea489a3d983b ("drm/ci: add sc7180-trogdor-kingoftown") dropped the msm-sc7180-skips.txt file, which disabled suspend-to-RAM tests. However testing shows that STR tests still can fail. Restore the skiplist, applying it to both limozeen and

Re: [PATCH 1/3] drm/ci: update IGT test names

2024-02-19 Thread Dmitry Baryshkov
On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote: > > Hi Dmitry, > > > On 18/02/2024 01:12, Dmitry Baryshkov wrote: > > Since the addition of testlist.txt the IGT has changed some of test > > names. Some test names were changed to use '-' instead of '_'. In other > > cases tests were just renamed.

Re: [PATCH 2/8] dt-bindings: clock: Add Qcom QCM2290 GPUCC

2024-02-19 Thread Rob Herring
rors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240219-topic-rb1_gpu-v1-2-d260fa854...@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check'

[PATCH 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-19 Thread Tony Lindgren
Commit 95da53d63dcf ("drm/omapdrm: Use regular fbdev I/O helpers") broke console because there is no damage handling in fb_sys_write() unlike we have in drm_fb_helper_sys_write(). Let's fix the issue by using deferred ops with fb helpers for damage. Fixes: 95da53d63dcf ("drm/omapdrm: Use regular

[PATCH 1/2] drm/omapdrm: Fix console by implementing fb_dirty

2024-02-19 Thread Tony Lindgren
The framebuffer console stopped updating with commit f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic"). Let's fix the issue by implementing fb_dirty similar to what was done with commit 039a72ce7e57 ("drm/i915/fbdev: Implement fb_dirty for intel custom fb helper").

Re: Re: Re: Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-19 Thread Sebastian Wick
On Thu, Feb 15, 2024 at 12:00:01PM +0100, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 06:06:18PM +0100, Sebastian Wick wrote: > > On Mon, Feb 12, 2024 at 05:53:48PM +0100, Maxime Ripard wrote: > > > On Mon, Feb 12, 2024 at 05:49:33PM +0200, Ville Syrjälä wrote: > > > > On Mon, Feb 12, 2024 at

[PATCH v4] drm/msm/dpu: add current resource allocation to dumped state

2024-02-19 Thread Dmitry Baryshkov
struct dpu_hw_blk **blks, int blks_size); +/** + * dpu_rm_print_state - output the RM private state + * @p: DRM printer + * @global_state: global state + */ +void dpu_rm_print_state(struct drm_printer *p, + const struct dpu_global_state *global_state); + /** * dpu_rm_get_intf - Return a struct dpu_hw_intf instance given it's index. * @rm: DPU Resource Manager handle --- base-commit: 41c177cf354126a22443b5c80cec9fdd313e67e1 change-id: 20240219-fd-rm-state-bd1218954b78 Best regards, -- Dmitry Baryshkov

Re: drm/msm: Second DisplayPort regression in 6.8-rc1

2024-02-19 Thread Johan Hovold
On Mon, Feb 19, 2024 at 11:41:41AM +0100, Johan Hovold wrote: > It seems my initial suspicion that at least some of these regressions > were related to the runtime PM work was correct. The hard resets happens > when the DP controller is runtime suspended after being probed: > [ 17.074925]

[PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-19 Thread Konrad Dybcio
Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). [1] https://docs.qualcomm.com/bundle/publicresource/87-61720-1_REV_A_QUALCOMM_ROBOTICS_RB1_PLATFORM__QUALCOMM_QRB2210__PRODUCT_BRIEF.pdf Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 8

[PATCH 7/8] arm64: dts: qcom: qcm2290: Add GPU nodes

2024-02-19 Thread Konrad Dybcio
Describe the GPU hardware on the QCM2290. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 154 ++ 1 file changed, 154 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi index

[PATCH 6/8] drm/msm/adreno: Add A702 support

2024-02-19 Thread Konrad Dybcio
The A702 is a weird mix of 600 and 700 series.. Perhaps even a testing ground for some A7xx features with good ol' A6xx silicon. It's basically A610 that's been beefed up with some new registers and hw features (like APRIV!), that was then cut back in size, memory bus and some other ways. Add

[PATCH 5/8] drm/msm/adreno: Add missing defines for A702

2024-02-19 Thread Konrad Dybcio
Add some defines required for A702. Can be substituted with a header sync after merging mesa!27665 [1]. [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27665 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 18 ++ 1 file changed, 18

[PATCH 3/8] clk: qcom: clk-alpha-pll: Add HUAYRA_2290 support

2024-02-19 Thread Konrad Dybcio
Commit 134b55b7e19f ("clk: qcom: support Huayra type Alpha PLL") introduced an entry to the alpha offsets array, but diving into QCM2290 downstream and some documentation, it turned out that the name Huayra apparently has been used quite liberally across many chips, even with noticeably different

[PATCH 4/8] clk: qcom: Add QCM2290 GPU clock controller driver

2024-02-19 Thread Konrad Dybcio
Add a driver for the GPU clock controller block found on the QCM2290 SoC. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/Kconfig | 9 + drivers/clk/qcom/Makefile| 1 + drivers/clk/qcom/gpucc-qcm2290.c | 423 +++ 3 files changed, 433

[PATCH 1/8] dt-bindings: arm-smmu: Add QCM2290 GPU SMMU

2024-02-19 Thread Konrad Dybcio
The GPU SMMU on QCM2290 nicely fits into the description we already have for SM61[12]5. Add it. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/8] dt-bindings: clock: Add Qcom QCM2290 GPUCC

2024-02-19 Thread Konrad Dybcio
Add device tree bindings for graphics clock controller for Qualcomm Technology Inc's QCM2290 SoCs. Signed-off-by: Konrad Dybcio --- .../bindings/clock/qcom,qcm2290-gpucc.yaml | 76 ++ include/dt-bindings/clock/qcom,qcm2290-gpucc.h | 32 + 2 files changed,

[PATCH 0/8] A702 support

2024-02-19 Thread Konrad Dybcio
/msm/adreno/adreno_device.c | 18 + drivers/gpu/drm/msm/adreno/adreno_gpu.h| 16 +- include/dt-bindings/clock/qcom,qcm2290-gpucc.h | 32 ++ 14 files changed, 888 insertions(+), 10 deletions(-) --- base-commit: 26d7d52b6253574d5b6fec16a93e1110d1489cef change-id: 20240219-topic

Re: [PATCH] drm/i915: Add some boring kerneldoc

2024-02-19 Thread Souza, Jose
On Mon, 2024-02-19 at 13:25 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Tooling appears very strict so lets pacify it by adding some comments, > even if fields are completely self-explanatory. > Reviewed-by: José Roberto de Souza > Signed-off-by: Tvrtko Ursulin > Fixes:

[PATCH] drm/i915: Add some boring kerneldoc

2024-02-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Tooling appears very strict so lets pacify it by adding some comments, even if fields are completely self-explanatory. Signed-off-by: Tvrtko Ursulin Fixes: b11236486749 ("drm/i915: Add GuC submission interface version query") Reported-by: Stephen Rothwell Cc: Jose Souza

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-19 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 11:26:44AM +0200, Ville Syrjälä wrote: > On Mon, Feb 12, 2024 at 05:50:36PM +0100, Sebastian Wick wrote: > > On Mon, Feb 12, 2024 at 11:10:15AM +0200, Pekka Paalanen wrote: > > > On Fri, 9 Feb 2024 17:53:07 +0100 > > > Xaver Hugl wrote: > > > > > > > Signed-off-by: Xaver

  1   2   >