[PATCH v4 3/4] drm/mipi-dsi: add mipi_dsi_compression_mode_ext()

2024-04-02 Thread Dmitry Baryshkov
Add the extended version of mipi_dsi_compression_mode(). It provides a way to specify the algorithm and PPS selector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_mipi_dsi.c | 41 ++--- include/drm/drm_mipi_dsi.h | 9 + 2 files

[PATCH v4 4/4] drm: panel: Add LG sw43408 panel driver

2024-04-02 Thread Dmitry Baryshkov
From: Sumit Semwal LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel, used in some Pixel3 phones. Signed-off-by: Sumit Semwal [vinod: Add DSC support] Signed-off-by: Vinod Koul [caleb: cleanup and support turning off the panel] Signed-off-by: Caleb Connolly [DB: partially rewrote the driver and

[PATCH v4 2/4] drm/mipi-dsi: use correct return type for the DSC functions

2024-04-02 Thread Dmitry Baryshkov
The functions mipi_dsi_compression_mode() and mipi_dsi_picture_parameter_set() return 0-or-error rather than a buffer size. Follow example of other similar MIPI DSI functions and use int return type instead of size_t. Fixes: f4dea1aaa9a1 ("drm/dsi: add helpers for DSI compression mode and PPS

[PATCH v4 0/4] drm/panel: add support for LG SW43408 panel

2024-04-02 Thread Dmitry Baryshkov
the .clock maths to show the reason behind the value (Marijn) - Moved the mode out of the match data (Marijn) - Link to v3: https://lore.kernel.org/r/20240402-lg-sw43408-panel-v3-0-144f17a11...@linaro.org Changes in v3: - Fixed return type of MIPI DSC functions - Replaced

[PATCH v4 1/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

2024-04-02 Thread Dmitry Baryshkov
From: Sumit Semwal LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel present on Google Pixel 3 phones. Signed-off-by: Vinod Koul Signed-off-by: Sumit Semwal [caleb: convert to yaml] Signed-off-by: Caleb Connolly Reviewed-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 4/4] drm: panel: Add LG sw43408 panel driver

2024-04-02 Thread Dmitry Baryshkov
On Tue, Apr 02, 2024 at 11:17:52PM +0200, Marijn Suijten wrote: > On 2024-04-02 02:51:15, Dmitry Baryshkov wrote: > > From: Sumit Semwal > > > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel, used in some Pixel3 > > phones. > > @60Hz? With the current settings and timings I'm only getting 30

Re: [PATCH v3 3/4] drm/mipi-dsi: add mipi_dsi_compression_mode_ext()

2024-04-02 Thread Dmitry Baryshkov
On Tue, Apr 02, 2024 at 11:09:29PM +0200, Marijn Suijten wrote: > On 2024-04-02 02:51:14, Dmitry Baryshkov wrote: > > Add the extended version of mipi_dsi_compression_mode(). It provides > > a way to specify the algorithm and PPS selector. > > > > Signed-off-by: Dmitry Baryshkov > > --- > >

Re: [PATCH v3 1/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

2024-04-02 Thread Dmitry Baryshkov
On Tue, Apr 02, 2024 at 10:59:11PM +0200, Marijn Suijten wrote: > On 2024-04-02 10:23:22, Dmitry Baryshkov wrote: > > On Tue, 2 Apr 2024 at 09:31, Krzysztof Kozlowski > > wrote: > > > > > > On 02/04/2024 01:51, Dmitry Baryshkov wrote: > > > > From: Sumit Semwal > > > > > > > > LG SW43408 is

Re: [PATCH 3/3] drm: panel: Add LG sw43408 panel driver

2024-04-02 Thread Dmitry Baryshkov
On Tue, 2 Apr 2024 at 23:57, Marijn Suijten wrote: > > On 2024-04-01 22:11:48, Dmitry Baryshkov wrote: > > On Mon, 1 Apr 2024 at 13:29, Marijn Suijten > > wrote: > > > > > > On 2024-03-30 16:37:08, Dmitry Baryshkov wrote: > > > > On Sat, 30 Mar 2024 at 12:27, Marijn Suijten > > > > wrote: > > >

[linux-next:master] BUILD REGRESSION c0b832517f627ead3388c6f0c74e8ac10ad5774b

2024-04-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: c0b832517f627ead3388c6f0c74e8ac10ad5774b Add linux-next specific files for 20240402 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404021504.ytp51bl3-...@intel.com https

[RFC PATCH net-next v8 14/14] selftests: add ncdevmem, netcat for devmem TCP

2024-04-02 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support,

[RFC PATCH net-next v8 13/14] net: add devmem TCP documentation

2024-04-02 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry --- v8: - Applied docs suggestions (Randy). Thanks! v7: - Applied docs suggestions (Jakub). v2: - Missing spdx (simon) - add to index.rst (simon) fix docs --- Documentation/networking/devmem.rst

[RFC PATCH net-next v8 12/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-04-02 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry ---

[RFC PATCH net-next v8 11/14] tcp: RX path for devmem TCP

2024-04-02 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a

[RFC PATCH net-next v8 10/14] net: add support for skbs with unreadable frags

2024-04-02 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[RFC PATCH net-next v8 09/14] net: support non paged skb frags

2024-04-02 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry --- v6: - Rebased on top of the merged netmem changes. Changes in v1: - Fix illegal_highdma() (Yunsheng). - Rework napi_pp_put_page()

[RFC PATCH net-next v8 08/14] memory-provider: dmabuf devmem memory provider

2024-04-02 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the

[RFC PATCH net-next v8 07/14] page_pool: devmem support

2024-04-02 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long

[RFC PATCH net-next v8 06/14] page_pool: convert to use netmem

2024-04-02 Thread Mina Almasry
Abstrace the memory type from the page_pool so we can later add support for new memory types. Convert the page_pool to use the new netmem type abstraction, rather than use struct page directly. As of this patch the netmem type is a no-op abstraction: it's always a struct page underneath. All the

[RFC PATCH net-next v8 05/14] netdev: netdevice devmem allocator

2024-04-02 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[RFC PATCH net-next v8 04/14] netdev: support binding dma-buf to netdevice

2024-04-02 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a

[RFC PATCH net-next v8 03/14] net: netdev netlink api to bind dma-buf to a net device

2024-04-02 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- v7: - Use flags: [ admin-perm ] instead of a CAP_NET_ADMIN check. Changes in v1: - Add rx-queue-type

[RFC PATCH net-next v8 02/14] net: page_pool: create hooks for custom page providers

2024-04-02 Thread Mina Almasry
From: Jakub Kicinski The page providers which try to reuse the same pages will need to hold onto the ref, even if page gets released from the pool - as in releasing the page from the pp just transfers the "ownership" reference from pp to the provider, and provider will wait for other references

[RFC PATCH net-next v8 01/14] queue_api: define queue api

2024-04-02 Thread Mina Almasry
This API enables the net stack to reset the queues used for devmem TCP. Signed-off-by: Mina Almasry --- include/linux/netdevice.h | 3 +++ include/net/netdev_queues.h | 27 +++ 2 files changed, 30 insertions(+) diff --git a/include/linux/netdevice.h

[RFC PATCH net-next v8 00/14] Device Memory TCP

2024-04-02 Thread Mina Almasry
RFC v8: === Major Changes: -- - Fixed build error generated by patch-by-patch build. - Applied docs suggestions from Randy. RFC v7: === Major Changes: -- This revision largely rebases on top of net-next and addresses the feedback RFCv6 received from folks,

Re: [PATCH 1/4] gpu/drm: Add SPDX-license-Identifier tag

2024-04-02 Thread Joe Perches
On Tue, 2024-04-02 at 22:43 +, Nicolas Devos wrote: > This commit fixes following checkpatch warning: > WARNING: Missing or malformed SPDX-License-Identifier tag NAK without specific agreement from Intel. The existing license in the file is neither GPL nor MIT > > Signed-off-by: Nicolas

linux-next: build failure after merge of the drm-misc tree

2024-04-02 Thread Stephen Rothwell
have used the drm-misc tree from next-20240402 for today. -- Cheers, Stephen Rothwell pgphtSsyRPklj.pgp Description: OpenPGP digital signature

[PATCH 4/5] drm/vmwgfx: Fix crtc's atomic check conditional

2024-04-02 Thread Zack Rusin
The conditional was supposed to prevent enabling of a crtc state without a set primary plane. Accidently it also prevented disabling crtc state with a set primary plane. Neither is correct. Fix the conditional and just driver-warn when a crtc state has been enabled without a primary plane which

[PATCH 5/5] drm/vmwgfx: Sort primary plane formats by order of preference

2024-04-02 Thread Zack Rusin
The table of primary plane formats wasn't sorted at all, leading to applications picking our least desirable formats by defaults. Sort the primary plane formats according to our order of preference. Fixes IGT's kms_atomic plane-invalid-params which assumes that the preferred format is a 32bpp

[PATCH 3/5] drm/vmwgfx: Fix prime import/export

2024-04-02 Thread Zack Rusin
vmwgfx never supported prime import of external buffers. Furthermore the driver exposes two different objects to userspace: vmw_surface's and gem buffers but prime import/export only worked with vmw_surfaces. Because gem buffers are used through the dumb_buffer interface this meant that the

[PATCH 2/5] drm/vmwgfx: Implement virtual crc generation

2024-04-02 Thread Zack Rusin
crc checksums are used to validate the output. Normally they're part of the actual display hardware but on virtual stack there's nothing to automatically generate them. Implement crc generation for the vmwgfx stack. This works only on screen targets, where it's possibly to easily make sure that

[PATCH 1/5] drm/vmwgfx: Implement virtual kms

2024-04-02 Thread Zack Rusin
By default vmwgfx doesn't support vblanking or crc generation which makes it impossible to use various IGT tests to validate vmwgfx. Implement virtual kernel mode setting, which is mainly related to simulated vblank support. Code is very similar to amd's vkms and the vkms module itself, except

[PATCH 0/5] drm/vmwgfx: vblank and crc generation support

2024-04-02 Thread Zack Rusin
vmwgfx didn't have support for vblank or crc generation which made it impossible to use a large number of IGT tests to properly test DRM functionality in the driver. This series add virtual vblank and crc generation support, which allows running most of IGT and immediately helped fix a number of

Re: Cross-device and cross-driver HMM support

2024-04-02 Thread Dave Airlie
On Wed, 27 Mar 2024 at 19:52, Thomas Hellström wrote: > > Hi! > > With our SVM mirror work we'll soon start looking at HMM cross-device > support. The identified needs are > > 1) Instead of migrating foreign device memory to system when the > current device is faulting, leave it in place... > 1a)

RE: [PATCH v2 4/4] drm: xlnx: zynqmp_dpsub: Add DP audio support

2024-04-02 Thread Klymenko, Anatoliy
Hi Tomi, > -Original Message- > From: Tomi Valkeinen > Sent: Tuesday, March 19, 2024 1:23 AM > To: Lars-Peter Clausen ; Jaroslav Kysela > ; Takashi Iwai ; Liam Girdwood > ; Mark Brown ; Laurent > Pinchart ; Maarten Lankhorst > ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ;

[PATCH 3/4] gpu/drm: Prefer `unsigned int` over `unsigned`

2024-04-02 Thread Nicolas Devos
This commit fixes following checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Nicolas Devos --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c

[PATCH 2/4] gpu/drm: Remove unnecessary braces

2024-04-02 Thread Nicolas Devos
This commit fixes following checkpatch warnings: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Nicolas Devos --- drivers/gpu/drm/drm_connector.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH 0/4] gpu/drm: Fix checkpatch warnings in drm_connector.c

2024-04-02 Thread Nicolas Devos
Hello, First time contributor here, I am getting familiar with the flow by fixing some checkpatch warnings. This patch series fixes the warnings of drivers/gpu/drm/drm_connector.c. The result is 4 patches that each address a separate issue raised by the checkpatch.pl script. My initial attempt

[PATCH 4/4] gpu/drm: Replace tabs with spaces in comments

2024-04-02 Thread Nicolas Devos
This commit fixes following warnings found by checkpatch: WARNING: please, no space before tabs Signed-off-by: Nicolas Devos --- drivers/gpu/drm/drm_connector.c | 712 1 file changed, 356 insertions(+), 356 deletions(-) diff --git

[PATCH 1/4] gpu/drm: Add SPDX-license-Identifier tag

2024-04-02 Thread Nicolas Devos
This commit fixes following checkpatch warning: WARNING: Missing or malformed SPDX-License-Identifier tag Signed-off-by: Nicolas Devos --- drivers/gpu/drm/drm_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index

[PATCH 2/2] drm/panthor: Fix some kerneldoc warnings

2024-04-02 Thread Liviu Dudau
When compiling with W=1 the build process will flag empty comments, misnamed documented variables and incorrect tagging of functions. Fix them in one go. Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Cc: Boris Brezillon Cc: Steven Price Signed-off-by: Liviu Dudau ---

[PATCH 1/2] drm/panthor: Cleanup unused variable 'cookie'

2024-04-02 Thread Liviu Dudau
Commit 962f88b9c916 ("drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()") removed the code that used the 'cookie' variable but left the declaration in place. Remove it. Fixes: 962f88b9c916 ("drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume()") Cc:

Re: [PATCH v3 4/4] drm: panel: Add LG sw43408 panel driver

2024-04-02 Thread Marijn Suijten
On 2024-04-02 02:51:15, Dmitry Baryshkov wrote: > From: Sumit Semwal > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel, used in some Pixel3 > phones. @60Hz? > > Signed-off-by: Sumit Semwal > [vinod: Add DSC support] > Signed-off-by: Vinod Koul > [caleb: cleanup and support turning off the

Re: [PATCH v3 3/4] drm/mipi-dsi: add mipi_dsi_compression_mode_ext()

2024-04-02 Thread Marijn Suijten
On 2024-04-02 02:51:14, Dmitry Baryshkov wrote: > Add the extended version of mipi_dsi_compression_mode(). It provides > a way to specify the algorithm and PPS selector. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_mipi_dsi.c | 33 +++-- >

Re: [PATCH v3 2/4] drm/mipi-dsi: use correct return type for the DSC functions

2024-04-02 Thread Marijn Suijten
On 2024-04-02 02:51:13, Dmitry Baryshkov wrote: > The functions mipi_dsi_compression_mode() and > mipi_dsi_picture_parameter_set() return 0-or-error rather than a buffer > size. Follow example of other similar MIPI DSI functions and use int > return type instead of size_t. > > Fixes: f4dea1aaa9a1

Re: [PATCH v3 1/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel

2024-04-02 Thread Marijn Suijten
On 2024-04-02 10:23:22, Dmitry Baryshkov wrote: > On Tue, 2 Apr 2024 at 09:31, Krzysztof Kozlowski > wrote: > > > > On 02/04/2024 01:51, Dmitry Baryshkov wrote: > > > From: Sumit Semwal > > > > > > LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel present on Google Pixel 3 > > > phones. > > > > > >

Re: [PATCH 3/3] drm: panel: Add LG sw43408 panel driver

2024-04-02 Thread Marijn Suijten
On 2024-04-01 22:11:48, Dmitry Baryshkov wrote: > On Mon, 1 Apr 2024 at 13:29, Marijn Suijten > wrote: > > > > On 2024-03-30 16:37:08, Dmitry Baryshkov wrote: > > > On Sat, 30 Mar 2024 at 12:27, Marijn Suijten > > > wrote: > > > > > > > > On 2024-03-30 05:59:30, Dmitry Baryshkov wrote: > > > > >

Re: [PATCH v2 24/25] fuse: virtio: drop owner assignment

2024-04-02 Thread Stefan Hajnoczi
On Sun, Mar 31, 2024 at 10:44:11AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Depends on the first patch. > --- > fs/fuse/virtio_fs.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH v2 23/25] scsi: virtio: drop owner assignment

2024-04-02 Thread Stefan Hajnoczi
On Sun, Mar 31, 2024 at 10:44:10AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Depends on the first patch. > --- > drivers/scsi/virtio_scsi.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH v2 19/25] vsock/virtio: drop owner assignment

2024-04-02 Thread Stefan Hajnoczi
On Sun, Mar 31, 2024 at 10:44:06AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Acked-by: Stefano Garzarella > Signed-off-by: Krzysztof Kozlowski > --- > > Depends on the first patch. > --- > net/vmw_vsock/virtio_transport.c | 1 - >

Re: [PATCH v2 06/25] virtio_blk: drop owner assignment

2024-04-02 Thread Stefan Hajnoczi
On Sun, Mar 31, 2024 at 10:43:53AM +0200, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Depends on the first patch. > --- > drivers/block/virtio_blk.c | 1 - > 1 file changed, 1 deletion(-)

[drm-misc:for-linux-next 3/4] drivers/gpu/drm/panthor/panthor_device.h:326:13: warning: unused variable 'cookie'

2024-04-02 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 10021ef27310279c850cf6cb38542c443a995e92 commit: 962f88b9c91647f3ff4a0d3709662641baed5164 [3/4] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume() config: arm64-defconfig

Re: [PATCH] dmabuf: fix dmabuf file poll uaf issue

2024-04-02 Thread T.J. Mercier
On Tue, Apr 2, 2024 at 1:08 AM Christian König wrote: > > Am 02.04.24 um 08:49 schrieb zhiguojiang: > >> As far as I can see that's not because of the DMA-buf code, but > >> because you are somehow using this interface incorrectly. > >> > >> When dma_buf_poll() is called it is mandatory for the

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-02 Thread Easwar Hariharan
On 4/2/2024 9:52 AM, Jani Nikula wrote: > On Tue, 02 Apr 2024, Easwar Hariharan wrote: >> On 4/2/2024 7:32 AM, Jani Nikula wrote: >>> On Tue, 02 Apr 2024, Easwar Hariharan wrote: On 4/2/2024 12:48 AM, Jani Nikula wrote: > On Fri, 29 Mar 2024, Easwar Hariharan > wrote: >> I2C

[drm-misc:for-linux-next 3/4] drivers/gpu/drm/panthor/panthor_device.h:326:13: error: unused variable 'cookie'

2024-04-02 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 10021ef27310279c850cf6cb38542c443a995e92 commit: 962f88b9c91647f3ff4a0d3709662641baed5164 [3/4] drm/panthor: Drop the dev_enter/exit() sections in _irq_suspend/resume() config: alpha-allyesconfig

Re: [PATCH 2/2] dt-bindings: display: bridge: lt8912b: document 'lontium,pn-swap' property

2024-04-02 Thread Conor Dooley
On Tue, Apr 02, 2024 at 01:59:25PM +0300, Alexandru Ardelean wrote: > On some HW designs, it's easier for the layout if the P/N pins are swapped. > The driver currently has a DT property to do that. "currently", because 1/2 adds it. bindings patches should precede the driver patches in the

Re: [PATCH 1/2] drm/bridge: lt8912b: add support for P/N pin swap

2024-04-02 Thread Francesco Dolcini
Hello Alexandru, thanks for your patch. On Tue, Apr 02, 2024 at 01:59:24PM +0300, Alexandru Ardelean wrote: > On some HW designs, it's easier for the layout if the P/N pins are swapped. > In those cases, we need to adjust (for this) by configuring the MIPI analog > registers differently.

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-02 Thread Jani Nikula
On Tue, 02 Apr 2024, Easwar Hariharan wrote: > On 4/2/2024 7:32 AM, Jani Nikula wrote: >> On Tue, 02 Apr 2024, Easwar Hariharan wrote: >>> On 4/2/2024 12:48 AM, Jani Nikula wrote: On Fri, 29 Mar 2024, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced

Re: [PATCH v3] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Dan Carpenter
On Tue, Apr 02, 2024 at 05:19:25PM +0200, Boris Brezillon wrote: > On Tue, 2 Apr 2024 17:44:18 +0300 > Dan Carpenter wrote: > > > On Tue, Apr 02, 2024 at 04:38:38PM +0200, Boris Brezillon wrote: > > > On Tue, 2 Apr 2024 07:14:11 -0700 > > > Harshit Mogalapalli wrote: > > > > > > > Currently

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-02 Thread Easwar Hariharan
On 4/2/2024 7:32 AM, Jani Nikula wrote: > On Tue, 02 Apr 2024, Easwar Hariharan wrote: >> On 4/2/2024 12:48 AM, Jani Nikula wrote: >>> On Fri, 29 Mar 2024, Easwar Hariharan wrote: I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" with more appropriate terms.

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-02 Thread Mark Brown
fig, the DT kselftest result isn't terribly informative but it can be seen here: https://lava.sirena.org.uk/scheduler/job/78288#L6007 which I bisected to this change: # bad: [c0b832517f627ead3388c6f0c74e8ac10ad5774b] Add linux-next specific files for 20240402 # good: [0fc83069

Re: [PATCH v3] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 17:44:18 +0300 Dan Carpenter wrote: > On Tue, Apr 02, 2024 at 04:38:38PM +0200, Boris Brezillon wrote: > > On Tue, 2 Apr 2024 07:14:11 -0700 > > Harshit Mogalapalli wrote: > > > > > Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and > > > NULL(when create is

Re: [PATCH v4 10/10] drm/vboxvideo: fix mapping leaks

2024-04-02 Thread Hans de Goede
Hi, On 4/2/24 3:50 PM, Philipp Stanner wrote: > On Thu, 2024-03-28 at 12:55 -0500, Bjorn Helgaas wrote: >> On Fri, Mar 01, 2024 at 12:29:58PM +0100, Philipp Stanner wrote: >>> When the PCI devres API was introduced to this driver, it was >>> wrongly >>> assumed that initializing the device with

Re: [PATCH v3] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Dan Carpenter
On Tue, Apr 02, 2024 at 04:38:38PM +0200, Boris Brezillon wrote: > On Tue, 2 Apr 2024 07:14:11 -0700 > Harshit Mogalapalli wrote: > > > Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and > > NULL(when create is false and if there is no poool attached to the > >

Re: [PATCH v3] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 07:14:11 -0700 Harshit Mogalapalli wrote: > Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and > NULL(when create is false and if there is no poool attached to the ^ pool > VM) > - Change the function to

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-02 Thread Jani Nikula
On Tue, 02 Apr 2024, Easwar Hariharan wrote: > On 4/2/2024 12:48 AM, Jani Nikula wrote: >> On Fri, 29 Mar 2024, Easwar Hariharan wrote: >>> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >>> with more appropriate terms. Inspired by and following on to Wolfram's >>> series

Re: [PATCH v12 2/8] mm/gup: Introduce check_and_migrate_movable_folios()

2024-04-02 Thread David Hildenbrand
On 25.02.24 08:56, Vivek Kasireddy wrote: This helper is the folio equivalent of check_and_migrate_movable_pages(). Therefore, all the rules that apply to check_and_migrate_movable_pages() also apply to this one as well. Currently, this helper is only used by memfd_pin_folios(). This patch also

[PATCH v3] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Harshit Mogalapalli
Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and NULL(when create is false and if there is no poool attached to the VM) - Change the function to return error pointers, when pool is NULL return -ENOENT - Also handle the callers to check for IS_ERR() on

Re: [PATCH v12 1/8] mm/gup: Introduce unpin_folio/unpin_folios helpers

2024-04-02 Thread David Hildenbrand
On 02.04.24 15:52, David Hildenbrand wrote: On 25.02.24 08:56, Vivek Kasireddy wrote: These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find

Re: [PATCH v2] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 19:35:41 +0530 Harshit Mogalapalli wrote: > Hi Boris, > On 02/04/24 19:32, Boris Brezillon wrote: > > On Tue, 2 Apr 2024 06:47:08 -0700 > > Harshit Mogalapalli wrote: > > > >> 1. The devm_drm_dev_alloc() function returns error pointers. > >> Update the error handling

Re: [PATCH v2] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Harshit Mogalapalli
Hi Boris, On 02/04/24 19:32, Boris Brezillon wrote: On Tue, 2 Apr 2024 06:47:08 -0700 Harshit Mogalapalli wrote: 1. The devm_drm_dev_alloc() function returns error pointers. Update the error handling to check for error pointers instead of NULL. 2. Currently panthor_vm_get_heap_pool()

Re: [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe()

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 03:40:40 -0700 Harshit Mogalapalli wrote: > The devm_drm_dev_alloc() function returns error pointers. > Update the error handling to check for error pointers instead of NULL. > > Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block") > Signed-off-by: Harshit

Re: [PATCH v2] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 06:47:08 -0700 Harshit Mogalapalli wrote: > 1. The devm_drm_dev_alloc() function returns error pointers. >Update the error handling to check for error pointers instead of NULL. > 2. Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and >NULL(when create is

[PATCH v2] drm: ensure drm headers are self-contained and pass kernel-doc

2024-04-02 Thread Jani Nikula
Ensure drm headers build, are self-contained, have header guards, and have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y. The mechanism follows similar patters used in i915, xe, and usr/include. To cover include/drm, we need to recurse there using the top level Kbuild and the new

Re: [PATCH v12 1/8] mm/gup: Introduce unpin_folio/unpin_folios helpers

2024-04-02 Thread David Hildenbrand
On 25.02.24 08:56, Vivek Kasireddy wrote: These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find new uses in the future, when more and more

Re: [PATCH v4 10/10] drm/vboxvideo: fix mapping leaks

2024-04-02 Thread Philipp Stanner
On Thu, 2024-03-28 at 12:55 -0500, Bjorn Helgaas wrote: > On Fri, Mar 01, 2024 at 12:29:58PM +0100, Philipp Stanner wrote: > > When the PCI devres API was introduced to this driver, it was > > wrongly > > assumed that initializing the device with pcim_enable_device() > > instead > > of

[PATCH v2] drm/panthor: Fix couple of NULL vs IS_ERR() bugs

2024-04-02 Thread Harshit Mogalapalli
1. The devm_drm_dev_alloc() function returns error pointers. Update the error handling to check for error pointers instead of NULL. 2. Currently panthor_vm_get_heap_pool() returns both ERR_PTR() and NULL(when create is false and if there is no poool attached to the VM) - Change

Re: [PATCH v10 0/9] Improve test coverage of TTM

2024-04-02 Thread Somalapuram, Amaranath
some issue with the latest drm-misc:  (commit 4c4f33be7e4d476566246e7166c54ef175287e00 (origin/for-linux-next, origin/drm-misc-next, origin/HEAD)) Regards, S.Amarnath $ make ARCH=um O=.kunit --jobs=16 ERROR:root:../arch/x86/um/user-offsets.c:17:6: warning: no previous prototype for ‘foo’

Re: [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_ioctl_tiler_heap_destroy()

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 18:52:12 +0530 Harshit Mogalapalli wrote: > Hello Boris, > > On 02/04/24 18:03, Boris Brezillon wrote: > > Hello Harshit, > > > > On Tue, 2 Apr 2024 03:33:58 -0700 > > Harshit Mogalapalli wrote: > > > >> panthor_vm_get_heap_pool() returns ERR_PTR on failure. > >> > >>

Re: [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_ioctl_tiler_heap_destroy()

2024-04-02 Thread Harshit Mogalapalli
Hello Boris, On 02/04/24 18:03, Boris Brezillon wrote: Hello Harshit, On Tue, 2 Apr 2024 03:33:58 -0700 Harshit Mogalapalli wrote: panthor_vm_get_heap_pool() returns ERR_PTR on failure. Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block") Signed-off-by: Harshit Mogalapalli

Re: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-04-02 Thread Herbert Xu
On Tue, Apr 02, 2024 at 12:36:41PM +, Akhil R wrote: > > Should I set the reqsize as below in sha_cra_init()? Seeing this in other > crypto drivers. > > crypto_ahash_set_reqsize(ahash_tfm, > sizeof(struct tegra_sha_reqctx) + >

RE: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

2024-04-02 Thread Akhil R
> On Tue, Mar 19, 2024 at 01:53:04PM +0530, Akhil R wrote: > > > > +struct tegra_sha_reqctx { > > + struct ahash_request fallback_req; > > This doesn't work because ahash_request is dynamically sized. > So you'll end up clobbering the rest of the struct if a fallback ends up > being used. >

Re: [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_ioctl_tiler_heap_destroy()

2024-04-02 Thread Boris Brezillon
Hello Harshit, On Tue, 2 Apr 2024 03:33:58 -0700 Harshit Mogalapalli wrote: > panthor_vm_get_heap_pool() returns ERR_PTR on failure. > > Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block") > Signed-off-by: Harshit Mogalapalli > --- > This is spotted by smatch and the patch is

Re: [PATCH] drm/panthor: Fix a couple -ENOMEM error codes

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 12:58:09 +0300 Dan Carpenter wrote: > These error paths forgot to set the error code to -ENOMEM. > > Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block") > Signed-off-by: Dan Carpenter Reviewed-by: Boris Brezillon > --- >

Re: [PATCH] drm/panthor: Fix off by one in panthor_fw_get_cs_iface()

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 12:56:42 +0300 Dan Carpenter wrote: > The ->iface.streams[csg_slot][] array has MAX_CS_PER_CSG elements so > this > comparison needs to be >= to prevent an out of bounds access. > > Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") > Signed-off-by: Dan Carpenter

Re: [PATCH] drm/panthor: Fix error code in panthor_gpu_init()

2024-04-02 Thread Boris Brezillon
On Tue, 2 Apr 2024 12:56:19 +0300 Dan Carpenter wrote: > This code accidentally returns zero/success on error because of a typo. > It should be "irq" instead of "ret". The other thing is that if > platform_get_irq_byname() were to return zero then the error code would > be cmplicated.

Re: [PATCH v0 03/14] drm/gma500,drm/i915: Make I2C terminology more inclusive

2024-04-02 Thread Easwar Hariharan
On 4/2/2024 12:48 AM, Jani Nikula wrote: > On Fri, 29 Mar 2024, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the terminology for

Re: [RFC PATCH 0/8] TTM shrinker helpers and xe buffer object shrinker

2024-04-02 Thread Somalapuram, Amaranath
On 3/29/2024 8:26 PM, Thomas Hellström wrote: This series implements TTM shrinker / eviction helpers and an xe bo shrinker. It builds on two previous series. First https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg484425.html for patch 1-4, which IMO still could be reviewed and

Re: [PATCH] drm/vmwgfx: Filter modes which exceed graphics memory

2024-04-02 Thread Zack Rusin
On Mon, Apr 1, 2024 at 4:35 PM Ian Forbes wrote: > > SVGA requires individual surfaces to fit within graphics memory > (max_mob_pages) which means that modes with a final buffer size that would > exceed graphics memory must be pruned otherwise creation will fail. > > This fixes an issue where VMs

Re: [PATCH v0 10/14] sfc: falcon: Make I2C terminology more inclusive

2024-04-02 Thread Martin Habets
On Fri, Mar 29, 2024 at 05:00:34PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT

Re: [PATCH v9 1/6] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec()

2024-04-02 Thread Paul Cercueil
Hi Vinod, Le jeudi 28 mars 2024 à 11:53 +0530, Vinod Koul a écrit : > On 10-03-24, 13:48, Paul Cercueil wrote: > > This function can be used to initiate a scatter-gather DMA > > transfer, > > where the address and size of each segment is located in one entry > > of > > the dma_vec array. > > > >

Re: [PATCH] drm/panthor: Fix IS_ERR() vs NULL bug in group_process_tiler_oom()

2024-04-02 Thread Harshit Mogalapalli
Hi, On 02/04/24 16:47, Harshit Mogalapalli wrote: panthor_vm_get_heap_pool() returns ERR_PTR on failure, update the check accordingly. Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Signed-off-by: Harshit Mogalapalli --- This is based on static analysis with smatch, only

[PATCH] drm/panthor: Fix IS_ERR() vs NULL bug in group_process_tiler_oom()

2024-04-02 Thread Harshit Mogalapalli
panthor_vm_get_heap_pool() returns ERR_PTR on failure, update the check accordingly. Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Signed-off-by: Harshit Mogalapalli --- This is based on static analysis with smatch, only compile tested. ---

[PATCH libdrm RESEND] modetest: add support for YUV422 and YUV444 plane format

2024-04-02 Thread Dmitry Baryshkov
Currently modetest supports only the YUV420 and YVU420 planar YCbCr plane formats (aka YV12 and YU12). Extend the code to add support for YUV422 / YVU422 and YUV444 / YVU444 plane formats. Signed-off-by: Dmitry Baryshkov --- tests/modetest/buffers.c | 42

Re: [PATCH] video: backlight: otm3225a: drop driver owner assignment

2024-04-02 Thread Daniel Thompson
On Wed, Mar 27, 2024 at 06:47:14PM +0100, Krzysztof Kozlowski wrote: > Core in spi_register_driver() already sets the .owner, so driver > does not need to. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

[PATCH 2/2] dt-bindings: display: bridge: lt8912b: document 'lontium, pn-swap' property

2024-04-02 Thread Alexandru Ardelean
On some HW designs, it's easier for the layout if the P/N pins are swapped. The driver currently has a DT property to do that. This change documents the 'lontium,pn-swap' property. Signed-off-by: Alexandru Ardelean --- .../devicetree/bindings/display/bridge/lontium,lt8912b.yaml | 6 ++ 1

[PATCH 1/2] drm/bridge: lt8912b: add support for P/N pin swap

2024-04-02 Thread Alexandru Ardelean
On some HW designs, it's easier for the layout if the P/N pins are swapped. In those cases, we need to adjust (for this) by configuring the MIPI analog registers differently. Specifically, register 0x3e needs to be 0xf6 (instead of 0xd6). This change adds a 'lontium,pn-swap' device-tree property

Re: [PATCH v5 2/2] backlight: Add new lm3509 backlight driver

2024-04-02 Thread Daniel Thompson
On Sat, Mar 30, 2024 at 03:59:25PM +0100, Patrick Gansterer wrote: > This is a general driver for LM3509 backlight chip of TI. > LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with > Dual Current Sinks. This driver supports OLED/White LED select, brightness > control and

[PATCH 8/8] accel/ivpu: Fix deadlock in context_xa

2024-04-02 Thread Jacek Lawrynowicz
ivpu_device->context_xa is locked both in kernel thread and IRQ context. It requires XA_FLAGS_LOCK_IRQ flag to be passed during initialization otherwise the lock could be acquired from a thread and interrupted by an IRQ that locks it for the second time causing the deadlock. This deadlock was

[PATCH 7/8] accel/ivpu: Fix missed error message after VPU rename

2024-04-02 Thread Jacek Lawrynowicz
Change "VPU" to "NPU" in ivpu_suspend() so it matches all other error messages. Signed-off-by: Jacek Lawrynowicz --- drivers/accel/ivpu/ivpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c index

  1   2   >