In the subject: s/Force//
On Wed, 24 Oct 2018 12:05:04 +0200
Boris Brezillon wrote:
> For the YUV conversion to work properly, ->x_scaling[0,1] should never
> be set to VC4_SCALING_NONE, but vc4_get_scaling_mode() might return
> VC4_SCALING_NONE if the horizontal scaling ratio exa
On Wed, 24 Oct 2018 12:05:03 +0200
Boris Brezillon wrote:
> The source image might be only vertically scaled, and in this case
> ->is_unity will be false, but we'd still have to force ->x_scaling[0]
> to VC4_SCALING_PPF for YUV conversion to work properly.
>
> Le
On Tue, 23 Oct 2018 15:44:43 +0200
Daniel Vetter wrote:
> On Tue, Oct 23, 2018 at 09:55:08AM +0200, Boris Brezillon wrote:
> > Hi Daniel,
> >
> > On Tue, 16 Oct 2018 14:57:43 +0200
> > Daniel Vetter wrote:
> >
> > > On Tue, Oct 16, 2018
On Thu, 25 Oct 2018 11:33:14 +0200
Daniel Vetter wrote:
> On Thu, Oct 25, 2018 at 10:09:31AM +0200, Boris Brezillon wrote:
> > On Tue, 23 Oct 2018 15:44:43 +0200
> > Daniel Vetter wrote:
> >
> > > On Tue, Oct 23, 2018 at 09:55:08AM +0200, Boris Brezil
'ret' var removal).
Regards,
Boris
Boris Brezillon (3):
drm/atomic: Add a generic infrastructure to track underrun errors
drm/vc4: Report underrun errors
drm/vc4: Add a load tracker to prevent HVS underflow errors
drivers/gpu/drm/drm_atomic.c| 12 +++
drivers/gpu/drm
The DRM framework provides a generic way to report underrun errors.
Let's implement the necessary hooks to support it in the VC4 driver.
Signed-off-by: Boris Brezillon
---
Changes in v2:
- New patch
---
drivers/gpu/drm/vc4/vc4_drv.h | 3 ++
drivers/gpu/drm/vc4/vc4_hvs.c
means the load tracking algorithm needs some tweaking/fixing.
Signed-off-by: Boris Brezillon
---
Changes in v2:
- New patch
---
drivers/gpu/drm/drm_atomic.c| 12 +++
drivers/gpu/drm/drm_atomic_helper.c | 4 +++
include/drm/drm_atomic_helper.h | 53
f the
memory bus. Same goes for the HVS limit, except the margin is smaller in
this case, since the HVS is not used by external components.
Signed-off-by: Boris Brezillon
---
Changes in v2:
- Remove an unused var in vc4_load_tracker_atomic_check()
---
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
driver
s done to highlight the fact that fbdev emulation is an
> internal client that makes use of the driver, it is not part of the
> driver as such. If fbdev setup fails, an error is printed, but the driver
> succeeds probing.
>
> Cc: Boris Brezillon
> Signed-off-by: Noralf Trønnes
&
Hi Daniel,
On Fri, 26 Oct 2018 12:33:37 +0200
Daniel Vetter wrote:
> On Thu, Oct 25, 2018 at 02:45:44PM +0200, Boris Brezillon wrote:
> > Display controllers usually provide a lot features like overlay planes,
> > hardware scalers, hardware rotations, ...
> > Most of th
On Fri, 26 Oct 2018 15:30:26 +0200
Daniel Vetter wrote:
> On Thu, Oct 25, 2018 at 11:41:14AM +0200, Boris Brezillon wrote:
> > On Thu, 25 Oct 2018 11:33:14 +0200
> > Daniel Vetter wrote:
> >
> > > On Thu, Oct 25, 2018 at 10:09:31AM +0200, Boris Brezillon wrote:
On Fri, 26 Oct 2018 15:36:15 +0200
Daniel Vetter wrote:
> On Fri, Oct 26, 2018 at 02:36:56PM +0200, Boris Brezillon wrote:
> > Hi Daniel,
> >
> > On Fri, 26 Oct 2018 12:33:37 +0200
> > Daniel Vetter wrote:
> >
> > > On Thu, Oct 25, 2018
On Fri, 26 Oct 2018 16:26:03 +0200
Daniel Vetter wrote:
> On Fri, Oct 26, 2018 at 3:57 PM Boris Brezillon
> wrote:
> >
> > On Fri, 26 Oct 2018 15:30:26 +0200
> > Daniel Vetter wrote:
> >
> > > On Thu, Oct 25, 2018 at 11:41:14AM +0200, Boris Brezillon
On Mon, 29 Oct 2018 09:06:40 +0100
Daniel Vetter wrote:
> On Fri, Oct 26, 2018 at 06:10:03PM +0300, Ville Syrjälä wrote:
> > On Fri, Oct 26, 2018 at 04:52:33PM +0200, Boris Brezillon wrote:
> > > On Fri, 26 Oct 2018 16:26:03 +0200
> > > Daniel Vetter wrote:
>
On Mon, 29 Oct 2018 10:03:01 +0100
Daniel Vetter wrote:
> On Mon, Oct 29, 2018 at 09:41:36AM +0100, Boris Brezillon wrote:
> > On Mon, 29 Oct 2018 09:06:40 +0100
> > Daniel Vetter wrote:
> >
> > > On Fri, Oct 26, 2018 at 06:10:03PM +0300, Ville Syrjälä wrote:
h) {
> + case 0: /* driver default */
> + case 8:
> + case 16:
> + case 24:
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> ddev = drm_dev_alloc(&atmel_hlcdc_dc_driver, &pdev->dev);
> if (IS_ERR(ddev))
> return PTR_ERR(ddev);
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, 28 Mar 2018 14:22:36 +0200
Daniel Vetter wrote:
> On Wed, Mar 28, 2018 at 09:34:54AM +0200, Boris Brezillon wrote:
> > Hi Peter,
> >
> > On Mon, 26 Mar 2018 09:35:02 +0200
> > Peter Rosin wrote:
> >
> > > I have an sama5d31-based system with
From: Gustavo Padovan
Add support for async updates of cursors by using the new atomic
interface for that. Basically what this commit does is do what
vc4_update_plane() did but through atomic.
v6: add missing drm_atomic_set_fb_for_plane() in
vc4_plane_atomic_async_update() (Boris Brezillon
avoid possible use-after-free
issues
v6: add missing drm_atomic_set_fb_for_plane() in
vc4_plane_atomic_async_update() (Boris Brezillon)
v5: add missing call to vc4_plane_atomic_check() (Eric Anholt)
v4: add drm_atomic_helper_async() commit (Eric Anholt)
v3: move size checks back to drivers
->atomic_async_update() requires that drivers update the plane->state
object before returning. Make sure at least common properties have been
updated.
Cc: Gustavo Padovan
Signed-off-by: Boris Brezillon
---
Hello,
This is a problem I had when debugging the VC4 ->atomic_asy
patch 1 in drm_atomic_helper.c. Also, I'd
like to have feedback from Padovan, Daniel and maybe others who have
already thought about handling async page flips generically.
And the last reason is that it's not been extensively tested, so it may
not work correctly :-).
Regards,
Boris
Boris Brezillon (2
The last user of vc4_queue_seqno_cb() (async page flip handling code)
is gone. Get rid of this function and all the related structs and
fields.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_drv.h | 14 --
drivers/gpu/drm/vc4/vc4_gem.c | 39
flip()
implementation and its dependencies and use
drm_atomic_helper_page_flip() instead.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_crtc.c | 103 +
drivers/gpu/drm/vc4/vc4_kms.c | 101 +---
2 files chang
On Fri, 30 Mar 2018 17:09:03 +0200
Boris Brezillon wrote:
> Rework the atomic commit logic to handle async page flip requests in
> the atomic update path.
>
> Async page flips are a bit more complicated than async cursor updates
> (already handled in the vc4_atomic_commit() fu
Use container_of() instead of type casting so that it keeps working
even if base is moved inside the drm_writeback_connector struct.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/drm_atomic.c | 4 +++-
include/drm/drm_writeback.h | 6 ++
2 files changed, 9 insertions(+), 1 deletion
Now that we have a way to fake VBLANK events when requested by the CRTC
hook it up to the generic commit_tail() helpers.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/drm_atomic_helper.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers
From: Boris Brezillon
The transposer block is providing support for mem-to-mem composition,
which is exposed as a drm_writeback connector in DRM.
Add a driver to support this feature.
Signed-off-by: Boris Brezillon
---
.../devicetree/bindings/display/brcm,bcm-vc4.txt | 6 +
drivers/gpu
much has changed except I modified a bit
the implementation to adjust the latest revision of the writeback
interface.
Regards,
Boris
Boris Brezillon (8):
drm/atomic: Avoid connector to writeback_connector casts
drm/connector: Pass a drm_connector_state to ->atomic_commit()
drm/vc4:
From: Boris Brezillon
The transposer block is allowing one to write the result of the VC4
composition back to memory instead of displaying it on a screen.
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts/bcm283x.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot
e the only thing we
want to check when calling drm_atomic_helper_wait_for_vblanks() from
vc4_atomic_complete_commit() is that new FBs are in use and the old
ones can be safely released.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_kms.c | 11 +--
1 file changed, 1 inse
nts. The core drm_atomic_helper_fake_vblank()
helper can then be used to fake VBLANKs at commit time.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/drm_atomic_helper.c | 40 +
include/drm/drm_atomic_helper.h | 1 +
include/drm/drm_crtc.h
Mimic what is done in drm_atomic_commit_tail() and call
drm_atomic_helper_fake_vblank() so that VBLANK events are faked
when the drm_crtc_state.no_vblank is true. Will be needed when we'll
add support for the transposer block.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_kms.
much has changed except I modified a bit
the implementation to adjust the latest revision of the writeback
interface.
Regards,
Boris
Boris Brezillon (8):
drm/atomic: Avoid connector to writeback_connector casts
drm/connector: Pass a drm_connector_state to ->atomic_commit()
drm/vc4:
Other atomic hooks are passed state objects, let's change this one to
be consistent.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/drm_atomic_helper.c | 2 +-
include/drm/drm_modeset_helper_vtables.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/driver
On Mon, 2 Jul 2018 09:54:32 +0200
Daniel Vetter wrote:
> On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote:
> > Now that we have a way to fake VBLANK events when requested by the CRTC
> > hook it up to the generic commit_tail() helpers.
> >
> > Sig
On Mon, 2 Jul 2018 09:57:30 +0200
Daniel Vetter wrote:
> On Mon, Jul 02, 2018 at 09:54:32AM +0200, Daniel Vetter wrote:
> > On Fri, Jun 29, 2018 at 01:17:18PM +0200, Boris Brezillon wrote:
> > > Now that we have a way to fake VBLANK events when requested by the CRTC
>
On Mon, 2 Jul 2018 10:02:52 +0200
Daniel Vetter wrote:
> On Fri, Jun 29, 2018 at 01:17:17PM +0200, Boris Brezillon wrote:
> > In some cases CRTCs are active but are not able to generating events, at
> > least not at every frame at it's expected to.
> > This is typically
On Mon, 2 Jul 2018 10:40:54 +0200
Daniel Vetter wrote:
> > >
> > > > + * Note that, even when no_blank is set to true, the CRTC driver
> > > > can still
> > > > + * steal the &drm_crtc_state.event object and send the event on
> > > > its own.
> > > > + * That's usually what happe
On Mon, 2 Jul 2018 10:37:22 +0200
Daniel Vetter wrote:
> On Mon, Jul 02, 2018 at 10:14:51AM +0200, Boris Brezillon wrote:
> > On Mon, 2 Jul 2018 10:02:52 +0200
> > Daniel Vetter wrote:
> >
> > > On Fri, Jun 29, 2018 at 01:17:17PM +0200, Boris Brezillon wrote:
On Mon, 2 Jul 2018 09:51:46 +0200
Daniel Vetter wrote:
> On Fri, Jun 29, 2018 at 12:37:10PM +0100, Liviu Dudau wrote:
> > On Fri, Jun 29, 2018 at 01:17:15PM +0200, Boris Brezillon wrote:
> > > Other atomic hooks are passed state objects, let's change this one
Hi Eric,
On Fri, 29 Jun 2018 13:35:04 -0700
Eric Anholt wrote:
> Boris Brezillon writes:
>
> > From: Boris Brezillon
> >
> > The transposer block is providing support for mem-to-mem composition,
> > which is exposed as a drm_writeback connector in DRM.
> &
On Fri, 29 Jun 2018 12:40:45 +0100
Liviu Dudau wrote:
> On Fri, Jun 29, 2018 at 01:17:22PM +0200, Boris Brezillon wrote:
> > Hello,
> >
> > This is the second version of this series adding writeback support
> > to the VC4 display engine.
> >
> > Thi
On Mon, 2 Jul 2018 12:14:20 +0100
Liviu Dudau wrote:
> On Mon, Jul 02, 2018 at 11:49:11AM +0200, Boris Brezillon wrote:
> > On Mon, 2 Jul 2018 09:51:46 +0200
> > Daniel Vetter wrote:
> >
> > > On Fri, Jun 29, 2018 at 12:37:10PM +0100, Liviu Dudau wrote:
>
Use container_of() instead of type casting so that it keeps working
even if base is moved inside the drm_writeback_connector struct.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v3:
- Add Daniel's and Liviu's R-b
---
drive
/rework
and the addition of one patch to make commit->atomic_commit() optional.
See the changelog in each patch you want more details.
Regards,
Boris
Boris Brezillon (9):
drm/atomic: Avoid connector to writeback_connector casts
drm/connector: Pass a drm_connector_state to ->atomic_
Other atomic hooks are passed state objects, let's change this one to
be consistent.
Signed-off-by: Boris Brezillon
Acked-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v3:
- Add Liviu's A-b and Daniel's R-b
Changes in v2:
- New patch
---
drivers/gpu/drm/drm_
function optional and reflect this fact in the doc.
Signed-off-by: Boris Brezillon
---
Changes in v3:
- New patch
---
drivers/gpu/drm/drm_atomic_helper.c | 2 ++
include/drm/drm_modeset_helper_vtables.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b
Now that we have a way to fake VBLANK events when requested by the CRTC
hook it up to the generic commit_tail() helpers.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v3:
- Add R-b tags
Changes in v2:
- New patch
---
drivers/gpu/drm
Mimic what is done in drm_atomic_commit_tail() and call
drm_atomic_helper_fake_vblank() so that VBLANK events are faked
when the drm_crtc_state.no_vblank is true. Will be needed when we'll
add support for the transposer block.
Signed-off-by: Boris Brezillon
Reviewed-by: Eric Anholt
---
Ch
nts. The core drm_atomic_helper_fake_vblank()
helper can then be used to fake VBLANKs at commit time.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v3:
- Use inline doc for @no_vblank
- Fix drm_atomic_helper_fake_vblank() to only check
n
e the only thing we
want to check when calling drm_atomic_helper_wait_for_vblanks() from
vc4_atomic_complete_commit() is that new FBs are in use and the old
ones can be safely released.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Eric Anholt
---
Changes in v3:
- Add E
From: Boris Brezillon
The transposer block is providing support for mem-to-mem composition,
which is exposed as a drm_writeback connector in DRM.
Add a driver to support this feature.
Signed-off-by: Boris Brezillon
---
Changes in v3:
- Add Eric's R-b
- Fix the code updating ->no_blank
From: Boris Brezillon
The transposer block is allowing one to write the result of the VC4
composition back to memory instead of displaying it on a screen.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Eric Anholt
---
Changes in v3:
- Add R-b tags
Changes in v2:
- None
]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-vc4-Add-support-for-the-transposer-IP/20180702-211805
> config: x86_64-randconfig-x015-201826 (attache
On Mon, 02 Jul 2018 11:52:58 -0700
Eric Anholt wrote:
> Boris Brezillon writes:
>
> > From: Boris Brezillon
> >
> > The transposer block is providing support for mem-to-mem composition,
> > which is exposed as a drm_writeback connector in DRM.
> >
>
e the only thing we
want to check when calling drm_atomic_helper_wait_for_vblanks() from
vc4_atomic_complete_commit() is that new FBs are in use and the old
ones can be safely released.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Eric Anholt
---
Changes in v4:
- None
Ch
Now that we have a way to fake VBLANK events when requested by the CRTC
hook it up to the generic commit_tail() helpers.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v4:
- None
Changes in v3:
- Add R-b tags
Changes in v2:
- New patch
Use container_of() instead of type casting so that it keeps working
even if base is moved inside the drm_writeback_connector struct.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v4:
- None
Changes in v3:
- Add Daniel's and Liviu&
the changelog in each patch for more details.
Regards,
Boris
Boris Brezillon (8):
drm/atomic: Avoid connector to writeback_connector casts
drm/connector: Pass a drm_connector_state to ->atomic_commit()
drm/connector: Make ->atomic_commit() optional
drm/vc4: Use wait_for_fli
Other atomic hooks are passed state objects, let's change this one to
be consistent.
Signed-off-by: Boris Brezillon
Acked-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v4:
- None
Changes in v3:
- Add Liviu's A-b and Daniel's R-b
Changes in v2:
- New patch
---
nts. The core drm_atomic_helper_fake_vblank()
helper can then be used to fake VBLANKs at commit time.
Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Reviewed-by: Daniel Vetter
---
Changes in v4:
- None
Changes in v3:
- Use inline doc for @no_vblank
- Fix drm_atomic_helper_fake_vbl
Mimic what is done in drm_atomic_commit_tail() and call
drm_atomic_helper_fake_vblank() so that VBLANK events are faked
when the drm_crtc_state.no_vblank is true. Will be needed when we'll
add support for the transposer block.
Signed-off-by: Boris Brezillon
Reviewed-by: Eric Anholt
---
Ch
function optional and reflect this fact in the doc.
Signed-off-by: Boris Brezillon
Acked-by: Liviu Dudau
---
Changes in v4:
- Add Liviu's ack
- Fix a build failure
Changes in v3:
- New patch
---
drivers/gpu/drm/drm_atomic_helper.c | 2 ++
include/drm/drm_modeset_helper_vtables.h | 2
From: Boris Brezillon
The transposer block is providing support for mem-to-mem composition,
which is exposed as a drm_writeback connector in DRM.
Add a driver to support this feature.
Signed-off-by: Boris Brezillon
Reviewed-by: Eric Anholt
---
Changes in v4:
- Actually add Eric'
Fix the bullet list declaration in the overview section.
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/drm_writeback.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
index 827395071f0b
On Tue, 3 Jul 2018 19:40:46 +0200
Boris Brezillon wrote:
> Fix the bullet list declaration in the overview section.
>
> Signed-off-by: Boris Brezillon
Forgot to add:
Reported-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_writeback.c | 11 +++
> 1 file changed,
On Tue, 3 Jul 2018 19:44:00 +0200
Boris Brezillon wrote:
> On Tue, 3 Jul 2018 19:40:46 +0200
> Boris Brezillon wrote:
>
> > Fix the bullet list declaration in the overview section.
> >
> > Signed-off-by: Boris Brezillon
>
> Forgot to add:
>
>
On Tue, 3 Jul 2018 09:50:14 +0200
Boris Brezillon wrote:
> Hello,
>
> This is the third version of this series adding writeback support
> to the VC4 display engine.
>
> This version is based on drm-misc-next and include a bunch of
> modifications to the core that I had t
On Tue, 3 Jul 2018 19:40:46 +0200
Boris Brezillon wrote:
> Fix the bullet list declaration in the overview section.
>
> Signed-off-by: Boris Brezillon
Applied to drm-misc-next.
> ---
> drivers/gpu/drm/drm_writeback.c | 11 +++
> 1 file changed, 7 insertio
Hi Alexandru,
On Fri, 20 Jul 2018 22:15:03 +0100
Alexandru Gheorghe wrote:
Please add a commit message here (even if it's just repeating what the
subject says).
> Signed-off-by: Alexandru Gheorghe
With this addressed:
Acked-by: Boris Brezillon
> ---
> drivers/gpu/d
wed.
Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane
update")
Signed-off-by: Boris Brezillon
---
Hello,
As discussed on IRC, I'm not sure this "plane should already be enabled
and assigned to the same CRTC to allow async updates" limitation
appl
plane, new_plane_state and
old_plane_state are initialized.
Explicitly initialized those variables to NULL to make gcc happy.
Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane
update")
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/drm_atomic_helper.c | 5 +++
On Mon, 23 Jul 2018 10:09:25 -0400
Sean Paul wrote:
> On Mon, Jul 23, 2018 at 03:59:02PM +0200, Boris Brezillon wrote:
> > drm_atomic_helper_async_check() declares the plane, old_plane_state and
> > new_plane_state variables to iterate over all planes of the atomic
> > sta
On Tue, 24 Jul 2018 09:14:02 +0100
Alexandru-Cosmin Gheorghe wrote:
> On Tue, Jul 24, 2018 at 09:48:53AM +0200, Philipp Zabel wrote:
> > Hi Alexandru,
> >
> > On Fri, 2018-07-20 at 22:15 +0100, Alexandru Gheorghe wrote:
> > > There are a lot of drivers that subclass drm_plane_state, all of the
wed.
Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane
update")
Cc:
Signed-off-by: Boris Brezillon
Reviewed-by: Eric Anholt
---
Changes in v2:
- Cc stable
- Add Eric's R-b
---
drivers/gpu/drm/drm_atomic_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletio
plane, new_plane_state and
old_plane_state are initialized.
Explicitly initialize those variables to NULL to make gcc happy.
Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane
update")
Cc:
Signed-off-by: Boris Brezillon
Reviewed-by: Sean Paul
---
Changes in v2:
-
This is needed to ensure ->is_unity is correct when the plane was
previously configured to output a multi-planar format with scaling
enabled, and is then being reconfigured to output a uniplanar format.
Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
Cc:
Signed-
hardly visible artifact (seen when using modetest
and a rather big overlay plane in YUV420).
Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
Cc:
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_plane.c | 25 -
1 file changed, 12 insertions(+
Hello Eric,
This is an attempt at fixing support for negative X/Y positioning of
various FB formats. I kept you as the author since I started from your
initial work and fixed a few things + split the changes in several
commits. Let me know if that's a problem, and I change the author.
This series
From: Eric Anholt
This is needed to support X/Y negative placement of planes using
T-format buffers.
Signed-off-by: Eric Anholt
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_regs.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers
From: Eric Anholt
Y_OFFSET field starts at bit 8 not 7.
Signed-off-by: Eric Anholt
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_regs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h
index
OM_SANDXXX.
Signed-off-by: Eric Anholt
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_plane.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index 39e1fa3a8466..2b8ba1c41
From: Eric Anholt
X/Y positioning of T-format buffers is quite tricky and the current
implementation was failing to position a plane using this format
correctly when the X, Y or both X and Y offsets were negative.
Signed-off-by: Eric Anholt
Signed-off-by: Boris Brezillon
---
Hi Eric,
I kept
from drm_plane_state.
Incidentally, it seems to fix a problem we had with negative X/Y
positioning of YUV planes.
Signed-off-by: Eric Anholt
Signed-off-by: Boris Brezillon
---
drivers/gpu/drm/vc4/vc4_drv.h | 9 --
drivers/gpu/drm/vc4/vc4_plane.c | 210
On Tue, 24 Jul 2018 15:32:15 +0200
Boris Brezillon wrote:
> Async plane update is supposed to work only when updating the FB or FB
> position of an already enabled plane. That does not apply to requests
> where the plane was previously disabled or assigned to a different
> CTRC
On Tue, 24 Jul 2018 15:33:00 +0200
Boris Brezillon wrote:
> drm_atomic_helper_async_check() declares the plane, old_plane_state and
> new_plane_state variables to iterate over all planes of the atomic
> state and make sure only one plane is enabled.
>
> Unfortunately gcc is not
On Tue, 24 Jul 2018 15:36:01 +0200
Boris Brezillon wrote:
> This is needed to ensure ->is_unity is correct when the plane was
> previously configured to output a multi-planar format with scaling
> enabled, and is then being reconfigured to output a uniplanar format.
>
> F
On Fri, 27 Jul 2018 13:38:08 -0700
Eric Anholt wrote:
> Boris Brezillon writes:
>
> > From: Eric Anholt
> >
> > drm_atomic_helper_check_plane_state() takes care of checking the
> > scaling capabilities and calculating the clipped X/Y offsets for us.
> >
On Wed, 25 Jul 2018 17:32:08 +0200
Boris Brezillon wrote:
> From: Eric Anholt
>
> The offset adjustment depends on the framebuffer modified, so let's
^ modifier
> just move this operation in the DRM_FORMAT_MOD_L
On Fri, 27 Jul 2018 13:46:31 -0700
Eric Anholt wrote:
> Boris Brezillon writes:
>
> > From: Eric Anholt
> >
> > X/Y positioning of T-format buffers is quite tricky and the current
> > implementation was failing to position a plane using this format
> > cor
Hi Sam,
On Sat, 8 Sep 2018 22:17:55 +0200
Sam Ravnborg wrote:
> Hi all.
>
> When working on the DRM driver for Atmel LCDC the first approach
> was to use a MFD driver, that had two sub-drivers:
> - PWM dirver
> - DRM driver
>
> Feedback was that the PWM feature was too small to warrant a MFD d
ing warnings via debug UART.
> Sometimes after disconnecting HDMI, i'm getting the expected screen.
Was it working with 4.14? Could you try after applying this patch
series [1]?
Regards,
Boris
[1]https://www.spinics.net/lists/stable/msg214527.html
--
Boris Brezillon, Bootlin (formerly
On Sat, 10 Feb 2018 18:18:30 +0100 (CET)
Stefan Wahren wrote:
> Hi Boris,
>
> > Boris Brezillon hat am 10. Februar 2018 um
> > 17:40 geschrieben:
> >
> >
> > Hi Stefan,
> >
> > On Sat, 10 Feb 2018 16:57:23 +0100 (CET)
> > Stefan Wah
Free Electrons is now Bootlin.
Signed-off-by: Boris Brezillon
---
Note that I'm planning to take this patch through the MTD tree.
---
.mailmap| 7 ---
MAINTAINERS | 10 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/.mailmap b/.mailmap
index e18cab7
Adding back all the people that were Cc-ed on the initial email.
On Fri, 16 Feb 2018 15:18:21 +0100
Kamil Konieczny wrote:
> On 16.02.2018 15:00, Boris Brezillon wrote:
> > On Fri, 16 Feb 2018 12:21:53 +0100
> > Kamil Konieczny wrote:
> >
> >> On 16.02.201
On Fri, 16 Feb 2018 16:35:27 +0100
Kamil Konieczny wrote:
> On 16.02.2018 15:54, Boris Brezillon wrote:
> > Adding back all the people that were Cc-ed on the initial email.
> >
> > On Fri, 16 Feb 2018 15:18:21 +0100
> > Kamil Konieczny wrote:
> >
> >
On Fri, 16 Feb 2018 11:44:49 +0100
Boris Brezillon wrote:
> Free Electrons is now Bootlin.
>
> Signed-off-by: Boris Brezillon
> ---
> Note that I'm planning to take this patch through the MTD tree.
Applied to the nand/next branch of the MTD tree.
>
On Fri, 3 Aug 2018 09:23:05 +0200
Peter Rosin wrote:
> Hi!
>
> This is perhaps not a true resend in that these three patches were
> originally in a larger series [1], and the series have been rebased
> to v4.18-rc6. However, I did ask that these three patches should be
> considered separately.
On Fri, 27 Jul 2018 13:55:03 -0700
Eric Anholt wrote:
> Boris Brezillon writes:
>
> > When there's no scaling requested ->is_unity should be true no matter
> > the format.
> >
> > Also, when no scaling is requested and we have a multi-planar YUV
> &g
On Fri, 27 Jul 2018 13:46:31 -0700
Eric Anholt wrote:
> Boris Brezillon writes:
>
> > From: Eric Anholt
> >
> > X/Y positioning of T-format buffers is quite tricky and the current
> > implementation was failing to position a plane using this format
> > cor
1101 - 1200 of 1788 matches
Mail list logo
