Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-06 Thread Boris Brezillon
On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: > +#ifdef CONFIG_LOCKDEP > +typedef struct lockdep_map *lockdep_map_p; > +#define drm_gpuva_manager_ext_assert_held(mgr) \ > + lockdep_assert(lock_is_held((mgr)->ext_lock) != LOCK_STATE_NOT_HELD) > +/** > + * drm_gpuva_m

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Boris Brezillon
On Thu, 6 Jul 2023 20:26:42 +0200 Boris Brezillon wrote: > On Fri, 30 Jun 2023 00:25:18 +0200 > Danilo Krummrich wrote: > > > +#ifdef CONFIG_LOCKDEP > > +typedef struct lockdep_map *lockdep_map_p; > > +#define drm_gpuva_manager_ext_assert_held(mgr)

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Boris Brezillon
On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: > +/** > + * drm_gpuva_for_each_va_range - iternator to walk over a range of > &drm_gpuvas > + * @va__: &drm_gpuva structure to assign to in each iteration step > + * @mgr__: &drm_gpuva_manager to walk over > + * @start__: starting offse

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-07 Thread Boris Brezillon
On Fri, 7 Jul 2023 14:41:23 +0200 Danilo Krummrich wrote: > >> + va__ && (va__->va.addr < (end__)) && \ > >> + !list_entry_is_head(va__, &(mgr__)->rb.list, rb.entry); \ > >> + va__ = list_next_entry(va__, rb.entry)) > > > > If you define: > > > > static inline struct drm_gpu

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Boris Brezillon
Hi Dmitry, On Mon, 17 Jul 2023 09:52:54 +0300 Dmitry Osipenko wrote: > Panfrost IRQ handler may stuck for a long time, for example this happens > when there is a bad HDMI connection and HDMI handler takes a long time to > finish processing, holding Panfrost. Make Panfrost's job timeout handler >

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Boris Brezillon
On Mon, 17 Jul 2023 10:20:02 +0300 Dmitry Osipenko wrote: > Hi, > > On 7/17/23 10:05, Boris Brezillon wrote: > > Hi Dmitry, > > > > On Mon, 17 Jul 2023 09:52:54 +0300 > > Dmitry Osipenko wrote: > > > >> Panfrost IRQ handler may stuck for

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Boris Brezillon
On Mon, 17 Jul 2023 09:06:56 +0100 Steven Price wrote: > On 17/07/2023 08:49, Boris Brezillon wrote: > > On Mon, 17 Jul 2023 10:20:02 +0300 > > Dmitry Osipenko wrote: > > > >> Hi, > >> > >> On 7/17/23 10:05, Boris Brezillon wrote: > >

Re: [PATCH v1] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-07-17 Thread Boris Brezillon
On Mon, 17 Jul 2023 11:15:44 +0300 Dmitry Osipenko wrote: > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > R

[PATCH] drm/sun4i: Check that the plane coordinates are not negative

2016-10-03 Thread Boris Brezillon
On Mon, 3 Oct 2016 14:58:11 +0200 Maxime Ripard wrote: > Hi Boris, > > On Fri, Sep 30, 2016 at 06:08:26PM +0200, Boris Brezillon wrote: > > On Fri, 30 Sep 2016 16:33:20 +0200 > > Maxime Ripard wrote: > > > > > Our planes cannot be set at negative c

Re: [Intel-gfx] [PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes.

2017-03-29 Thread Boris Brezillon
gt; > > intel_dp.c however ignores the force flag, so still lock > > connection_mutex there if needed. > > > > Signed-off-by: Maarten Lankhorst > > Cc: Boris Brezillon > > Cc: Manasi Navare > > Hm only noticed this now, but mixing up force with the

Re: [PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes, v4.

2017-04-10 Thread Boris Brezillon
fy the locking situation. (danvet) Maybe this is something DRM-specific, but usually we put the changelog after the '---' to avoid having it in the final commit. Same goes for the ", v4" suffix in the commit title, it should be '[PATCH vX] '. > > Signed-off-by: Ma

[PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

2017-04-11 Thread Boris Brezillon
in vc4_hdmi_encoder_disable(). Note that the sequencing imposed by the IP requires that we move vc4_hdmi_encoder_mode_set() code into vc4_hdmi_encoder_enable(). Signed-off-by: Boris Brezillon --- Hi Eric, As for the previous submission, I first send a preliminary version of the patch for

Re: [PATCH] drm/vc4: Allow using more than 256MB of CMA memory.

2017-04-14 Thread Boris Brezillon
ake sure the memory used by the tile binner (still have to look at what a tile binner is :-)) does not cross a 256MB. So, not sure my review has a real value here, but Reviewed-by: Boris Brezillon > > Signed-off-by: Eric Anholt > --- > drivers/gpu/drm/vc4/vc4_drv.h | 28

Re: [RFC PATCH v3 0/6] Introduce writeback connectors

2017-04-14 Thread Boris Brezillon
Hi Brian, On Fri, 25 Nov 2016 16:48:58 + Brian Starkey wrote: > Hi, > > This is v3 of my series introducing a new connector type: > DRM_MODE_CONNECTOR_WRITEBACK > See v1 and v2 here: [1] [2] > > Writeback connectors are used to expose the memory writeback engines > found in some display c

Re: [PATCH 6/6] drm: mali-dp: Add writeback connector

2017-04-14 Thread Boris Brezillon
On Fri, 25 Nov 2016 16:49:04 + Brian Starkey wrote: > +static int > +malidp_mw_encoder_atomic_check(struct drm_encoder *encoder, > +struct drm_crtc_state *crtc_state, > +struct drm_connector_state *conn_state) > +{ > + struct malidp_

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-14 Thread Boris Brezillon
On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index b5c6a8e..6bbd93f 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -86,6 +86,7 @@ struct drm_conn_prop_en

Re: [PATCH 2/6] drm: writeback: Add out-fences for writeback connectors

2017-04-14 Thread Boris Brezillon
On Fri, 25 Nov 2016 16:49:00 + Brian Starkey wrote: > Add the OUT_FENCE_PTR property to writeback connectors, to enable > userspace to get a fence which will signal once the writeback is > complete. It is not allowed to request an out-fence without a > framebuffer attached to the connector. >

Re: [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

2017-04-14 Thread Boris Brezillon
On Fri, 14 Apr 2017 11:20:52 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > The HDMI driver is currently enabling all clks and probe time and keep > > the power-domain connected to the HDMI encoder enabled. > > How about "The HDMI driver is currently

Re: [PATCH] drm: atmel-hlcdc: Uninitialized return in atmel_hlcdc_create_outputs()

2017-04-18 Thread Boris Brezillon
13567 ("drm: convert drivers to use > drm_of_find_panel_or_bridge") > Signed-off-by: Dan Carpenter Acked-by: Boris Brezillon Daniel, should I directly apply this patch to drm-misc-next-fixes or should I wait for someone else to take it? > > diff --git a/drivers/gpu/drm/atmel-hl

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-18 Thread Boris Brezillon
Hi Brian, On Tue, 18 Apr 2017 18:34:43 +0100 Brian Starkey wrote: > >> @@ -214,6 +214,19 @@ struct drm_connector_state { > >>struct drm_encoder *best_encoder; > >> > >>struct drm_atomic_state *state; > >> + > >> + /** > >> + * @writeback_job: Writeback job for writeback connectors > >

Re: [PATCH 1/6] drm: Add writeback connector type

2017-04-19 Thread Boris Brezillon
On Wed, 19 Apr 2017 10:51:23 +0100 Brian Starkey wrote: > On Tue, Apr 18, 2017 at 09:57:17PM +0200, Boris Brezillon wrote: > >Hi Brian, > > > >On Tue, 18 Apr 2017 18:34:43 +0100 > >Brian Starkey wrote: > > > >> >> @@ -214,6 +214,19 @@ str

[PULL] drm/atmel-hlcdc: Changes for 4.11

2017-01-30 Thread Boris Brezillon
x27;s registration time instead of waiting for the connector status change. Boris Brezillon (1): drm/atmel-hlcdc: Rework the fbdev creation logic drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 18 +++--- 1 file chang

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Boris Brezillon
Hi Daniel, On Thu, 26 Jan 2017 18:08:42 +0100 Daniel Vetter wrote: > Hi all, > > We've discussed this a bit at LCA (with Dave and Eric), and it's > probably best if I just summarize all the questions and opens and > throw them out here for discussions: > > - When's a driver small enough for a

[PATCH] drm/atmel-hlcdc: Simplify the HLCDC layer logic

2017-02-06 Thread Boris Brezillon
leading to a -EBUSY error) which I failed to clearly identify. Signed-off-by: Boris Brezillon --- Hi Daniel, You might not remember, but this is something you asked me to do a while ago, and it's finally there. This patch reworks the Atmel HLCDC plane logic to get rid of all the complexity i

Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Boris Brezillon
t in the driver > code becomes redundant and can be removed now. > > Signed-off-by: Shawn Guo > Cc: Alexey Brodkin > Cc: Liviu Dudau > Cc: Mali DP Maintainers > Cc: Russell King > Cc: Boris Brezillon Acked-by: Boris Brezillon > Cc: Inki Dae > Cc: Stefan Agner

Re: [PATCH v3 07/23] drm: atmel: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Boris Brezillon
; > Signed-off-by: Shawn Guo > Cc: Boris Brezillon Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 21 + > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 21 - > 2 files changed, 21 insertions(+), 21 de

[PATCH v2] drm/atmel-hlcdc: Simplify the HLCDC layer logic

2017-02-10 Thread Boris Brezillon
leading to a -EBUSY error) which I failed to clearly identify. Signed-off-by: Boris Brezillon --- Hi Daniel, I intentionally dropped your ack, since inheriting from atmel_hlcdc_layer is implying a lot of changes. Regards, Boris Changes in v2: - make atmel_hlcdc_plane inherit from atmel_h

Re: [PATCH v2 5/6] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-13 Thread Boris Brezillon
On Thu, 9 Feb 2017 13:05:57 -0600 Rob Herring wrote: > Similar to the previous commit, convert drivers open coding OF graph > parsing to use drm_of_find_panel_or_bridge instead. > > This changes some error messages to debug messages (in the graph core). > Graph connections are often "no connect

Re: [PATCH 2/3] drm/vc4: Add HDMI audio support

2017-02-24 Thread Boris Brezillon
Hi Eric, On Tue, 7 Feb 2017 13:07:02 -0800 Eric Anholt wrote: > +static int vc4_hdmi_audio_init(struct vc4_hdmi *hdmi) > +{ > + struct snd_soc_dai_link *dai_link = &hdmi->audio.link; > + struct snd_soc_card *card = &hdmi->audio.card; > + struct device *dev = &hdmi->pdev->dev; > +

Re: [PATCH v2] drm/atmel-hlcdc: Simplify the HLCDC layer logic

2017-02-28 Thread Boris Brezillon
Hi Eric, On Mon, 27 Feb 2017 14:30:13 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > An HLCDC layers in Atmel's nomenclature is either a DRM plane or a 'Post > > Processing Layer' which can be used to output the results of the HLCDC &

Re: [PATCH v2 2/3] drm/vc4: Add HDMI audio support

2017-02-28 Thread Boris Brezillon
lsalib will format-convert for us. > > This patch is the combined work of Eric Anholt (initial register setup > with a separate dmaengine driver and using simple-audio-card) and > Boris Brezillon (moving it all into HDMI, massive debug to get it > actually working), and which Eric has

[maintainers-tools] dim: Clarify how to proceed when adding drm-xxx remotes

2017-02-28 Thread Boris Brezillon
through SSH. Signed-off-by: Boris Brezillon --- dim.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/dim.rst b/dim.rst index 911b4666b4aa..bbb1d15a6d4b 100644 --- a/dim.rst +++ b/dim.rst @@ -54,6 +54,13 @@ This will also check out the latest maintainer-tools branches, so please replace

[PATCH] drm/atmel-hlcdc: Rework the fbdev creation logic

2016-11-28 Thread Boris Brezillon
dev creation (polling period = 10 seconds). Signed-off-by: Boris Brezillon Reported-by: Alex Vazquez --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/

[PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code

2016-11-29 Thread Boris Brezillon
the encoder and optional previous bridge to perform that task, > update all the callers. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 4 +- For atmel-hlcdc Acked-by: Boris Brezillon > drivers/gpu/drm/bridge/an

Re: [PATCH 2/2] drm/vc4: Add get/set tiling ioctls.

2017-06-13 Thread Boris Brezillon
Hi Eric, On Wed, 7 Jun 2017 17:13:36 -0700 Eric Anholt wrote: > This allows mesa to set the tiling format for a BO and have that > tiling format be respected by mesa on the other side of an > import/export (and by vc4 scanout in the kernel), without defining a > protocol to pass the tiling thro

Re: [PATCH 1/2] drm/vc4: Add T-format scanout support.

2017-06-13 Thread Boris Brezillon
a RPi3, we go from about 15% of system memory bandwidth > with linear to about 20% with tiled. However, for X11 this still ends > up being a huge performance win in active usage. > > This patch doesn't yet handle src_x/src_y offsetting within the tiled > buffer. However, we fai

Re: [PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

2017-06-13 Thread Boris Brezillon
+Gustavo On Tue, 06 Jun 2017 13:27:09 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > The VC4 KMS driver is implementing its own ->atomic_commit() but there > > are a few generic helpers we can use instead of open-coding the logic. > > > &g

Re: Color lookup support for the atmel-hlcdc driver

2017-06-13 Thread Boris Brezillon
Hi Peter, On Tue, 13 Jun 2017 16:34:25 +0200 Peter Rosin wrote: > Hi! > > I need color lookup support for the atmel-hlcdc driver, and had a peek > at the code. I also looked at the drivers/gpu/drm/stm driver and came > up with the below diff. It compiles, but I have not booted it for the > simp

Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

2017-06-15 Thread Boris Brezillon
On Thu, 15 Jun 2017 11:24:13 +0200 Peter Rosin wrote: > From: Peter Rosin > > Remove the layer. Duh. It was present in the datasheet I had. Just downloaded last version of the datasheet and it's no longer there. Nicolas, there's still a reference to OVR2 in the block diagram (Section "31.3 Bl

Re: Color lookup support for the atmel-hlcdc driver

2017-06-15 Thread Boris Brezillon
On Thu, 15 Jun 2017 11:54:29 +0200 Peter Rosin wrote: > On 2017-06-13 17:30, Boris Brezillon wrote: > > Hi Peter, > > > > On Tue, 13 Jun 2017 16:34:25 +0200 > > Peter Rosin wrote: > > > >> Hi! > >> > >> I need color lookup support

Re: Color lookup support for the atmel-hlcdc driver

2017-06-15 Thread Boris Brezillon
On Thu, 15 Jun 2017 13:47:35 +0200 Peter Rosin wrote: > On 2017-06-15 12:15, Boris Brezillon wrote: > > On Thu, 15 Jun 2017 11:54:29 +0200 > > Peter Rosin wrote: > > > >> On 2017-06-13 17:30, Boris Brezillon wrote: > >>> Hi Peter, > >>>

Re: [PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

2017-06-16 Thread Boris Brezillon
On Thu, 15 Jun 2017 16:33:11 -0700 Eric Anholt wrote: > Eric Anholt writes: > > > [ Unknown signature status ] > > Boris Brezillon writes: > > > >> On Tue, 06 Jun 2017 13:27:09 -0700 > >> Eric Anholt wrote: > >> > >>>

Re: [PATCH 2/7] drm/vc4: Fix vblank handling

2017-06-16 Thread Boris Brezillon
On Thu, 15 Jun 2017 16:30:58 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > There are two problems related to VBLANK handling in the current CRTC > > driver: > > > > * VBLANK events are missed when the CRTC is being disabled because the > > driv

[PATCH v2] drm/vc4: Send a VBLANK event when disabling a CRTC

2017-06-16 Thread Boris Brezillon
VBLANK events are missed when the CRTC is being disabled because the driver does not wait till the end of the frame before stopping the HVS and PV blocks. In this case, we should explicitly issue a VBLANK event if there's one waiting. Signed-off-by: Boris Brezillon --- Changes in v2: -

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-16 Thread Boris Brezillon
Hi Peter, On Fri, 16 Jun 2017 11:12:25 +0200 Peter Rosin wrote: > All layers of chips support this, the only variable is the base address > of the lookup table in the register map. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 48 > +

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-16 Thread Boris Brezillon
Hi Peter, On Fri, 16 Jun 2017 17:54:04 +0200 Peter Rosin wrote: > On 2017-06-16 12:01, Boris Brezillon wrote: > > Hi Peter, > > > > On Fri, 16 Jun 2017 11:12:25 +0200 > > Peter Rosin wrote: > > > >> All layers of chips support this, the only varia

Re: [RFC PATCH 1/3] atmel-hlcdc: add support for 8-bit color lookup table mode

2017-06-16 Thread Boris Brezillon
Le Sat, 17 Jun 2017 00:46:12 +0200, Peter Rosin a écrit : > Hm, it's probably too late to do it here. Planes have already been > enabled and the engine may have started to fetch data and do the > composition. You could do that in ->update_plane() [1], and make it a > per-plane

Re: [PATCH v3 0/3] drm: atmel-hlcdc: clut support

2017-06-19 Thread Boris Brezillon
+Alexandre and Nicolas Hi Peter, Can you please Cc at91 maintainers next time? On Mon, 19 Jun 2017 09:44:23 +0200 Peter Rosin wrote: > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. > > I have now tested patch 1 with the below program (modeset.c > adapte

Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

2017-06-19 Thread Boris Brezillon
On Tue, 13 Jun 2017 11:02:47 +0200 Andrzej Hajda wrote: > Hi, > > Just spotted this thread. > > On 06.06.2017 14:58, Tomi Valkeinen wrote: > > On 06/06/17 15:48, Boris Brezillon wrote: > > > >> Okay. Thanks for the clarification. Can you confi

Re: [PATCH v3 2/3] drm/fb-cma-helper: expose more of fb cma guts

2017-06-19 Thread Boris Brezillon
Le Mon, 19 Jun 2017 09:44:25 +0200, Peter Rosin a écrit : > DRM drivers supporting clut may want a convenient way to only use > non-default .gamma_set and .gamma_get ops in the drm_fb_helper_funcs > in order to avoid the following > > /* >* The driver really shouldn't advertise pse

Re: [PATCH v3 0/3] drm: atmel-hlcdc: clut support

2017-06-19 Thread Boris Brezillon
Le Mon, 19 Jun 2017 09:44:23 +0200, Peter Rosin a écrit : > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. > > I have now tested patch 1 with the below program (modeset.c > adapted from https://github.com/dvdhrm/docs/tree/master/drm-howto > to use an 8-bit

Re: [PATCH] drm: More links for gamma support helpers

2017-06-20 Thread Boris Brezillon
t; properly. > > Cc: Peter Rosin > Cc: Boris Brezillon Reviewed-by: Boris Brezillon > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_color_mgmt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_color_mgmt.c > b/dri

Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending().

2017-06-21 Thread Boris Brezillon
Le Wed, 21 Jun 2017 11:50:02 -0700, Eric Anholt a écrit : > It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic > drm_atomic_helper_commit() behavior") > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_crtc.c

Re: [PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 08:37:55 +0200 Daniel Vetter wrote: > On Thu, Jun 22, 2017 at 12:34:36AM +0800, kbuild test robot wrote: > > Hi Peter, > > > > [auto build test ERROR on drm/drm-next] > > [also build test ERROR on next-20170621] > > [cannot apply to v4.12-rc6] > > [if your patch is applied to

Re: [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode.

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 11:50:00 -0700 Eric Anholt wrote: > We should allow SIGIO and things to interrupt us before we get to the > no-error stage of the commit process. This code is effectively copied > from drm_atomic_helper_commit(). > > Signed-off-by: Eric Anholt Reviewed-by:

Re: [PATCH 1/4] drm/vc4: Hook up plane prepare_fb to lookup dma-buf reservations.

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 11:49:59 -0700 Eric Anholt wrote: > This way drm_atomic_helper_wait_for_fences() will actually do > something. The vc4_seqno_cb has been doing the fence waits on V3D > manually, so far. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > ---

Re: [PATCH 3/4] drm/vc4: Use the atomic state's commit workqueue.

2017-06-22 Thread Boris Brezillon
On Wed, 21 Jun 2017 11:50:01 -0700 Eric Anholt wrote: > Now that we're using the atomic helpers for fence waits, we can use > the same codepath as drm_atomic_helper_commit() does for async, > getting rid of our custom vc4_commit struct. > > Signed-off-by: Eric Anholt

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 13:47:43 +0530 Archit Taneja wrote: > On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: > > 2017-06-20 19:31 GMT+02:00 Eric Anholt : > >> Archit Taneja writes: > >> > >>> On 06/16/2017 08:13 PM, Eric Anholt wrote: > Archit Taneja writes: > > > On 06/16/2

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 14:29:07 +0200 Andrzej Hajda wrote: > On 22.06.2017 11:23, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 13:47:43 +0530 > > Archit Taneja wrote: > > > >> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: > >>> 2017-06-20 19:31

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 15:16:47 +0200 Andrzej Hajda wrote: > On 22.06.2017 14:41, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 14:29:07 +0200 > > Andrzej Hajda wrote: > > > >> On 22.06.2017 11:23, Boris Brezillon wrote: > >>> On Thu, 22 Jun 2017

[PATCH] drm/vc4: Fix VBLANK handling in crtc->enable() path

2017-06-22 Thread Boris Brezillon
When we are enabling a CRTC, drm_crtc_vblank_get() is called before drm_crtc_vblank_on(), which is not supposed to happen (hence the WARN_ON() in the code). To solve the problem, we delay the 'update display list' operation after the CRTC is actually enabled. Signed-off-by: Boris

Re: [PATCH v5 0/2] drm: atmel-hlcdc: clut support

2017-06-22 Thread Boris Brezillon
On Thu, 22 Jun 2017 07:03:09 +0200 Peter Rosin wrote: > Hi! > > This series adds support for an 8-bit clut mode in the atmel-hlcdc > driver. Applied to drm-misc-next. Thanks, Boris > > Changes since v4: > > - Added .clut_offset for overlay2 at 0xe00 for sama5d4 (unconfirmed if 0xe00 > is

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-23 Thread Boris Brezillon
On Fri, 23 Jun 2017 09:22:15 +0200 Andrzej Hajda wrote: > On 22.06.2017 15:34, Boris Brezillon wrote: > > On Thu, 22 Jun 2017 15:16:47 +0200 > > Andrzej Hajda wrote: > > > >> On 22.06.2017 14:41, Boris Brezillon wrote: > >>> On Thu, 22 Jun 2017

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-28 Thread Boris Brezillon
> drivers/gpu/drm/arm/malidp_crtc.c | 5 ++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 ++-- For atmel-hlcdc: Acked-by: Boris Brezillon ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable()

2017-06-28 Thread Boris Brezillon
tmel_hlcdc_crtc.c | 5 +++-- For atmel-hlcdc: Acked-by: Boris Brezillon ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified

2017-07-03 Thread Boris Brezillon
On Mon, 3 Jul 2017 11:42:10 +0200 Peter Rosin wrote: > At init and if the gamma_lut property is ever removed, the clut > registers must be programmed with a default gamma ramp instead of > being left in some unknown state. > > Fixes: 364a7bf574eb ("drm: atmel-hlcdc: add support for 8-bit color

Re: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified

2017-07-03 Thread Boris Brezillon
On Mon, 3 Jul 2017 13:53:28 +0200 Peter Rosin wrote: > On 2017-07-03 13:31, Boris Brezillon wrote: > > On Mon, 3 Jul 2017 11:42:10 +0200 > > Peter Rosin wrote: > > > >> At init and if the gamma_lut property is ever removed, the clut > >> registers

Re: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified

2017-07-03 Thread Boris Brezillon
Le Mon, 3 Jul 2017 22:59:36 +0200, Peter Rosin a écrit : > On 2017-07-03 14:02, Boris Brezillon wrote: > > On Mon, 3 Jul 2017 13:53:28 +0200 > > Peter Rosin wrote: > > > >> On 2017-07-03 13:31, Boris Brezillon wrote: > >>> On Mon, 3 Jul 20

Re: [PATCH 08/16] drm/atmel-hlcdec: Use for_each_new_connector_in_state

2017-07-12 Thread Boris Brezillon
On Wed, 12 Jul 2017 10:13:36 +0200 Maarten Lankhorst wrote: > for_each_obj_in_state is about to be removed, so use the new iterator > macros. > > Signed-off-by: Maarten Lankhorst > Cc: Boris Brezillon Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/a

Re: [PATCH] MAINTAINERS: Update git entries for drivers in drm-misc

2017-02-28 Thread Boris Brezillon
On Tue, 28 Feb 2017 20:36:57 +0100 Daniel Vetter wrote: > It's still just an experiment, but one lesson learned from drm-misc is > that not updating MAINTAINERS just leads to confusion. And this is > easy to revert. > > Cc: Boris Brezillon Acked-by: Boris Brezillon

[PATCH] drm/atmel-hlcdc: Fix suspend/resume implementation

2017-03-01 Thread Boris Brezillon
: Boris Brezillon --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 33 -- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 31 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 8 --- 3 files changed, 21 insertions(+), 51 deletions(-) diff

Re: [PATCH 1/2 RESEND] drm/vc4: Fulfill user BO creation requests from the kernel BO cache.

2017-03-02 Thread Boris Brezillon
c-add-add-1 by > -1.44989% +/- 0.862891% (n=28, 1 outlier removed from each that > appeared to be other system noise) > > Note that there's an intel-gpu-tools test to check for the proper > zeroing behavior here, which we continue to pass. > > Signed-off-by: Eric Anholt Reviewed

Re: [PATCH 2/2 RESEND] drm/vc4: Fix OOPSes from trying to cache a partially constructed BO.

2017-03-02 Thread Boris Brezillon
l would OOPS. > > Signed-off-by: Eric Anholt > Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_bo.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/dri

Re: [PATCH] drm/atmel-hlcdc: Rework the fbdev creation logic

2017-03-02 Thread Boris Brezillon
On Thu, 2 Mar 2017 17:04:51 +0100 Richard Genoud wrote: > On 28/11/2016 16:01, Boris Brezillon wrote: > > Now that we wait for DRM panels to be available before registering the > > DRM device (returning -EPROBE_DEFER if the panel has not been probed > > yet), we no longer

Re: [PATCH] drm/atmel-hlcdc: Fix suspend/resume implementation

2017-03-16 Thread Boris Brezillon
On Wed, 1 Mar 2017 13:31:01 +0100 Boris Brezillon wrote: > The current suspend resume implementation is assuming register values are > kept when entering suspend, which is no longer the case with the > suspend-to-RAM on the sama5d2. > > While at it, switch to the generic in

Re: [PATCH v2] drm/atmel-hlcdc: Simplify the HLCDC layer logic

2017-03-16 Thread Boris Brezillon
On Fri, 10 Feb 2017 19:07:45 +0100 Boris Brezillon wrote: > An HLCDC layers in Atmel's nomenclature is either a DRM plane or a 'Post > Processing Layer' which can be used to output the results of the HLCDC > composition in a memory buffer. > > atmel_hlcdc_laye

Re: [PATCH] drm-misc: Next phase in small drivers in drm-misc

2017-03-29 Thread Boris Brezillon
> Cc: Sean Paul > Cc: Archit Taneja > Cc: Gerd Hoffmann > Cc: Boris Brezillon Acked-by: Boris Brezillon > Cc: Neil Armstrong > Cc: Mark Yao > Cc: Eric Anholt > Cc: Shawn Guo > Cc: Dave Airlie > Signed-off-by: Daniel Vetter > --- > drm-misc.rst | 4

Re: [PATCH 1/6] drm: Add writeback connector type

2017-05-05 Thread Boris Brezillon
On Fri, 25 Nov 2016 16:48:59 + Brian Starkey wrote: > +/** > + * drm_writeback_connector_init - Initialize a writeback connector and its > properties > + * @dev: DRM device > + * @wb_connector: Writeback connector to initialize > + * @funcs: Connector funcs vtable > + * @formats: Array of su

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

2017-05-11 Thread Boris Brezillon
> > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon A few comments below (no need to address them, those are just minor things that can be fixed later on, or things I'm not comfortable with but cannot be addressed easily). > --- > > This patch is just a proposal fo

Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

2017-05-11 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:27 -0700 Eric Anholt wrote: > drm_encoder_cleanup() finishes with memsetting it to 0, already. > > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +--- > 1 file changed,

Re: [PATCH v2 1/7] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-12 Thread Boris Brezillon
way. > > v2: Fix build with CONFIG_DRM=m, drop "dev" argument that should just > be the panel's dev, move kerneldoc up a level and document > _remove(). > > Signed-off-by: Eric Anholt > Acked-by: Daniel Vetter Reviewed-by: Boris Brezillon >

Re: [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.

2017-05-12 Thread Boris Brezillon
"dev" argument. > > Signed-off-by: Eric Anholt > Acked-by: Daniel Vetter Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/Kconfig | 2 +- > drivers/gpu/drm/vc4/vc4_dsi.c | 154 > ++ > 2 files changed, 21 insertio

Re: [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:24 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone, while allowing for bridges to > be connected in the display chain. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/v

Re: [PATCH v2 4/7] drm/mediatek: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
ould be when you do things that require the link to be > brought up), but there may be issues here. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > > Note that I haven't tested this change, and am not committed to this > patch. It's ju

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-12 Thread Boris Brezillon
On Thu, 11 May 2017 11:31:26 -0700 Eric Anholt wrote: > Another 100 lines of boilerplate gone. Bridges aren't supported yet, > but will be trivial to add later. > > Signed-off-by: Eric Anholt > --- > [...] > @@ -1082,28 +993,13 @@ int ltdc_load(struct drm_device *ddev) > > DRM_INFO(

[PATCH] drm/atmel-hlcdc: Fix output initialization

2017-05-18 Thread Boris Brezillon
atmel_hlcdc_rgb_output allocation after the panel/bridge detection to avoid useless allocations. Reported-by: Alexandre Belloni Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge") Signed-off-by: Boris Brezillon --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_out

Re: [PATCH v5 0/2] drm: Introduce writeback connectors

2017-05-23 Thread Boris Brezillon
Hi Liviu, On Mon, 15 May 2017 18:20:55 +0100 Liviu Dudau wrote: > Hi, > > This is v5 of the writeback connector series. Boris Brezillon thought > that having to explicitly instantiate an encoder when using > drm_writeback_connector > is a bit too cumbersome, so I'm p

Re: [PATCH v5 0/2] drm: Introduce writeback connectors

2017-05-23 Thread Boris Brezillon
On Tue, 23 May 2017 15:38:42 +0100 Liviu Dudau wrote: > On Tue, May 23, 2017 at 04:33:55PM +0200, Boris Brezillon wrote: > > Hi Liviu, > > Hi Boris, > > > > > On Mon, 15 May 2017 18:20:55 +0100 > > Liviu Dudau wrote: > > > > > Hi,

Re: [PATCH 13/37] drm: better document how to send out the crtc disable event

2017-05-24 Thread Boris Brezillon
On Wed, 24 May 2017 16:51:48 +0200 Daniel Vetter wrote: > The kernel doc explained what needs to happen, but not how to most > easily accomplish that using the functions. Fix that. > > Cc: Boris Brezillon > Signed-off-by: Daniel Vetter Reviewed-by: Boris Brezillon >

Re: [PATCH 17/37] drm/atmel: Drop drm_vblank_cleanup

2017-05-24 Thread Boris Brezillon
> > Cc: Boris Brezillon > Signed-off-by: Daniel Vetter Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > b/drivers/gpu/drm/atmel-h

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-30 Thread Boris Brezillon
Hi Philippe, Le Tue, 30 May 2017 16:55:42 +, Philippe CORNU a écrit : > Hi Eric, > > I took your patch for the panel-bridge and it works perfectly in both > DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-) I still don't understand how it can work without a call to drm_

Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper.

2017-05-31 Thread Boris Brezillon
Hi Archit, Le Wed, 31 May 2017 13:31:16 +0530, Archit Taneja a écrit : > Hi Boris, > > On 05/31/2017 11:56 AM, Boris Brezillon wrote: > > Hi Philippe, > > > > Le Tue, 30 May 2017 16:55:42 +, > > Philippe CORNU a écrit : > > > >> Hi Eric,

Re: [PATCH] drm/vc4: Mark the device as active when enabling runtime PM.

2017-06-02 Thread Boris Brezillon
w using more than 256MB of CMA memory.") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_v3d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c > index e3d5c59dbd4a..825a8462a63b 100644

[PATCH 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings

2017-06-02 Thread Boris Brezillon
Document the bindings used for the Cadence DSI bridge. Signed-off-by: Boris Brezillon --- .../bindings/display/bridge/cdns,dsi.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt diff

[PATCH 1/2] drm/bridge: Add Cadence DSI driver

2017-06-02 Thread Boris Brezillon
Add a driver for Cadence DPI -> DSI bridge. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/bridge/Kconfig|7 + drivers/gpu/drm/bridge/Makefile |1 + drivers/gpu/drm/bridge/cdns-dsi.c | 1087 + 3 files changed, 1095 insertions(+) create m

[PATCH 2/7] drm/vc4: Fix vblank handling

2017-06-02 Thread Boris Brezillon
nabled. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_crtc.c | 80 ++ 1 file changed, 57 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index d86c8cce3182..df1d81533076 100644 --- a/

[PATCH 1/7] drm: Add drm_atomic_helper_wait_for_flip_done()

2017-06-02 Thread Boris Brezillon
Add an helper to wait for all page flips of an atomic state to be done. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/drm_atomic_helper.c | 30 ++ include/drm/drm_atomic_helper.h | 3 +++ 2 files changed, 33 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 5/7] drm/vc4: Add support for the TXP (transposer) block

2017-06-02 Thread Boris Brezillon
s completely bypassed. In order to make things work, we have to detect when the TXP is enabled, avoid enabling the PV when this is the case, and generate fake VBLANK events when the TXP is done writing the frame back to memory. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/Makefile

[PATCH 4/7] drm/vc4: Use drm_atomic_helper_wait_for_flip_done()

2017-06-02 Thread Boris Brezillon
event' problem that can arise when the CRTC is configured in oneshot mode (only a single frame is generated and the CRTC is immediately paused after this frame). Note that this oneshot mode will be used for the writeback connector feature. Signed-off-by: Boris Brezillon --- drivers/g

[PATCH 3/7] drm/vc4: Mimic drm_atomic_helper_commit() behavior

2017-06-02 Thread Boris Brezillon
The VC4 KMS driver is implementing its own ->atomic_commit() but there are a few generic helpers we can use instead of open-coding the logic. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/vc4/vc4_kms.c | 38 -- 1 file changed, 12 insertions(+),

<    4   5   6   7   8   9   10   11   12   13   >