From: Tomi Valkeinen
Hi,
These add new pixel formats for Renesas V3U and V4H SoCs.
As the display pipeline is split between DRM and V4L2 components, this
series touches both subsystems. I'm sending all these together to
simplify review. If needed, I can later split this to V4L2 and DRM
Hi,
On 06/12/2022 19:39, Nicolas Dufresne wrote:
Hi,
Le mardi 06 décembre 2022 à 15:39 +0200, Tomi Valkeinen a écrit :
Add XBGR2101010, ABGR2101010 and BGRA1010102 formats.
Signed-off-by: Tomi Valkeinen
This patch is simply missing an update to
Documentation/userspace-api/media/v4l
Add Y210, Y212 and Y216 formats.
Signed-off-by: Tomi Valkeinen
---
.../media/v4l/pixfmt-packed-yuv.rst | 44 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 3 ++
include/uapi/linux/videodev2.h| 8
3 files changed, 55 insertions(+)
diff
V3U is actually gen 4 IP, like in V4H. Bumb up V3U gen in the
rcar_du_r8a779a0_info.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
b/drivers/gpu/drm/rcar-du
VI6_IP_VERSION_MODEL_VSPD_GEN4 as gen 4 in vsp1_device_info,
and update the code to correcly match for gen 4.
Signed-off-by: Tomi Valkeinen
---
drivers/media/platform/renesas/vsp1/vsp1_drv.c | 4 ++--
drivers/media/platform/renesas/vsp1/vsp1_hgo.c | 4 ++--
drivers/media/platform/renesas/vsp1
Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010 and Y210.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 24 +
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 49 +--
2 files changed, 71 insertions(+), 2 deletions(-)
diff
ad(dispc, DSS_SYSSTATUS)) &&
Reviewed-by: Tomi Valkeinen
Tomi
Hi,
On 19/11/2022 19:30, Aradhya Bhatia wrote:
Add support for the DSS controller on TI's new AM625 SoC in the tidss
driver.
The first video port (VP0) in am625-dss can output OLDI signals through
2 OLDI TXes. A 3rd output port has been added with "DISPC_VP_OLDI" bus
type.
DSS controllers befo
On 20/12/2022 16:24, Laurent Pinchart wrote:
Hi Tomi,
On Tue, Dec 20, 2022 at 04:12:29PM +0200, Tomi Valkeinen wrote:
On 19/12/2022 21:10, Laurent Pinchart wrote:
On Mon, Dec 19, 2022 at 04:01:33PM +0200, Tomi Valkeinen wrote:
Add XBGR2101010, ABGR2101010 and BGRA1010102 formats.
Signed-off
And if the same function is used for
am625, maybe rename the func to "_am6xx_".
Other than that:
Reviewed-by: Tomi Valkeinen
Tomi
On 19/12/2022 23:01, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Mon, Dec 19, 2022 at 04:01:35PM +0200, Tomi Valkeinen wrote:
V3U is actually gen4, not gen3. The same IP is also used in the
(not-yet-supported) V4H.
Change VI6_IP_VERSION_MODEL_VSPD_V3U to
On 19/12/2022 21:10, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Mon, Dec 19, 2022 at 04:01:33PM +0200, Tomi Valkeinen wrote:
Add XBGR2101010, ABGR2101010 and BGRA1010102 formats.
Signed-off-by: Tomi Valkeinen
---
.../userspace-api/media/v4l/pixfmt-rgb.rst| 194
Hi,
On 19/11/2022 19:30, Aradhya Bhatia wrote:
The newer version of DSS (AM625-DSS) has 2 OLDI TXes at its disposal.
These can be configured to support the following modes:
1. OLDI_SINGLE_LINK_SINGLE_MODE
Single Output over OLDI 0.
+--++-+ +---+
| ||
Add VI6_IP_VERSION_SOC_V4H so that we can identify V4H SoC.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
drivers/media/platform/renesas/vsp1/vsp1_regs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/renesas/vsp1/vsp1_regs.h
b/drivers/media
From: Tomi Valkeinen
Hi,
These add new pixel formats for Renesas V3U and V4H SoCs.
As the display pipeline is split between DRM and V4L2 components, this
series touches both subsystems. I'm sending all these together to
simplify review. If needed, I can later split this to V4L2 and DRM
dge/cadence/cdns-dsi-j721e.h | 16 ++
6 files changed, 125 insertions(+), 1 deletion(-)
create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.c
create mode 100644 drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.h
Reviewed-by: Tomi Valkeinen
Tomi
Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010, Y210 and
Y212.
Signed-off-by: Tomi Valkeinen
---
.../media/platform/renesas/vsp1/vsp1_pipe.c | 18 +++
.../media/platform/renesas/vsp1/vsp1_regs.h | 23
.../media/platform/renesas/vsp1/vsp1_rpf.c| 52
Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010, Y210 and
Y212.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 50 +--
2 files changed, 78 insertions(+), 2 deletions
VI6_IP_VERSION_MODEL_VSPD_GEN4 as gen 4 in vsp1_device_info,
and update the code to correctly match for gen 4.
Signed-off-by: Tomi Valkeinen
---
drivers/media/platform/renesas/vsp1/vsp1_drv.c | 4 ++--
drivers/media/platform/renesas/vsp1/vsp1_hgo.c | 4 ++--
drivers/media/platform/renesas/vsp1
Add Y210, Y212 and Y216 formats.
Signed-off-by: Tomi Valkeinen
---
.../media/v4l/pixfmt-packed-yuv.rst | 49 ++-
drivers/media/v4l2-core/v4l2-ioctl.c | 3 ++
include/uapi/linux/videodev2.h| 8 +++
3 files changed, 58 insertions(+), 2
Add XBGR2101010, ABGR2101010 and BGRA1010102 formats.
Signed-off-by: Tomi Valkeinen
---
.../userspace-api/media/v4l/pixfmt-rgb.rst| 194 ++
drivers/media/v4l2-core/v4l2-ioctl.c | 3 +
include/uapi/linux/videodev2.h| 3 +
3 files changed, 200
V3U is actually gen 4 IP, like in V4H. Bump up V3U gen in the
rcar_du_r8a779a0_info.
Signed-off-by: Tomi Valkeinen
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
lts
in calling bridge->funcs->hpd_enable() before the rest of the pipeline
was set up properly.
For the series:
Reviewed-by: Tomi Valkeinen
I've been using this series in my local branch for quite a while to fix
the HPD issues. Works for me.
I still think the "fix" aspect
On 05/01/2023 14:31, Dmitry Baryshkov wrote:
On 04/01/2023 11:05, Neil Armstrong wrote:
On 04/01/2023 08:29, Tomi Valkeinen wrote:
On 28/12/2022 23:58, Dmitry Baryshkov wrote:
On 02/11/2022 20:06, Dmitry Baryshkov wrote:
From all the drivers using drm_bridge_connector only iMX/dcss and
OMAP
On 26/12/2022 16:56, Laurent Pinchart wrote:
Hi Tomi,
(CC'ing Daniel and Dave)
On Wed, Dec 21, 2022 at 11:24:41AM +0200, Tomi Valkeinen wrote:
From: Tomi Valkeinen
Hi,
These add new pixel formats for Renesas V3U and V4H SoCs.
As the display pipeline is split between DRM and
On 05/04/2023 17:24, Jayesh Choudhary wrote:
In J721s2 EVM, DP0 HPD is not connected to correct HPD pin on SOC
which results in HPD detect as always connnected, so when display
is not connected driver continuously retries to read EDID and DPCD
registers.
Where is the DP0 HPD connected to? Nowhe
On 14/04/2023 18:10, Jayesh Choudhary wrote:
On 06/04/23 07:22, Laurent Pinchart wrote:
Hi Jayesh,
Thank you for the patch.
On Wed, Apr 05, 2023 at 07:54:40PM +0530, Jayesh Choudhary wrote:
From: Rahul T R
In J721S2 EVMs DP0 hpd is not connected to correct
hpd pin on SOC, to handle such c
/omapdrm/omap_drv.c
index 699ed814e021..fb403b44769c 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -6,6 +6,7 @@
#include
#include
+#include
#include
#include
Reviewed-by: Tomi Valkeinen
Tomi
t;fb);
+ if (fb)
+ drm_framebuffer_remove(fb);
drm_fb_helper_unprepare(helper);
kfree(fbdev);
Reviewed-by: Tomi Valkeinen
Tomi
On 30/03/2023 11:32, Thomas Zimmermann wrote:
Fbdev's framebuffer stores a pointer to the GEM object. Remove
struct omap_fbdev.exynos_gem, which contains the same value. No
Copy paste error? =)
Reviewed-by: Tomi Valkeinen
Tomi
functional changes.
Signed-off-by: Thomas Zimme
Is this line needed anymore? As you dropped the priv->fbdev assignment
in omap_fbdev_init(), it would look symmetrical to also drop this one.
I'm sure it doesn't hurt, just wondering if this is something drivers
are supposed to do, or is this just an extra line in the driver.
In either case:
Reviewed-by: Tomi Valkeinen
Tomi
this could be as well merged to the next patch, as this is such
a short one.
Reviewed-by: Tomi Valkeinen
Tomi
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/omapdrm/omap_fbdev.c | 33 +++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/driver
t(dev->fb_helper);
+
+ ret = drm_fb_helper_init(dev, fb_helper);
+ if (ret)
+ goto err_drm_err;
+
+ if (!drm_drv_uses_atomic_modeset(dev))
Why do we need this? omapdrm supports atomic.
That's my only real comment. Kernel test bot had one comment too. But
othe
Hi Thomas,
On 03/04/2023 11:24, Thomas Zimmermann wrote:
That's my only real comment. Kernel test bot had one comment too. But
other than that:
Reviewed-by: Tomi Valkeinen
I tested this series on TI DRA76 EVM, and worked fine for me.
That you so much.
I'm going to send out
Hi Thomas,
On 03/04/2023 13:40, Thomas Zimmermann wrote:
Convert omapdrm's fbdev code to struct drm_client. Replaces the current
ad-hoc integration. The conversion includes a number of cleanups. As
with most other drivers' fbdev emulation, fbdev in omapdrm is now just
another DRM client that run
On 12/04/2023 11:50, Laurent Pinchart wrote:
Hi Tony,
Thank you for the patch.
On Wed, Apr 12, 2023 at 10:39:53AM +0300, Tony Lindgren wrote:
We may not have dsi->dsidev initialized during probe, and that can
lead into various dsi related warnings as omap_dsi_host_detach() gets
called with dsi
nd 1 of clock output.
I think it should be explained that OLDI is not supported in this
version, but will be added later.
Other than that:
Reviewed-by: Tomi Valkeinen
Tomi
to reduce the required OLDI clock
output.
The second video port is same from AM65x DSS and it outputs DPI video
data. It can support 2K resolutions @ 60fps, independently.
Add the new controller's compatible and update descriptions.
Signed-off-by: Aradhya Bhatia
Reviewed-by: Tomi Valkeinen
Tomi
Add drm-misc as the git tree for tilcdc and omapdrm. Change Tomi's email
to point to ideasonboard.com instead of kernel.org.
Signed-off-by: Tomi Valkeinen
---
MAINTAINERS | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index aa0aa6c
On 16/06/2023 18:08, Aradhya Bhatia wrote:
This patch series adds a new compatible for the Display SubSystem (DSS)
controller on TI's AM625 SoC. It further adds the required support for
the same in the tidss driver.
The AM625-DSS is a newer version of the DSS from the AM65X version with
the majo
riant.
Signed-off-by: Uwe Kleine-König
---
drivers/gpu/drm/tidss/tidss_drv.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c
b/drivers/gpu/drm/tidss/tidss_drv.c
index 2dac8727d2f4..13177d58c8f9 1
negotiation can be added based on EDID data.
This patch adds the minimal required support to avoid failure
after moving to new connector model.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
You need to add your SoB to this and the other patches.
---
Notes:
changes from
On 09/05/2023 12:30, Aradhya Bhatia wrote:
Hi all,
I have picked up this long standing series from Nikhil Devshatwar[1].
This series moves the tidss to using new connectoe model, where the SoC
driver (tidss) creates the connector and all the bridges are attached
with the flag DRM_BRIDGE_ATTACH_
, ops: 0x0, OF:
/bus@f/i2c@2000/dsi@e:toshiba,tc358778
bridge[2] type: 0, ops: 0x3, OF:
/bus@f/i2c@2001/hdmi@48:lontium,lt8912b
bridge[3] type: 11, ops: 0x7, OF: /hdmi-connector:hdmi-connector
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/drm_bridge.c
, ops: 0x0, OF:
/bus@f/i2c@2000/dsi@e:toshiba,tc358778
bridge[2] type: 0, ops: 0x3, OF:
/bus@f/i2c@2001/hdmi@48:lontium,lt8912b
bridge[3] type: 11, ops: 0x7, OF: /hdmi-connector:hdmi-connector
Signed-off-by: Tomi Valkeinen
---
Changes in v2:
- Fixed compilation
On 25/07/2023 14:37, Laurent Pinchart wrote:
Hi Tomi,
Thank you for the patch.
On Fri, Jul 21, 2023 at 06:01:39PM +0300, Tomi Valkeinen wrote:
DRM bridges are not visible to the userspace and it may not be
immediately clear if the chain is somehow constructed incorrectly. I
have had two
, ops: 0x0, OF:
/bus@f/i2c@2000/dsi@e:toshiba,tc358778
bridge[2] type: 0, ops: 0x3, OF:
/bus@f/i2c@2001/hdmi@48:lontium,lt8912b
bridge[3] type: 11, ops: 0x7, OF: /hdmi-connector:hdmi-connector
Signed-off-by: Tomi Valkeinen
---
Changes in v3:
truct drm_minor;
struct drm_panel;
struct edid;
struct i2c_adapter;
@@ -949,4 +950,6 @@ static inline struct drm_bridge *drmm_of_get_bridge(struct
drm_device *drm,
}
#endif
+void drm_bridge_debugfs_init(struct drm_minor *minor);
+
#endif
---
base-commit: a0c64d153d687756c8719b8d10e609d62e1cb6fd
change-id: 20230721-drm-bridge-chain-debugfs-0bbc1522f57a
Best regards,
--
Tomi Valkeinen
s DSI HSW, HFP and VSDly calculations
- Adds DRM_BRIDGE_ATTACH_NO_CONNECTOR support
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (11):
drm/bridge: tc358768: Fix use of uninitialized variable
drm/bridge: tc358768: Fix bit updates
drm/bridge: tc358768: Cleanup PL
smatch reports:
drivers/gpu/drm/bridge/tc358768.c:223 tc358768_update_bits() error:
uninitialized symbol 'orig'.
Fix this by bailing out from tc358768_update_bits() if the
tc358768_read() produces an error.
Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-of
: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index bc97a837955b..b6
ingly, as it simplifies the PLL code.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index b668f77673c3..d5831a1236e9 1
Simplify the code by capturing the priv->dev value to dev variable, and
use it.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 41 ---
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
r with the documentation, change the 'dsibclk'
variable to 'hsbyteclk'. This also make it easier to visually separate
'dsibclk' and 'dsiclk' variables.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 48 +++
in a more human
consumable form.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index 9b633038af33..0ef51d04b
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 64 +++
1 file changed, 45 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index ea19de5509ed..a567f136ddc7 100644
--- a
The tc358768_ns_to_cnt() is, most likely, supposed to do a div-round-up
operation, but it misses subtracting one from the dividend.
Fix this by just using DIV_ROUND_UP().
Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/
p by just saying the periods are in picoseconds.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 60 +++
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.
uses. This
makes it much easier to work on the code when using the TC358768
documentation as a reference.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 45 +--
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu
ight cause a
regression.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 211 +-
1 file changed, 183 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index dc2241c18dde..ea
Fix various issues in lt8912b driver.
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (4):
drm/bridge: lt8912b: Fix bridge_detach
drm/bridge: lt8912b: Fix crash on bridge detach
drm/bridge: lt8912b: Manually disable HPD only if it was enabled
drm/bridge: lt8912b
quot;)
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c
b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 4eaea67fb71c..0e581f6e3c88 100644
-
HDMI bridge")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c
b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 9ee639e75a1c..03532efb893b 100644
--- a/drivers/gpu/
DMI bridge")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c
b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 0e581f6e3c88..2d752e083433 100644
--- a/drivers/gpu/drm/bridge/lo
ssues causing by this wrong call, though.
Add the check to avoid wrongly calling drm_bridge_hpd_disable().
Fixes: 3b0a01a6a522 ("drm/bridge: lt8912b: Add hot plug detection")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +-
1 file changed, 1 insertion
Fix two cases where smatch reports a use of an uninitialized variable.
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (2):
drm/drm_file: fix use of uninitialized variable
drm/framebuffer: Fix use of uninitialized variable
drivers/gpu/drm/drm_file.c| 2 +-
drivers
hat is the case or not, I think it is good to initialize
'supported_status' to 0 to silence the warning (and possibly fix a bug).
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/drm_file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_file.c
od to initialize 'ret' to 0.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/drm_framebuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_framebuffer.c
b/drivers/gpu/drm/drm_framebuffer.c
index aff3746dedfb..1955eaeba0ab 100644
--- a/driv
On 16/05/2023 17:25, Aradhya Bhatia wrote:
Hi Neil,
Thank you for reviewing the patch.
On 16-May-23 12:51, Neil Armstrong wrote:
On 15/05/2023 17:59, Aradhya Bhatia wrote:
Hi Tomi,
On 12-May-23 14:45, Tomi Valkeinen wrote:
On 09/05/2023 12:30, Aradhya Bhatia wrote:
From: Nikhil Devshatwar
On 29/05/2023 08:37, Aradhya Bhatia wrote:
Btw, we seem to be missing get-output-fmt from the mdhp driver.
Yes, we are.
With the drm_bridge_attach call added, the display-connector bridge will
assign MEDIA_BUS_FMT_FIXED as the default output format. And most
bridges support only their primary o
on,
we can eventually remove DRM's wrapper functions entirely.
v4:
* use initializer macros for struct fb_ops
v2:
* use FB_SYS_HELPERS option
Signed-off-by: Thomas Zimmermann
Acked-by: Sam Ravnborg
Cc: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
DMA_BIT));
+ ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT));
+ if (ret)
+ return ret;
This seems reasonable.
Reviewed-by: Laurent Pinchart
Tomi, would you be able to quickly test this ?
Works for me.
Reviewed-by: Tomi Valkeinen
Tomi
tidss.
Would it be possible for you to pick all the patches together once Tomi
acks the tidss patch?
Sure
I think this looks fine. For the series:
Reviewed-by: Tomi Valkeinen
Tomi
On 08/06/2023 19:26, Laurent Pinchart wrote:
Hi Doug,
On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote:
On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote:
On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote:
this patch series adapts the platform drivers below dri
On 11/08/2023 19:44, Péter Ujfalusi wrote:
On 04/08/2023 13:44, Tomi Valkeinen wrote:
I would rather have a commit message than a blank one.
Oops...
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 64 +++
1 file changed, 45
On 11/08/2023 19:23, Péter Ujfalusi wrote:
On 04/08/2023 13:44, Tomi Valkeinen wrote:
The driver has a few places where it does:
if (thing_is_enabled_in_config)
update_thing_bit_in_hw()
This means that if the thing is _not_ enabled, the bit never gets
cleared. This affects the h
On 11/08/2023 19:31, Péter Ujfalusi wrote:
On 04/08/2023 13:44, Tomi Valkeinen wrote:
The driver debug prints DSI related timings as raw register values in
hex. It is much more useful to see the "logical" value of the timing,
not the register value.
I'm a bit confused by th
On 13/08/2023 03:23, Maxim Schwalm wrote:
Hi,
On 11.08.23 19:02, Tomi Valkeinen wrote:
On 11/08/2023 19:23, Péter Ujfalusi wrote:
On 04/08/2023 13:44, Tomi Valkeinen wrote:
The driver has a few places where it does:
if (thing_is_enabled_in_config)
update_thing_bit_in_hw()
This
On 13/08/2023 20:11, Maxim Schwalm wrote:
On 04.08.23 12:44, Tomi Valkeinen wrote:
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 64 +++
1 file changed, 45 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/bridge
On 13/08/2023 20:11, Maxim Schwalm wrote:
On 04.08.23 12:44, Tomi Valkeinen wrote:
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 64 +++
1 file changed, 45 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/bridge
Hi Sam,
On 14/08/2023 13:10, Sam Ravnborg wrote:
Hi Tomi,
From c13c691bd8826b978325575be9a87f577b83b86b Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen
Date: Mon, 14 Aug 2023 13:02:23 +0300
Subject: [PATCH] drm/bridge: tc358768: fix 'Add DRM_BRIDGE_ATTACH_NO_CONNECTOR
support'
On 15/08/2023 20:21, Maxim Schwalm wrote:
On 14.08.23 08:34, Tomi Valkeinen wrote:
On 13/08/2023 03:23, Maxim Schwalm wrote:
Hi,
On 11.08.23 19:02, Tomi Valkeinen wrote:
On 11/08/2023 19:23, Péter Ujfalusi wrote:
On 04/08/2023 13:44, Tomi Valkeinen wrote:
The driver has a few places
On 15/08/2023 20:21, Maxim Schwalm wrote:
On 14.08.23 08:34, Tomi Valkeinen wrote:
On 13/08/2023 03:23, Maxim Schwalm wrote:
Hi,
On 11.08.23 19:02, Tomi Valkeinen wrote:
On 11/08/2023 19:23, Péter Ujfalusi wrote:
On 04/08/2023 13:44, Tomi Valkeinen wrote:
The driver has a few places
ve the DSI HSW, HFP and VSDly
calculations.
Tomi
Signed-off-by: Tomi Valkeinen
---
Changes in v2:
- Add "drm/tegra: rgb: Parameterize V- and H-sync polarities" so that
Tegra can configure the polarities correctly.
- Add "drm/bridge: tc358768: Default to positive h/v syncs" as
]
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tegra/rgb.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c
index 79566c9ea8ff..fc66bbd913b2 100644
--- a/drivers/gpu/drm/tegra/rgb.c
+++ b/drivers/gpu
smatch reports:
drivers/gpu/drm/bridge/tc358768.c:223 tc358768_update_bits() error:
uninitialized symbol 'orig'.
Fix this by bailing out from tc358768_update_bits() if the
tc358768_read() produces an error.
Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-of
: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index bc97a837955b..b6
ingly, as it simplifies the PLL code.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index b668f77673c3..d5831a1236e9 1
in a more human
consumable form.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index 9b633038af33..0ef51d04b
r with the documentation, change the 'dsibclk'
variable to 'hsbyteclk'. This also make it easier to visually separate
'dsibclk' and 'dsiclk' variables.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 48 +++
uses. This
makes it much easier to work on the code when using the TC358768
documentation as a reference.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 45 +--
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu
ight cause a
regression.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 211 +-
1 file changed, 183 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index dc2241c18dde..ea
Simplify the code by capturing the priv->dev value to dev variable, and
use it.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 41 ---
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
The tc358768_ns_to_cnt() is, most likely, supposed to do a div-round-up
operation, but it misses subtracting one from the dividend.
Fix this by just using DIV_ROUND_UP().
Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/
p by just saying the periods are in picoseconds.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 60 +++
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.
As the TC358768 is a DPI to DSI bridge, the DSI side does not need to
define h/v sync polarities. This means that sometimes we have a mode
without defined sync polarities, which does not work on the DPI side.
Add a mode_fixup hook to default to positive sync polarities.
Signed-off-by: Tomi
On 16/08/2023 14:25, Tomi Valkeinen wrote:
This series contains various fixes and cleanups for TC358768. The target
of this work is to get TC358768 working on Toradex's AM62 based board,
which has the following display pipeline:
AM62 DPI -> TC358768 -> LT8912B -> HDMI connector
On 22/08/2023 01:22, Maxim Schwalm wrote:
Hi Tomi,
On 16.08.23 13:25, Tomi Valkeinen wrote:
The driver has a few places where it does:
if (thing_is_enabled_in_config)
update_thing_bit_in_hw()
This means that if the thing is _not_ enabled, the bit never gets
cleared. This affects the
ve the DSI HSW, HFP and VSDly
calculations.
Tomi
Signed-off-by: Tomi Valkeinen
---
Changes in v3:
- Add Peter's reviewed-bys
- Move "Default to positive h/v syncs" earlier in the series to avoid
regression in the middle of the series
- Link to v2:
https://lore.kernel.org/r/202
d-by: Peter Ujfalusi
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/bridge/tc358768.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/bridge/tc358768.c
b/drivers/gpu/drm/bridge/tc358768.c
index 819a4b6ec2a0..bc97a837955b 100644
--- a/drivers/gpu/drm/bridge/tc358768.c
+
1101 - 1200 of 3477 matches
Mail list logo
