Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Xaver Hugl
I'm afraid that would not be very useful. It indeed depends on the refresh rate, but also on how close to vblank the compositor does its commits / on what the latency requirements for the currently shown content are. When the compositor presents a fullscreen video with frames that are queued up in

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Xaver Hugl
Am Fr., 27. Okt. 2023 um 12:01 Uhr schrieb Sebastian Wick < sebastian.w...@redhat.com>: > On Fri, Oct 27, 2023 at 10:59:25AM +0200, Michel Dänzer wrote: > > On 10/26/23 21:25, Alex Goins wrote: > > > On Thu, 26 Oct 2023, Sebastian Wick wrote: > > >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka

Re: [PATCH 1/6] drm/uapi: Document CTM matrix better

2023-04-28 Thread Xaver Hugl
I can't say anything about the other commits in this series, but "Document in which order the CTM matrix elements are stored" is Reviewed-by: Xaver Hugl

[PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-09 Thread Xaver Hugl
Signed-off-by: Xaver Hugl --- drivers/gpu/drm/drm_connector.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index b0516505f7ae..01e13984629b 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm

Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread Xaver Hugl
Am Do., 11. Jan. 2024 um 18:13 Uhr schrieb Simon Ser : > Are we sure that all drivers handle these two props properly with async > page-flips? This is a new codepath not taken by the legacy uAPI. > I've only tested on amdgpu so far. Afacs the other drivers that would need testing / that support

Re: [PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread Xaver Hugl
Great, thank you! Am Do., 11. Jan. 2024 um 19:05 Uhr schrieb André Almeida < andrealm...@igalia.com>: > Em 11/01/2024 14:59, Xaver Hugl escreveu: > > Am Do., 11. Jan. 2024 um 18:13 Uhr schrieb Simon Ser > > mailto:cont...@emersion.fr>>: > > > > Are we

[PATCH] drm: allow IN_FENCE_FD and FB_DAMAGE_CLIPS to be changed with async commits

2024-01-11 Thread Xaver Hugl
Like with FB_ID, the driver never has to do bandwidth validation to use these properties, so there's no reason not to allow them. Signed-off-by: Xaver Hugl --- drivers/gpu/drm/drm_atomic_uapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: BUG / design challenge: vmwgfx + PRIME handle free == clobbering errno

2024-01-11 Thread Xaver Hugl
Am Mi., 10. Jan. 2024 um 01:28 Uhr schrieb Zack Rusin < zack.ru...@broadcom.com>: > On Tue, Jan 9, 2024 at 11:06 AM Xaver Hugl wrote: > > > > Hi, > > > > KWin does use DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT. > > Can you point me to the code that implements

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-16 Thread Xaver Hugl
My plan is to require support for IN_FENCE_FD at least. If the driver doesn't allow tearing with that, then tearing just doesn't happen. For overlay planes though, it depends on how the compositor prioritizes things. If the compositor prioritizes overlay planes and would like to do tearing if

Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async

2024-01-17 Thread Xaver Hugl
Am Mi., 17. Jan. 2024 um 09:55 Uhr schrieb Pekka Paalanen : > Is it important enough to be special-cased, e.g. to be always allowed > with async commits? I thought so, and sent a patch to dri-devel to make it happen, but there are some concerns about untested driver paths.

Re: BUG / design challenge: vmwgfx + PRIME handle free == clobbering errno

2024-01-09 Thread Xaver Hugl
Hi, KWin does use DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT. Tying the check to DRM_CLIENT_CAP_ATOMIC instead would IMO make more sense though (even if it's still weird) and would work with older versions of KWin and other compositors. Greetings, Xaver Hugl

Re: [PATCH] drm/amd/display: fix cursor-plane-only atomic commits not triggering pageflips

2023-12-08 Thread Xaver Hugl
Sorry, it looks like I sent this too soon. I tested the patch on a second PC and it doesn't fix the issue there. Am Do., 7. Dez. 2023 um 19:25 Uhr schrieb Xaver Hugl : > > With VRR, every atomic commit affecting a given display must trigger > a new scanout cycle, so that userspac

[PATCH] drm/amd/display: fix cursor-plane-only atomic commits not triggering pageflips

2023-12-08 Thread Xaver Hugl
://gitlab.freedesktop.org/drm/amd/-/issues/3034 Cc: sta...@vger.kernel.org Signed-off-by: Xaver Hugl --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display

Re: [PATCH v2 2/2] drm/amdgpu: Implement check_async_props for planes

2024-01-23 Thread Xaver Hugl
Am Mo., 22. Jan. 2024 um 16:50 Uhr schrieb Harry Wentland : > > > > On 2024-01-19 13:25, Ville Syrjälä wrote: > > On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote: > >> AMD GPUs can do async flips with changes on more properties than just > >> the FB ID, so implement a custom

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Xaver Hugl
Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello : > So the idea being if the compositor isn't using it we let > power-profiles-daemon (or any other software) take control via sysfs and > if the compositor does want to control it then it then it writes a DRM > cap and we destroy the

Re: [PATCH] drm/amd: Drop abm_level property

2024-03-06 Thread Xaver Hugl
Like already mentioned in the power profiles daemon repository, I don't think this makes sense. This is a display setting, which compositors have interest in controlling, for example to: - disable it in a bright environment, because afaiu it reduces the maximum screen brightness - disable it

Handling pageflip timeouts

2024-03-13 Thread Xaver Hugl
them, no matter what - and if that is not possible or desirable, uAPI has to be changed, for example by introducing the mentioned "pageflip failed" event. Looking forward to some answers, Xaver Hugl

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Xaver Hugl
Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : > > On 5/21/2024 08:43, Simon Ser wrote: > > This makes sense to me in general. I like the fact that it's simple and > > vendor-neutral. > > > > Do we want to hardcode "panel" in the name? Are we sure that this will > > ever only apply

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Xaver Hugl
Am Di., 21. Mai 2024 um 19:28 Uhr schrieb Leo Li : > > > > On 2024-05-21 12:21, Mario Limonciello wrote: > > On 5/21/2024 11:14, Xaver Hugl wrote: > >> Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello > >> : > >>> > >>> On 5/2