Re: [patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread Ingo Molnar
* Joel Becker wrote: > On Thu, Nov 12, 2009 at 11:17:58AM -0800, Joel Becker wrote: > > On Thu, Nov 12, 2009 at 09:10:43AM +0100, Ingo Molnar wrote: > > > 5 out of 8 places look buggy - i.e. more than 60% - a checkpatch warning > > > would avoid real bugs here. (even ignoring the cleanliness ef

Re: [Mesa3d-dev] Gallium3D Technical Session

2009-11-12 Thread Corbin Simpson
I will be around via the more traditional IRC. Maybe a freenode channel would be a good way for absentees to stay in touch. Posting from a mobile, pardon my terseness. ~ C. On Nov 12, 2009 4:54 PM, "Jens Owen" wrote: Well...it will be a miracle if we can stream it live; but we are going to try.

Re: [patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread Joel Becker
On Thu, Nov 12, 2009 at 11:17:58AM -0800, Joel Becker wrote: > On Thu, Nov 12, 2009 at 09:10:43AM +0100, Ingo Molnar wrote: > > 5 out of 8 places look buggy - i.e. more than 60% - a checkpatch warning > > would avoid real bugs here. (even ignoring the cleanliness effects of > > using proper error

Re: [patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread Joel Becker
On Thu, Nov 12, 2009 at 09:10:43AM +0100, Ingo Molnar wrote: > 5 out of 8 places look buggy - i.e. more than 60% - a checkpatch warning > would avoid real bugs here. (even ignoring the cleanliness effects of > using proper error propagation) > > Cc:-ed affected maintainers. The rightmost column

[Bug 25059] Some Artifacts with kwin when ForceLowPowerMode is on

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25059 --- Comment #3 from Daniel Stone 2009-11-12 17:15:12 PST --- On Thu, Nov 12, 2009 at 01:12:25PM -0800, bugzilla-dae...@freedesktop.org wrote: > Platform: IA64 (Itanium) If you really are on Itanium, I assume the GPU is not really

[Bug 25063] Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 --- Comment #6 from Gavin Kinsey 2009-11-12 16:58:26 PST --- Created an attachment (id=31158) --> (http://bugs.freedesktop.org/attachment.cgi?id=31158) xrandr output after setting scaled and changing to 1024x768 -- Configure bugmail: htt

[Bug 25063] Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 --- Comment #5 from Gavin Kinsey 2009-11-12 16:57:51 PST --- Created an attachment (id=31157) --> (http://bugs.freedesktop.org/attachment.cgi?id=31157) xrandr output after setting scaled -- Configure bugmail: http://bugs.freedesktop.org/

[Bug 25063] Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 --- Comment #4 from Gavin Kinsey 2009-11-12 16:57:19 PST --- Created an attachment (id=31156) --> (http://bugs.freedesktop.org/attachment.cgi?id=31156) xrandr output before setting scaled -- Configure bugmail: http://bugs.freedesktop.org

[Bug 25063] Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 --- Comment #3 from Gavin Kinsey 2009-11-12 16:56:49 PST --- Created an attachment (id=31155) --> (http://bugs.freedesktop.org/attachment.cgi?id=31155) Kernel config -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=ema

[Bug 25063] Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 --- Comment #2 from Gavin Kinsey 2009-11-12 16:56:22 PST --- Created an attachment (id=31154) --> (http://bugs.freedesktop.org/attachment.cgi?id=31154) dmesg -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email -

[Bug 25063] Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 --- Comment #1 from Gavin Kinsey 2009-11-12 16:55:54 PST --- Created an attachment (id=31153) --> (http://bugs.freedesktop.org/attachment.cgi?id=31153) lspci -vvv -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email

[Bug 25063] New: Scaled mode doesn't actually scale

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25063 Summary: Scaled mode doesn't actually scale Product: DRI Version: DRI CVS Platform: Other OS/Version: All Status: NEW Severity: minor Priority: medium Compo

Re: [Mesa3d-dev] Gallium3D Technical Session

2009-11-12 Thread Jens Owen
Well...it will be a miracle if we can stream it live; but we are going to try. I apologize for the last minute notice, but this just came together today. If you or anyone in the community would like to join the event via WebEx, please send me an e-mail and I will forward an invite. We pl

[Bug 25059] Some Artifacts with kwin when ForceLowPowerMode is on

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25059 --- Comment #2 from Rafał Miłecki 2009-11-12 15:59:05 PST --- Well, that's effect of *forcing* low power mode. I wouldn't consider this a bug. You can hack driver to don't decrease amount of lanes, this should help. For real, dynamic, not-

[Bug 25059] Some Artifacts with kwin when ForceLowPowerMode is on

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25059 --- Comment #1 from Ronny 2009-11-12 13:13:28 PST --- Created an attachment (id=31139) --> (http://bugs.freedesktop.org/attachment.cgi?id=31139) Xorg.log -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- Yo

[Bug 25059] New: Some Artifacts with kwin when ForceLowPowerMode is on

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25059 Summary: Some Artifacts with kwin when ForceLowPowerMode is on Product: Mesa Version: git Platform: IA64 (Itanium) OS/Version: Linux (All) Status: NEW Severity: normal

Re: [PATCH] drm/radeon/kms: rework scaler handling

2009-11-12 Thread Jerome Glisse
On Thu, 2009-11-12 at 14:59 -0500, Alex Deucher wrote: > From af779d3c5a530db7f88d16969a49b9dcb1db Mon Sep 17 00:00:00 2001 > From: Alex Deucher > Date: Thu, 12 Nov 2009 14:55:14 -0500 > Subject: [PATCH] drm/radeon/kms: rework scaler handling > > Keep requested scaler type in radeon_encoder >

[PATCH] drm/radeon/kms: rework scaler handling

2009-11-12 Thread Alex Deucher
>From af779d3c5a530db7f88d16969a49b9dcb1db Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Thu, 12 Nov 2009 14:55:14 -0500 Subject: [PATCH] drm/radeon/kms: rework scaler handling Keep requested scaler type in radeon_encoder and the actual scaler type used in radeon_crtc. This prevents us fr

[Bug 23695] [i915g] piglit gen-teximage signal 11

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=23695 Vinson Lee changed: What|Removed |Added AssignedTo|dri-|ja...@vmware.com |de...@l

[Bug 23694] [i915g] piglit occlusion_query signal 11

2009-11-12 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=23694 Vinson Lee changed: What|Removed |Added AssignedTo|dri-|ja...@vmware.com |de...@l

Re: [PATCH 1/2] APPLE_object_purgeable

2009-11-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chris Wilson wrote: > Ian, thanks for your detailed comments! The patch was just guess work > from looking at similar extensions - I couldn't see a step-by-step guide > on how to add an extension to Mesa. That's the tough thing about adding a new exte

Re: [PATCH] drm/i915: Add page flipping ioctl

2009-11-12 Thread Jakob Bornecrantz
On 12 nov 2009, at 17.44, Kristian Høgsberg wrote: > This adds a page flipping ioctl to the KMS API. The ioctl takes an > fb ID > and a ctrc ID and flips the crtc to the given fb at the next vblank. > The ioctl returns immediately but the flip doesn't happen until after > any rendering that's cu

[PATCH] drm/radeon/kms: fix typo in legacy internal tmds mode fixup

2009-11-12 Thread Alex Deucher
>From 40f18784d4b9471a9db6432a53a1bc4fa29b1f04 Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Thu, 12 Nov 2009 14:01:36 -0500 Subject: [PATCH] drm/radeon/kms: fix typo in legacy internal tmds mode fixup Call to set active device was missing. Signed-off-by: Alex Deucher --- drivers/gpu/drm/r

[Bug 13683] Internal Laptopdisplay blurrys to white screen after enabling modesetting on Radeon X700 Mobility

2009-11-12 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=13683 --- Comment #22 from Jan Kreuzer 2009-11-12 18:34:38 --- Created an attachment (id=23760) --> (http://bugzilla.kernel.org/attachment.cgi?id=23760) vbios The vbios. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --

Re: drm/radeon/kms: ask for little help with timers (PM)

2009-11-12 Thread Rafał Miłecki
W dniu 12 listopada 2009 14:46 użytkownik Jerome Glisse napisał: > On Wed, 2009-11-11 at 21:51 +0100, Rafał Miłecki wrote: >> I attach my very hackish patch to downclock GPU. >> >> Could someone tell me please, why first method in this patch works >> while second locks up my GPU? >> >> I've run >>

[PATCH] drm/i915: Add page flipping ioctl

2009-11-12 Thread Kristian Høgsberg
This adds a page flipping ioctl to the KMS API. The ioctl takes an fb ID and a ctrc ID and flips the crtc to the given fb at the next vblank. The ioctl returns immediately but the flip doesn't happen until after any rendering that's currently queued up against the new framebuffer is done. After s

[Bug 13683] Internal Laptopdisplay blurrys to white screen after enabling modesetting on Radeon X700 Mobility

2009-11-12 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=13683 --- Comment #21 from Alex Deucher 2009-11-12 17:29:33 --- Unfortunately, the register dumps are identical. The only regs that are different are irrelevant to this. I guess it must be a timing or ordering issue. Can you attach your video bios

Re: [patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread Mike Christie
roel kluin wrote: * Andrew Morton wrote: Andy, can we have a checkpatch rule please? Note, that will upset creative uses of error codes i guess, such as fs/xfs/. But yeah, +1 from me too. Ob'post'mortem - looked for similar patterns in the kernel and there's quite a few bugs there: inclu

RE: [PATCH 3/4] APPLE_object_purgeable: core

2009-11-12 Thread Brian Paul
One minor thing here: +void GLAPIENTRY +_mesa_GetObjectParameterivAPPLE(GLenum objectType, GLuint name, GLenum pname, GLint* params) +{ + GET_CURRENT_CONTEXT(ctx); + struct gl_buffer_object *bufObj; + + switch (objectType) { + case GL_TEXTURE: + case GL_BUFFER_OBJECT_APPLE: + case G

[PATCH] drm/radeon/kms: Report vga connector is connected according to ddc_probe

2009-11-12 Thread Jerome Glisse
On broken EDID we were reporting vga connector to be disconnected even if ddc probe did found a monitor. This patch report that the connector is connected on such case. This allow drm to add a fail safe mode (800x600 at the time of this patch) thus user can boot and later add a mode which match its

[Bug 14574] using a displayport connector results in stack in dmesg and blank screen

2009-11-12 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=14574 Jérôme Glisse changed: What|Removed |Added CC||gli...@freedesktop.org --- Comment #4

Re: [PATCH] drm/radeon/kms: (V2) Add default 800x600 mode when getting bad EDID

2009-11-12 Thread Jerome Glisse
On Thu, 2009-11-12 at 11:58 +0100, Jerome Glisse wrote: > Adding default 800x600 mode should be a safe fail solution in front > of broken EDID, user can then add new mode to fit its needs. > > Signed-off-by: Jerome Glisse Forget this one a better is on the way. Cheers, Jerome

Re: drm/radeon/kms: ask for little help with timers (PM)

2009-11-12 Thread Jerome Glisse
On Wed, 2009-11-11 at 21:51 +0100, Rafał Miłecki wrote: > I attach my very hackish patch to downclock GPU. > > Could someone tell me please, why first method in this patch works > while second locks up my GPU? > > I've run > cat radeon_pm_info > 100x times with first method. No problem. Second me

Re: [PATCH] drm/radeon/kms: Add default 800x600 mode when getting bad EDID

2009-11-12 Thread Jerome Glisse
On Thu, 2009-11-12 at 10:09 +0100, Jerome Glisse wrote: > Adding default 800x600 mode should be a safe fail solution in front > of broken EDID, user can then add new mode to fit its needs. > > Signed-off-by: Jerome Glisse Forget this patch a better one is coming. Cheers, Jerome Glisse ---

[xf86-video-intel] mplayer + GL backend

2009-11-12 Thread Tobias Jakobi
Hi there, I have some issues with playing back HD (720p) material with mplayer and using the GL video output backend. Usually my system is fast enough to playback 720p if the material is not subtitled. In case ASS style subtitles are used, using the standard Xv output is not fast enough. Ther

[PATCH 1/4] APPLE_object_purgeable: xml

2009-11-12 Thread Chris Wilson
Signed-off-by: Chris Wilson --- src/mesa/glapi/APPLE_object_purgeable.xml | 37 + src/mesa/glapi/Makefile |1 + src/mesa/glapi/gl_API.xml |1 + 3 files changed, 39 insertions(+), 0 deletions(-) create mode 100644 src/mesa/gl

APPLE_object_purgeable [v2]

2009-11-12 Thread Chris Wilson
Thank you Ian and Brian for your review, hopefully I've interpreted your comments correctly and updated the patches appropriately. -ickle -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day tri

[PATCH] drm/radeon/kms: (V2) Add default 800x600 mode when getting bad EDID

2009-11-12 Thread Jerome Glisse
Adding default 800x600 mode should be a safe fail solution in front of broken EDID, user can then add new mode to fit its needs. Signed-off-by: Jerome Glisse --- drivers/gpu/drm/radeon/radeon_connectors.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

Re: [patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread roel kluin
> * Andrew Morton wrote: >> Andy, can we have a checkpatch rule please? > > Note, that will upset creative uses of error codes i guess, such as > fs/xfs/. > > But yeah, +1 from me too. > > Ob'post'mortem - looked for similar patterns in the kernel and there's > quite a few bugs there: > >  includ

Re: [PATCH] drm/radeon/kms: Fix oops when set_base is call with no FB

2009-11-12 Thread Jerome Glisse
On Tue, 2009-11-10 at 14:30 -0800, Andrew Morton wrote: > On Wed, 4 Nov 2009 20:03:19 +0100 > Jerome Glisse wrote: > > > Just do nothings crct_set_base i call with no FB. > > > > hmpf. It's obvious that you spent hours carefully describing this > patch for us. > Sorry, truth is i don't unde

[PATCH 3/4] APPLE_object_purgeable: core

2009-11-12 Thread Chris Wilson
Signed-off-by: Chris Wilson --- src/mesa/main/api_exec.c |6 ++ src/mesa/main/bufferobj.c | 161 src/mesa/main/bufferobj.h | 11 +++ src/mesa/main/dd.h | 10 +++ src/mesa/main/extensions.c |4 + src/mesa/main/mfeatures.h |

[PATCH] xdemos: Add X11 and pthread linking options to satisfy GNU gold

2009-11-12 Thread Sedat Dilek
Hi, I had some discussion on #grml about using GNU-gold linker instead of GNU-ld the last days and remembered a problem with mesa. Some xdemos programs fail to build. Unfortunately, I found a very old broken build-log from radeon-rewrite GIT branch: $ grep glsync BROKEN_mesa_7.5+radeon~rewrite+

[PATCH 4/4] APPLE_object_purgeable: intel

2009-11-12 Thread Chris Wilson
Signed-off-by: Chris Wilson --- src/mesa/drivers/dri/intel/intel_buffer_objects.c | 43 + src/mesa/drivers/dri/intel/intel_extensions.c |2 + 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_buffer_objects.c b/src/mesa

Re: [PATCH 2/2] intel: APPLE_object_purgeable

2009-11-12 Thread Chris Wilson
Excerpts from Ian Romanick's message of Wed Nov 11 20:18:58 + 2009: > Chris Wilson wrote: > > +#if FEATURE_APPLE_object_purgeable > > +static GLenum > > +intel_bufferobj_purgeable(GLcontext * ctx, > > + struct gl_buffer_object *obj, > > + GLenum option) > > +{ > > +

Re: [PATCH 1/2] APPLE_object_purgeable

2009-11-12 Thread Chris Wilson
Ian, thanks for your detailed comments! The patch was just guess work from looking at similar extensions - I couldn't see a step-by-step guide on how to add an extension to Mesa. Excerpts from Ian Romanick's message of Wed Nov 11 20:06:04 + 2009: > Eric's suggestion of doing 3 commits (XML, re

[PATCH] drm/radeon/kms: Add default 800x600 mode when getting bad EDID

2009-11-12 Thread Jerome Glisse
Adding default 800x600 mode should be a safe fail solution in front of broken EDID, user can then add new mode to fit its needs. Signed-off-by: Jerome Glisse --- drivers/gpu/drm/radeon/radeon_connectors.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

Re: [patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread Dave Airlie
On Thu, Nov 12, 2009 at 6:10 PM, Ingo Molnar wrote: > > * Andrew Morton wrote: > >> > @@ -3730,7 +3730,7 @@ tracing_stats_read(struct file *filp, char __user >> > *ubuf, >> > >> >     s = kmalloc(sizeof(*s), GFP_KERNEL); >> >     if (!s) >> > -           return ENOMEM; >> > +           return -E

[patch] Fix: 'return -ENOMEM' instead of 'return ENOMEM'

2009-11-12 Thread Ingo Molnar
* Andrew Morton wrote: > > @@ -3730,7 +3730,7 @@ tracing_stats_read(struct file *filp, char __user > > *ubuf, > > > > s = kmalloc(sizeof(*s), GFP_KERNEL); > > if (!s) > > - return ENOMEM; > > + return -ENOMEM; > > > > trace_seq_init(s); > > > > lol, there