Re: drivers/gpu/drm/radeon: move a dereference below a NULL test

2009-12-25 Thread Julien Cristau
On Thu, Dec 24, 2009 at 23:44:30 +1100, Darren Jenkins wrote: If a NULL value is possible, the dereference should only occur after the NULL test. Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_irq.c b/drivers/gpu/drm/radeon/radeon_irq.c

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-25 Thread Rafał Miłecki
W dniu 24 grudnia 2009 23:19 użytkownik Luca Tettamanti kronos...@gmail.com napisał: 2009/12/24 Rafał Miłecki zaj...@gmail.com: W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: I think it would be safer to execute that code in the IH (or in a tasklet, which

[Bug 8056] s3tc broken in ut2004

2009-12-25 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=8056 Tomasz Czapiewski xe...@irc.pl changed: What|Removed |Added CC||xe...@irc.pl ---

Re: drm/radeon/kms: pm: single frame corruptions on reclocking

2009-12-25 Thread Rafał Miłecki
W dniu 26 grudnia 2009 02:46 użytkownik Rafał Miłecki zaj...@gmail.com napisał: W dniu 24 grudnia 2009 08:19 użytkownik Michel Dänzer mic...@daenzer.net napisał: I suspect the delay is more likely due to the workqueue than the interrupt itself. Way back when I implemented DRI1 tear-free buffer

Re: drm/radeon/kms: pm: single frame corruptions on reclocking

2009-12-25 Thread Rafał Miłecki
W dniu 24 grudnia 2009 08:19 użytkownik Michel Dänzer mic...@daenzer.net napisał: I suspect the delay is more likely due to the workqueue than the interrupt itself. Way back when I implemented DRI1 tear-free buffer swaps for i945, I had to use a tasklet to reliably do work within the vertical