Re: 2.6.34-rc5: Reported regressions from 2.6.33

2010-04-21 Thread Ben Gamari
On Tue, 20 Apr 2010 05:15:57 +0200 (CEST), Rafael J. Wysocki r...@sisk.pl wrote: This message contains a list of some regressions from 2.6.33, for which there are no fixes in the mainline known to the tracking team. If any of them have been fixed already, please let us know. If you know of

Re: [linux-pm] [PATH] i915: Read outside array bounds

2009-07-28 Thread Ben Gamari
On Tue, Jul 28, 2009 at 02:50:03PM -0700, Andrew Morton wrote: (cc jbarnes) This looks rather correct and the original code looked rather wrong. Someone please tell me that this might fix one of our splendid number of i915 bugs :( Unfortunately, according to the docs we were just

[PATCH 2/3] Move i915 proc files to seq_file

2009-02-17 Thread Ben Gamari
This patch ports the i915 proc files to use the seq_file interface. Also, we move these files into debugfs. Signed-off-by: Ben Gamari bgam...@gmail.com --- drivers/gpu/drm/i915/Makefile |2 +- drivers/gpu/drm/i915/i915_drv.c |6 +- drivers/gpu/drm/i915/i915_drv.h

[PATCH 1/3] Convert proc files to seq_file and introduce debugfs

2009-02-17 Thread Ben Gamari
and exposes all of the proc files in debugfs as well. Signed-off-by: Ben Gamari bgam...@gmail.com --- drivers/gpu/drm/Makefile |3 +- drivers/gpu/drm/drm_debugfs.c | 242 ++ drivers/gpu/drm/drm_drv.c | 12 +- drivers/gpu/drm/drm_info.c| 325 +++ drivers

[PATCH final] DRM proc file handling rework

2009-02-17 Thread Ben Gamari
Hey all, Hopefully this will be the last time I pollute the lists with this patchset. From the look of the diffstat, this cleanup went pretty well. We managed to introduce support for debugfs while both eliminating large portions of code and standardizing the interface for drm proc/debugfs file

[PATCH 3/3] Consolidate gem object list dumping

2009-02-17 Thread Ben Gamari
Here we eliminate a few functions in favor of using a single function to dump from all of the object lists. Signed-Off-By: Ben Gamari bgam...@gmail.com --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 84 ++- 1 files changed, 26 insertions(+), 58 deletions(-) diff

[PATCH] Move proc/debugfs info functions into separate files

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |2 +- drivers/gpu/drm/drm_debugfs.c | 61 +--- drivers/gpu/drm/drm_info.c| 351 + drivers/gpu/drm/drm_info.h| 13 ++ drivers/gpu/drm/drm_proc.c| 314 + 5 files

[PATCH] Proc to debugfs migration

2009-01-14 Thread Ben Gamari
Hey everyone, Here is my procfs cleanup patchset. As you can see, the first two patches attempt to clean up the existing proc file creation code and port the files' implementations to the seq_file interface. The remaining patches focus on implementing a similar system for debugfs files.

[PATCH] declare debugfs init/cleanup hooks

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_drv.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 9158a94..ff6f1e5 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -611,6

[PATCH] add i915 debugfs implementation

2009-01-14 Thread Ben Gamari
Port old i915-specific proc file entries to debugfs --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_drv.c |4 + drivers/gpu/drm/i915/i915_drv.h |4 + drivers/gpu/drm/i915/i915_gem_debugfs.c | 205 +++ 4 files

[PATCH] add former proc files to debugfs as well

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index fc03a45..e523069 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -10,6 +10,14 @@

[PATCH] remove i915 proc hooks

2009-01-14 Thread Ben Gamari
These are going into debugfs. There is no reason why they need to be in proc. --- drivers/gpu/drm/i915/Makefile|1 - drivers/gpu/drm/i915/i915_drv.c |2 - drivers/gpu/drm/i915/i915_drv.h |2 - drivers/gpu/drm/i915/i915_gem_proc.c | 334

[PATCH] add debugfs hooks to drm_driver struct

2009-01-14 Thread Ben Gamari
--- include/drm/drmP.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 3f45fb7..c318736 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -765,6 +765,8 @@ struct drm_driver { int (*proc_init)(struct

[PATCH] add debugfs declarations

2009-01-14 Thread Ben Gamari
add drm_debugfs_node stuct, drm_debugfs_root, debugfs entries to drm_minor. Also add debugfs function declarations --- include/drm/drmP.h | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index

[PATCH] remove declarations of proc hooks

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_drv.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 467572a..9158a94 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -575,8

[PATCH] add proc structure definitions to header

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c |2 +- include/drm/drmP.h | 24 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 5ca132a..566847d 100644 --- a/drivers/gpu/drm/drm_stub.c +++

[PATCH] remove last remnants of i915 proc implementations

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/Makefile|1 - drivers/gpu/drm/i915/i915_gem_proc.c | 334 -- 2 files changed, 0 insertions(+), 335 deletions(-) delete mode 100644 drivers/gpu/drm/i915/i915_gem_proc.c diff --git a/drivers/gpu/drm/i915/Makefile

[PATCH] create/remove debugfs roots during driver init/cleanup

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_drv.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index febb517..9b74efb 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -46,9 +46,11 @@ * OTHER

[PATCH] add debugfs declarations

2009-01-14 Thread Ben Gamari
add drm_debugfs_node stuct, drm_debugfs_root, debugfs entries to drm_minor. Also add debugfs function declarations --- include/drm/drmP.h | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index

[PATCH] add debugfs init hooks

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 566847d..eb5d100 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -50,6 +50,7 @@ struct idr

[PATCH] add debugfs file implementations

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c | 268 + 1 files changed, 268 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs.c diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c new file mode 100644 index

[PATCH] Add drm core debugfs implementation

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c | 268 + drivers/gpu/drm/drm_stub.c| 13 ++ 2 files changed, 281 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs.c diff --git a/drivers/gpu/drm/drm_debugfs.c

[PATCH] add debugfs sources to Makefile

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 30022c4..2aeaf02 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -10,7 +10,8 @@ drm-y :=

[PATCH] Implement gem object search by gtt offset

2009-01-14 Thread Ben Gamari
When dumping a batch buffer, we need to find its gem object so that we may pin it. Here we look through active_list, inactive_list, and flushing_list looking for an object with a valid and matching gtt_offset --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 47 +-- 1

[RFC] [PATCH] Ring buffer dumping

2009-01-14 Thread Ben Gamari
Hey again everyone, Here is my latest attempt at implementing batch buffer dumping in GEM. The patches have changed relatively little except for the fact that they now work. At this point, reading from the debugfs file will dump not only the ring buffer but also any batch buffers still valid and

[PATCH] add proc structure definitions to header

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c |2 +- include/drm/drmP.h | 24 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 5ca132a..566847d 100644 --- a/drivers/gpu/drm/drm_stub.c +++

[PATCH] convert proc files to seq_file

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_proc.c | 726 1 files changed, 266 insertions(+), 460 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 8df849f..b949e89 100644 --- a/drivers/gpu/drm/drm_proc.c +++

[PATCH] add former proc files to debugfs as well

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index e6f0725..e03457c 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -10,6 +10,14 @@

[PATCH] Correctly implement batchbuffer dumping

2009-01-14 Thread Ben Gamari
We need to map the batch buffer before we attempt to dump it. Also, break dumping out into a separate function to make error handling a bit cleaner. --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 63 -- 1 files changed, 50 insertions(+), 13 deletions(-) diff --git

[PATCH] add memory type of batch buffer to ring dump output

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_gem_debugfs.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_debugfs.c b/drivers/gpu/drm/i915/i915_gem_debugfs.c index cc91461..10ca9ae 100644 --- a/drivers/gpu/drm/i915/i915_gem_debugfs.c +++

[PATCH] Move proc/debugfs info functions into separate files

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |2 +- drivers/gpu/drm/drm_debugfs.c | 61 +--- drivers/gpu/drm/drm_info.c| 351 + drivers/gpu/drm/drm_info.h| 13 ++ drivers/gpu/drm/drm_proc.c| 314 + 5 files

[PATCH] add debugfs hooks to drm_driver struct

2009-01-14 Thread Ben Gamari
--- include/drm/drmP.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 8933f9d..48a240a 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -765,6 +765,8 @@ struct drm_driver { int (*proc_init)(struct

[PATCH] add i915 debugfs implementation

2009-01-14 Thread Ben Gamari
Port old i915-specific proc file entries to debugfs --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_drv.c |4 + drivers/gpu/drm/i915/i915_drv.h |4 + drivers/gpu/drm/i915/i915_gem_debugfs.c | 205 +++ 4 files

[PATCH] Proc to debugfs migration, 2nd attempt

2009-01-14 Thread Ben Gamari
Hey everyone, Here is my procfs cleanup patchset. As you can see, the first two patches attempt to clean up the existing proc file creation code and port the files' implementations to the seq_file interface. The remaining patches focus on implementing a similar system for debugfs files.

[PATCH] convert proc files to seq_file

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_proc.c | 726 1 files changed, 266 insertions(+), 460 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 8df849f..b949e89 100644 --- a/drivers/gpu/drm/drm_proc.c +++

[PATCH] create/remove debugfs roots during driver init/cleanup

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_drv.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index febb517..9b74efb 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -46,9 +46,11 @@ * OTHER

Re: [PATCH] Proc to debugfs migration

2009-01-14 Thread Ben Gamari
Bah, naturally just as I sent this out I realized that anholt sent me comments on the last iteration of this patch set. I'll incorporate his proposed changes and any others I receive in the next few hours and send it out again. Sorry about the spam, - Ben On Wed, 2009-01-14 at 19:27 -0500, Ben

[PATCH] remove i915 proc hooks

2009-01-14 Thread Ben Gamari
These are going into debugfs. There is no reason why they need to be in proc. --- drivers/gpu/drm/i915/Makefile|1 - drivers/gpu/drm/i915/i915_drv.c |2 - drivers/gpu/drm/i915/i915_drv.h |2 - drivers/gpu/drm/i915/i915_gem_proc.c | 334

[PATCH] add debugfs declarations

2009-01-14 Thread Ben Gamari
--- include/drm/drmP.h | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index efe50b6..1484797 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -800,6 +800,27 @@ struct drm_driver {

[PATCH] correct dev_root reference

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 592192d..5697764 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -312,7 +312,7 @@ static int

[PATCH] create/remove debugfs roots during driver init/cleanup

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/drm_drv.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 0b9f316..cc90440 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -46,9 +46,11 @@ * OTHER

Rework DRM proc file handling [rev 2]

2008-12-21 Thread Ben Gamari
This is the latest patch series reworking the drm proc file handling using seq_file. Like before, I've moved some of the debug-oriented proc files into debugfs, especially those pertaining to i915. Moreover, the series now has a proper git history and is split up better than the previous

[PATCH] add debugfs sources to Makefile

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 30022c4..2aeaf02 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -10,7 +10,8 @@ drm-y :=

[PATCH] add DRM_DEBUGFS config option to Kconfig

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/Kconfig |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 6903e54..fd7418a 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -16,6 +16,13 @@ menuconfig DRM

[PATCH] add i915 debugfs implementation

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_gem_debugfs.c | 778 +++ 1 files changed, 778 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/i915/i915_gem_debugfs.c diff --git a/drivers/gpu/drm/i915/i915_gem_debugfs.c b/drivers/gpu/drm/i915/i915_gem_debugfs.c new

[PATCH] add proc structure definitions to header

2008-12-21 Thread Ben Gamari
--- include/drm/drmP.h | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 7802c80..efe50b6 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -801,6 +801,25 @@ struct drm_driver { #define

[PATCH] remove i915 proc hooks

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_drv.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index cbee41c..5f0d8c2 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -124,8

[PATCH] add debugfs file implementations

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c | 268 + 1 files changed, 268 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs.c diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c new file mode 100644 index

[PATCH] convert proc files to seq_file

2008-12-21 Thread Ben Gamari
--- drivers/gpu/drm/drm_proc.c | 723 1 files changed, 264 insertions(+), 459 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 7dbaa1a..40e320e 100644 --- a/drivers/gpu/drm/drm_proc.c +++

Re: [i915 drm] irq 16: nobody cared with latest git kernels

2008-12-02 Thread Ben Gamari
This bug was first reported a few weeks ago and it seems still hasn't been resolved for some. The bug report can be found here, https://bugs.freedesktop.org/show_bug.cgi?id=18609 . - Ben On Tue, 2008-12-02 at 14:21 +0100, fredi ml wrote: Hi all, lately starting from kernel

Re: Status of everything?

2008-07-11 Thread Ben Gamari
On the note of GEM, would it be worth pulling down the GEM trees to play around with and submit bugs against? Is the code in a state at all resembling stable (can you run a moderately standard X session for more than 10 seconds)? I'd be glad to start reporting if so. Thanks, - Ben On Wed,

Re: [Mesa3d-dev] intel-batchbuffer with DRI2

2008-04-06 Thread Ben Gamari
I'm definitely in the same position here (still). I looked into the issue with gdb and I also observed no FBConfigs being returned. Any input? - Ben On Sun, 2008-04-06 at 02:33 +0200, Johannes Engel wrote: Hi, Kristian and the rest of the DRI world! ;) Testing your most recent DRI2 work

DRI card reinitialization after suspend

2005-12-30 Thread Ben Gamari
Howdy all! What is the present status of S3 suspend support in the DRI? I ask because my laptop locks up with a scrambled screen on resume from S3 standby when using the radeon driver with DRI enabled. This is a known problem with the DRI drivers and as such, at least one workaround has be

R300 RENDER Support

2005-12-13 Thread Ben Gamari
in tracing the operation of the driver? Does it entail just tracing the instruction flow with a disassembler? I look forward to hopefully working with you guys in the future (exams end next Thursday :( ) Thanks for your time, - Ben Gamari