Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-09 Thread Dave Airlie
> > > > Looks like David has already ported & applied it to XFree86. > > yeah but I'm hanging on bug 484 to make sure he is correct.. read 484, > David believes there is a drm/driver issue... I'm not 100% convinced it > is that important, of course he does know better than me :-), so I'll > apply h

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-09 Thread Dave Airlie
On Wed, 9 Jul 2003, Keith Whitwell wrote: > > > > if no-one screams I'll apply it tomorrow... > > Looks like David has already ported & applied it to XFree86. yeah but I'm hanging on bug 484 to make sure he is correct.. read 484, David believes there is a drm/driver issue... I'm not 100% convinced

Re: [Dri-devel] Re: Problem with latest trunk and i810? (fwd)

2003-07-09 Thread Dave Airlie
gt; To: Keith Whitwell <[EMAIL PROTECTED]> Cc: dri-devel <[EMAIL PROTECTED]>, Ronald Baljeu <[EMAIL PROTECTED]> Subject: Re: [Dri-devel] Re: Problem with latest trunk and i810? On Wed, 9 Jul 2003, Keith Whitwell wrote: > > > > if no-one screams I'll apply it tom

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-09 Thread Keith Whitwell
Dave Airlie wrote: Yes, that would be cleaner. patch for not only the i810 but also the fixes for radoen/r128/mga drivers, along with the changes to xf86drm.[ch] ... http://www.skynet.ie/~airlied/patches/dri/agp_drm.diff I think XFree86 tree is going to need something along these lines also, but

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-08 Thread Dave Airlie
> > Yes, that would be cleaner. patch for not only the i810 but also the fixes for radoen/r128/mga drivers, along with the changes to xf86drm.[ch] ... http://www.skynet.ie/~airlied/patches/dri/agp_drm.diff I think XFree86 tree is going to need something along these lines also, but I don't have

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-08 Thread Keith Whitwell
Dave Airlie wrote: I'd lean towards using ~0 as the error value and keeping the existing types, etc. potential patch at: http://www.skynet.ie/~airlied/patches/dri/i810_drm_agp.diff I wonder if we should change the drmAgpAlloc function to set the handle to DRM_AGP_NO_HANDLE? Yes, that would be cle

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-08 Thread Dave Airlie
> I'd lean towards using ~0 as the error value and keeping the existing > types, etc. > potential patch at: http://www.skynet.ie/~airlied/patches/dri/i810_drm_agp.diff I wonder if we should change the drmAgpAlloc function to set the handle to DRM_AGP_NO_HANDLE? Other drivers will need some fixi

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-08 Thread Keith Whitwell
Dave Airlie wrote: and of course d) revert back to using memory->memory, requires whoever switched us to key to explain :-) Okay this was done by David Dawes back in April, and was taken from the XFree trunk, it looks like it is needed. so one of the other three approaches is needed... I'd lean t

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-07 Thread Dave Airlie
> > and of course > d) revert back to using memory->memory, requires whoever switched us to > key to explain :-) Okay this was done by David Dawes back in April, and was taken from the XFree trunk, it looks like it is needed. so one of the other three approaches is needed... Dave. -

Re: [Dri-devel] Re: Problem with latest trunk and i810?

2003-07-07 Thread Dave Airlie
He looks to have something here, alright.. the key can be zero, I'm just updating to trunk at the moment to see if I can reproduce it.. the radeon_dri.c has a similiar issue but it isn't as serious in their case, they check for freeing the AGP memory if (info->agpMemHandle) they use the return va

[Dri-devel] Re: Problem with latest trunk and i810?

2003-07-07 Thread Keith Whitwell
Ronald Baljeu wrote: On Mon, Jul 07, 2003 at 09:59:15AM +0100, Keith Whitwell wrote: Ronald Baljeu wrote: The traditional approach would be to do a binary search to narrow down which change caused the problems -- probably using the DRI cvs tree. Keith Ok, after several days of searching I thin