Re: [Dri-devel] drm pci ids diff 2...

2004-04-20 Thread Dave Airlie
> > You could still generate a string to help with debug. Something like "Radeon QX" > by converting the PCI ID to ASCII. Later when you get the family you could > generate "Radeon R250 QX" for the string. well if someone builds their kernel with pci strings turned off I persume they know what the

Re: [Dri-devel] drm pci ids diff 2...

2004-04-20 Thread Jon Smirl
--- Dave Airlie <[EMAIL PROTECTED]> wrote: > so Linux no longer carries the device name around with it, it uses the > kernel to get if support is there if not you get blank string, You could still generate a string to help with debug. Something like "Radeon QX" by converting the PCI ID to ASCII. L

Re: [Dri-devel] drm pci ids diff 2...

2004-04-20 Thread Dave Airlie
> > The patch looks good. However, doesn't drm_pci_id_list need to be updated for > BSD to add the 2 new fields? Other than that, it looks good to me. nope that's why there are two scripts, the bsd generates the info bsd wants, the linux one generates the info linux wants.. so Linux no longer c

Re: [Dri-devel] drm pci ids diff 2...

2004-04-20 Thread Alan Cox
On Maw, 2004-04-20 at 18:26, Jon Smirl wrote: > The kernel provides symbols for all of the PCI ID constants via pci_ids.h. The > strings describing the hardware are duplicated against drivers/pci/pci.ids. How pci.ids isnt used by 2.6, its primarily used by lspci in user space, and the name stuff h

Re: [Dri-devel] drm pci ids diff 2...

2004-04-20 Thread Jon Smirl
The kernel provides symbols for all of the PCI ID constants via pci_ids.h. The strings describing the hardware are duplicated against drivers/pci/pci.ids. How do the kernel people feel about us not using their symbols and strings? We're creating duplicate definitions for these items. I seem to reca

Re: [Dri-devel] drm pci ids diff 2...

2004-04-20 Thread Ian Romanick
Dave Airlie wrote: http://freedesktop.org/~airlied/drm_pci_ids.diff Same as last patch except now it uses the Linux PCI structures in the DRM, it still doesn't do any of the other stuff, again I want to have this stuff in nice clean steps so breakage is obvious, I believe this is a good first step

[Dri-devel] drm pci ids diff 2...

2004-04-19 Thread Dave Airlie
http://freedesktop.org/~airlied/drm_pci_ids.diff Same as last patch except now it uses the Linux PCI structures in the DRM, it still doesn't do any of the other stuff, again I want to have this stuff in nice clean steps so breakage is obvious, I believe this is a good first step to satisfying t