Re: [Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-03 Thread Keith Packard
On Fri, 02 Jul 2010 17:19:18 +0100, Chris Wilson wrote: > On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard wrote: > > On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson > > wrote: > > > > > This looks like the responsibility of miCloseScreen(). Are we failing to > > > chain up properly? > > >

Re: [Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-02 Thread Chris Wilson
On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard wrote: > On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson > wrote: > > > This looks like the responsibility of miCloseScreen(). Are we failing to > > chain up properly? > > I don't think miCloseScreen (or fbCloseScreen) can do this -- before >

Re: [Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-02 Thread Keith Packard
On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson wrote: > This looks like the responsibility of miCloseScreen(). Are we failing to > chain up properly? I don't think miCloseScreen (or fbCloseScreen) can do this -- before we're called, rendering may not have been finished, after we're called, th

Re: [Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-02 Thread Chris Wilson
On Thu, 1 Jul 2010 09:56:40 -0400, Keith Packard wrote: > This avoids a memory leak on server reset. > > Signed-off-by: Keith Packard > --- > uxa/uxa.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/uxa/uxa.c b/uxa/uxa.c > index a9a705c..dcfaaa9 100644 > --

[PATCH] Destroy screen pixmap on screen close.

2010-07-01 Thread Keith Packard
This avoids a memory leak on server reset. Signed-off-by: Keith Packard --- uxa/uxa.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/uxa/uxa.c b/uxa/uxa.c index a9a705c..dcfaaa9 100644 --- a/uxa/uxa.c +++ b/uxa/uxa.c @@ -1,7 +1,7 @@ /* - * Copyright © 2001 Keith P