Re: [r300] per-component negation for SWZ

2006-05-31 Thread Keith Whitwell
Tilman Sauerbeck wrote: > Roland Scheidegger [2006-05-30 22:33]: >> Tilman Sauerbeck wrote: >>> I finally ran glean today, and noticed that SWZ wasn't implemented >>> properly for r300 ARB vertex programs. >>> >>> So far I didn't handle per-component negation flags, the attached patch >>> adds that

Re: [r300] per-component negation for SWZ

2006-05-31 Thread Brian Paul
Tilman Sauerbeck wrote: > Roland Scheidegger [2006-05-30 22:33]: > >>Tilman Sauerbeck wrote: >> >>>I finally ran glean today, and noticed that SWZ wasn't implemented >>>properly for r300 ARB vertex programs. >>> >>>So far I didn't handle per-component negation flags, the attached patch >>>adds tha

Re: [r300] per-component negation for SWZ

2006-05-31 Thread Roland Scheidegger
Tilman Sauerbeck wrote: >>> If there are no objections, I'll commit this in a few days. >> Wouldn't it be simpler to just change t_src to always apply >> src->NegateBase? I can't see a need for that "src->NegateBase ? >> VSF_FLAG_ALL : VSF_FLAG_NONE", as the mesa parser sets all 4 bits anyway >>

Re: [r300] per-component negation for SWZ

2006-05-30 Thread Tilman Sauerbeck
Roland Scheidegger [2006-05-30 22:33]: > Tilman Sauerbeck wrote: > > I finally ran glean today, and noticed that SWZ wasn't implemented > > properly for r300 ARB vertex programs. > > > > So far I didn't handle per-component negation flags, the attached patch > > adds that. > > > > Question: is it

Re: [r300] per-component negation for SWZ

2006-05-30 Thread Roland Scheidegger
Tilman Sauerbeck wrote: > Hi, > I finally ran glean today, and noticed that SWZ wasn't implemented > properly for r300 ARB vertex programs. > > So far I didn't handle per-component negation flags, the attached patch > adds that. > > Question: is it okay to assume that "NegateBase" in > struct pro

[r300] per-component negation for SWZ

2006-05-30 Thread Tilman Sauerbeck
Hi, I finally ran glean today, and noticed that SWZ wasn't implemented properly for r300 ARB vertex programs. So far I didn't handle per-component negation flags, the attached patch adds that. Question: is it okay to assume that "NegateBase" in struct prog_src_register will always be filled the w