Re: [Dri-devel] g++-3.0 fix for lib/GLU/libnurbs/nurbtess/quicksort.cc

2002-05-27 Thread Brian Paul
Felix Kühling wrote: Hi, I had trouble when compiling DRI with g++ 3.0.4 and -O3 related to function inlining. The function swap is declared static globally in quicksort.cc. In function quicksort it is redeclared. The redeclaration prevents g++ from inlining the swap function. Instead it

Re: [Dri-devel] g++-3.0 fix for lib/GLU/libnurbs/nurbtess/quicksort.cc

2002-05-27 Thread Brian Paul
Alexander Stohr wrote: Good fix Felix. I do hate local function prototypes. Its just bad coding style and laziness. Further it shows a critical lack of knowledge for the header file organisation. They are never verified against the implementation by the compiler and might be

RE: [Dri-devel] g++-3.0 fix for lib/GLU/libnurbs/nurbtess/quicksort.cc

2002-05-24 Thread Alexander Stohr
Good fix Felix. I do hate local function prototypes. Its just bad coding style and laziness. Further it shows a critical lack of knowledge for the header file organisation. They are never verified against the implementation by the compiler and might be overseen rather quickly when the

Re: [Dri-devel] g++-3.0 fix for lib/GLU/libnurbs/nurbtess/quicksort.cc

2002-05-24 Thread Felix Kühling
On Fri, 24 May 2002 18:18:51 +0200 Alexander Stohr [EMAIL PROTECTED] wrote: Good fix Felix. I do hate local function prototypes. Its just bad coding style and laziness. Further it shows a critical lack of knowledge for the header file organisation. In this case there aren't even any

Re: [Dri-devel] g++-3.0 fix for lib/GLU/libnurbs/nurbtess/quicksort.cc

2002-05-24 Thread David Dawes
On Thu, May 23, 2002 at 10:44:20PM +0200, Felix Kühling wrote: Hi, I had trouble when compiling DRI with g++ 3.0.4 and -O3 related to function inlining. The function swap is declared static globally in quicksort.cc. In function quicksort it is redeclared. The redeclaration prevents g++ from