Re: remove trailing white space from DRM directory

2004-09-08 Thread Jon Smirl
The purpose of returning -EINVAL is to flush out the few people that are using xorg.conf to change the location of their framebuffer. Changing the framebuffer location with xorg.conf on Linux is an illegal operation that happened to work on older kernels but it is very likely to break on newer one

Re: remove trailing white space from DRM directory

2004-09-08 Thread Felix Kühling
On Wed, 8 Sep 2004 02:45:46 +0100 (IST) Dave Airlie <[EMAIL PROTECTED]> wrote: > > sorry its in the kernel tarball... > > > > I'm game if you want to run it over the whole project. Let's merge > > dyn-minor first so I don't have to rewrite it. > > > > Are you ok with perm.patch going in? > > If

Re: remove trailing white space from DRM directory

2004-09-07 Thread Dave Airlie
sorry its in the kernel tarball... > > I'm game if you want to run it over the whole project. Let's merge > dyn-minor first so I don't have to rewrite it. > > Are you ok with perm.patch going in? If it fixes up the savage put it in, the real work is starting to impinge on my drm hacking at the mo

Re: remove trailing white space from DRM directory

2004-09-07 Thread Jon Smirl
On Wed, 8 Sep 2004 02:34:24 +0100 (IST), Dave Airlie <[EMAIL PROTECTED]> wrote: > scripts/Lindent, I used it on the i915.. You didn't check it in. I'm game if you want to run it over the whole project. Let's merge dyn-minor first so I don't have to rewrite it. Are you ok with perm.patch going in

Re: remove trailing white space from DRM directory

2004-09-07 Thread Dave Airlie
> checking anything in. I'd prefer that route since it enforces style > rules. There's an approved set of parameters for using ident on the > kernel somewhere. > scripts/Lindent, I used it on the i915.. Dave. > > On Wed, 8 Sep 2004 00:47:24 +0100 (IST), Dave Airlie <[EMAIL PROTECTED]> wrote: > >

Re: remove trailing white space from DRM directory

2004-09-07 Thread Jon Smirl
I just checked and we have trailing blanks all over the place in the kernel tree too. Instead of just fixing the trailing blanks maybe we should bite the bullet and run indent over everthing. There are about 1,500 lines with trailing white space. You don't lose the blame annotations, you just have

Re: remove trailing white space from DRM directory

2004-09-07 Thread Dave Airlie
> I used sed: > sed -e 's/[ ]*$//' < $TMP > $1 > > to strip the trailing white space from all of the DRM files. > Any objections to a check in? Kernel rules for patches are no trailing > white space. Hold off for a while, the problem with this is generating diffs against the kernel gets mess

Re: remove trailing white space from DRM directory

2004-09-07 Thread Jon Smirl
When we get to a point that there are no big patches pending I'd like to run the whole thing through ident with the default kernel indent rules. But doing that will break any pending patches. Just stripping the white space off from the end shouldn't upset any development. On Tue, 7 Sep 2004 20:43

Re: remove trailing white space from DRM directory

2004-09-07 Thread Simon 'corecode' Schubert
On 07.09.2004, at 18:54, Jon Smirl wrote: I used sed: sed -e 's/[ ]*$//' < $TMP > $1 to strip the trailing white space from all of the DRM files. Any objections to a check in? Kernel rules for patches are no trailing white space. while you're at doing whitespace commits: there is a bunch of st