Re: [Intel-gfx] [PATCH] Manage PIPESTAT pending interrupt values to unblock vblank interrupts

2008-11-04 Thread Eric Anholt
pending pipe status */ + I915_WRITE(PIPEASTAT, I915_READ(PIPEASTAT) 0x8000); + I915_WRITE(PIPEBSTAT, I915_READ(PIPEBSTAT) 0x8000); Could we get a PIPESTAT_STATUS_MASK instead of 0x800 all over? -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED

[PATCH] drm: Remove infrastructure for supporting i915's vblank swapping.

2008-11-04 Thread Eric Anholt
It's not used in any other drivers, and doesn't look like it will be from drm.git master. Signed-off-by: Eric Anholt [EMAIL PROTECTED] --- drivers/gpu/drm/drm_irq.c | 80 drivers/gpu/drm/drm_lock.c |9 - drivers/gpu/drm/drm_stub.c |1

[PATCH] i915: Remove racy delayed vblank swap ioctl.

2008-11-04 Thread Eric Anholt
and emitting wait-for-vblank-before-rendering in the command stream. That path also falls back correctly, at the performance cost of not being able to queue up rendering before the flip occurs. Signed-off-by: Eric Anholt [EMAIL PROTECTED] --- drivers/gpu/drm/i915/i915_drv.h | 15 -- drivers/gpu/drm/i915

Re: [PATCH] DRM: radeon: map registers at load time

2008-11-05 Thread Eric Anholt
://lists.sourceforge.net/lists/listinfo/dri-devel -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part - This SF.Net email is sponsored by the Moblin Your

Re: [PATCH] DRM: i915: add GEM GTT mapping support

2008-11-05 Thread Eric Anholt
) + 0xf000) 32; val |= obj_priv-gtt_offset 0xf000; val |= ((obj_priv-stride / 128) - 1) I965_FENCE_PITCH_SHIFT; if (obj_priv-tiling_mode == I915_TILING_Y) -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc

[PATCH] i915: Filter pci devices based on PCI_CLASS_DISPLAY_VGA

2008-11-05 Thread Eric Anholt
This fixes hangs on 855-class hardware by avoiding double attachment of the driver due to the stub second head device having the same pci id as the real device. Other DRM drivers probably want this treatment as well, but I'm applying it just to this one for safety. Signed-off-by: Eric Anholt

Re: [Intel-gfx] [PATCH] Manage PIPESTAT pending interrupt values to unblock vblank interrupts

2008-11-07 Thread Eric Anholt
On Fri, 2008-11-07 at 14:01 +, Steven J Newbury wrote: On Tue, 2008-11-04 at 16:04 -0800, Eric Anholt wrote: On Tue, 2008-11-04 at 02:03 -0800, Keith Packard wrote: The pipestat fields affect reporting of all vblank-related interrupts, so we have to reset them during

Final intel IRQ fixes patch series

2008-11-11 Thread Eric Anholt
This is the patch series I've pushed to for-airlied for 2.6.28. It's similar to the previous IRQ patch series, but with the IMR - IER change that had snuck in reverted. On non-MSI chipsets, twiddling IER apparently sometimes gets the interrupt wedged despite IIR=0, and the interrupt gets

[PATCH] i915: Manage PIPESTAT to control vblank interrupts instead of IMR.

2008-11-11 Thread Eric Anholt
see an interrupt again. This patch adds i915_enable_pipestat and i915_disable_pipestat to abstract out the steps needed to change the reported interrupts. Signed-off-by: Keith Packard [EMAIL PROTECTED] Signed-off-by: Eric Anholt [EMAIL PROTECTED] --- drivers/gpu/drm/i915/i915_drv.h |8

Re: [PATCH] DRM: i915: add GEM GTT mapping support

2008-11-11 Thread Eric Anholt
with the libdrm stuff and this fixed. addr_ptr should probably be called offset since it's not actually a pointer, right? -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part

Re: [PATCH] DRM: i915: add GEM GTT mapping support

2008-11-11 Thread Eric Anholt
On Tue, 2008-11-11 at 17:15 -0800, Jesse Barnes wrote: On Tuesday, November 11, 2008 4:55 pm Eric Anholt wrote: On Tue, 2008-11-11 at 16:48 -0800, Jesse Barnes wrote: On Tuesday, November 11, 2008 2:16 pm Jesse Barnes wrote: +struct drm_i915_gem_mmap_gtt { + /** Handle

Re: [Intel-gfx] [patch] Use intel_viewport for i915 dri driver

2008-11-13 Thread Eric Anholt
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part - This SF.Net email is sponsored

Re: [Intel-gfx] [PATCH][drm/i915] restore HWS_PGA if resuming from suspend

2008-11-17 Thread Eric Anholt
; + } obj = drm_gem_object_alloc(dev, 4096); if (obj == NULL) { ___ Intel-gfx mailing list [EMAIL PROTECTED] http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Eric Anholt [EMAIL PROTECTED] [EMAIL

Re: [PATCH] DRM: add mode setting support

2008-11-20 Thread Eric Anholt
file mode 100644 index 000..dccfba9 --- /dev/null +++ b/include/drm/drm_edid.h @@ -0,0 +1,178 @@ +#ifndef __DRM_EDID_H__ +#define __DRM_EDID_H__ + +#include linux/types.h Copyright? -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc

Re: [PATCH] DRM: i915: add mode setting support

2008-11-20 Thread Eric Anholt
to write DP support. My major concern is basically license clarification. diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h new file mode 100644 index 000..b122ea1 --- /dev/null +++ b/drivers/gpu/drm/i915/dvo.h @@ -0,0 +1,159 @@ +/* + * Copyright © 2006 Eric Anholt

Re: Handling buffer swaps in composited environments

2008-11-25 Thread Eric Anholt
(waiting only for getting its n-1 frame completed), getting damage posted as it swaps (flips front/back BO handles), and the compositor's picking up the last swapped frame when it wakes up to prepare the next frame to get displayed. -- Eric Anholt [EMAIL PROTECTED] [EMAIL

[PATCH] drm/i915: Respect GM965/GM45 bit-17-instead-of-bit-11 option for swizzling.

2008-11-25 Thread Eric Anholt
intrusive changes targeted at the next kernel release, not this one. Signed-off-by: Eric Anholt [EMAIL PROTECTED] --- drivers/gpu/drm/i915/i915_gem_tiling.c |7 --- drivers/gpu/drm/i915/i915_reg.h|1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH] [drm/i915] Retry execbuffer pinning after clearing the GTT

2008-11-25 Thread Eric Anholt
*/ + for (i = 0; i pinned; i++) + i915_gem_object_unpin(object_list[i]); + + /* evict everyone we can from the aperture */ + ret = i915_gem_evict_everything(dev); + if (ret) + goto err; } -- Eric

Re: [Intel-gfx] [PATCH] [drm/i915] In execbuffer, split handle lookup and relocation

2008-11-25 Thread Eric Anholt
++) { object_list[i]-pending_read_domains = 0; object_list[i]-pending_write_domain = 0; ret = i915_gem_object_pin_and_relocate(object_list[i], -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc Description: This is a digitally signed

Re: intel renderbuffer formats

2008-11-30 Thread Eric Anholt
by the hardware or the driver? Can the hardware do RGBA16? The public specs list r10g10b10a2, r16g16b16a16, and many others as available formats. -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part

Re: intel text mode restore problem

2008-12-10 Thread Eric Anholt
. -- Eric Anholt [EMAIL PROTECTED] [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada

Re: [Intel-gfx] [PATCH] Reallocate frame buffer on resize

2008-12-11 Thread Eric Anholt
-virtualX; + else + fb_height = pScrn-virtualY; +} FbMemBox-x1 = 0; FbMemBox-x2 = pScrn-displayWidth; -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] libdrm merge of KMS bits

2008-12-12 Thread Eric Anholt
does would be awesome) -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- SF.Net email is Sponsored by MIX09, March 18-20

Re: [Intel-gfx] [PATCH] [intel] Dump out memory usage information when the kernel fails to pin

2008-12-13 Thread Eric Anholt
available aperture, %dkb vs %dkb\n, total / 1024, (int)bufmgr_gem-gtt_size / 1024); return -1; -- 1.5.6.5 ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Eric

Re: [Intel-gfx] [PATCH] intel: Limit re-use cache size

2008-12-15 Thread Eric Anholt
; } } -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las

Re: [Intel-gfx] [PATCH] intel: Cache tiling/swizzle state in user mode. Reset tiling on reuse.

2008-12-15 Thread Eric Anholt
; +*swizzle_mode = bo_gem-swizzle_mode; return 0; } -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- SF.Net

Re: [Intel-gfx] [PATCH] Make i830_allocate_memory take tiling parameters.

2008-12-15 Thread Eric Anholt
) { + name, size, PITCH_NONE, GTT_PAGE_SIZE, + ALIGN_BOTH_ENDS, TILE_NONE)) == NULL) { ErrorF(Fail to alloc \n); return BadAlloc; } -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message

Re: [Intel-gfx] [PATCH] intel: When re-use cache is full, wait instead of allocating

2008-12-15 Thread Eric Anholt
-max_entries) + alloc_from_cache = 1; + else { + ret = ioctl(bufmgr_gem-fd, DRM_IOCTL_I915_GEM_BUSY, busy); + alloc_from_cache = (ret == 0 busy.busy == 0); + } if (alloc_from_cache) { bucket-head = bo_gem-next; -- Eric Anholt e...@anholt.net

[PATCH] intel: Sync GEM ioctl comments for easier diffing against the kernel.

2008-12-17 Thread Eric Anholt
--- shared-core/i915_drm.h | 27 --- 1 files changed, 20 insertions(+), 7 deletions(-) diff --git a/shared-core/i915_drm.h b/shared-core/i915_drm.h index 976ff18..628f7f8 100644 --- a/shared-core/i915_drm.h +++ b/shared-core/i915_drm.h @@ -469,8 +469,12 @@ struct

[PATCH] intel: Rename plane[AB]* back to pipe[AB]*.

2008-12-17 Thread Eric Anholt
The values are really going to continue meaning pipe, not plane, and that's what they're called in the kernel copy of the header. Userland hasn't ever made the switch to pipe!=plane, since userland checks are based on DRM version, which is still stuck at 1.6. However, Mesa did start using

Re: [PATCH] Pin new and unpin old buffer when setting a mode.

2008-12-19 Thread Eric Anholt
On Wed, 2008-12-17 at 22:14 -0500, Kristian Høgsberg wrote: This removes the requirement for user space to pin a buffer before setting a mode that is backed by the pixels from that buffer. Signed-off-by: Kristian Høgsberg k...@redhat.com Committed. Thanks! -- Eric Anholt e...@anholt.net

Re: [PATCH 0/6] drm/i915: fix sparse warnings

2008-12-19 Thread Eric Anholt
deleting the function, and using the updated #6 patch. Thanks! -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/3] drivers/gpu/drm: Move a dereference below a NULL test

2008-12-19 Thread Eric Anholt
? The original test is to check it dev-driver-unload exists, not it dev-driver exists. I think your test parameters are wrong. No, it was valid, but I think the better patch is: From 1e0a24cfe75a328db5a50dbcdaaf0eb461638b6b Mon Sep 17 00:00:00 2001 From: Eric Anholt e...@anholt.net Date: Fri, 19

Re: [PATCH] Rework DRM proc file handling

2008-12-19 Thread Eric Anholt
than reviewing a 1700-line patch :) -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Intel-gfx] [PATCH] Rework DRM proc file handling

2008-12-19 Thread Eric Anholt
On Sat, 2008-12-20 at 09:21 +1000, Dave Airlie wrote: On Sat, Dec 20, 2008 at 9:19 AM, Eric Anholt e...@anholt.net wrote: On Tue, 2008-12-09 at 14:00 -0500, Ben Gamari wrote: Hey everyone, This is the latest version of my procfs file handling patch. I have ported the old proc files

[PATCH] drm: Add a debug node for vblank state.

2008-12-19 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/drm_irq.c |9 ++ drivers/gpu/drm/drm_proc.c | 63 include/drm/drmP.h |1 + 3 files changed, 73 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b

Re: [PATCH 2/13] drivers/gpu/drm/i915: Remove redundant test

2008-12-21 Thread Eric Anholt
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

[ANNOUNCE] libdrm-2.4.3

2008-12-22 Thread Eric Anholt
: ddf2876bd8b4b484a9c2a360a835aee8 libdrm-2.4.3.tar.gz SHA1: 465f3b7d26021225ca936043fbfadc2780f13653 libdrm-2.4.3.tar.gz -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Intel-gfx] [PATCH] drm/i915: use drm vma accounting functions to make sure VMs don't get lost

2009-01-02 Thread Eric Anholt
vm_area_struct *vma); extern unsigned long drm_core_get_map_ofs(struct drm_map * map); extern unsigned long drm_core_get_reg_ofs(struct drm_device *dev); extern unsigned int drm_poll(struct file *filp, struct poll_table_struct *wait); -- Eric Anholt e...@anholt.net eric.anh

[PATCH] drm/i915: Don't allow objects to get bound while VT switched.

2009-01-05 Thread Eric Anholt
fallback performance. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index cc2ca55..14afc23 100644 --- a/drivers

[PATCH] drm/i915: Respect the other stolen memory sizes we know of.

2009-01-05 Thread Eric Anholt
fd.o bug #19336. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_dma.c | 46 --- drivers/gpu/drm/i915/i915_reg.h |8 ++- 2 files changed, 40 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b

[PATCH] drm/i915: Pin cursor bo and unpin old bo when setting cursor.

2009-01-05 Thread Eric Anholt
From: Kristian Høgsberg k...@redhat.com We also didn't track the cursor bo before and would leak a reference when the cursor image was change. Signed-off-by: Kristian Høgsberg k...@redhat.com Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/intel_display.c | 29

[PATCH] drm/i915: Don't oops when root asks to unpin an already unpinned buffer.

2009-01-05 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 14afc23..e87db6f 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b

intel KMS and stability series

2009-01-05 Thread Eric Anholt
Here comes a series of patches I've been cleaning up over the last few days. The first couple are bugfixes that we've tripped over with 2.6.28 that I'll want to get merged to stable. The rest are getting KMS ready to go. Dropped from the series is airlied's vma patch, which caused lock ordering

[PATCH] drm/i915: Fix failure to take the mode_config lock in driver setup.

2009-01-05 Thread Eric Anholt
We're not really concerned with races during setup, but we do want to keep the warning around given how easy it is to misplace that lock. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/drm_crtc_helper.c |3 +++ drivers/gpu/drm/i915/intel_tv.c |2 ++ 2 files changed, 5

[PATCH] drm/i915: Non-mobile parts don't have integrated TV-out.

2009-01-05 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 14d82de..5824462 100644 --- a/drivers/gpu/drm/i915

[PATCH] drm/i915: Add support for integrated HDMI on G4X hardware.

2009-01-05 Thread Eric Anholt
This is ported directly from the userland 2D driver code. The HDMI audio bits aren't hooked up yet. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/Makefile|1 + drivers/gpu/drm/i915/i915_drv.h |2 + drivers/gpu/drm/i915/i915_reg.h | 17

Re: [PATCH] drm/i915: Don't oops when root asks to unpin an already unpinned buffer.

2009-01-06 Thread Eric Anholt
On Tue, 2009-01-06 at 14:22 +, Renato Caldas wrote: Hello, On Tue, Jan 6, 2009 at 12:34 AM, Eric Anholt e...@anholt.net wrote: Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff

Re: KMS with Xorg on G45 failing

2009-01-06 Thread Eric Anholt
happily submit a bug but thought the code was a little too new to harp on about especially if this is a known issue The segfault should be fixed as of: commit 342120be0956bfc12822d1ffbfbd8aaabf3e922f Author: Eric Anholt e...@anholt.net Date: Mon Jan 5 23:21:07 2009 -0800 Fix pin leakage

Re: [RFC] add timeout to drmWaitVBlank to avoid hangs

2009-01-07 Thread Eric Anholt
=], [AC_CHECK_LIB([rt], [clock_gettime], [CLOCK_LIB=-lrt], [AC_MSG_ERROR([Couldn't find clock_gettime])])]) AC_SUBST([CLOCK_LIB]) -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] create IDR mutex for mode_config identifier allocation

2009-01-14 Thread Eric Anholt
configuration (mode lists etc.) */ + struct mutex idr_mutex; /* for IDR management */ struct idr crtc_idr; /* use this idr for all IDs, fb, crtc, connector, modes - just makes life easier */ /* this is limited to one for now */ int num_fb; -- Eric Anholt e...@anholt.net

Re: [PATCH] add debugfs init hooks

2009-01-14 Thread Eric Anholt
, watch the whitespace -- the kernel uses 8-space tabs, not 8 spaces. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] add DRM_DEBUGFS config option to Kconfig

2009-01-14 Thread Eric Anholt
the debugfs filesystem + for the DRM and drivers. + config DRM_TDFX tristate 3dfx Banshee/Voodoo3+ depends on DRM PCI I'd rather see this not be an option -- if you've got both debugfs and drm in your kernel, you get the drm debugfs bits. -- Eric Anholt e...@anholt.net

Re: Add GEM to i915 broke compilation on MIPS

2009-01-14 Thread Eric Anholt
8a8d7ba9cac5f569c9b0426e583203bab1feeb73 Mon Sep 17 00:00:00 2001 From: Eric Anholt e...@anholt.net Date: Wed, 14 Jan 2009 17:16:25 -0800 Subject: [PATCH] drm: stash AGP include under the do-we-have-AGP ifdef This should fix the MIPS with DRM build. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu

Re: [Intel-gfx] [RFC] VGA hotplug support for i915 kms

2009-01-17 Thread Eric Anholt
. Our experience with trying to do something sensible when we notice new things plugged in in the early randr 1.2 days was that it was a terrible idea that made users hate us. I suspect it would be even worse if we tried it in the kernel. -- Eric Anholt e...@anholt.net

[PATCH] drm/i915: Skip SDVO/HDMI init when the chipset tells us it's not present.

2009-01-23 Thread Eric Anholt
This saves startup time from probing SDVO, and saves setting up HDMI outputs on G4X devices that don't have them. --- drivers/gpu/drm/i915/intel_display.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c

[PATCH] drm/i915: Suppress GEM teardown on X Server exit in KMS mode.

2009-01-23 Thread Eric Anholt
Fixes hangs when starting X for the second time. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 96316fd..3741101

Re: [Intel-gfx] [PATCH] support tiled rendering in 2D driver

2009-01-23 Thread Eric Anholt
will use the tiling state rather than the unset fence registers, and you'll get swizzled. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Intel-gfx] [PATCH] add fence register management to execbuf

2009-01-23 Thread Eric Anholt
code probably ought to live in i915_gem_tiling.c. Something for the next kernel, I guess. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Intel-gfx] [PATCH] support tiled rendering in 2D driver

2009-01-23 Thread Eric Anholt
On Fri, 2009-01-23 at 16:24 -0800, Eric Anholt wrote: On Fri, 2009-01-23 at 14:15 -0800, Jesse Barnes wrote: Set alignments, tile settings and flags correctly in the 2D driver to support tiled rendering. UXA's create pixmap function currently assumes the worst about the alignment

Re: [Intel-gfx] [PATCH] support tiled rendering in 2D driver

2009-01-27 Thread Eric Anholt
On Sat, 2009-01-24 at 11:01 -0800, Jesse Barnes wrote: On Friday, January 23, 2009 4:24 pm Eric Anholt wrote: +/** + * On some chips, pitch width has to be a power of two tile width, so + * calculate that here. + */ +unsigned long +I830GetFencePitch(I830Ptr pI830, unsigned long

[PATCH] drm: Rip out the racy, unused vblank signal code.

2009-01-27 Thread Eric Anholt
Schedule a vblank signal, kill the process, and we'll go walking over freed memory. Given that no open-source userland exists using this, nor have I ever heard of a consumer, just let this code die. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/drm_irq.c | 161

Re: [PATCH] drm: Drop unused and broken dri_library_name sysfs attribute.

2009-01-29 Thread Eric Anholt
this. Acked-by: Eric Anholt e...@anholt.net -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- This SF.net email

Re: [PATCH 2/3] drm: Split drm_map and drm_local_map

2009-02-02 Thread Eric Anholt
some remote plans and half finished patch to completely kill the drm_local_map_t typedef so I left those bits in. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Thanks for taking on this mess! Acked-by: Eric Anholt e...@anholt.net -- Eric Anholt e...@anholt.net

Re: [PATCH 3/3] drm: Make drm_local_map use a resource_size_t offset

2009-02-02 Thread Eric Anholt
is fixed at a 32-bit offset, while PCI resources may live above that, we ignore the map offset for maps of type _DRM_FRAMEBUFFER or _DRM_REGISTERS. It is assumed that each driver will have only one resource of each type. (I want to remember later what exact ABI problem was in question) -- Eric Anholt

Re: [PATCH 1/3] drm: Use resource_size_t for drm_get_resource_{start, len}

2009-02-02 Thread Eric Anholt
-- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

[PATCH] drm: Fix lock order reversal between mmap_sem and struct_mutex.

2009-02-03 Thread Eric Anholt
()), such as i915_gem_pwrite(). Solve this by moving the one thing that needed struct_mutex with mmap_sem held to using a lock to cover just those data structures (offset hash and offset manager). Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/drm_gem.c |8 drivers/gpu

Re: intel bufmgr concerns?

2009-02-04 Thread Eric Anholt
. What happens if a shared texture, for example, is used by multiple contexts from multiple threads simultaneously? Shared textures and renderbuffers don't have relocations. validate_index is protected by the lock held across bo_exec. check_aperture needs the same locking treatment. -- Eric Anholt

Re: Gem GTT mmaps..

2009-02-04 Thread Eric Anholt
. You do need to refcount the objects. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- Create and Deploy Rich Internet

Re: [Bug #12574] possible circular locking dependency detected

2009-02-10 Thread Eric Anholt
to the GTT mmap code. It's going to be a pain to fix (I tried getting the mmap_sem - struct_mutex path to go away, but the fact that mmap_sem is held over the fault handler pretty much kills that). It's high on the list, though. -- Eric Anholt e...@anholt.net eric.anh...@intel.com

Re: Gem GTT mmaps..

2009-02-10 Thread Eric Anholt
object to be freed sw_finish doesn't mean unmap (note that it doesn't actually unmap). If you want to actually unmap, that should be done with munmap. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message

Re: [Mesa3d-dev] radeon-rewrite branch merging.

2009-02-11 Thread Eric Anholt
tree is mostly memory management and fbo handling right now (until I fix it, then we'll hopefully need a more complicated testcase than gears to actually hit it hard). -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally

Re: [PATCH 1/2] Remove Intel drivers from linux-core

2009-02-15 Thread Eric Anholt
. Signed-off-by: Pekka Paalanen p...@iki.fi --- If the patches are acceptable, I can push them myself to drm.git. Acked-by: Eric Anholt e...@anholt.net -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message

[PATCH] drm: Fix lock order reversal between mmap_sem and struct_mutex.

2009-02-17 Thread Eric Anholt
(copy_from/to_user()), such as i915_gem_pwrite(). Solve this by moving the easy things that needed struct_mutex with mmap_sem held to using a lock to cover just those data structures (offset hash and offset manager), and do trylock and reschedule in fault. Signed-off-by: Eric Anholt e...@anholt.net

Re: [PATCH] drm: Take mmap_sem up front to avoid lock order violations.

2009-02-18 Thread Eric Anholt
); + up_read(current-mm-mmap_sem); + pre_mutex_err: drm_free(object_list, sizeof(*object_list) * args-buffer_count, DRM_MEM_DRIVER); -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] drm: Fix lock order reversal between mmap_sem and struct_mutex.

2009-02-19 Thread Eric Anholt
object caching in the future, which has the potential of saving steaming piles of memory. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] drm: Take mmap_sem up front to avoid lock order violations.

2009-02-20 Thread Eric Anholt
bulk copies (ie. that will blow the L1 cache), do you? 16kb is the most common size (batchbuffers). 32k is popular on 915 (vertex), and varying between 0-128k on 965 (vertex). The pwrite path generally represents 10-30% of CPU consumption in CPU-bound apps. -- Eric Anholt e...@anholt.net

Re: [PATCH 2/4] radeon: add r6xx/r7xx microcode

2009-02-24 Thread Eric Anholt
loading framework for DRM drivers instead of building it into the code. Maybe do it with the introduction of new microcode here? [1] http://lkml.org/lkml/2008/8/7/42 -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed

Re: [PATCH] drm: Fix lock order reversal between mmap_sem and struct_mutex.

2009-02-25 Thread Eric Anholt
On Fri, 2009-02-20 at 08:36 +0100, Peter Zijlstra wrote: On Thu, 2009-02-19 at 18:04 -0800, Eric Anholt wrote: On Thu, 2009-02-19 at 23:26 +0100, Peter Zijlstra wrote: On Thu, 2009-02-19 at 22:02 +0100, Thomas Hellstrom wrote: It looks to me like the driver preferred locking order

Re: i915 X lockup

2009-02-27 Thread Eric Anholt
by using nomodesetting so that might be a quick thing to try... KMS support is not a feature of the server but of your 2D driver. You want 2.6.2, or things will be bad. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally

Re: i915 X lockup

2009-02-28 Thread Eric Anholt
On Sat, 2009-02-28 at 00:47 -0800, Andrew Morton wrote: On Sat, 28 Feb 2009 09:31:28 +0100 Jiri Slaby jirisl...@gmail.com wrote: On 28.2.2009 01:20, Eric Anholt wrote: KMS support is not a feature of the server but of your 2D driver. You want 2.6.2, or things will be bad. I have

Re: i915 X lockup

2009-02-28 Thread Eric Anholt
On Sat, 2009-02-28 at 19:24 +0100, Bruno Prémont wrote: On Sat, 28 February 2009 Eric Anholt e...@anholt.net wrote: On Sat, 2009-02-28 at 00:47 -0800, Andrew Morton wrote: The kernel deadlocked on struct_mutex, did it not? That's a kernel bug regardless of what userspace you're running

Re: [TIP,regression,i915] /dev/dri/card0 is no longer present

2009-03-03 Thread Eric Anholt
behavior). Give us a mapping, whether or not it's really WC. Failing the mapping is not OK. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Intel-gfx] [PATCH] drm/i915: TV modes' parameters sync up with 2D driver

2009-03-06 Thread Eric Anholt
it my best shot, not being the author of the change. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- Open Source

Re: [Patch 1/5]: DRM/I915: Add the crt save/restore function for VT switch

2009-03-06 Thread Eric Anholt
talking about for user-mode backporting last week? -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- Open Source Business

Re: [Patch 4/5]: DRM/I915: Add the load-detection for crt detect

2009-03-06 Thread Eric Anholt
(intel_output, NULL, + dpms_mode); Indent this guy into lining up with the other arguments. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] make KMS resource mappings exclusive

2009-03-06 Thread Eric Anholt
of really useful userland tools for debugging that rely on read-only mapping of registers, we're pending this until we get that information into the kernel somehow. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed

Re: [Patch 3/5]: DRM/I915: Sync crt hotplug detection with intel video driver

2009-03-06 Thread Eric Anholt
Yakui yakui.z...@intel.com Signed-off-by: Eric Anholt e...@anholt.net (please use this format in the future) -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Intel-gfx] [PATCH] xf86-video-intel: support swapbuffers using page flipping

2009-03-06 Thread Eric Anholt
is getting a outside-of-this-client reference to it and avoid putting it in the BO cache if it gets unreferenced while still being scanned out. -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [PATCH] drm: edid revision 0 is valid

2009-03-10 Thread Eric Anholt
w/ CVT calculation, etc. right now for an embedded Linux video project. Would there be any interest incorporating parts of that work? There's work going on for CEA-861 and syncing KMS against UMS. But certainly we love fixes when we don't even have to write them ourselves. -- Eric Anholt e

[PATCH] drm: Use a little stash on the stack to avoid kmalloc in most DRM ioctls.

2009-03-19 Thread Eric Anholt
The kmalloc was taking up about 1.5% of the CPU on an ioctl-heavy workload (x11perf -aa10text on 965). Initial results look like they have a corresponding improvement in performance for aa10text, but more numbers might not hurt. Thanks to ajax for pointing out this performance regression I'd

Re: [Intel-gfx] [PATCH] drm/i915: Fix TV get_modes to return modes count

2009-03-20 Thread Eric Anholt
and applied this series, but in the future please use separate commits for separate issues (for example with this commit, one would be returning the count, one would be int overflow, and one would be the clock accuracy check). -- Eric Anholt e...@anholt.net eric.anh...@intel.com

Re: [Intel-gfx] [PATCH] drm/i915: Check for dev-primary-master before dereference.

2009-03-20 Thread Eric Anholt
them? I think for any future performance debug like these did, we'd just expose values in debugfs (it keeps the debug code from interfering with app behavior, anyway). -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally

Re: [Patch 0/3]: [DRM/I915] : Sync the mode validation for INTERLACE/DBLSCAN

2009-03-20 Thread Eric Anholt
) { if (mode-status == MODE_OK) mode-status = connector_funcs-mode_valid(connector, -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part

Re: [Patch 3/3]: [DRM/I915] : Sync the default modes for LVDS output device

2009-03-20 Thread Eric Anholt
+ fixed_ret + ret; } /** -- Eric Anholt e...@anholt.net eric.anh...@intel.com signature.asc Description: This is a digitally signed message part -- Apps built with the Adobe(R) Flex(R

Re: [Intel-gfx] [PATCH] drm: read EDID extensions from monitor (v2)

2009-03-20 Thread Eric Anholt
, struct edid *edid); extern void drm_mode_probed_add(struct drm_connector *connector, struct drm_display_mode *mode); extern void drm_mode_remove(struct drm_connector *connector, struct drm_display_mode *mode); -- Eric Anholt e...@anholt.net eric.anh...@intel.com

[PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path.

2009-03-25 Thread Eric Anholt
to using get_user_pages to pin the user's memory, and map those pages atomically when copying it to the GPU. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c | 166 -- 1 files changed, 139 insertions(+), 27 deletions(-) diff --git

[PATCH 2/6] drm/i915: Make GEM object's page lists refcounted instead of get/free.

2009-03-25 Thread Eric Anholt
We've wanted this for a few consumers that touch the pages directly (such as the following commit), which have been doing the refcounting outside of get/put pages. --- drivers/gpu/drm/i915/i915_drv.h |3 +- drivers/gpu/drm/i915/i915_gem.c | 70 --- 2

[PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path.

2009-03-25 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c | 221 ++- 1 files changed, 195 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index bdc7326..010af90 100644

[PATCH 3/6] drm/i915: Fix lock order reversal in shmem pwrite path.

2009-03-25 Thread Eric Anholt
Like the GTT pwrite path fix, this uses an optimistic path and a fallback to get_user_pages. Note that this means we have to stop using vfs_write and roll it ourselves. Signed-off-by: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c | 225

<    1   2   3   4   5   6   >