[PATCH v3 1/6] mfd:rtsx: Read vendor setting from config space

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Normally OEMs will set vendor setting to the config space of Realtek card reader in BIOS stage. This patch reads the setting at the first, and configure the internal registers according to it, to improve card reader's compatibility condition. Signed-off-by:

[PATCH v3 6/6] mfd:rtsx: Modify copyright comments

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Update copyright date, and remove author address. Signed-off-by: Wei WANG wei_w...@realsil.com.cn --- drivers/mfd/rtl8411.c |4 ++-- drivers/mfd/rts5209.c |3 +-- drivers/mfd/rts5227.c |5 +

[PATCH v3 2/6] mfd:rtsx: Add shutdown callback in rtsx_pci_driver

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Some actions to clear power state should be handled in .shutdown callback in rtsx_pci_driver. This patch adopts the following measures to catch this goal: 1. Add a function rtsx_pci_power_off to abstract the common ops in .shutdown and .suspend 2. Add

[PATCH v3 5/6] mfd:rtsx: Configure to enter a deeper power-saving mode in S3

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Set a bit to enable rts5227 and rts5249 to enter a deeper internal power-saving mode in S3, and recover it after resuming. Signed-off-by: Wei WANG wei_w...@realsil.com.cn --- drivers/mfd/rtl8411.c|2 +- drivers/mfd/rts5209.c|2 +-

[PATCH v3 4/6] mfd:rtsx: Clear hardware PFM mode in rtl8411b

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Clear hw_pfm_en to disable hardware PFM mode, to fix a bug that in some situation registers in 0xFDxx domain can't be accessed. Signed-off-by: Wei WANG wei_w...@realsil.com.cn --- drivers/mfd/rtl8411.c|2 ++ include/linux/mfd/rtsx_pci.h |1

[PATCH v3 3/6] mfd:rtsx: Move some actions from rtsx_pci_init_hw to individual extra_init_hw

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn These actions are individual for each reader model, so should be put in extra_init_hw instead of rtsx_pci_init_hw. Signed-off-by: Wei WANG wei_w...@realsil.com.cn --- drivers/mfd/rts5209.c |4 drivers/mfd/rts5227.c |2 ++

[PATCH v3 0/6] MFD patches for Realtek cardreader

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn v3: Seperate copyright changes to a distinct patch Modify some coding style and naming style Fix a bug that sd30_drive_sel would be assigned a wrong value, in rts5227 and rts5249 v2: Use macro when initializing vendor settings Wei WANG (6): mfd:rtsx:

Re: [PATCH] LMK: Optimize lowmem_shrink

2013-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2013 at 09:16:33AM +0800, Leon Ma wrote: From: Leon Ma xindong...@intel.com Date: Mon, 19 Aug 2013 14:22:38 +0800 Subject: [PATCH] LMK: Optimize lowmem_shrink. By comparing with selected_oom_score_adj instead of min_score_adj, we may do less calculation. The patch is line

Re: [PATCH] staging: dgnc: driver.c: fixes warning about assigning pointer

2013-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2013 at 12:18:10AM -0400, Lidza Louina wrote: This patch fixes a warning associated with assigining a pointer in the dgnc_mbuf function. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] staging: dgnc: mgmt.c: removes unused variable

2013-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2013 at 12:19:38AM -0400, Lidza Louina wrote: This patch removes the inode variable from the dgnc_mgmt_ioctl function. It's never used in the function. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/dgnc/dgnc_mgmt.c | 1 - 1 file changed, 1

[patch] staging: comedi: dt282x: dt282x_ai_insn_read() always fails

2013-08-20 Thread Dan Carpenter
In dt282x_ai_insn_read() we call this macro like: wait_for(!mux_busy(), comedi_error(dev, timeout\n); return -ETIME;); Because the if statement doesn't have curly braces it means we always return -ETIME and the function never succeeds. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com ---

[patch] staging: comedi: usbdux: allocating too much data

2013-08-20 Thread Dan Carpenter
We only need to allocate enough space for a pointer. We allocate the space for the urbs themselves with the call to usb_alloc_urb() a few lines later. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Untested. diff --git a/drivers/staging/comedi/drivers/usbdux.c

Re: [patch] staging: comedi: dt282x: dt282x_ai_insn_read() always fails

2013-08-20 Thread Ian Abbott
On 2013-08-20 09:57, Dan Carpenter wrote: In dt282x_ai_insn_read() we call this macro like: wait_for(!mux_busy(), comedi_error(dev, timeout\n); return -ETIME;); Because the if statement doesn't have curly braces it means we always return -ETIME and the function never succeeds. Signed-off-by:

Re: [patch] staging: comedi: pcmuio: remove an unneeded check

2013-08-20 Thread Ian Abbott
On 2013-08-20 10:00, Dan Carpenter wrote: devpriv is non-NULL at this point. We dereference it earlier in the function and the inconsistent checking upsets static checkers. We don't need to check devpriv-sprivs because kfree() accepts NULL pointers. Signed-off-by: Dan Carpenter

Re: [patch] staging: comedi: pcmuio: remove an unneeded check

2013-08-20 Thread Dan Carpenter
On Tue, Aug 20, 2013 at 11:02:45AM +0100, Ian Abbott wrote: On 2013-08-20 10:00, Dan Carpenter wrote: devpriv is non-NULL at this point. We dereference it earlier in the function and the inconsistent checking upsets static checkers. We don't need to check devpriv-sprivs because kfree()

[PATCH] staging: comedi: pcmmio: fix possible NULL deref on detach

2013-08-20 Thread Ian Abbott
pcmmio_detach is called by the comedi core even if pcmmio_attach() returned an error, so `dev-private` might be `NULL`. Check for that before dereferencing it. Also, as pointed out by Dan carpenter for the similar pcmuio driver, there is no need to check the pointer passed to `kfree()`, so

[PATCH] Staging: olpc_dcon: Removed more completed TODO entries

2013-08-20 Thread Jens Frederich
1. Console event notifier support: No one I've asked knows what this all about. 2. Audit code for unnecessary code: This is done. 3. Verify sane i2cAPI usage: This is also done. Signed-off-by: Jens Frederich jfreder...@gmail.com diff --git a/drivers/staging/olpc_dcon/TODO

[PATCH v2] staging: comedi: pcmmio: remove unneeded checks on detach

2013-08-20 Thread Ian Abbott
As pointed out by Dan carpenter for the similar pcmuio driver, there is no need to check the pointer passed to `kfree()`, so remove that check from `pcmmio_detach()`. Also, check the `devpriv` (`dev-private`) pointer once, outside the `for` loop. Signed-off-by: Ian Abbott abbo...@mev.co.uk Cc:

Re: [PATCH] staging: dgnc: mgmt.c: removes unused variable

2013-08-20 Thread Lidza Louina
On Tue, Aug 20, 2013 at 4:48 AM, Dan Carpenter dan.carpen...@oracle.com wrote: The ifdef here is to support older kernels which don't have the the -unlocked_ioctl function pointer. We don't care about older kernels so we could delete the #else side of this and remove the #ifdef. You can do

[PATCH v2 2/2] staging: dgnc: removes ifdef HAVE_UNLOCKED_IOCTL conditionals

2013-08-20 Thread Lidza Louina
This patch removes the HAVE_UNLOCKED_IOCTL conditional statements from driver.c, mgmt.c and mgmt.h. This was used to support older kernels. It isn't needed now. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 4 drivers/staging/dgnc/dgnc_mgmt.c

[PATCH] staging: et131x: Remove frame error TODO item

2013-08-20 Thread Mark Einon
After prolonged testing for a few days of normal use with new et131x hardware, I've concluded that this was a hardware issue with the older hardware I had. Removing this item from the TODO. Signed-off-by: Mark Einon mark.ei...@gmail.com --- drivers/staging/et131x/README |1 - 1 file changed,

Re: [PATCH v2 1/2] staging: dgnc: driver.c: fixes warning about assigning pointer

2013-08-20 Thread Greg KH
On Tue, Aug 20, 2013 at 02:15:35PM -0400, Lidza Louina wrote: This patch fixes a warning associated with assigining a pointer in the dgnc_mbuf function. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 1/2] staging: dgnc: driver.c: fixes warning about assigning pointer

2013-08-20 Thread Lidza Louina
Ok, I'm sending it now. On Tue, Aug 20, 2013 at 7:27 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Aug 20, 2013 at 02:15:35PM -0400, Lidza Louina wrote: This patch fixes a warning associated with assigining a pointer in the dgnc_mbuf function. Signed-off-by: Lidza Louina

[PATCH] staging: dgnc: builds into kernel

2013-08-20 Thread Lidza Louina
This patch builds the dgnc driver into the kernel. Signed-off-by: Lidza Louina lidza.lou...@gmail.com --- drivers/staging/Kconfig | 2 ++ drivers/staging/Makefile | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 1665705..0d9d92b

[PATCH 0/3] Fix sd3.0 issues for Realtek card reader

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Wei WANG (3): mfd:mmc:rtsx: Change default tx phase mmc:rtsx:Clear SD_CLK toggle enable bit if switching voltage fail mmc:memstick:rtsx: Modify copyright comments drivers/memstick/host/rtsx_pci_ms.c |3 +- drivers/mfd/rtl8411.c |

[PATCH 1/3] mfd:mmc:rtsx: Change default tx phase

2013-08-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn The default phase can meet most cards' requirement, but it is not the optimal one. In some extreme situation, the rx phase point produced by the following tuning process will drift quite a distance. Before tuning UHS card, this patch will set a more proper

[PATCH] LMK: Optimize lowmem_shrink

2013-08-20 Thread Leon Ma
From: Leon Ma xindong...@intel.com Date: Mon, 19 Aug 2013 14:22:38 +0800 Subject: [PATCH] LMK: Optimize lowmem_shrink. By comparing with selected_oom_score_adj instead of min_score_adj, we may do less calculation. Signed-off-by: Leon Ma xindong...@intel.com ---