Re: [PATCH 5/5] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation

2013-09-05 Thread Jürgen Beisert
Hi Dan, On Wednesday 04 September 2013 16:37:14 Dan Carpenter wrote: On Wed, Sep 04, 2013 at 03:01:46PM +0200, Juergen Beisert wrote: Signed-off-by: Juergen Beisert j...@pengutronix.de CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut ma...@denx.de

Re: [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits

2013-09-05 Thread Jürgen Beisert
Hi Marek, On Wednesday 04 September 2013 16:06:34 Marek Vasut wrote: [...] +# define LRADC_CTRL0_MX28_TOUCH_DETECT_ENABLE (1 23) +# define LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE(1 22) +# define LRADC_CTRL0_MX28_YNNSW/* YM */(1 21) +# define LRADC_CTRL0_MX28_YPNSW

Re: [PATCH v2] Staging: comedi: Fix dependencies for drivers misclassified as PCI

2013-09-05 Thread Ian Abbott
On 2013-09-05 01:00, Ben Hutchings wrote: The Fastwel UNIOxx-5 is a PC/104 board, so put COMEDI_UNIOXX5 under COMEDI_ISA_DRIVERS. The DIL/Net-PC 1486 is a 486 system, so put COMEDI_SSV_DNP under COMEDI_MISC_DRIVERS and add a dependency on X86_32 || COMPILE_TEST. Signed-off-by: Ben Hutchings

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Jürgen Beisert
Hi Dan, On Wednesday 04 September 2013 16:27:39 Dan Carpenter wrote: [...] ACTUALLY! When I look at it now the third argument is almost always set, clear or toggle. So we could do: static inline void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Dan Carpenter
On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote: I like this simplification, but all the other drivers for the MXS series of SoCs don't use such a method. Do you think this new style will be accepted? My lradc_plate_mask() is basically the same idea as what Marek said about

Re: [PATCH] mfd: rtsx: Modify rts5249_optimize_phy

2013-09-05 Thread Dan Carpenter
On Thu, Sep 05, 2013 at 05:45:38PM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn In some platforms, specially Thinkpad series, rts5249 won't be initialized properly. So we need adjust some phy parameters to improve the compatibility issue. Signed-off-by: Wei

Re: [PATCH 05/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

2013-09-05 Thread Pavel Machek
Hi! It'd be better to send a removal of the whole lot. Does anyone still use this driver? I do have the hardware, in subnotebook with terrible keyboard. So I do not use it a lot. Pavel -- (english)

Re: [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver

2013-09-05 Thread Marek Vasut
Dear Dan Carpenter, On Thu, Sep 05, 2013 at 12:16:18PM +0200, Jürgen Beisert wrote: I like this simplification, but all the other drivers for the MXS series of SoCs don't use such a method. Do you think this new style will be accepted? My lradc_plate_mask() is basically the same idea as

Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor

2013-09-05 Thread Gleb Natapov
On Wed, Sep 04, 2013 at 03:16:30PM +, KY Srinivasan wrote: -Original Message- From: Gleb Natapov [mailto:g...@redhat.com] Sent: Wednesday, September 04, 2013 2:40 AM To: KY Srinivasan Cc: x...@kernel.org; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;

drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)-(foo *)

2013-09-05 Thread Avi
From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001 From: AVI avi@avi-VPCCW15FG.(none) Date: Thu, 5 Sep 2013 21:03:45 +0530 Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: (foo*) should be (foo *) Signed-off-by: Avinash Kumar avi.kp@gmail.com ---

Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)-(foo *)

2013-09-05 Thread Dan Carpenter
Please send this instead of as an attachment. Send it to yourself first and apply it with 'git am'. Resend when that works. From: AVI avi@avi-VPCCW15FG.(none) That's wrong. The subject is too long and not the right format. It should be: Subject: [PATCH]

Re: [PATCH 2/3] staging: octeon-ethernet: remove skb alloc failure warnings

2013-09-05 Thread David Daney
On 09/05/2013 11:44 AM, Aaro Koskinen wrote: Remove skb allocation failure warnings. They will trigger a page allocation warning already. Also, one of the warnings was not ratelimited, causing the box to lock up under heavy traffic low memory. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi

Re: [PATCH 1/3] staging: octeon-ethernet: make dropped packets to consume NAPI budget

2013-09-05 Thread David Daney
On 09/05/2013 11:43 AM, Aaro Koskinen wrote: We should count also dropped packets, otherwise the NAPI handler may end up running too long. Is this actually a problem? If so ... the patch looks sane and you and add Acked-by me. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi ---

[PATCH 2/3] staging: octeon-ethernet: remove skb alloc failure warnings

2013-09-05 Thread Aaro Koskinen
Remove skb allocation failure warnings. They will trigger a page allocation warning already. Also, one of the warnings was not ratelimited, causing the box to lock up under heavy traffic low memory. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/staging/octeon/ethernet-mem.c | 7

Re: [patch] iio: mxs-lradc: use helper functions to simplify the code

2013-09-05 Thread Fabio Estevam
On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter dan.carpen...@oracle.com wrote: I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies the callers and makes the lines shorter. Looks good, just one minor suggestion: Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff

[PATCH] staging: bcm: InterfaceMisc.c: fixed styling issue in casting (foo*)-(foo *)

2013-09-05 Thread Avinash Kumar
fixed styling issue in pointer typecast. Signed-off-by: Avinash Kumar avi.kp@gmail.com --- drivers/staging/bcm/InterfaceMisc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c index

[PATCH v2] mfd: rtsx: Modify rts5249_optimize_phy

2013-09-05 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn v2: Name those new-added register values Wei WANG (1): mfd: rtsx: Modify rts5249_optimize_phy drivers/mfd/rts5249.c| 35 -- include/linux/mfd/rtsx_pci.h | 43 ++ 2 files

[PATCH v2] mfd: rtsx: Modify rts5249_optimize_phy

2013-09-05 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn In some platforms, specially Thinkpad series, rts5249 won't be initialized properly. So we need adjust some phy parameters to improve the compatibility issue. Signed-off-by: Wei WANG wei_w...@realsil.com.cn --- drivers/mfd/rts5249.c| 35