Re: [PATCH v2 30/31] staging: comedi: ni_pcidio: request_irq() before seting up subdevices

2013-12-06 Thread Ian Abbott
On 2013-12-05 20:43, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. Only hook up the command support of the irq was sucessfully requested. Note that, because of the IRQF_SHARED flag, nidio_interrupt() _may_ be called before the device is ready and the subdevices

Re: [PATCHv5][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:07PM +0100, Denis Carikli wrote: [...] diff --git a/arch/arm/boot/dts/imx51-apf51dev.dts b/arch/arm/boot/dts/imx51-apf51dev.dts index f36a3aa..3b6de6a 100644 --- a/arch/arm/boot/dts/imx51-apf51dev.dts +++ b/arch/arm/boot/dts/imx51-apf51dev.dts @@ -19,7 +19,7 @@

Re: [PATCHv5][ 5/8] staging: imx-drm: parallel display: add regulator support.

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 07:28:09PM +0100, Denis Carikli wrote: [...] diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c [...] @@ -260,6 +275,13 @@ static int imx_pd_probe(struct platform_device *pdev) if (ret) return ret;

Re: [PATCHv5][ 2/8] staging: imx-drm: Add RGB666 support for parallel display.

2013-12-06 Thread Lucas Stach
Am Freitag, den 06.12.2013, 14:14 +0100 schrieb Thierry Reding: On Thu, Dec 05, 2013 at 07:28:06PM +0100, Denis Carikli wrote: [...] diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c [...] @@ -155,6 +156,8 @@ static int ipu_pixfmt_to_map(u32

[PATCH 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 17ac711..b6ce68e 100644 ---

[PATCH 5/7] staging: et131x: reduce split lines in nic_rx_pkts

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 3e34c2e..8d75a3f 100644 --- a/drivers/staging/et131x/et131x.c +++

[PATCH 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index e3a71d3..ee231f2 100644 ---

Re: [PATCH 00/13] staging: comedi: pcmuio: cleanup driver

2013-12-06 Thread Ian Abbott
On 2013-12-05 23:54, H Hartley Sweeten wrote: I orignally posted this series on 07/24/2013. At that time Ian Abbott had some comments on it. I finally got around to addressing them. This series cleans up the interrupt support and private data usage. It also does a bit of cleanup to clarify the

RE: [PATCH 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread Hartley Sweeten
On Friday, December 06, 2013 1:19 AM, Dan Carpenter wrote: Signed-off-by is missing. Oops... Just reposted that patch with the sign off. Sorry about that, Hartley ___ devel mailing list de...@linuxdriverproject.org

RE: [PATCH v2 30/31] staging: comedi: ni_pcidio: request_irq() before seting up subdevices

2013-12-06 Thread Hartley Sweeten
On Friday, December 06, 2013 3:34 AM, Ian Abbott wrote: On 2013-12-05 20:43, H Hartley Sweeten wrote: [snip] +irq = mite_irq(devpriv-mite); +if (irq) { +ret = request_irq(irq, nidio_interrupt, IRQF_SHARED, + dev-board_name, dev); +

Re: [PATCH v3 30/31] staging: comedi: ni_pcidio: request_irq() before setting up subdevices

2013-12-06 Thread Ian Abbott
On 2013-12-06 16:57, H Hartley Sweeten wrote: Do the request_irq() before setting up the subdevices. Only hook up the command support of the irq was sucessfully requested. Note that, because of the IRQF_SHARED flag, nidio_interrupt() _may_ be called before the device is ready and the subdevices

[PATCH v2 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread H Hartley Sweeten
Unfortunatly, since there could be two asics, we can't use dev-read_subdev to get the subdevice. But, the comedi_subdevice associated with the 'asic' can easily be calculated. This allows removing the for () loop that searched for the correct subdevice. Tidy up the function. Signed-off-by: H

Re: [PATCH 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:00PM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

Re: [PATCH 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:01PM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com Acked-by: Mark Einon mark.ei...@gmail.com ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 4/7] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:03PM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

Re: [PATCH 5/7] staging: et131x: reduce split lines in nic_rx_pkts

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 09:35:04PM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com This is good, thanks. Acked-by: Mark Einon mark.ei...@gmail.com ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 4/7] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread Mark Einon
On Fri, Dec 06, 2013 at 08:40:17PM +, Mark Einon wrote: On Fri, Dec 06, 2013 at 09:35:03PM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff

Re: [PATCH v2 03/13] staging: comedi: pcmuio: tidy up pcmuio_handle_asic_interrupt()

2013-12-06 Thread Greg KH
Minor nit, can you name your v2 patches like: [PATCH 03/13 v2] ... so that when I sort them in mutt, they show up in the proper order with the other patches in the series? Don't worry about this one, I got it, but in the future it would be great. thanks, greg k-h

[PATCH] staging: dwc2: don't issue traffic to LS devices in FS mode

2013-12-06 Thread Paul Zimmerman
From: Nick Hudson sk...@netbsd.org I fell over the problem reported in https://github.com/raspberrypi/linux/pull/390: Issuing low-speed packets when the root port is in full-speed mode causes the root port to stop responding. Explicitly fail when enqueuing URBs to a LS endpoint on a FS bus.

[PATCH 1/7 RESEND] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index e3a71d3..0372f23 100644 ---

[PATCH 3/7 RESEND] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 63d28ae..881ae4f 100644 ---

[PATCH 4/7 RESEND] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread ZHAO Gang
Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 881ae4f..90ef45b 100644 ---

[PATCH 2/9] Staging: bcm: DDRInit: replaced multiple tabs with tab.

2013-12-06 Thread Gary Rookard
This is second in a series of patches. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 910 +- 1 file changed, 455 insertions(+), 455 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH 3/9] Staging: bcm: DDRInit: added space after commas.

2013-12-06 Thread Gary Rookard
Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 1332 - 1 file changed, 666 insertions(+), 666 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index

[PATCH 4/9] Staging: bcm: DDRInit: added spaces around operators.

2013-12-06 Thread Gary Rookard
This is the fourth patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch-staging-next drivers/staging/bcm/DDRInit.c | 86 +-- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH 6/9] Staging: bcm: DDRInit: tidy up bracing issues.

2013-12-06 Thread Gary Rookard
This is the sixth patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 174 +++--- 1 file changed, 63 insertions(+), 111 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH 7/9] Staging: bcm: DDRInit: removed extra lines

2013-12-06 Thread Gary Rookard
This is the seventh patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 163 +++--- 1 file changed, 43 insertions(+), 120 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH 8/9] Staging: bcm: DDRInit: tidy up indentation.

2013-12-06 Thread Gary Rookard
This is the eighth patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch stanging-next drivers/staging/bcm/DDRInit.c | 394 +- 1 file changed, 195 insertions(+), 199 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH 9/9] Staging: bcm: DDRInit: removed space from front of semicolon.

2013-12-06 Thread Gary Rookard
This is the ninth patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

Re: [PATCH] staging: dwc2: don't issue traffic to LS devices in FS mode

2013-12-06 Thread Stephen Warren
On 12/06/2013 03:01 PM, Paul Zimmerman wrote: From: Nick Hudson sk...@netbsd.org I fell over the problem reported in https://github.com/raspberrypi/linux/pull/390: Issuing low-speed packets when the root port is in full-speed mode causes the root port to stop responding. Explicitly fail

[PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments.

2013-12-06 Thread Gary Rookard
This is the fifth patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 270 +- 1 file changed, 135 insertions(+), 135 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH] staging: rtl8192u: fix some type confusion

2013-12-06 Thread Ilia Mirkin
The first 8 bytes of skb-cb are used to store a struct net_device *. Adjust the memcpy's src/dst types to reflect that. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Noticed this with spatch looking for sizes in memcpy's inconsistent with the arguments.

Re: [PATCH] staging: rtl8192u: fix some type confusion

2013-12-06 Thread Dan Carpenter
On Fri, Dec 06, 2013 at 11:59:26PM -0500, Ilia Mirkin wrote: The first 8 bytes of skb-cb are used to store a struct net_device *. Adjust the memcpy's src/dst types to reflect that. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu This isn't right. The correct fix is just to remove all the

Re: [PATCH 1/7 RESEND] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-06 Thread Dan Carpenter
On Sat, Dec 07, 2013 at 09:19:04AM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 10/10] Staging: bcm: DDRInit: tidy up comments.

2013-12-06 Thread Gary Rookard
This is the tenth patch of a series. Signed-off-by:Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 231 +- 1 file changed, 116 insertions(+), 115 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

[PATCH 03/10] Staging: bcm: DDRInit: added space after commas.

2013-12-06 Thread Gary Rookard
This is the third patch of a series. Signed-off-by: Gary Alan Rookard garyrook...@gmail.com --- On branch staging-next drivers/staging/bcm/DDRInit.c | 1332 - 1 file changed, 666 insertions(+), 666 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c

Re: [PATCH 4/7 RESEND] staging: et131x: reduce split lines in nic_return_rfd

2013-12-06 Thread Dan Carpenter
On Sat, Dec 07, 2013 at 09:39:07AM +0800, ZHAO Gang wrote: Signed-off-by: ZHAO Gang gamer...@gmail.com --- drivers/staging/et131x/et131x.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/et131x/et131x.c