On Fri, Dec 20, 2013 at 03:13:16PM +0800, Wenliang Fan wrote:
The checking condition in 'validateFlash2xReadWrite()' is not sufficient.
A large number invalid would cause an integer overflow and pass
the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
We fixed checkpatch errors in the rtl8192e driver and noticed that some
macros that produced errors in checkpatch are unused, so we removed them.
There are no functional changes in this patch.
___
devel mailing list
de...@linuxdriverproject.org
On Fri, Dec 20, 2013 at 06:19:56PM +0800, Wenliang Fan wrote:
The checking condition in 'validateFlash2xReadWrite()' is not
sufficient. A large number invalid would cause an integer overflow and
pass the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
The checking condition in 'validateFlash2xReadWrite()' is not
sufficient. A large number invalid would cause an integer overflow and
pass the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
Signed-off-by: Wenliang Fan fanwle...@gmail.com
---
On Fri, Dec 20, 2013 at 07:07:38PM +0800, Wenliang Fan wrote:
The checking condition in 'validateFlash2xReadWrite()' is not
sufficient. A large number invalid would cause an integer overflow and
pass the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.
I just made a patch myself that I added to the pull request I just posted.
You didn't CC me or CC the linux-media list when you posted your patch, so I
never saw it.
Regards,
Hans
On 12/20/2013 01:47 PM, Prabhakar Lad wrote:
Hi Hans,
On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhakar
Hi Hans,
On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil hverk...@xs4all.nl wrote:
I just made a patch myself that I added to the pull request I just posted.
You didn't CC me or CC the linux-media list when you posted your patch, so I
never saw it.
I dont know why this patch didnt make up in
Hi Prabhakar,
On 12/20/2013 02:02 PM, Prabhakar Lad wrote:
Hi Hans,
On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil hverk...@xs4all.nl wrote:
I just made a patch myself that I added to the pull request I just posted.
You didn't CC me or CC the linux-media list when you posted your patch, so
This patch addresses several problems in bypass.c found by checkpatch.
Furthermore it removes/adds some empty lines to make the code more readable.
The following problems are fixed:
- line over 80 characters
- space after logical operator !
- spaces instead of tabs
- missing empty line after
In this patch we fix some logical errors in bypass.c of the silicom bypass
driver (in staging).
Checkpatch complains about the following errors:
- unnecessary forward declarations in a source file
- assignment in if condition
In addition to that the __init and __exit macros were missing at the
Hello Michael,
On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
michael.hoef...@studium.uni-erlangen.de wrote:
This patch addresses several problems in bypass.c found by checkpatch.
Furthermore it removes/adds some empty lines to make the code more readable.
The following problems are fixed:
This patch series fix all the warning and errors found by
checkpatch.pl script, Additionally removed the developer
debug BCM_DEBUG_PRINT() prints as per TODO list.
Gokulnath Avanashilingam (4):
staging:bcm: Remove Developer Debug prints in InterfaceIdleMode.c
staging: bcm: line over 80
From: Gokulnath Avanashilingam gokulnath.avanashilin...@in.bosch.com
Fixed all the line over 80 characters warning found by
checkpatch.pl script.
Signed-off-by: Gokulnath Avanashilingam gokulnath.avanashilin...@in.bosch.com
---
drivers/staging/bcm/InterfaceIdleMode.c | 153
From: Gokulnath Avanashilingam gokulnath.avanashilin...@in.bosch.com
This patch fixes all the warning related to spacing issues
found by checkpatch.pl script in InterfaceIdleMode.c
Signed-off-by: Gokulnath Avanashilingam gokulnath.avanashilin...@in.bosch.com
---
From: Gokulnath Avanashilingam gokulnath.avanashilin...@in.bosch.com
Removed the developer debug prints BCM_DEBUG_PRINT()
as per the TODO list, also removed braces for the
if-statement to match coding style
Signed-off-by: Gokulnath Avanashilingam gokulnath.avanashilin...@in.bosch.com
---
From: Lucas Stach l.st...@pengutronix.de
Signed-off-by: Lucas Stach l.st...@pengutronix.de
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-plane.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/ipuv3-plane.c
From: Lucas Stach l.st...@pengutronix.de
Signed-off-by: Lucas Stach l.st...@pengutronix.de
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-crtc.c | 3 ++-
drivers/staging/imx-drm/ipuv3-plane.c | 4
2 files changed, 6 insertions(+), 1 deletion(-)
diff
These patches fix the issue of frame buffer offsets being forgotten
during crtc pageflip. Also we set the second buffer address.
Lucas Stach (2):
staging: drm/imx: handle framebuffer offsets correctly
staging: drm/imx: don't drop crtc offsets when doing pageflip
Philipp Zabel (1):
staging:
From: stalinsrinivasan.s stalinsrinivasan.subraman...@in.bosch.com
This is a patch to the dgnc_cls.c file that
fixes up 80 characters per line and code indent
warnings found by the checkpatch.pl tool.
Signed-off-by: S. Stalin Srinivasan stalinsrinivasa...@gmail.com
---
From: stalinsrinivasan.s stalinsrinivasan.subraman...@in.bosch.com
This is a patch to the dgnc_cls.c file that fixes up volatile usage
warning found by the checkpatch.pl tool
Signed-off-by: S. Stalin Srinivasan stalinsrinivasa...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c |7 ++-
1
On 2013-12-19 23:31, H Hartley Sweeten wrote:
The ni_tio module is used by the ni_atmio, ni_660x, ni_pcimio and ni_mio_cs
drivers to provide support functions for the NI General Purpose Counters.
The ni_tiocmd module is used by the ni_660x and ni_pcimio to support async
commands with the
From: stalinsrinivasan.s stalinsrinivasan.subraman...@in.bosch.com
This is a patch to the dgnc_cls.c file that fixes up comparison with
jiffies usage warning found by the checkpatch.pl tool
Signed-off-by: S. Stalin Srinivasan stalinsrinivasa...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c |
With this series applied, I get a ton of unused variable warnings, can
you please fix them up now too?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Fri, Dec 20, 2013 at 10:36:09AM -0600, Larry Finger wrote:
On 12/20/2013 01:14 AM, Dan Carpenter wrote:
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
Hello Michael,
On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
michael.hoef...@studium.uni-erlangen.de wrote:
This patch addresses several problems in bypass.c found by checkpatch.
Furthermore it removes/adds some empty lines
On 12/20/2013 01:14 AM, Dan Carpenter wrote:
On Thu, Dec 19, 2013 at 10:38:34PM -0600, Larry Finger wrote:
Some comment lines that mentioned spin_lock_bh() are also removed.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
@@ -1509,10 +1509,6 @@ _func_enter_;
On Fri, Dec 20, 2013 at 10:31 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
Hello Michael,
On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
michael.hoef...@studium.uni-erlangen.de wrote:
This patch addresses several
The i.MX Image Processing Unit (IPU) contains a number of image processing
blocks that sit right in the middle between DRM and V4L2. Some of the modules,
such as Display Controller, Processor, and Interface (DC, DP, DI) or CMOS
Sensor Interface (CSI) and their FIFOs could be assigned to either
Hi,
this is mostly about the first patch, which moves the IPUv3 core code
(drivers/staging/imx-drm/ipu-v3) to drivers/gpu. host1x, which
serves a similar purpose, already sits there.
The other four patches add the necessary code for CSI and SMFC handling,
which is used by the V4L2 CSI capture
Signed-off-by: Lucas Stach l.st...@pengutronix.de
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/gpu/ipu-v3/ipu-common.c | 35 +++
include/video/imx-ipu-v3.h | 1 +
2 files changed, 32 insertions(+), 4 deletions(-)
diff --git
On 12/20/2013 01:18 PM, Greg KH wrote:
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of unused variable warnings, can
you please fix them up now too?
Strange, but I don't get any. My compiler is gcc
On Fri, Dec 20, 2013 at 02:30:39PM -0600, Larry Finger wrote:
On 12/20/2013 01:18 PM, Greg KH wrote:
On Fri, Dec 20, 2013 at 11:22:35AM -0600, Larry Finger wrote:
On 12/20/2013 10:58 AM, Greg KH wrote:
With this series applied, I get a ton of unused variable warnings, can
you please fix
On 12/20/2013 02:34 PM, Greg KH wrote:
Nah, I just switched to 4.8 and rebuilt all of the different kernel
trees on this box with it, so I'll stay there for now.
The problem wasn't the fault of gcc 4.8. I only use the staging tree to base
patches to send to you, and my .config in that
A recent set of patches revealed that a line of code had been incorrectly
removed in an earlier edit. That line is added back. In addition, a
configuration
problem resulted in a number of unused variable warnings.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
Larry Finger (2):
A previous set of patches were test compiled with one of the configuration
variables not set. As a result, a number of unused variables were left in the
code.
In several instances, declaration of the unused variable was the only statement
inside ifdef .. endif pairs. In those cases, the entire
On Fri, Dec 20, 2013 at 02:58:43PM -0600, Larry Finger wrote:
A recent set of patches revealed that a line of code had been incorrectly
removed in an earlier edit. That line is added back. In addition, a
configuration
problem resulted in a number of unused variable warnings.
Thanks for the
A line in the P2P code had been removed in the process of converting the vendor
driver to a form suitable for the kernel. The output of this call was ignored,
and the initial analysis incorrectly determined that the call had no other
effect.
Signed-off-by: Larry Finger larry.fin...@lwfinger.net
Hi all,
here is another patch which fixes a kernel warning where a subdevice is
released which no longer exists. The subdevice was removed before the
main comedi device. The functions for the main dev removal and the
subdevice were in different files/modules, were called from different
Moving the register_netdev to the end of probe to prevent
possible open call happens before NetVSP is connected.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/netvsc_drv.c | 20
1 files changed,
39 matches
Mail list logo
