oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/frontier/alphatrack.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/frontier/alphatrack.c
OK. I will remove that comment and send again.
Thanks.
Daeseok Youn.
2014-03-07 17:14 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote:
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
oldi_buffer and write_buffer need to free when usb_alphatrack_delete()
is called.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
v2: remove the unneeded comment.
drivers/staging/frontier/alphatrack.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git
On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote:
This patch for hwdrv_apci1564.c fixes the register map defines for the
digital input registers such that they are all the real offsets to each
This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch fixes the register map defines for the digital output registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function.
Hello Ken Cox,
The patch e423812a9e43: staging: visorchannel module from Mar 4,
2014, leads to the following Smatch warning:
drivers/staging/unisys/include/guidutils.h:60 GUID_format2()
error: format string overflow. buf_size: 50 length: 63
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Friday, March 7, 2014 1:46 PM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
On Fri, Mar 07, 2014 at 09:07:42AM +, KY Srinivasan wrote:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Friday, March 7, 2014 1:46 PM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote:
How many warnings does this generate does this generate when you run it
across the whole tree?
A lot.
Check back with me after the week or so
it'll take to run on this little netboook.
Try this with both patches applied if you want
to
On Thu, 2014-03-06 at 12:01 -0800, gre...@linuxfoundation.org wrote:
On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote:
This patch updates the MAINTAINERS file to add the maintainer for the
Unisys s-Par driver set.
Signed-off-by: Ken Cox j...@redhat.com
signed-off-by:
On Fri, 2014-03-07 at 17:41 +0300, Dan Carpenter wrote:
On Fri, Mar 07, 2014 at 08:18:44AM -0600, Romer, Benjamin M wrote:
On Thu, 2014-03-06 at 12:01 -0800, gre...@linuxfoundation.org wrote:
On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote:
This patch updates the
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Friday, March 7, 2014 2:51 PM
To: KY Srinivasan
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
On 03/07/2014 10:02 AM, Greg KH wrote:
On Fri, Mar 07, 2014 at 07:10:57AM -0600, Ken Cox wrote:
A character array was declared on the stack with variable length. This has
been corrected to use a fixed length.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Ken Cox
A character array was declared on the stack with variable length. This has
been corrected to use a fixed length.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/virthba/virthba.c | 5 -
1 file changed, 4 insertions(+), 1
On Thu, Mar 06, 2014 at 05:04:25PM +0100, Denis Carikli wrote:
According to the datasheet, setting the di0_polarity_disp_clk
field in the GENERAL di register sets the output clock polarity
to active high.
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v8-v9:
- New patch that
On Friday, March 07, 2014 1:32 AM, Chase Southwood wrote:
On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
This one is incomplete and breaks the build.
Be sure to do a build after each patch to make sure it works.
Hartley,
I'm sorry for this, it
On Thu, Mar 06, 2014 at 02:54:40PM +0100, Philipp Zabel wrote:
@@ -566,9 +566,18 @@ static int imx_ldb_bind(struct device *dev, struct
device *master, void *data)
return -EINVAL;
}
- panel_node = of_parse_phandle(child, fsl,panel, 0);
-
On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote:
This patch allows to optionally attach the lvds-channel to a panel
supported by a drm_panel driver instead of supplying the modes via
device tree.
Hmm, I think something may be missing in this patch... you're introducing
calls into
On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood
Hi Russell,
Am Freitag, den 07.03.2014, 17:22 + schrieb Russell King - ARM
Linux:
On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote:
This patch allows to optionally attach the lvds-channel to a panel
supported by a drm_panel driver instead of supplying the modes via
device
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote:
Hi,
this latest version of the imx-drm DT binding patches applies
on top of staging-next and also depends on the OF graph binding
patchset that moves the v4l2_of helpers to drivers/of.
Currently, the two patchsets are also
Make sure BusListLock is unlocked before returning. If an error is encountered
early on in info_proc_read_helper() the function can return without unlocking.
Also changed the PROCLINE macro so that it doesn't include a goto statement.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote:
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote:
Hi,
this latest version of the imx-drm DT binding patches applies
on top of staging-next and also depends on the OF graph binding
patchset that moves
[Added Shawn to Cc:]
On Fri, Mar 7, 2014 at 7:28 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote:
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote:
Hi,
this latest version of the imx-drm DT
This patch adds the Unisys s-Par driver maintainers to the MAINTAINERS
file, changes the state to Supported, modifies TODO to address patches
to the Unisys mailing list, and adds Greg Kroah-Hartman to the patch
recipients list.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
diff
On Fri, Mar 07, 2014 at 11:38:03AM +0300, Dan Carpenter wrote:
Hello Ken Cox,
The patch e423812a9e43: staging: visorchannel module from Mar 4,
2014, leads to the following Smatch warning:
drivers/staging/unisys/include/guidutils.h:60 GUID_format2()
error: format string
On Fri, Mar 07, 2014 at 07:57:51PM +0100, Philipp Zabel wrote:
[Added Shawn to Cc:]
On Fri, Mar 7, 2014 at 7:28 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote:
On Wed, Mar 05, 2014 at 10:20:51AM +0100,
Am Freitag, 7. März 2014, 20:17:56 schrieb Greg KH:
On Fri, Mar 07, 2014 at 11:38:03AM +0300, Dan Carpenter wrote:
drivers/staging/unisys/include/guidutils.h
57 static inline char *
58 GUID_format2(const GUID *guid, char *s)
59 {
60 sprintf(s,
There were multiple variable length arrays declared on the stack in proc
handlers:
char buf[count];
I changed these to be fixed length arrays.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/uislib/uislib.c | 39 +---
For aesthetics, rename the subdevice private data pointer from 'p' to
'spriv' and add a local variable for the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetics, use a pointer to the comedi_subdevice instead of
accessing the dev-subdevices array directly.
Move the local variable for the subdevice private data so that
this function does not declare the variable twice.
Change the kzalloc for the subdevice private data to remove the
For aesthetics, rename the subdevice private data pointer from 'subdevpriv'
to 'spriv' and add a local variable for the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This callback function for comedi_load_firmware() first validates that
the firmware data is the correct format then it writes the data to each
subdevice.
Split the two operations out as separate functions to clarify the code.
Tidy up the new functions.
Signed-off-by: H Hartley Sweeten
Refactor the function to reduce the indent level.
For aesthetics, rename the subdevice private data pointer from 'p'
to 'spriv'.
Rename the lacal variable used for the channel-full_scale to 'fs'
to reduce the line lengths.
Remove the setting of range[8]. The min,max values are the same as
the
Factor the code that allocates and initializes the subdevice private data
out of the (*attach) to reduce the indent level and make the code easier
to follow.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Use the helper function to allocate the subdevice private data. This
sets the s-private variable for us and allows the comedi core to
automatically kfree() the memory during the (*detach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
For aesthetics, rename the subdevice private data pointer from 'p'
to 'spriv' and the variable used to check the errno from 'result'
to 'ret'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Create an enum for the boards supported by this driver and pass that enum in
the pci_driver id_table as the driver_data.
Introduce a boardinfo struct to hold the board specific data for the boards
supported by this driver. Use the boardinfo when attaching to the driver
instead of using the
Cleanup the (*attach) of this driver and tidy up the existing code.
H Hartley Sweeten (14):
staging: comedi: jr3_pci: tidy up subdevice init
staging: comedi: jr3_pci: use comedi_alloc_spriv()
staging: comedi: jr3_pci: factor subdevice private data init out of (*attach)
staging: comedi:
Rename this private struct so it has namespace associated with the
driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/jr3_pci.c | 20 ++--
1
This member of the private data is actually the number of subdevices. We
can get that information directly from the comedi_device. Do that instead
and remove the unnecessary member from the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Refactor this function to make it clearer.
The channel does not need to be validated. The comedi core does that for us.
Exit early if the subdevice private data is invalid.
Exit early if the subdevice 'state' is not done or there is an error.
Factor out the code that actually reads the channel
Rename this private struct so it has namespace associated with the
driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/jr3_pci.c | 18 +-
1 file
Changes the declaration of TWV_table to 'static void' to eliminate a sparse
should it be static warning.
Signed-off-by: Shaun Laing sh...@xresource.ca
---
drivers/staging/cxt1e1/comet.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/comet.c
From: K. Y. Srinivasan k...@microsoft.com
Date: Thu, 6 Mar 2014 21:32:36 -0800
+static u32 fill_pg_buf(struct page *page, u32 offset, u32 len,
+ struct hv_page_buffer *pb)
+{
+ int j = 0;
+
+ /* Deal with compund pages by ignoring unused part
+ * of the
This is just for comments. The indentation was alread so far
over 80 chars I (as recommended earlier) make a couple of
new functions. Somehow I don't think this is proper and there
is probably a better way to do this. This is untested.
Signed-off-by: Mark Hounschell ma...@compro.net
---
Greg,
Please incorporate the latest imx-drm changes, which can be found at:
git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging
with SHA1 6a6317113391b482a6715d1c826b2d78bfdf9366.
This set of changes reorganises imx-drm's DT bindings by re-using the OF
graph parsing code which was
On Fri, Mar 07, 2014 at 10:02:03PM +, Russell King wrote:
Greg,
Please incorporate the latest imx-drm changes, which can be found at:
git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging
with SHA1 6a6317113391b482a6715d1c826b2d78bfdf9366.
Pulled and now pushed out,
On Fri, Mar 07, 2014 at 04:57:50PM -0500, Mark Hounschell wrote:
This is just for comments. The indentation was alread so far
over 80 chars I (as recommended earlier) make a couple of
new functions. Somehow I don't think this is proper and there
is probably a better way to do this. This is
The dev_warn() will automatically have the comedi prefix.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.c | 2 +-
1 file changed, 1 insertion(+), 1
Tidy up the multi-line comment to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.h | 37 +++---
1 file
Typically the comedi_subdevice variable is simply named 's'. Rename
the variables in comedi_fc.h.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.h | 22
Typically the comedi_subdevice variable is simply named 's'. Rename
the variables in this file.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.c | 28
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Also, remove the clearing of the events, comedi_event() does that.
In the Kconfig, COMEDI_NI_AT_A2150 already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten
Tidy up the multi-line comment to follow the CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.c | 36 ++
1 file
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Update the Kconfig so that COMEDI_PCL818 selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
In the Kconfig, COMEDI_DAS1800 already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The 'extern' is not needed in the prototypes for the exported functions
in the header. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.h | 14
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
In the Kconfig, COMEDI_ADL_PCI9111 already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The ni_event() function in this file is an open coded version of
cfc_handle_events() where instead of calling the subdevice (*cancel)
function a switch is used to call the function based on the subdevice
'index'.
Use the comedi_fc helper function to simplify the code.
This also allows removing a
The comedi core resets the async-events in comedi_buf_reset() which is
called when the subdevice is restored to an idle state and at the start
of an async command. The async-events are also cleared after handling
the events in comedi_event().
Drivers should not clear the events manually.
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Also, remove the clearing of the events, comedi_event() does that.
In the Kconfig, COMEDI_CB_PCIDAS already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten
Use the comedi_fc helper function instead of duplicating the code.
In the Kconfig, COMEDI_NI_660X selects COMEDI_FC indirectly by selecting
COMEDI_NI_TIOCMD which selects COMEDI_MITE which selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
For aesthetics, move the MODULE_* information to the end of the file
and move the module_{init,exit}() after the functions.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This function returns the total number of bytes for a full scan of
an async command chanlist. The returned value is an unsigned int.
Change all the local variables to unsigned int and use a local
variable for the s-async-cmd.chanlist_len.
Signed-off-by: H Hartley Sweeten
Use the comedi_fc helper function instead of duplicating the code.
In the Kconfig, COMEDI_NI_PCIDIO selects COMEDI_FC indirectly by
selecting COMEDI_MITE which selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
This helper function is a bit long to be inlined. Move it to the
source file and export it.
The mite driver is the only external user right now. Update the
Kconfig to select COMEDI_FC when COMEDI_MITE is enabled.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This module has a number of helper functions for common operations in
comedi drivers. Tidy it up and then use the helpers in the drivers to
remove some of the duplicate code.
H Hartley Sweeten (31):
staging: comedi: comedi_fc: tidy up module init
staging: comedi: comedi_fc: tidy up multi-line
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Also, remove the clearing of the events, comedi_event() does that.
In the Kconfig, COMEDI_NI_LABPC already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Also, remove the clearing of the event, comedi_event() does that.
In the Kconfig, COMEDI_DAS800 already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
In the Kconfig, COMEDI_AMPLC_PCI224 already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Update the Kconfig to select COMEDI_FC when COMEDI_ADL_PCI9111 is enabled.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
In the Kconfig, COMEDI_ADL_PCI9118 already selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Update the Kconfig so that COMEDI_PCL812 selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Update the Kconfig so that COMEDI_DT3000 selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_fc helper function to automatically call the subdevice
(*cancel) function when needed and call comedi_event().
Update the Kconfig so that COMEDI_QUATECH_DAQP_CS selects COMEDI_FC.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
Use the comedi_fc helper function instead of duplicating the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mite.c | 11 +++
1 file changed, 3
On Friday, March 7, 2014 11:38 AM, Hartley Sweeten
hartl...@visionengravers.com wrote:
On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote:
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real
This patch fixes the register map defines for the digital output registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function.
This patch fixes the register map defines for the digital input registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function. Upon
This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: Simplified commit message, fixed
On Friday, March 07, 2014 5:42 PM, Chase Southwood wrote:
This patch fixes the register map defines for the digital input registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Further, some of the old defines were
This patch changes a handful of while loops to timeouts to prevent
infinite looping on hardware failure. A couple such loops are in a
function (s626_debi_transfer()) which is called from critical sections,
so comedi_timeout() is unusable for them, and an iterative timeout is
used instead. For the
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Saturday, March 8, 2014 3:18 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Subject: Re:
From: KY Srinivasan k...@microsoft.com
Date: Sat, 8 Mar 2014 04:12:01 +
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Saturday, March 8, 2014 3:18 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
89 matches
Mail list logo
