[PATCH] staging: frontier: fix memory leak in usb_alphatrack_probe()

2014-03-07 Thread Daeseok Youn
oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/frontier/alphatrack.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/frontier/alphatrack.c

Re: [PATCH] staging: frontier: fix memory leak in usb_alphatrack_probe()

2014-03-07 Thread DaeSeok Youn
OK. I will remove that comment and send again. Thanks. Daeseok Youn. 2014-03-07 17:14 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Mar 07, 2014 at 05:02:25PM +0900, Daeseok Youn wrote: oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called.

[PATCH v2] staging: frontier: fix memory leak in usb_alphatrack_probe()

2014-03-07 Thread Daeseok Youn
oldi_buffer and write_buffer need to free when usb_alphatrack_delete() is called. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- v2: remove the unneeded comment. drivers/staging/frontier/alphatrack.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten hartl...@visionengravers.com wrote: On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote: This patch for hwdrv_apci1564.c fixes the register map defines for the digital input registers such that they are all the real offsets to each

[PATCH v2 3/5] Staging: comedi: addi-data: tidy up watchdog register

2014-03-07 Thread Chase Southwood
This patch for fixes the register map defines for the watchdog registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- 2: Simplified commit message, fixed

[PATCH v2 4/5] Staging: comedi: addi-data: tidy up timer register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
This patch for fixes the register map defines for the timer registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- 2: Simplified commit message, fixed

[PATCH v2 2/5] Staging: comedi: addi-data: tidy up digital output register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
This patch fixes the register map defines for the digital output registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Further, some of the old defines were being used incorrectly in the i_APCI1564_Reset() function.

re: staging: visorchannel module

2014-03-07 Thread Dan Carpenter
Hello Ken Cox, The patch e423812a9e43: staging: visorchannel module from Mar 4, 2014, leads to the following Smatch warning: drivers/staging/unisys/include/guidutils.h:60 GUID_format2() error: format string overflow. buf_size: 50 length: 63

RE: [PATCH 1/1] Drivers: hv: vmbus: Include the limit on the number of pfns we can handle

2014-03-07 Thread KY Srinivasan
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Friday, March 7, 2014 1:46 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com

Re: [PATCH 1/1] Drivers: hv: vmbus: Include the limit on the number of pfns we can handle

2014-03-07 Thread Dan Carpenter
On Fri, Mar 07, 2014 at 09:07:42AM +, KY Srinivasan wrote: -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Friday, March 7, 2014 1:46 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;

Re: [PATCH] checkpatch: net and drivers/net: Warn on missing blank line after variable declaration

2014-03-07 Thread Joe Perches
On Fri, 2014-03-07 at 10:54 +0300, Dan Carpenter wrote: How many warnings does this generate does this generate when you run it across the whole tree? A lot. Check back with me after the week or so it'll take to run on this little netboook. Try this with both patches applied if you want to

Re: [PATCH 1/1] staging: unisys: Fix MAINTAINERS

2014-03-07 Thread Romer, Benjamin M
On Thu, 2014-03-06 at 12:01 -0800, gre...@linuxfoundation.org wrote: On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote: This patch updates the MAINTAINERS file to add the maintainer for the Unisys s-Par driver set. Signed-off-by: Ken Cox j...@redhat.com signed-off-by:

Re: [PATCH 1/1] staging: unisys: Fix MAINTAINERS

2014-03-07 Thread Romer, Benjamin M
On Fri, 2014-03-07 at 17:41 +0300, Dan Carpenter wrote: On Fri, Mar 07, 2014 at 08:18:44AM -0600, Romer, Benjamin M wrote: On Thu, 2014-03-06 at 12:01 -0800, gre...@linuxfoundation.org wrote: On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote: This patch updates the

RE: [PATCH 1/1] Drivers: hv: vmbus: Include the limit on the number of pfns we can handle

2014-03-07 Thread KY Srinivasan
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Friday, March 7, 2014 2:51 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com

Re: [PATCH] Staging: unisys: virthba: Fix variable length array

2014-03-07 Thread Ken Cox
On 03/07/2014 10:02 AM, Greg KH wrote: On Fri, Mar 07, 2014 at 07:10:57AM -0600, Ken Cox wrote: A character array was declared on the stack with variable length. This has been corrected to use a fixed length. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Ken Cox

[Patch V3] Staging: unisys: virthba: Fix variable length array

2014-03-07 Thread Ken Cox
A character array was declared on the stack with variable length. This has been corrected to use a fixed length. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Ken Cox j...@redhat.com --- drivers/staging/unisys/virthba/virthba.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [PATCH v9][ 4/8] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 05:04:25PM +0100, Denis Carikli wrote: According to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high. Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v8-v9: - New patch that

RE: [PATCH 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

2014-03-07 Thread Hartley Sweeten
On Friday, March 07, 2014 1:32 AM, Chase Southwood wrote: On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten hartl...@visionengravers.com wrote: This one is incomplete and breaks the build. Be sure to do a build after each patch to make sure it works. Hartley, I'm sorry for this, it

Re: [PATCH 2/2] imx-drm: imx-ldb: Use OF graph to find connected panel

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 02:54:40PM +0100, Philipp Zabel wrote: @@ -566,9 +566,18 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data) return -EINVAL; } - panel_node = of_parse_phandle(child, fsl,panel, 0); -

Re: [PATCH 1/2] imx-drm: imx-ldb: Add drm_panel support

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote: This patch allows to optionally attach the lvds-channel to a panel supported by a drm_panel driver instead of supplying the modes via device tree. Hmm, I think something may be missing in this patch... you're introducing calls into

RE: [PATCH v2 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

2014-03-07 Thread Hartley Sweeten
On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote: This patch fixes the register map defines for the counter registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood

Re: [PATCH 1/2] imx-drm: imx-ldb: Add drm_panel support

2014-03-07 Thread Philipp Zabel
Hi Russell, Am Freitag, den 07.03.2014, 17:22 + schrieb Russell King - ARM Linux: On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote: This patch allows to optionally attach the lvds-channel to a panel supported by a drm_panel driver instead of supplying the modes via device

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: Hi, this latest version of the imx-drm DT binding patches applies on top of staging-next and also depends on the OF graph binding patchset that moves the v4l2_of helpers to drivers/of. Currently, the two patchsets are also

[PATCH] Staging: unisys: uislib: Fix locking in info_proc_read_helper()

2014-03-07 Thread Ken Cox
Make sure BusListLock is unlocked before returning. If an error is encountered early on in info_proc_read_helper() the function can return without unlocking. Also changed the PROCLINE macro so that it doesn't include a goto statement. Reported-by: Dan Carpenter dan.carpen...@oracle.com

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Greg Kroah-Hartman
On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote: On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: Hi, this latest version of the imx-drm DT binding patches applies on top of staging-next and also depends on the OF graph binding patchset that moves

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Philipp Zabel
[Added Shawn to Cc:] On Fri, Mar 7, 2014 at 7:28 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote: On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: Hi, this latest version of the imx-drm DT

[PATCH 1/1] staging: unisys: update MAINTAINERS and TODO

2014-03-07 Thread Romer, Benjamin M
This patch adds the Unisys s-Par driver maintainers to the MAINTAINERS file, changes the state to Supported, modifies TODO to address patches to the Unisys mailing list, and adds Greg Kroah-Hartman to the patch recipients list. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- diff

Re: staging: visorchannel module

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 11:38:03AM +0300, Dan Carpenter wrote: Hello Ken Cox, The patch e423812a9e43: staging: visorchannel module from Mar 4, 2014, leads to the following Smatch warning: drivers/staging/unisys/include/guidutils.h:60 GUID_format2() error: format string

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 07:57:51PM +0100, Philipp Zabel wrote: [Added Shawn to Cc:] On Fri, Mar 7, 2014 at 7:28 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote: On Wed, Mar 05, 2014 at 10:20:51AM +0100,

Re: staging: visorchannel module

2014-03-07 Thread Peter Hüwe
Am Freitag, 7. März 2014, 20:17:56 schrieb Greg KH: On Fri, Mar 07, 2014 at 11:38:03AM +0300, Dan Carpenter wrote: drivers/staging/unisys/include/guidutils.h 57 static inline char * 58 GUID_format2(const GUID *guid, char *s) 59 { 60 sprintf(s,

[PATCH] Staging: unisys: Fix multiple variable length array declarations

2014-03-07 Thread Ken Cox
There were multiple variable length arrays declared on the stack in proc handlers: char buf[count]; I changed these to be fixed length arrays. Signed-off-by: Ken Cox j...@redhat.com --- drivers/staging/unisys/uislib/uislib.c | 39 +---

[PATCH 08/14] staging: comedi: jr3_pci: tidy up jr3_pci_open()

2014-03-07 Thread H Hartley Sweeten
For aesthetics, rename the subdevice private data pointer from 'p' to 'spriv' and add a local variable for the comedi_subdevice pointer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 01/14] staging: comedi: jr3_pci: tidy up subdevice init

2014-03-07 Thread H Hartley Sweeten
For aesthetics, use a pointer to the comedi_subdevice instead of accessing the dev-subdevices array directly. Move the local variable for the subdevice private data so that this function does not declare the variable twice. Change the kzalloc for the subdevice private data to remove the

[PATCH 05/14] staging: comedi: jr3_pci: tidy up jr3_pci_poll_dev()

2014-03-07 Thread H Hartley Sweeten
For aesthetics, rename the subdevice private data pointer from 'subdevpriv' to 'spriv' and add a local variable for the comedi_subdevice pointer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 07/14] staging: comedi: jr3_pci: tidy up jr3_download_firmware()

2014-03-07 Thread H Hartley Sweeten
This callback function for comedi_load_firmware() first validates that the firmware data is the correct format then it writes the data to each subdevice. Split the two operations out as separate functions to clarify the code. Tidy up the new functions. Signed-off-by: H Hartley Sweeten

[PATCH 06/14] staging: comedi: jr3_pci: tidy up jr3_pci_poll_subdevice()

2014-03-07 Thread H Hartley Sweeten
Refactor the function to reduce the indent level. For aesthetics, rename the subdevice private data pointer from 'p' to 'spriv'. Rename the lacal variable used for the channel-full_scale to 'fs' to reduce the line lengths. Remove the setting of range[8]. The min,max values are the same as the

[PATCH 03/14] staging: comedi: jr3_pci: factor subdevice private data init out of (*attach)

2014-03-07 Thread H Hartley Sweeten
Factor the code that allocates and initializes the subdevice private data out of the (*attach) to reduce the indent level and make the code easier to follow. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 02/14] staging: comedi: jr3_pci: use comedi_alloc_spriv()

2014-03-07 Thread H Hartley Sweeten
Use the helper function to allocate the subdevice private data. This sets the s-private variable for us and allows the comedi core to automatically kfree() the memory during the (*detach). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 04/14] staging: comedi: jr3_pci: rename some local vars in the (*attach)

2014-03-07 Thread H Hartley Sweeten
For aesthetics, rename the subdevice private data pointer from 'p' to 'spriv' and the variable used to check the errno from 'result' to 'ret'. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 10/14] staging: comedi: jr3_pci: introduce boardinfo for the supported boards

2014-03-07 Thread H Hartley Sweeten
Create an enum for the boards supported by this driver and pass that enum in the pci_driver id_table as the driver_data. Introduce a boardinfo struct to hold the board specific data for the boards supported by this driver. Use the boardinfo when attaching to the driver instead of using the

[PATCH 00/14] staging: comedi: jr3_pci: start cleaning up driver

2014-03-07 Thread H Hartley Sweeten
Cleanup the (*attach) of this driver and tidy up the existing code. H Hartley Sweeten (14): staging: comedi: jr3_pci: tidy up subdevice init staging: comedi: jr3_pci: use comedi_alloc_spriv() staging: comedi: jr3_pci: factor subdevice private data init out of (*attach) staging: comedi:

[PATCH 13/14] staging: comedi: jr3_pci: rename struct poll_delay_t

2014-03-07 Thread H Hartley Sweeten
Rename this private struct so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/jr3_pci.c | 20 ++-- 1

[PATCH 11/14] staging: comedi: jr3_pci: remove 'n_channels' from private data

2014-03-07 Thread H Hartley Sweeten
This member of the private data is actually the number of subdevices. We can get that information directly from the comedi_device. Do that instead and remove the unnecessary member from the private data. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 09/14] staging: comedi: jr3_pci: tidy up jr3_pci_ai_insn_read()

2014-03-07 Thread H Hartley Sweeten
Refactor this function to make it clearer. The channel does not need to be validated. The comedi core does that for us. Exit early if the subdevice private data is invalid. Exit early if the subdevice 'state' is not done or there is an error. Factor out the code that actually reads the channel

[PATCH 12/14] staging: comedi: jr3_pci: rename struct transform_t

2014-03-07 Thread H Hartley Sweeten
Rename this private struct so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/jr3_pci.c | 18 +- 1 file

[PATCH] staging: cxt1e1: change declaration of TWV_table

2014-03-07 Thread Shaun Laing
Changes the declaration of TWV_table to 'static void' to eliminate a sparse should it be static warning. Signed-off-by: Shaun Laing sh...@xresource.ca --- drivers/staging/cxt1e1/comet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/cxt1e1/comet.c

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Thu, 6 Mar 2014 21:32:36 -0800 +static u32 fill_pg_buf(struct page *page, u32 offset, u32 len, + struct hv_page_buffer *pb) +{ + int j = 0; + + /* Deal with compund pages by ignoring unused part + * of the

[PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-07 Thread Mark Hounschell
This is just for comments. The indentation was alread so far over 80 chars I (as recommended earlier) make a couple of new functions. Somehow I don't think this is proper and there is probably a better way to do this. This is untested. Signed-off-by: Mark Hounschell ma...@compro.net ---

[GIT PULL] imx-drm staging changes

2014-03-07 Thread Russell King
Greg, Please incorporate the latest imx-drm changes, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging with SHA1 6a6317113391b482a6715d1c826b2d78bfdf9366. This set of changes reorganises imx-drm's DT bindings by re-using the OF graph parsing code which was

Re: [GIT PULL] imx-drm staging changes

2014-03-07 Thread Greg Kroah-Hartman
On Fri, Mar 07, 2014 at 10:02:03PM +, Russell King wrote: Greg, Please incorporate the latest imx-drm changes, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging with SHA1 6a6317113391b482a6715d1c826b2d78bfdf9366. Pulled and now pushed out,

Re: [PATCH RFC] staging: dgap: more 80+ char lines work

2014-03-07 Thread Greg KH
On Fri, Mar 07, 2014 at 04:57:50PM -0500, Mark Hounschell wrote: This is just for comments. The indentation was alread so far over 80 chars I (as recommended earlier) make a couple of new functions. Somehow I don't think this is proper and there is probably a better way to do this. This is

[PATCH 04/31] staging: comedi: comedi_fc: remove unnecessary prefix in dev_warn() message

2014-03-07 Thread H Hartley Sweeten
The dev_warn() will automatically have the comedi prefix. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_fc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 05/31] staging: comedi: comedi_fc: tidy up multi-line comment in header

2014-03-07 Thread H Hartley Sweeten
Tidy up the multi-line comment to follow the CodingStyle. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_fc.h | 37 +++--- 1 file

[PATCH 07/31] staging: comedi: comedi_fc: rename comedi_subdevice variables in header

2014-03-07 Thread H Hartley Sweeten
Typically the comedi_subdevice variable is simply named 's'. Rename the variables in comedi_fc.h. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_fc.h | 22

[PATCH 03/31] staging: comedi: comedi_fc: rename comedi_subdevice variables

2014-03-07 Thread H Hartley Sweeten
Typically the comedi_subdevice variable is simply named 's'. Rename the variables in this file. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_fc.c | 28

[PATCH 19/31] staging: comedi: ni_at_a2150: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Also, remove the clearing of the events, comedi_event() does that. In the Kconfig, COMEDI_NI_AT_A2150 already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten

[PATCH 02/31] staging: comedi: comedi_fc: tidy up multi-line comment

2014-03-07 Thread H Hartley Sweeten
Tidy up the multi-line comment to follow the CodingStyle. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_fc.c | 36 ++ 1 file

[PATCH 25/31] staging: comedi: pcl818: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Update the Kconfig so that COMEDI_PCL818 selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 17/31] staging: comedi: das1800: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). In the Kconfig, COMEDI_DAS1800 already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 06/31] staging: comedi: comedi_fc: remove 'extern' from function prototypes

2014-03-07 Thread H Hartley Sweeten
The 'extern' is not needed in the prototypes for the exported functions in the header. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_fc.h | 14

[PATCH 13/31] staging: comedi: adl_pci9111: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). In the Kconfig, COMEDI_ADL_PCI9111 already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 20/31] staging: comedi: ni_mio_common: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
The ni_event() function in this file is an open coded version of cfc_handle_events() where instead of calling the subdevice (*cancel) function a switch is used to call the function based on the subdevice 'index'. Use the comedi_fc helper function to simplify the code. This also allows removing a

[PATCH 31/31] staging: comedi: drivers should not clear the async-events

2014-03-07 Thread H Hartley Sweeten
The comedi core resets the async-events in comedi_buf_reset() which is called when the subdevice is restored to an idle state and at the start of an async command. The async-events are also cleared after handling the events in comedi_event(). Drivers should not clear the events manually.

[PATCH 22/31] staging: comedi: cb_pcidas: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Also, remove the clearing of the events, comedi_event() does that. In the Kconfig, COMEDI_CB_PCIDAS already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten

[PATCH 26/31] staging: comedi: ni_660x: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function instead of duplicating the code. In the Kconfig, COMEDI_NI_660X selects COMEDI_FC indirectly by selecting COMEDI_NI_TIOCMD which selects COMEDI_MITE which selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 01/31] staging: comedi: comedi_fc: tidy up module init

2014-03-07 Thread H Hartley Sweeten
For aesthetics, move the MODULE_* information to the end of the file and move the module_{init,exit}() after the functions. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 08/31] staging: comedi: comedi_fc: tidy up cfc_bytes_per_scan()

2014-03-07 Thread H Hartley Sweeten
This function returns the total number of bytes for a full scan of an async command chanlist. The returned value is an unsigned int. Change all the local variables to unsigned int and use a local variable for the s-async-cmd.chanlist_len. Signed-off-by: H Hartley Sweeten

[PATCH 29/31] staging: comedi: ni_pcidio: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function instead of duplicating the code. In the Kconfig, COMEDI_NI_PCIDIO selects COMEDI_FC indirectly by selecting COMEDI_MITE which selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 09/31] staging: comedi: comedi_fc: export cfc_bytes_per_scan()

2014-03-07 Thread H Hartley Sweeten
This helper function is a bit long to be inlined. Move it to the source file and export it. The mite driver is the only external user right now. Update the Kconfig to select COMEDI_FC when COMEDI_MITE is enabled. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 00/31] staging: comedi: comedi_fc: tidy up and use

2014-03-07 Thread H Hartley Sweeten
This module has a number of helper functions for common operations in comedi drivers. Tidy it up and then use the helpers in the drivers to remove some of the duplicate code. H Hartley Sweeten (31): staging: comedi: comedi_fc: tidy up module init staging: comedi: comedi_fc: tidy up multi-line

[PATCH 28/31] staging: comedi: ni_labpc: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Also, remove the clearing of the events, comedi_event() does that. In the Kconfig, COMEDI_NI_LABPC already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten

[PATCH 16/31] staging: comedi: das800: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Also, remove the clearing of the event, comedi_event() does that. In the Kconfig, COMEDI_DAS800 already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten

[PATCH 21/31] staging: comedi: amplc_pci224: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). In the Kconfig, COMEDI_AMPLC_PCI224 already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 14/31] staging: comedi: adv_pci1710: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Update the Kconfig to select COMEDI_FC when COMEDI_ADL_PCI9111 is enabled. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk

[PATCH 12/31] staging: comedi: adl_pci9118: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). In the Kconfig, COMEDI_ADL_PCI9118 already selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 23/31] staging: comedi: pcl812: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Update the Kconfig so that COMEDI_PCL812 selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 27/31] staging: comedi: dt3000: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Update the Kconfig so that COMEDI_DT3000 selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 30/31] staging: comedi: quatech_daqp_cs: use cfc_handle_events()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function to automatically call the subdevice (*cancel) function when needed and call comedi_event(). Update the Kconfig so that COMEDI_QUATECH_DAQP_CS selects COMEDI_FC. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc:

[PATCH 11/31] staging: comedi: mite: use cfc_inc_scan_progress()

2014-03-07 Thread H Hartley Sweeten
Use the comedi_fc helper function instead of duplicating the code. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/mite.c | 11 +++ 1 file changed, 3

Re: [PATCH v2 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
On Friday, March 7, 2014 11:38 AM, Hartley Sweeten hartl...@visionengravers.com wrote: On Friday, March 07, 2014 1:38 AM, Chase Southwood wrote: This patch fixes the register map defines for the counter registers such that they are all the real offsets to each register, rather than a mix of real

[PATCH v3 2/5] Staging: comedi: addi-data: tidy up digital output register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
This patch fixes the register map defines for the digital output registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Further, some of the old defines were being used incorrectly in the i_APCI1564_Reset() function.

[PATCH v3 1/5] Staging: comedi: addi-data: tidy up digital input register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
This patch fixes the register map defines for the digital input registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Further, some of the old defines were being used incorrectly in the i_APCI1564_Reset() function. Upon

[PATCH v3 3/5] Staging: comedi: addi-data: tidy up watchdog register

2014-03-07 Thread Chase Southwood
This patch for fixes the register map defines for the watchdog registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- 2: Simplified commit message, fixed

[PATCH v3 4/5] Staging: comedi: addi-data: tidy up timer register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
This patch for fixes the register map defines for the timer registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- 2: Simplified commit message, fixed

[PATCH v3 5/5] Staging: comedi: addi-data: tidy up counter register map defines in hwdrv_apci1564.c

2014-03-07 Thread Chase Southwood
This patch fixes the register map defines for the counter registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- 2: Simplified commit message, fixed

RE: [PATCH v3 1/5] Staging: comedi: addi-data: tidy up digital input register map defines in hwdrv_apci1564.c

2014-03-07 Thread Hartley Sweeten
On Friday, March 07, 2014 5:42 PM, Chase Southwood wrote: This patch fixes the register map defines for the digital input registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Further, some of the old defines were

[PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in

2014-03-07 Thread Chase Southwood
This patch changes a handful of while loops to timeouts to prevent infinite looping on hardware failure. A couple such loops are in a function (s626_debi_transfer()) which is called from critical sections, so comedi_timeout() is unusable for them, and an iterative timeout is used instead. For the

RE: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread KY Srinivasan
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Saturday, March 8, 2014 3:18 AM To: KY Srinivasan Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Subject: Re:

Re: [PATCH V2 1/6] Drivers: net: hyperv: Enable scatter gather I/O

2014-03-07 Thread David Miller
From: KY Srinivasan k...@microsoft.com Date: Sat, 8 Mar 2014 04:12:01 + -Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Saturday, March 8, 2014 3:18 AM To: KY Srinivasan Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;