[PATCH] imx-drm: fix hdmi hotplug detection initial state

2014-04-18 Thread Russell King
The initial state at boot is assumed to be disconnected, and we hope to receive an interrupt to update the status. Let's be more explicit about the current state - reading the PHY status register tells us the current level of the hotplug signal, which we can report back in the _detect() method. S

Re: [PATCH v2 0/8] Reorder i.MX IPU display enable/disable sequence

2014-04-18 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 11:53:15PM +0200, Philipp Zabel wrote: > Repeatedly enabling and disabling the display currently can lead to a state > in which the IPU doesn't produce a valid signal anymore because we disable > IPU submodules before they can finish their interaction. > > This series reord

Re: [PATCH] mmc: rtsx: fix possible circular locking dependency

2014-04-18 Thread Peter Wu
Hi! On Wednesday 16 April 2014 09:38:44 micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > To avoid dead lock, we need make sure host->lock is always acquire > before pcr->lock. But in irq handler, we acquired pcr->lock in rtsx mfd > driver, and sd_isr_done_transfer() is called during pcr

Re: [PATCH] staging: panel: fix sparse warnings

2014-04-18 Thread Bastien Armand
On Thu, Apr 17, 2014 at 11:15:10PM -0700, Greg Kroah-Hartman wrote: > On Fri, Apr 18, 2014 at 08:01:22AM +0200, Bastien Armand wrote: > > This patch fixes sparse warnings in panel.c. > > What sparse warnings were fixed here? > > It looks like you did a lot of different things, can you please brea

[PATCH v2 0/2] staging: panel: fix sparse warnings.

2014-04-18 Thread Bastien Armand
This serie of two patch fix the following sparse warnings in panel.c : panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces) panel.c:1235:26:expected void const volatile [noderef] * panel.c:1235:26:got char const *tmp panel.c:1353:20: warning: incorrect type in

[PATCH v2 1/2] staging: panel: fix sparse warnings in keypad_read

2014-04-18 Thread Bastien Armand
This patch fixes two sparse warnings related to keypad_read : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) Signed-off-by: Bastien Armand --- drivers/staging/panel/panel.c |4 ++--

[PATCH v2 2/2] staging: panel: fix sparse warnings in lcd_write

2014-04-18 Thread Bastien Armand
This patch fixes two sparse warnings related to lcd_write : warning: incorrect type in argument 1 (different address spaces) warning: incorrect type in initializer (incompatible argument 2 (different address spaces)) lcd_write can be used from kernel space (in panel_lcd_print) or from user space.

r8192e_pci driver broken 3.14+

2014-04-18 Thread Sean MacLennan
Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci driver on my laptop. The bulk of the commit is fine. It is just the following change that causes grief: diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 3183627..7796488 100644 ---

[PATCH] Staging: crystalhd: Mark local functions as static

2014-04-18 Thread Bojan Prtvar
This fixes the following sparse warnings: drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol 'chd_dec_pci_suspend' was not declared. Should it be static? drivers/staging/crystalhd/crystalhd_lnx.c:665:5: warning: symbol 'chd_dec_pci_resume' was not declared. Should it be static? driv

Re: r8192e_pci driver broken 3.14+

2014-04-18 Thread Greg KH
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote: > Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci > driver on my laptop. The bulk of the commit is fine. It is just the > following change that causes grief: > > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c

Re: r8192e_pci driver broken 3.14+

2014-04-18 Thread Dan Carpenter
On Fri, Apr 18, 2014 at 01:36:19PM -0400, Sean MacLennan wrote: > Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci > driver on my laptop. This patch went through the intern code review process and not the normal code review process. The changelog didn't justify why changing

Re: [PATCH v3] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-18 Thread Dan Carpenter
On Thu, Apr 17, 2014 at 08:12:17AM -0400, Marcos A. Di Pietro wrote: > Fixes code style errors in drivers/staging/bcm/Qos.c Looks good, it applies fine, thanks. :) More comments at the bottom. > > Signed-off-by: Marcos A. Di Pietro > --- > drivers/staging/bcm/Qos.c | 17 - >

[PATCH 1/1] Fix some lines over 80 characters in imx-drm staging driver

2014-04-18 Thread Antoine Schweitzer-Chaput
>From 73eb48f2b376c56f0a354ea0e6c2c71972aaffae Mon Sep 17 00:00:00 2001 From: Antoine Schweitzer-Chaput Date: Wed, 16 Apr 2014 09:59:26 +0200 Subject: [PATCH 1/1] Fix some lines over 80 characters in imx-drm staging driver Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/imx-drm/ipu

[PATCH 0/2] staging: rtl8188eu: fix checkpatch errors.

2014-04-18 Thread Konrad Zapalowicz
From: Konrad M Zapalowicz This patch removes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c: - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use tabs where possible rtl818

[PATCH 1/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_p2p.c

2014-04-18 Thread Konrad Zapalowicz
From: Konrad M Zapalowicz This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use tabs where possible Signed-

[PATCH 2/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_recv.c

2014-04-18 Thread Konrad Zapalowicz
From: Konrad M Zapalowicz This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_recv.c - 1874: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz --- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[GIT PULL] Staging driver fixes for 3.15-rc2

2014-04-18 Thread Greg KH
The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.15-rc2 for you to fetch changes up to 33c84bc14c2

Re: [PATCH 1/1] Fix some lines over 80 characters in imx-drm staging driver

2014-04-18 Thread Dan Carpenter
The subject doesn't have a prefix. It should be: [PATCH] Staging: imx-drm: fix some lines over 80 characters On Fri, Apr 18, 2014 at 11:18:44PM +0200, Antoine Schweitzer-Chaput wrote: > >From 73eb48f2b376c56f0a354ea0e6c2c71972aaffae Mon Sep 17 00:00:00 2001 > From: Antoine Schweitzer-Chaput > D

Re: [PATCH 1/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_p2p.c

2014-04-18 Thread Dan Carpenter
On Fri, Apr 18, 2014 at 11:31:35PM +0200, Konrad Zapalowicz wrote: > From: Konrad M Zapalowicz Don't include this line when your sending on your own behalf. > > This commit fixes the following checkpatch errors: > > rtl8188eu/core/rtw_p2p.c > - 1508: ERROR: code indent should use tabs wher

Re: [PATCH 0/3] staging: gdm72xx: Minor cleanup

2014-04-18 Thread Greg KH
On Fri, Mar 21, 2014 at 04:34:56PM +0800, Michalis Pappas wrote: > The following patches perform various cleanups on the gdm72xx driver. > > PATCH 1/3 fixes some small coding style issues > PATCH 2/3 removes an already completed item from the TODO list > PATCH 3/3 replaces some jiffies comparisons

Re: [PATCH 01/02] linux-next: staging: gdm72xx: coding style fixes

2014-04-18 Thread Greg Kroah-Hartman
On Thu, Apr 17, 2014 at 04:29:47PM +0300, Alexandr Terekhov wrote: > Fix: > - unnecessary whitespace before a quoted newline > - using `time_before` instread of comparisons of jiffies > - enclosing macro in parenthesis You failed to actually build this driver with this patch applied :( _

Re: [PATCH 02/02] linux-next: staging: gdm72xx: Fix naked sscanf

2014-04-18 Thread Greg Kroah-Hartman
On Thu, Apr 17, 2014 at 04:31:44PM +0300, Alexandr Terekhov wrote: > Fix naked sscanf > > Signed-off-by: Alexandr Terekhov > > diff --git a/drivers/staging/gdm72xx/gdm_wimax.c > b/drivers/staging/gdm72xx/gdm_wimax.c > index 05ce2a2..7f60da3 100644 > --- a/drivers/staging/gdm72xx/gdm_wimax.c >

Re: [PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings

2014-04-18 Thread Greg KH
On Fri, Mar 21, 2014 at 04:07:49PM +0200, Matei Oprea wrote: > Fix sparse "should be static" warnings. Those structures are > only referenced in file scope so they can be marked as static. > > Signed-off-by: Matei Oprea > Cc: ROSEdu Kernel Community > --- > drivers/staging/rtl8192u/r8192U_wx.c

Re: [PATCH v2 3/4] staging: vt6655: remove dead code

2014-04-18 Thread Greg KH
On Wed, Apr 02, 2014 at 02:53:03PM -0300, Guido Martínez wrote: > Remove dead code in many places on this driver. > > Signed-off-by: Guido Martínez This patch does not apply, can you refresh it, and the 4/4 patch, against my latest tree and resend? thanks, greg k-h

Re: [PATCH] staging: vt6656: fix sparse warning

2014-04-18 Thread Greg KH
On Mon, Apr 14, 2014 at 10:41:07AM +1000, Angus Gibson wrote: > This patch fixes the following warning: > drivers/staging/vt6656/aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was > not declared. Should it be static? > > Signed-off-by: Angus Gibson > --- > drivers/staging/vt6656/aes_ccmp.c | 1

Locking issues in "mmc: rtsx: add support for pre_req and post_req" (was: Re: [PATCH] mmc: rtsx: fix possible circular locking dependency)

2014-04-18 Thread Peter Wu
So, I reverted c42deffd5b53c9e583d83c7964854ede2f12410d ("mmc: rtsx: add support for pre_req and post_req") on top of v3.15-rc1-49-g10ec34f and the hang issue went away. There is something that is possibly problematic. All three tasklets (cmd, data, finish) try to spinlock on host->lock. Accord

Re: [PATCH 2/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_recv.c

2014-04-18 Thread Greg KH
On Fri, Apr 18, 2014 at 11:31:36PM +0200, Konrad Zapalowicz wrote: > From: Konrad M Zapalowicz > > This commit fixes the following checkpatch errors: > > rtl8188eu/core/rtw_recv.c > - 1874: ERROR: code indent should use tabs where possible > > Signed-off-by: Konrad Zapalowicz As Dan point

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-18 Thread Greg KH
On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: > This fixes the following sparse warnings: > drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol > 'chd_dec_pci_suspend' was not declared. Should it be static? > drivers/staging/crystalhd/crystalhd_lnx.c:665:5: warning: sy

Re: [PATCH] fix the code style errors in sn9c102

2014-04-18 Thread Jianyu Zhan
On Sat, Apr 19, 2014 at 11:09 AM, Jinqiang Zeng wrote: > --- > drivers/staging/media/sn9c102/sn9c102.h| 30 +- > drivers/staging/media/sn9c102/sn9c102_core.c | 342 > ++-- > drivers/staging/media/sn9c102/sn9c102_devtable.h | 22 +- > drivers/staging/media