On Thursday, April 17, 2014 1:33 AM, Chase Southwood
chase.southw...@yahoo.com wrote:
The reset function for this driver is a bit of a mess; clean it up to
ensure that it is functioning properly.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: *Changed order of register accesses
On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote:
After all patches have been applied, the only remaining issue on the
TODO list is to conform to the coding standards. The remaining issues
reported by checkpatch.pl are probably pedantic, so if agreed, that
task can be removed
On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote:
The pci_get_drvdata() and checking NULL for dev are
called twice in while loop in is_bypass_dev().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This patch has an warning from checkpatch.pl.
checkpatch.pl warning:
On Wed, Apr 23, 2014 at 09:01:24AM +0530, navin patidar wrote:
dan, It is ok to rearrange and remove members of enum LED_STATE_871x
and enum LED_CTL_MODE.
these enum are not related to firmware .
Ok. Cool.
regards,
dan carpenter
___
devel
On 04/23/2014 04:04 PM, Dan Carpenter wrote:
On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote:
After all patches have been applied, the only remaining issue on the
TODO list is to conform to the coding standards. The remaining issues
reported by checkpatch.pl are probably
On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote:
Hi Dan, thanks for looking at this. From the above snippet I realize
that I wasn't aware of the strict flag, so significantly less errors
were produced.
The issues I was referring to as pedantic are:
WARNING: unchecked
On Wed, Apr 23, 2014 at 12:05:57PM +0300, Dan Carpenter wrote:
On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote:
Hi Dan, thanks for looking at this. From the above snippet I realize
that I wasn't aware of the strict flag, so significantly less errors
were produced.
The
On 2014-04-17 07:33, Chase Southwood wrote:
The reset function for this driver is a bit of a mess; clean it up to
ensure that it is functioning properly.
Signed-off-by: Chase Southwood chase.southw...@yahoo.com
---
2: *Changed order of register accesses for digital input registers back to
2014-04-23 17:35 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote:
The pci_get_drvdata() and checking NULL for dev are
called twice in while loop in is_bypass_dev().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This
When unmapping the pci memory, the pointer was explicitly casted to void*,
thus omitting the __iomem designation.
Signed-off-by: Anders Darander anders.daran...@gmail.com
---
drivers/staging/rtl8821ae/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wed, Apr 23, 2014 at 02:06:25PM +0200, Anders Darander wrote:
When unmapping the pci memory, the pointer was explicitly casted to void*,
thus omitting the __iomem designation.
It looks like the struct definition should be updated instead of every
single reference being casted.
regards,
dan
Change the definition of pci_mem_start|end from correct from pci_io(un)map's
point of view.
Signed-off-by: Anders Darander anders.daran...@gmail.com
---
Changes v1 - v2:
* Change the struct definition instead of casting all
pci_iomap and pci_iounmap calls.
Change the definition of pci_mem_start|end from correct from pci_io(un)map's
point of view.
Signed-off-by: Anders Darander anders.daran...@gmail.com
---
Changes v2 - v3
* Fix a style error
v1 - v2:
* Change the struct definition instead of casting all
pci_iomap and
On Wed, Apr 23, 2014 at 02:59:46PM +0200, Anders Darander wrote:
Change the definition of pci_mem_start|end from correct from pci_io(un)map's
point of view.
Terrific. Thanks!
If you really wanted to then you could just delete pci_mem_end and also
you could remove all the casting of
Hello Peng Tao,
The patch d7e09d0397e8: staging: add Lustre file system client
support from May 2, 2013, leads to the following static checker
warning:
drivers/staging/lustre/include//linux/libcfs/libcfs_ioctl.h:200
libcfs_ioctl_is_invalid()
error: buffer overflow
Btw, what's the trick to navigating the lustre source? I normally do
a make cscope but that doesn't work and I am having a very hard time
with this code.
regards,
dan carpenter
On Wed, Apr 23, 2014 at 04:54:26PM +0300, Dan Carpenter wrote:
Hello Peng Tao,
The patch d7e09d0397e8: staging:
This patch changes the way we insure the config data
is a string. Clearly this was just wrong. After a
certain number of loads/unloads various OOPs were
generated indicating something other than this driver
had a problem. It was this driver.
Signed-off-by: Mark Hounschell ma...@compro.net
This patch fixes an OOPS caused by a pointer being
changed between the malloc and free.
Signed-off-by: Mark Hounschell ma...@compro.net
Tested-by: Mark Hounschell ma...@compro.net
Reported-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This patch series fixes 2 different BUGS that didn't
reveal themselves until the 3.15 series started.
patch 1 fixes how we insure the config data
is a string. The original code is clearly
just wrong. After many loads/unloads of the
driver, various OOPs would occure. None of
which indicated this
On Wednesday, April 23, 2014 12:09 AM, Chase Southwood wrote:
On Thursday, April 17, 2014 1:33 AM, Chase Southwood
chase.southw...@yahoo.com wrote:
The reset function for this driver is a bit of a mess; clean it up to
ensure that it is functioning properly.
Signed-off-by: Chase Southwood
On Tue, Apr 22, 2014 at 2:22 AM, Bintian Wang bintian.w...@huawei.com wrote:
ram_console is replaced by pstore and pstore_ram drivers,
and there is no code to use this head file, so remove it.
Signed-off-by: Bintian Wang bintian.w...@huawei.com
---
drivers/staging/android/ram_console.h |
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
Out of curiosity, have you tested this patch?
On Fri, Apr 18, 2014 at 06:10:57PM +0200, Bastien Armand wrote:
This patch fixes two sparse warnings related to lcd_write :
warning: incorrect type in argument 1 (different address
This patch fix a regression in lcd_write caused by commit
70a8c3eb8546cefe40fb0bc7991e8899b7b91075
Signed-off-by: Bastien Armand armand.bast...@laposte.net
---
drivers/staging/panel/panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/panel/panel.c
-Original Message-
From: K. Y. Srinivasan [mailto:k...@microsoft.com]
Sent: Tuesday, April 8, 2014 6:45 PM
To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Cc: KY Srinivasan
From: Haiyang Zhang haiya...@microsoft.com
Date: Mon, 21 Apr 2014 14:54:43 -0700
Removed recv_pkt_list and lock, and updated related code, so that
the locking overhead is reduced especially when multiple channels
are in use.
The recv_pkt_list isn't actually necessary because the packets are
From: Haiyang Zhang haiya...@microsoft.com
Date: Mon, 21 Apr 2014 14:54:44 -0700
The union contains only one member now, so we use the variables in it
directly.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
Also applied, thanks.
This patch changes all of the various representations of the copyright symbol
to (C).
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/channels/channel.c | 2 +-
drivers/staging/unisys/channels/chanstub.c
From: K. Y. Srinivasan k...@microsoft.com
Date: Tue, 22 Apr 2014 11:03:32 -0700
+ skb = (struct sk_buff *)
+ packet-send_completion_tid;
As in netvsc_xmit_completion() this must be coded as:
skb = (struct sk_buff *) (unsigned
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote:
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
The aim of my patch was basically to add __user annotation. I tried to
keep the change minimal to lessen the risk of regression
Yes. That's the right approach. These
This patch fixes sparse warnings for the
re_map_membase and re_map_port variables.
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 24
drivers/staging/dgap/dgap.h | 4 ++--
2 files
The current code posts periodic memory pressure status from a dedicated thread.
Under some conditions, especially when we are releasing a lot of memory into
the guest, we may not send timely pressure reports back to the host. Fix this
issue by reporting pressure in all contexts that can be active
This patch fixes sparse warnings for the entire bs_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell ma...@compro.net
Tested-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 22
We send packets using a copy-free mechanism (this is the Guest to Host transport
via VMBUS). While this is obviously optimal for large packets,
it may not be optimal for small packets. Hyper-V host supports
a second mechanism for sending packets that is copy based. We implement that
mechanism in
This patch fixes sparse warnings for the entire cm_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell ma...@compro.net
Tested-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 8
On 22/04/14 22:41, Randy Dunlap wrote:
On 04/22/14 04:23, Masanari Iida wrote:
Correct spelling typo in comment within staging/iio
Signed-off-by: Masanari Iida standby2...@gmail.com
Acked-by: Randy Dunlap rdun...@infradead.org
Oh good, a cut and paste typo ;)
Anyhow, applied to the togreg
TLDR; Style nits and we should return -ENOMEM on error instead of
success.
On Wed, Apr 23, 2014 at 02:24:45PM -0700, K. Y. Srinivasan wrote:
We send packets using a copy-free mechanism (this is the Guest to Host
transport
via VMBUS). While this is obviously optimal for large packets,
it may
This test is unnecessary. It covers all the possible combinations of the
scan_end_src and stop_src triggers so the final else can never be reached.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This test is unnecessary. The cfc_check_trigger_src() in Step 1 ensures that
the trigger source is one of these values and Step 2 makes sure it's only one
of these values.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Clarify step 2b of the adl_pci9111 driver.
Remove the unnecessary step 2b tests in the cb_pcidas64 and me4000 drivers.
H Hartley Sweeten (3):
staging: comedi: adl_pci9111: clarify Step 2b of the (*do_cmdtest)
staging: comedi: cb_pcidas64: remove unnecessary Step 2b test in (*do_cmdtest)
When the cmd-scan_begin_src == TRIG_TIMER the divisors needed to
generate the pacer time are calculated in the (*do_cmdtest) to
validate the cmd-scan_begin_arg. The core always does the
(*do_cmdtest) before the (*do_cmd) so there is no reason to recalc
the divisors.
Signed-off-by: H Hartley
Tidy up the timer/pacer code in this driver.
H Hartley Sweeten (4):
staging: comedi: amplc_pci224: remove pci224_cascade_ns_to_timer()
staging: comedi: amplc_pci224: factor out the 'start pacer' code
staging: comedi: amplc_pci224: always cascade the 8254 timers
staging: comedi:
The 8254 timers are only used in this driver to generate the analog
output pacer. To simplify the driver, always cascade the timers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This function is just a wrapper around i8253_cascade_ns_to_timer().
Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci224.c | 24
Remove the unnecessary members from the private data and cleanup the
async command support code.
H Hartley Sweeten (22):
staging: comedi: adv_pci1710: remove 'ai_timer2' from private data
staging: comedi: adv_pci1710: remove 'ai_timer1' from private data
staging: comedi: adv_pci1710: remove
This member of the private data is just a copy of the cmd-flags. Use
that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 6 ++
1 file
This member of the private data is just a copy of the cmd-chanlist.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 6 ++
1
This member of the private data is just a copy of the cmd-convert_arg.
Use that instead and remove the unnecessary sanity checking since it
was already validated in the (*do_cmdtest).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This member of the private data is set to 0 but it is never used. Just
remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 2 --
1 file
This member of the private data is just a copy of the cmd-stop_arg.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 16
For aesthetics, rename the helper functions that are called by
the interrupt function to handle reading the analog input samples.
Also, change the parameters to the helpers to the comedi_device
and comedi_subdevice pointers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
This member of the private data is set to the mode that the ai command
is operating in but nothing uses it. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetics, rename this function so it has namespace associated
with the driver.
Also, change it's parameters. The cmd-chanlist and cmd-chanlist_len
are always passed, just pass the comedi_cmd pointer instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This define enables code that checks for analog input channel dropout
when reading sampled. The define is enabled so we might as well always
enable the code and remove the define.
Factor out the common channel dropout detect code as a helper function.
And cleanup the code.
Signed-off-by: H
The local variable 'mode' is not necessary. We can determine the mode
by checking the cmd-convert_src and cmd-start_src. Do this instead
to clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
In Step 1 of the (*do_cmdtest), the cmd-scan_begin_src is checked to
only allow TRIG_FOLLOW. The (*do_cmd) does not need to recheck this.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Tidy up this function to clarify what the chanlist is being checked for.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 81
This member of the private data is just a copy of the cmd-chanlist_len.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 14
The chanlist is checked in Step 5 of the (*do_cmdtest) there is no
reason to check it again in the (*do_cmd). The only reasonm its done
is to get the actual 'seglen', the non-repeating length of the chanlist.
Save the 'seglen' found by pci171x_ai_check_chanlist() in the private
data and use that
When the cmd-convert_src == TRIG_TIMER the divisors needed to
generate the pacer time are calculated in the (*do_cmdtest) to
validate the cmd-convert_arg. The core always does the (*do_cmdtest)
before the (*do_cmd) so there is no reason to recalc the divisors.
Signed-off-by: H Hartley Sweeten
Hi Dan,
Thanks for reporting this.
On Wed, Apr 23, 2014 at 10:13 PM, Dan Carpenter
dan.carpen...@oracle.com wrote:
Btw, what's the trick to navigating the lustre source? I normally do
a make cscope but that doesn't work and I am having a very hard time
with this code.
I use cscope + ctags
Hello!
On Apr 23, 2014, at 11:14 PM, Peng Tao wrote:
Btw, what's the trick to navigating the lustre source? I normally do
a make cscope but that doesn't work and I am having a very hard time
with this code.
I use cscope + ctags to navigate the lustre source. I guess you hit
some dead
61 matches
Mail list logo
