Using the addi-data common code in addi_apci_1564 introduces a lot of
bloat. By separating this driver off from addi_common.c, a lot of the
common code can be stripped out. This patch copies the code over from
addi_common.c, and removes the #include of the file. The auto_attach
function from
Fix coding style warnings reported by checkpath.
Signed-off-by: Jerry Snitselaar d...@snitselaar.org
---
drivers/staging/line6/capture.c | 3 +++
drivers/staging/line6/midi.c | 2 ++
drivers/staging/line6/playback.c | 6 +-
drivers/staging/line6/pod.c | 5 +
On Thu, Apr 24, 2014 at 05:55:21AM +, Drokin, Oleg wrote:
Hello!
On Apr 23, 2014, at 11:14 PM, Peng Tao wrote:
Btw, what's the trick to navigating the lustre source? I normally do
a make cscope but that doesn't work and I am having a very hard time
with this code.
I use cscope
On 2014-04-24 08:19, Chase Southwood wrote:
Using the addi-data common code in addi_apci_1564 introduces a lot of
bloat. By separating this driver off from addi_common.c, a lot of the
common code can be stripped out. This patch copies the code over from
addi_common.c, and removes the #include
On 2014-04-23 23:52, H Hartley Sweeten wrote:
Clarify step 2b of the adl_pci9111 driver.
Remove the unnecessary step 2b tests in the cb_pcidas64 and me4000 drivers.
H Hartley Sweeten (3):
staging: comedi: adl_pci9111: clarify Step 2b of the (*do_cmdtest)
staging: comedi: cb_pcidas64:
On 2014-04-23 23:57, H Hartley Sweeten wrote:
Tidy up the timer/pacer code in this driver.
H Hartley Sweeten (4):
staging: comedi: amplc_pci224: remove pci224_cascade_ns_to_timer()
staging: comedi: amplc_pci224: factor out the 'start pacer' code
staging: comedi: amplc_pci224: always
On 2014-04-24 00:07, H Hartley Sweeten wrote:
When the cmd-convert_src == TRIG_TIMER the divisors needed to
generate the pacer time are calculated in the (*do_cmdtest) to
validate the cmd-convert_arg. The core always does the (*do_cmdtest)
before the (*do_cmd) so there is no reason to recalc the
On 2014-04-24 00:07, H Hartley Sweeten wrote:
For aesthetics, rename this function so it has namespace associated
with the driver.
Change the parameters to the function. The 'mode' is really a flag to
load the counters and the divisors can be found in the private data.
To clarify the code and
On 2014-04-24 00:07, H Hartley Sweeten wrote:
The helper functions that handle reading the analog input samples for
the interrupt function both call cfc_handle_events() and clear the
interrupt request at various times.
Move this to the main interrupt handler to make sure the events are
posted
On Thu, Apr 24, 2014 at 11:14:46AM +0800, Peng Tao wrote:
Hi Dan,
Thanks for reporting this.
On Wed, Apr 23, 2014 at 10:13 PM, Dan Carpenter
dan.carpen...@oracle.com wrote:
Btw, what's the trick to navigating the lustre source? I normally do
a make cscope but that doesn't work and I
On 2014-04-24 00:06, H Hartley Sweeten wrote:
Remove the unnecessary members from the private data and cleanup the
async command support code.
H Hartley Sweeten (22):
staging: comedi: adv_pci1710: remove 'ai_timer2' from private data
staging: comedi: adv_pci1710: remove 'ai_timer1' from
On Thu, Apr 24, 2014 at 02:51:15PM +0300, Dan Carpenter wrote:
if (libcfs_ioctl_is_invalid(data)) {
Why do we even have all the (130) checks? I don't understand.
Anything over 1024 is invalid.
I believe it is just a safe keeper. Anything that large is certainly
wrong.
This patch fixes a few more sparse warnings related to __iomem
Signed-off-by: Mark Hounschell ma...@compro.net
Tested-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 37 +++--
1 file changed,
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Oops, ignore this. I got the subject wrong. resending...
Mark
On 04/24/2014 10:31 AM, Mark Hounschell wrote:
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This patch fixes sparse warnings:
warning: Using plain integer as NULL pointer
Signed-off-by: Mark Hounschell ma...@compro.net
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/dgap/dgap.c | 32
1 file changed, 16 insertions(+), 16
From: Benjamin Romer benjamin.ro...@unisys.com
This patch adds support for detection of s-Par firmware by checking for the
hypervisor bit in the CPU capabilities, and then querying the hypervisor ID
cpuid leaf.
This functionality will be used by the unisys drivers to determine if
they are
This fixes a problem reported from upstream where a panic occurs if the
unisys drivers are loaded on a non s-Par system.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Ken Cox j...@redhat.com
Tested by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/channels/chanstub.c
This series fixes the problem reported by Fengguang Wu fengguang...@intel.com
where the unisys modules will cause a panic if loaded on a non s-Par
platform.
Each module now has a check in the init function to ensure that it is being
loaded on an s-Par platform and returns an error if it isn't.
The visorutil module was lacking license info.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c
b/drivers/staging/unisys/visorutil/visorkmodutils.c
Add x86_cpu_id struct and call to MODULE_DEVICE_TABLE so this module
will be auto loaded on boot.
Signed-off-by: Ken Cox j...@redhat.com
Tested-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/virthba/virthba.c | 8
1 file changed, 8 insertions(+)
diff --git
Nice.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 24/04/14 18:35, Hartley Sweeten wrote:
On Thursday, April 24, 2014 4:06 AM, Ian Abbott wrote:
On 2014-04-24 00:07, H Hartley Sweeten wrote:
The chanlist is checked in Step 5 of the (*do_cmdtest) there is no
reason to check it again in the (*do_cmd). The only reasonm its done
is to get the
On 24/04/14 19:11, Hartley Sweeten wrote:
On Thursday, April 24, 2014 4:50 AM, Ian Abbott wrote:
On 2014-04-24 00:07, H Hartley Sweeten wrote:
The helper functions that handle reading the analog input samples for
the interrupt function both call cfc_handle_events() and clear the
interrupt
On 24/04/14 19:14, Hartley Sweeten wrote:
On Thursday, April 24, 2014 4:27 AM, Ian Abbott wrote:
On 2014-04-24 00:07, H Hartley Sweeten wrote:
For aesthetics, rename this function so it has namespace associated
with the driver.
Change the parameters to the function. The 'mode' is really a
On Fri, Apr 18, 2014 at 2:46 AM, Russell King
rmk+ker...@arm.linux.org.uk wrote:
The initial state at boot is assumed to be disconnected, and we hope
to receive an interrupt to update the status. Let's be more explicit
about the current state - reading the PHY status register tells us
the
The obd_ioctl_getdata() function caps data-ioc_len at
OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
that the other values inside data are valid.
There are several lengths inside data but when they are added together
they must not be larger than data-ioc_len. The checks
We copy hdr-ioc_len from the user twice but we only verify that it's
within the limit on the first copy. Otherwise we could read unmapped
memory and Oops.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Not tested.
diff --git
-Original Message-
From: Andev [mailto:debian...@gmail.com]
Sent: Thursday, April 24, 2014 2:50 PM
To: KY Srinivasan
Cc: da...@davemloft.net; net...@vger.kernel.org; LKML;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com
Subject: Re: [PATCH V1
On Thu, Apr 24, 2014 at 02:00:49PM -0700, Tim Harvey wrote:
I'm still seeing issues with HDMI detect on powerup, at least on my
Gateworks Ventana boards (which have no voltage devider or anything
else on the HPD line to the IMX6 other than a TVS). I'm currently
using your latest
On Thu, Apr 24, 2014 at 10:06:24PM +, KY Srinivasan wrote:
From: Andev [mailto:debian...@gmail.com]
Your use of goto exit/cleanup in some functions and returning directly on
errors in others could use a cleanup. Please consider doing that while you
are
touching those files.
Will
On Thu, Apr 24, 2014 at 3:07 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Thu, Apr 24, 2014 at 02:00:49PM -0700, Tim Harvey wrote:
I'm still seeing issues with HDMI detect on powerup, at least on my
Gateworks Ventana boards (which have no voltage devider or anything
else on
On Thu, Apr 24, 2014 at 03:57:27PM -0700, Tim Harvey wrote:
On Thu, Apr 24, 2014 at 3:07 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Thu, Apr 24, 2014 at 02:00:49PM -0700, Tim Harvey wrote:
I'm still seeing issues with HDMI detect on powerup, at least on my
Gateworks
Use a newline character appropriately.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
drivers/staging/rtl8723au/os_dep/usb_intf.c
Signed-off-by: Jimmy Li coder.l...@gmail.com
---
drivers/staging/iio/resolver/ad2s1200.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/resolver/ad2s1200.c
b/drivers/staging/iio/resolver/ad2s1200.c
index e2b4820..017d2f8 100644
---
On Fri, Apr 25, 2014 at 5:49 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
We copy hdr-ioc_len from the user twice but we only verify that it's
within the limit on the first copy. Otherwise we could read unmapped
memory and Oops.
Thanks for the patch.
Reviewed-by: Peng Tao
On Fri, Apr 25, 2014 at 5:49 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
The obd_ioctl_getdata() function caps data-ioc_len at
OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
that the other values inside data are valid.
There are several lengths inside data but
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote:
On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
Btw, this whole function is terrible. It should be reading larger
chunks at once instead of get_user() for each character.
Just for the record, very small character
39 matches
Mail list logo
