Re: [PATCH v3 0/2] Fix subject line

Hi Davidlohr! Don't worry. I am not discouraged. :) I understand your concern that the patch feels superficial. It's what the task asked us to do. I suspect the author(s) of the Eudyptula Challenge designed this task to get us involved with the Linux kernel community. I have been looking for a b

Re: [PATCH] Staging/comedi: Fixes static analysis warning raised by sparse

Hi Josh. On Wed, Jun 11, 2014 at 02:45:29PM -0700, j...@joshtriplett.org wrote: > On Thu, Jun 12, 2014 at 12:24:25AM +0300, Dan Carpenter wrote: > > Let's forward this to the Sparse mailing list. > > > > We're seeing a Sparse false positive testing > > drivers/staging/comedi/drivers/ni_pcimio.c.

[PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

The same code regardless of the outcome of the if statement. And clean up another duplicate line of code. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8

[PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

The same code regardless of the outcome of the if statement. This may of course be a miss and there should be a difference in the code. And clean up another duplicate line of code. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): staging: rtl8

[PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up unclear and confusing code

Removes confusing and unclear code. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8192u/r8192U_core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 1bb6143..fd8f37f 10

[PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up unclear and confusing code

Removes confusing and unclear code. Using memcpy to set a pointer, what is the point? The use of &= instead of & fills no benefit in this case. None of these is a direct error, but I think you should replace the confusing code. Rickard Strandqvist (1): staging: rtl8192u: r8192U_core.c: Cleani

[PATCH] staging cxt1e1: refactored ring buffer dump functions to avoid sparse warnings

Sparse spit out these warnings: drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for

Re: [PATCH] msi3103: Use time_before_eq()

Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Mauro, pick that from patchwork to 3.16. I am not going to PULL request it. regards Antti On 05/25/2014 03:39 PM, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use time_before

Re: [PATCH v2] staging/media/rtl2832u_sdr: fix coding style problems by adding blank lines

Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Mauro, pick that from patchwork to 3.16. I am not going to PULL request it. Antti On 06/03/2014 03:38 AM, Ovidiu Toader wrote: This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c The new version of the file please