On Fri, Jun 27, 2014 at 1:39 AM, Greg KH wrote:
> On Tue, Jun 24, 2014 at 10:12:03PM +0800, Stefan Hajnoczi wrote:
>> On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote:
>> > On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote:
>> >> On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko
>>
On Thu, Jun 26, 2014 at 10:43:55PM +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Quentin Lee
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c |1 +
> 1 file changed, 1 ins
On Mon, Jun 23, 2014 at 06:41:29PM +0300, Kristina Martšenko wrote:
> The driver hasn't been cleaned up and nobody is working to do so, so
> remove it.
>
> Signed-off-by: Kristina Martšenko
> Cc: Pavel Machek
This patch didn't apply to my tree for some odd reason, can you please
refresh it and
On Mon, Jun 23, 2014 at 08:10:54PM +0300, Kristina Martšenko wrote:
> Remove the driver as it hasn't been cleaned up and it doesn't look like
> anyone is going to work on it anymore.
>
> Signed-off-by: Kristina Martšenko
> Cc: Henk de Groot
> Cc: David Kilroy
This patch didn't apply either, ca
On Mon, Jun 23, 2014 at 01:41:05PM -0700, j...@joshtriplett.org wrote:
> On Mon, Jun 23, 2014 at 11:42:29AM +0200, Matthias Beyer wrote:
> > This patch fixes some indentation errors, where multi-line statements
> > where not indented.
> >
> > Signed-off-by: Matthias Beyer
>
> This patch also fix
On Sun, Jun 22, 2014 at 01:01:50PM +0200, Thomas Vegas wrote:
> The variable 'pxmitbuf' is already set to NULL when entering the
> function. We can remove the first conditional. When _rtw_queue_empty()
> returns false, 'pxmitbuf' if not NULL. We can merge the second and
> third conditional.
>
> Si
On Thu, Jun 26, 2014 at 09:55:55AM -0500, Ken Cox wrote:
> The use of __DATE__ and __TIME__ is no longer allowed in the kernel so this
> commit removes those. They were once useful when the drivers were being
> built externally, but now that the drivers are in the kernel the use of the
> macros is
On Wed, Jun 25, 2014 at 08:19:52AM +0530, Chetal Patil wrote:
> Hi,
>
> I recently joined the Linux Driver Development mailing list and would
> like to contribute to the Linux Driver Project. Specifically, I would
> like to contribute by working on ACPI Support for HP Pavillion laptops
> (Referred
On Tue, Jun 24, 2014 at 10:12:03PM +0800, Stefan Hajnoczi wrote:
> On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote:
> > On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote:
> >> On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko
> >> wrote:
> >> > I'm helping Greg do a bit of cleanup
> -Original Message-
> From: KY Srinivasan
> > -Original Message-
> > From: Yue Zhang [mailto:yue...@microsoft.com]
> > hv_fcopy_daemon fails to overwrite a file if the target file already exits.
> >
> > Add O_TRUNC flag on opening.
> >
> > Signed-off-by: Yue Zhang
> > ---
> > t
On Wed, Jun 25, 2014 at 11:44:47AM +0200, Denis Carikli wrote:
> On 06/25/2014 06:48 AM, Sascha Hauer wrote:
>>> +#define ENABLE_POL_LOW 0
>>> +#define ENABLE_POL_HIGH1
>>
>> Adding defines without a proper namespace (IPU_) outside a driver
>> private header file is not nice
> -Original Message-
> From: Yue Zhang [mailto:yue...@microsoft.com]
> Sent: Thursday, June 26, 2014 2:09 PM
> To: KY Srinivasan; Haiyang Zhang; driverdev-devel@linuxdriverproject.org;
> linux-ker...@vger.kernel.org; o...@aepfle.de; jasow...@redhat.com;
> a...@canonical.com
> Cc: Dexuan C
Currently the VSC has no chance to notify the VSP of the dirty rectangle on VM
panic because the notification work is done in a workqueue, and in panic() the
kernel typically ends up in an infinite loop, and a typical kernel config has
CONFIG_PREEMPT_VOLUNTARY=y and CONFIG_PREEMPT is not set, so a
> > >> MS-TFS: 157532
> >
> > > What is this line for?
> >
> > Hi Greg,
> > This line is for our internal bug repository.
> > We have an automated system to correlate bugs with fixes so that our test
> > team knows when a bug fix has been accepted upstream and they need to
> > write a new test case
From: Yue Zhang
hv_fcopy_daemon fails to overwrite a file if the target file already
exits.
Add O_TRUNC flag on opening.
Signed-off-by: Yue Zhang
---
tools/hv/hv_fcopy_daemon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy
On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote:
> On 2014-06-18 13:33, Kristina Martšenko wrote:
> > Hi Alois,
> >
> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > nobody seems to have worked towards moving ced1401 out of staging in
> > over a year.
There is only one member in the subdevice private data, an unsigned value
that is the 'base_port' that the subdevice uses to access the port registers.
Just cast the appropriate value into s->private instead of allocating the
private data for each subdevice. The casts are a bit of a nusance but it
Clean up the multi-line comments at the beginning of the file so they
follow the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 95 +++-
1 file changed, 57 insertions(+), 38 d
For aesthetics, factor the code that disables the input filters out of
ni_65xx_auto_attach().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions
The INSN_CONFIG_FILTER instruction is used to set the deglitch filter
interval used to debounce the input channels.
Absorb the helper function into the (*insn_config) function and refactor
the code to not require the 'filter_interval' and 'filter_enable' members
in the private data.
Signed-off-by
The IO Select registers are readable. Remove the need for the
'dio_direction' member in the private data by just checking the
register value for the INSN_CONFIG_DIO_QUERY instruction.
Also, refactor the switch statement to return -EINVAL for unhandled
instructions and have the (*insn_config) retur
Subdevice 3 is used in this driver to provide edge detection of the input
channels.
Move the reset/disable of the interrupts and the request_irq() so that
when subdevice 3 is setup we can conditionally hookup the async command
support only if the irq is available.
Also, remove the noise when the
Remove the need for the 'output_bits' in the private data by just
reading the current state of the data port when updating the output
channels in the (*insn_bits) function.
Add a local variable to handle the inverting of the hardware values
when the boardinfo indicates that the outputs are inverte
During the attach of this driver, the digital output ports are all
initialized to a known state. Some of the boards supported by this
driver have output ports that are inverted from the comedi view of
the output state. For these boards the values written to the ports
needs to be inverted.
Currentl
According to the register programming manual, the filter interval
register is 32-bit. Fix the writes to this register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
For aesthetics, add some whitespace to the comedi_driver declaration.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/n
Some of the boards supported by this driver have output ports that are
inverted from the comedi view of the output state. For these boards the
read values from the output ports needs to be inverted before being
modified and inverted again before being written back in the (*insn_bits)
operation.
Cu
Introduce some convienence macros to handle the port to channel,
channel to port, and channel mask calculations based on the 8
channels per port of the hardware.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 40 +++
For aesthetics, tidy up the whitespace of this function declarations to
follow the form in the rest of the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -
Rename the CamelCase defines used for the non-recurring registers.
Define all the non-recurring registers and bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 99
1 file changed, 62 ins
Convert the inline functions used to calculate the offsets to the
recurring port registers and rename them to remove the CamelCase.
Define all the recurring registers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 88
For aesthetics, add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 46
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/
Update the MODULE_DESCRIPTION to better describe the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_65xx.c
b/drive
Refactor this function to follow the standard (*insn_config) form.
Add a sanity check of the number of data parameters (insn->n). Currently
the core does not check INSN_CONFIG_CHANGE_NOTIFY.
Fix the writes to the rise/fall edge enable registers. The macro expects
a "port" value not the port offse
This series cleans up the comedi ni_65xx driver.
v2: drop the patch that removed the 'invert_outputs' from the boardinfo
reorder the series a bit to handle the 'invert_outputs' correctly
H Hartley Sweeten (18):
staging: comedi: ni_65xx: filter interval register is 32-bit
staging: comedi:
On 2014/06/20 07:10 PM, H Hartley Sweeten wrote:
> The National Instruments MIO drivers, ni_pcimio, ni_mio_cs, and ni_atmio, all
> include the ni_mio_common.c source file to provide the common functionality
> for the drivers. Including source files is a bit ugly.
>
> Remove some cruft from the NI
By convention, the first member of the boardinfo is a 'const char *' to
the board name, especially for those comedi drivers that rely on the
comedi core to set dev->board_ptr to the entry matching the board name
when doing a legacy (*attach) to a comedi driver.
Modify the ni_board_struct appropria
On Thu, Jun 26, 2014 at 11:14 AM, Matthias Beyer wrote:
> Hi,
>
> your email client sends HTML-Emails. Can you switch this off? Maybe
> that's also the reason why your emails don't show up in the
> archives[0]!
Yeh, sorry about that. During the day I use gmail instead of mutt and
I forget to turn
Hi,
your email client sends HTML-Emails. Can you switch this off? Maybe
that's also the reason why your emails don't show up in the
archives[0]!
I will send my patches tomorrow, no time now.
Regards,
Matthias
[0]:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-June/thre
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Thursday, June 26, 2014 4:46 AM
> To: Haiyang Zhang
> Cc: Greg KH; net...@vger.kernel.org; jasow...@redhat.com; driverdev-
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> da...@davemloft.net
> Subject
On 26-06-2014 10:58:20, Kevin McKinney wrote:
>On Thu, Jun 26, 2014 at 10:42 AM, Matthias Beyer
>wrote:
>
> Hi,
>
> I have a question related to some patches I send in.
>
> (I send them to de...@driverdev.osuosl.org, but they show up in the
> archives of this list...
The use of __DATE__ and __TIME__ is no longer allowed in the kernel so this
commit removes those. They were once useful when the drivers were being
built externally, but now that the drivers are in the kernel the use of the
macros is redundant since the kernel already has the same information
else
The unisys drivers now properly check to make sure they are running
on the s-Par platform before they will initialize. This was fixed in
commit fcd0157ece so it is safe to allow the unisys drivers to be built.
This has been tested in the same qemu environment that originally
produced the panic an
This series removes all references to __DATE__ and __TIME__ from the
unisys drivers and also removes BROKEN from the Kconfig so the drivers
can be built.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman
Hi,
I have a question related to some patches I send in.
(I send them to de...@driverdev.osuosl.org, but they show up in the
archives of this list... so I'm asking here)
I send 6 patch sets since the beginning of the month. Some of them
where reviewed, some not. None of them is upstream by now.
On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> Hi Russell,
>
> On Tue, Jun 24, 2014 at 9:29 PM, Russell King
> wrote:
> [...]
> > +/*
> > + * Add a component to be matched.
> > + *
> > + * The match array is first created or extended if necessary.
> > + */
> > +void component_ma
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Quentin Lee
---
drivers/staging/wlan-ng/hfa384x_usb.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/stagi
On Thu, Jun 26, 2014 at 05:37:35AM -0500, Ken Cox wrote:
>
> On 06/25/2014 10:57 PM, Greg KH wrote:
> >On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote:
> --snip--
> >>.id_table = virthba_id_table,
> >>.probe = virthba_probe,
> >>.remove = virthba_remove,
> >>@@ -1413,9 +1413,6
Hi Russell,
On Tue, Jun 24, 2014 at 9:29 PM, Russell King
wrote:
[...]
> +/*
> + * Add a component to be matched.
> + *
> + * The match array is first created or extended if necessary.
> + */
> +void component_match_add(struct device *dev, struct component_match
> **matchptr,
> + int (*com
On 06/25/2014 10:57 PM, Greg KH wrote:
On Wed, Jun 25, 2014 at 11:48:23AM -0500, Ken Cox wrote:
--snip--
.id_table = virthba_id_table,
.probe = virthba_probe,
.remove = virthba_remove,
@@ -1413,9 +1413,6 @@ info_proc_read(struct file *file, char __user *buf,
size_t len
The macros CONFIG_SPAR_GUEST, GUESTDRIVERBUILD, and NOAUTOVERSION are
defined in Makefiles for the Unisys SPAR driver. They are never used.
Remove the lines that define these macros.
Signed-off-by: Paul Bolle
---
Compile tested only, on top of next-20140626, by fiddling with BROKEN
and setting
On Mon, Jun 23, Haiyang Zhang wrote:
> Yes, there is a link down/up event from the host, we currently call
> netif_carrier_off()
> / netif_carrier_on() with these events. Will hotplug scripts be triggered by
> netif_carrier_off/on? Where are the scripts located at (SLES)?
In /etc/sysconfig/net
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 4 ++--
drivers/staging/rtl8723au/include/sta_info.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
b/drivers/staging/rtl8723au
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sreset.c | 11 ---
drivers/staging/rtl8723au/hal/rtl8723a_sreset.c | 1 -
drivers/staging/rtl8723au/hal/usb_ops_linux.c| 11 ---
drivers/staging/rtl8723au/include/rtw_sreset.h | 11
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sreset.c| 29 --
drivers/staging/rtl8723au/include/rtw_sreset.h | 1 -
2 files changed, 30 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c
b/drivers/staging
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/rtw_pwrctrl.h
b/drivers/staging/rtl8723au/include/rtw_pwrctrl.h
index a458af9..577914d 100644
--- a/drivers/
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
index 62e35dd..f13a470 100644
From: Jes Sorensen
No point carrying a bunch of code around that is never going to get
called.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sreset.c | 7 ---
drivers/staging/rtl8723au/hal/rtl8723a_sreset.c | 14 --
drivers/staging/rtl8723au/include/rt
From: Jes Sorensen
This fixes a minor sparse warning.
Reported-by: Fengguang Wu
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_ops_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_ops_linux.c
b/drivers/staging/rt
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 --
drivers/staging/rtl8723au/hal/rtl8723a_sreset.c | 4
drivers/staging/rtl8723au/include/rtl8723a_sreset.h | 1 -
3 files changed, 7 deletions(-)
diff --git a/drivers/staging/r
From: Clément Calmels
Found running sparse on the rtl8723au driver.
CHECK drivers/staging/rtl8723au/core/rtw_cmd.c
drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in
argument 2 (different base types)
drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:expected int
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
index 14a82be..62e35dd 1006
From: Jes Sorensen
Greg,
A couple of sparse fixes (a fix from Clement Calmels and one reported
by Fengguang Wu) as well as some cleanups removing dead code.
Cheers,
Jes
Clément Calmels (1):
staging: rtl8723au: fix sparse warning
Jes Sorensen (9):
staging: rtl8723au: usb_ops_linux.c: Add b
Hi!
Short:
1)
greg k-h> don't add marker lines like this that provide no relevancy to anyone
else.
"no relevancy to anyone else" -- strange: it "has relevance for Hyper-V
sysadmins"
For search by keywords in web archives of this mail list
1b)
greg k-h> If you want to refer to a public bug t
On 2014-06-18 13:33, Kristina Martšenko wrote:
> Hi Alois,
>
> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> nobody seems to have worked towards moving ced1401 out of staging in
> over a year. Are there any plans to clean it up and move it out soon?
> Because otherwise
Fengguang Wu writes:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git
> rtl8723au-devel
> head: 07068767ab5cc9eb549dc85cb858e00c384ade4c
> commit: 068bf12cd5cc11f85a5b4d5423e629b640e12df7 [206/499] staging:
> rtl8723au: hal/usb_ops_linux.c: Various cleanups
>
> scripts/che
66 matches
Mail list logo
